From: <Ajay.Kathat@microchip.com> To: <linux-wireless@vger.kernel.org> Cc: <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>, <johannes@sipsolutions.net>, <Nicolas.Ferre@microchip.com>, <Claudiu.Beznea@microchip.com>, <Sripad.Balwadgi@microchip.com>, <Venkateswara.Kaja@microchip.com>, <Ajay.Kathat@microchip.com> Subject: [PATCH v7 00/17] wilc1000: move out of staging Date: Tue, 23 Jun 2020 11:00:04 +0000 [thread overview] Message-ID: <20200623110000.31559-1-ajay.kathat@microchip.com> (raw) From: Ajay Singh <ajay.kathat@microchip.com> This patch series is to review and move wilc1000 driver out of staging. Most of the review comments received in [1] & [2] are addressed in the latest code. Please review and provide your inputs. [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/ [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/ Changes since v6: - added Reviewed-by tag received for DT binding document patch earlier. * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus - merged latest driver and included --base commit as suggested. Changes since v5: - handle DT binding review comments suggested in below link: * https://lore.kernel.org/driverdev-devel/20200320175920.GA31641@bogus - merged latest driver from staging which contains few cleanup patches and changes to use crc7 from existing library instead of having private implementation. Changes since v4: - merged wilc1000 SDIO and SPI DT binding into a single file. - handle DT binding review comments suggested in below links: * https://lore.kernel.org/linux-wireless/20200303015558.GA6876@bogus * https://lore.kernel.org/linux-wireless/20200306144400.4269-2-ajay.kathat@microchip.com Changes since v3: - handle few Smatch static checker reported issues. - use flexible-array member instead of zero-length array. Changes since v2: - use 'struct' to extract FW info from received commands. - make use of C style comments instead of C++. - remove use of bool type for firmware struct. - deleted unused code related to interrupt handling. - make use of RCU list to maintain interfaces list. - remove 'wilc_' prefix from file name. - added 'WILC_' prefix for header guard macro. - remove use of infinite loops(i.e. while(1)). - move firmware related struct to a separate file. - refactor SPI command handling by using 'struct'. - use different functions to handle different SPI commands. - cleanup spi.c and sdio.c by removing unused code. - remove use of vendor specific IE for p2p handling. - refactor p2p related code to avoid use of buf pointer operation. - make use of FIELD_GET/PREP macro. - use #define instead of magic values. - use YAML schemes for DT binding documentation. - deleted unused code from spi.c and sdio.c. - added changes for few issues reported by smatch static code analyzer. Changes since v1: - remove use of shadow buffer to keep scan result. - remove internal messaging flow to handle cfg80211_ops. - make use of cfg80211 provide API. - use 'struct' for packing firmware commands. - make use of kernel API's and Macro. - remove unnecessary log messages - supported dynamically add/remove interfaces. - cleanup and deleted around 3.3k lines of code. Ajay Singh (17): wilc1000: add hif.h wilc1000: add hif.c wilc1000: add wlan_if.h wilc1000: add wlan_cfg.h wilc1000: add wlan_cfg.c wilc1000: add cfg80211.c wilc1000: add cfg80211.h wilc1000: add netdev.h wilc1000: add netdev.c wilc1000: add mon.c wilc1000: add spi.c wilc1000: add wlan.h wilc1000: add wlan.c wilc1000: add sdio.c wilc1000: add fw.h dt: bindings: net: add microchip,wilc1000.yaml wilc1000: add Makefile and Kconfig files for wilc1000 compilation .../net/wireless/microchip,wilc1000.yaml | 71 + drivers/net/wireless/Kconfig | 1 + drivers/net/wireless/Makefile | 1 + drivers/net/wireless/microchip/Kconfig | 15 + drivers/net/wireless/microchip/Makefile | 2 + .../net/wireless/microchip/wilc1000/Kconfig | 47 + .../net/wireless/microchip/wilc1000/Makefile | 14 + .../wireless/microchip/wilc1000/cfg80211.c | 1846 ++++++++++++++++ .../wireless/microchip/wilc1000/cfg80211.h | 30 + drivers/net/wireless/microchip/wilc1000/fw.h | 119 + drivers/net/wireless/microchip/wilc1000/hif.c | 1961 +++++++++++++++++ drivers/net/wireless/microchip/wilc1000/hif.h | 214 ++ drivers/net/wireless/microchip/wilc1000/mon.c | 260 +++ .../net/wireless/microchip/wilc1000/netdev.c | 931 ++++++++ .../net/wireless/microchip/wilc1000/netdev.h | 287 +++ .../net/wireless/microchip/wilc1000/sdio.c | 1023 +++++++++ drivers/net/wireless/microchip/wilc1000/spi.c | 945 ++++++++ .../net/wireless/microchip/wilc1000/wlan.c | 1238 +++++++++++ .../net/wireless/microchip/wilc1000/wlan.h | 397 ++++ .../wireless/microchip/wilc1000/wlan_cfg.c | 413 ++++ .../wireless/microchip/wilc1000/wlan_cfg.h | 54 + .../net/wireless/microchip/wilc1000/wlan_if.h | 803 +++++++ drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - 24 files changed, 10672 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml create mode 100644 drivers/net/wireless/microchip/Kconfig create mode 100644 drivers/net/wireless/microchip/Makefile create mode 100644 drivers/net/wireless/microchip/wilc1000/Kconfig create mode 100644 drivers/net/wireless/microchip/wilc1000/Makefile create mode 100644 drivers/net/wireless/microchip/wilc1000/cfg80211.c create mode 100644 drivers/net/wireless/microchip/wilc1000/cfg80211.h create mode 100644 drivers/net/wireless/microchip/wilc1000/fw.h create mode 100644 drivers/net/wireless/microchip/wilc1000/hif.c create mode 100644 drivers/net/wireless/microchip/wilc1000/hif.h create mode 100644 drivers/net/wireless/microchip/wilc1000/mon.c create mode 100644 drivers/net/wireless/microchip/wilc1000/netdev.c create mode 100644 drivers/net/wireless/microchip/wilc1000/netdev.h create mode 100644 drivers/net/wireless/microchip/wilc1000/sdio.c create mode 100644 drivers/net/wireless/microchip/wilc1000/spi.c create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan.c create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan.h create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_cfg.c create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_cfg.h create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_if.h base-commit: a15a20acc980342c97d804c5fae1cfc0cd7712a9 -- 2.24.0
WARNING: multiple messages have this Message-ID (diff)
From: <Ajay.Kathat@microchip.com> To: <linux-wireless@vger.kernel.org> Cc: devel@driverdev.osuosl.org, Ajay.Kathat@microchip.com, Venkateswara.Kaja@microchip.com, gregkh@linuxfoundation.org, Nicolas.Ferre@microchip.com, johannes@sipsolutions.net, Sripad.Balwadgi@microchip.com Subject: [PATCH v7 00/17] wilc1000: move out of staging Date: Tue, 23 Jun 2020 11:00:04 +0000 [thread overview] Message-ID: <20200623110000.31559-1-ajay.kathat@microchip.com> (raw) From: Ajay Singh <ajay.kathat@microchip.com> This patch series is to review and move wilc1000 driver out of staging. Most of the review comments received in [1] & [2] are addressed in the latest code. Please review and provide your inputs. [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/ [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/ Changes since v6: - added Reviewed-by tag received for DT binding document patch earlier. * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus - merged latest driver and included --base commit as suggested. Changes since v5: - handle DT binding review comments suggested in below link: * https://lore.kernel.org/driverdev-devel/20200320175920.GA31641@bogus - merged latest driver from staging which contains few cleanup patches and changes to use crc7 from existing library instead of having private implementation. Changes since v4: - merged wilc1000 SDIO and SPI DT binding into a single file. - handle DT binding review comments suggested in below links: * https://lore.kernel.org/linux-wireless/20200303015558.GA6876@bogus * https://lore.kernel.org/linux-wireless/20200306144400.4269-2-ajay.kathat@microchip.com Changes since v3: - handle few Smatch static checker reported issues. - use flexible-array member instead of zero-length array. Changes since v2: - use 'struct' to extract FW info from received commands. - make use of C style comments instead of C++. - remove use of bool type for firmware struct. - deleted unused code related to interrupt handling. - make use of RCU list to maintain interfaces list. - remove 'wilc_' prefix from file name. - added 'WILC_' prefix for header guard macro. - remove use of infinite loops(i.e. while(1)). - move firmware related struct to a separate file. - refactor SPI command handling by using 'struct'. - use different functions to handle different SPI commands. - cleanup spi.c and sdio.c by removing unused code. - remove use of vendor specific IE for p2p handling. - refactor p2p related code to avoid use of buf pointer operation. - make use of FIELD_GET/PREP macro. - use #define instead of magic values. - use YAML schemes for DT binding documentation. - deleted unused code from spi.c and sdio.c. - added changes for few issues reported by smatch static code analyzer. Changes since v1: - remove use of shadow buffer to keep scan result. - remove internal messaging flow to handle cfg80211_ops. - make use of cfg80211 provide API. - use 'struct' for packing firmware commands. - make use of kernel API's and Macro. - remove unnecessary log messages - supported dynamically add/remove interfaces. - cleanup and deleted around 3.3k lines of code. Ajay Singh (17): wilc1000: add hif.h wilc1000: add hif.c wilc1000: add wlan_if.h wilc1000: add wlan_cfg.h wilc1000: add wlan_cfg.c wilc1000: add cfg80211.c wilc1000: add cfg80211.h wilc1000: add netdev.h wilc1000: add netdev.c wilc1000: add mon.c wilc1000: add spi.c wilc1000: add wlan.h wilc1000: add wlan.c wilc1000: add sdio.c wilc1000: add fw.h dt: bindings: net: add microchip,wilc1000.yaml wilc1000: add Makefile and Kconfig files for wilc1000 compilation .../net/wireless/microchip,wilc1000.yaml | 71 + drivers/net/wireless/Kconfig | 1 + drivers/net/wireless/Makefile | 1 + drivers/net/wireless/microchip/Kconfig | 15 + drivers/net/wireless/microchip/Makefile | 2 + .../net/wireless/microchip/wilc1000/Kconfig | 47 + .../net/wireless/microchip/wilc1000/Makefile | 14 + .../wireless/microchip/wilc1000/cfg80211.c | 1846 ++++++++++++++++ .../wireless/microchip/wilc1000/cfg80211.h | 30 + drivers/net/wireless/microchip/wilc1000/fw.h | 119 + drivers/net/wireless/microchip/wilc1000/hif.c | 1961 +++++++++++++++++ drivers/net/wireless/microchip/wilc1000/hif.h | 214 ++ drivers/net/wireless/microchip/wilc1000/mon.c | 260 +++ .../net/wireless/microchip/wilc1000/netdev.c | 931 ++++++++ .../net/wireless/microchip/wilc1000/netdev.h | 287 +++ .../net/wireless/microchip/wilc1000/sdio.c | 1023 +++++++++ drivers/net/wireless/microchip/wilc1000/spi.c | 945 ++++++++ .../net/wireless/microchip/wilc1000/wlan.c | 1238 +++++++++++ .../net/wireless/microchip/wilc1000/wlan.h | 397 ++++ .../wireless/microchip/wilc1000/wlan_cfg.c | 413 ++++ .../wireless/microchip/wilc1000/wlan_cfg.h | 54 + .../net/wireless/microchip/wilc1000/wlan_if.h | 803 +++++++ drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - 24 files changed, 10672 insertions(+), 3 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml create mode 100644 drivers/net/wireless/microchip/Kconfig create mode 100644 drivers/net/wireless/microchip/Makefile create mode 100644 drivers/net/wireless/microchip/wilc1000/Kconfig create mode 100644 drivers/net/wireless/microchip/wilc1000/Makefile create mode 100644 drivers/net/wireless/microchip/wilc1000/cfg80211.c create mode 100644 drivers/net/wireless/microchip/wilc1000/cfg80211.h create mode 100644 drivers/net/wireless/microchip/wilc1000/fw.h create mode 100644 drivers/net/wireless/microchip/wilc1000/hif.c create mode 100644 drivers/net/wireless/microchip/wilc1000/hif.h create mode 100644 drivers/net/wireless/microchip/wilc1000/mon.c create mode 100644 drivers/net/wireless/microchip/wilc1000/netdev.c create mode 100644 drivers/net/wireless/microchip/wilc1000/netdev.h create mode 100644 drivers/net/wireless/microchip/wilc1000/sdio.c create mode 100644 drivers/net/wireless/microchip/wilc1000/spi.c create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan.c create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan.h create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_cfg.c create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_cfg.h create mode 100644 drivers/net/wireless/microchip/wilc1000/wlan_if.h base-commit: a15a20acc980342c97d804c5fae1cfc0cd7712a9 -- 2.24.0 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2020-06-23 11:00 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-23 11:00 Ajay.Kathat [this message] 2020-06-23 11:00 ` [PATCH v7 00/17] wilc1000: move out of staging Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 01/17] wilc1000: add hif.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 02/17] wilc1000: add hif.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 03/17] wilc1000: add wlan_if.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 04/17] wilc1000: add wlan_cfg.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 05/17] wilc1000: add wlan_cfg.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 06/17] wilc1000: add cfg80211.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-24 9:00 ` Johannes Berg 2020-06-24 9:00 ` Johannes Berg 2020-06-23 11:00 ` [PATCH v7 07/17] wilc1000: add cfg80211.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 08/17] wilc1000: add netdev.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 09/17] wilc1000: add netdev.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 10/17] wilc1000: add mon.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 12/17] wilc1000: add wlan.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 11/17] wilc1000: add spi.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 13/17] wilc1000: add wlan.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 15/17] wilc1000: add fw.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 14/17] wilc1000: add sdio.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 17/17] wilc1000: add Makefile and Kconfig files for wilc1000 compilation Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 14:52 ` kernel test robot 2020-06-23 14:52 ` kernel test robot 2020-06-23 14:52 ` kernel test robot 2020-06-24 5:26 ` Ajay.Kathat 2020-06-24 5:26 ` Ajay.Kathat 2020-06-24 5:26 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 16/17] dt: bindings: net: add microchip,wilc1000.yaml Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-24 8:50 ` [PATCH v7 00/17] wilc1000: move out of staging Kalle Valo 2020-06-24 8:50 ` Kalle Valo 2020-06-24 9:10 ` Greg KH 2020-06-24 9:10 ` Greg KH 2020-06-24 9:49 ` Kalle Valo 2020-06-24 9:49 ` Kalle Valo 2020-06-24 14:52 ` Greg KH 2020-06-24 14:52 ` Greg KH 2020-06-26 5:34 ` Kalle Valo 2020-06-26 5:34 ` Kalle Valo 2020-06-26 13:46 ` Greg KH 2020-06-26 13:46 ` Greg KH 2020-07-02 7:05 ` Kalle Valo 2020-07-02 7:05 ` Kalle Valo 2020-06-29 13:26 ` Pali Rohár 2020-06-29 13:26 ` Pali Rohár 2020-06-30 3:17 ` Ajay.Kathat 2020-06-30 3:17 ` Ajay.Kathat 2020-07-01 7:55 ` Pali Rohár 2020-07-01 7:55 ` Pali Rohár 2020-07-01 7:56 ` Pali Rohár 2020-07-01 7:56 ` Pali Rohár 2020-07-06 8:12 ` Ulf Hansson 2020-07-06 8:12 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200623110000.31559-1-ajay.kathat@microchip.com \ --to=ajay.kathat@microchip.com \ --cc=Claudiu.Beznea@microchip.com \ --cc=Nicolas.Ferre@microchip.com \ --cc=Sripad.Balwadgi@microchip.com \ --cc=Venkateswara.Kaja@microchip.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.