All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ahmed S. Darwish" <a.darwish@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, will@kernel.org, tglx@linutronix.de,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	rostedt@goodmis.org, bigeasy@linutronix.de, davem@davemloft.net,
	sparclinux@vger.kernel.org, mpe@ellerman.id.au,
	linuxppc-dev@lists.ozlabs.org, heiko.carstens@de.ibm.com,
	linux-s390@vger.kernel.org, linux@armlinux.org.uk
Subject: Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables
Date: Tue, 23 Jun 2020 17:00:31 +0200	[thread overview]
Message-ID: <20200623150031.GA2986783@debian-buster-darwi.lab.linutronix.de> (raw)
In-Reply-To: <20200623083721.512673481@infradead.org>

On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote:
...
> -#define lockdep_assert_irqs_disabled()	do {				\
> -		WARN_ONCE(debug_locks && !current->lockdep_recursion &&	\
> -			  current->hardirqs_enabled,			\
> -			  "IRQs not disabled as expected\n");		\
> -	} while (0)
> +#define lockdep_assert_irqs_enabled()					\
> +do {									\
> +	WARN_ON_ONCE(debug_locks && !this_cpu_read(hardirqs_enabled));	\
> +} while (0)
>

Can we add a small comment on top of lockdep_off(), stating that lockdep
IRQ tracking will still be kept after a lockdep_off call?

thanks,

--
Ahmed S. Darwish
Linutronix GmbH

WARNING: multiple messages have this Message-ID (diff)
From: "Ahmed S. Darwish" <a.darwish@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, will@kernel.org, tglx@linutronix.de,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	rostedt@goodmis.org, bigeasy@linutronix.de, davem@davemloft.net,
	sparclinux@vger.kernel.org, mpe@ellerman.id.au,
	linuxppc-dev@lists.ozlabs.org, heiko.carstens@de.ibm.com,
	linux-s390@vger.kernel.org, linux@armlinux.org.uk
Subject: Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables
Date: Tue, 23 Jun 2020 15:00:31 +0000	[thread overview]
Message-ID: <20200623150031.GA2986783@debian-buster-darwi.lab.linutronix.de> (raw)
In-Reply-To: <20200623083721.512673481@infradead.org>

On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote:
...
> -#define lockdep_assert_irqs_disabled()	do {				\
> -		WARN_ONCE(debug_locks && !current->lockdep_recursion &&	\
> -			  current->hardirqs_enabled,			\
> -			  "IRQs not disabled as expected\n");		\
> -	} while (0)
> +#define lockdep_assert_irqs_enabled()					\
> +do {									\
> +	WARN_ON_ONCE(debug_locks && !this_cpu_read(hardirqs_enabled));	\
> +} while (0)
>

Can we add a small comment on top of lockdep_off(), stating that lockdep
IRQ tracking will still be kept after a lockdep_off call?

thanks,

--
Ahmed S. Darwish
Linutronix GmbH

WARNING: multiple messages have this Message-ID (diff)
From: "Ahmed S. Darwish" <a.darwish@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	bigeasy@linutronix.de, x86@kernel.org, heiko.carstens@de.ibm.com,
	linux-kernel@vger.kernel.org, rostedt@goodmis.org,
	davem@davemloft.net, sparclinux@vger.kernel.org,
	linux@armlinux.org.uk, tglx@linutronix.de, will@kernel.org,
	mingo@kernel.org
Subject: Re: [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables
Date: Tue, 23 Jun 2020 17:00:31 +0200	[thread overview]
Message-ID: <20200623150031.GA2986783@debian-buster-darwi.lab.linutronix.de> (raw)
In-Reply-To: <20200623083721.512673481@infradead.org>

On Tue, Jun 23, 2020 at 10:36:52AM +0200, Peter Zijlstra wrote:
...
> -#define lockdep_assert_irqs_disabled()	do {				\
> -		WARN_ONCE(debug_locks && !current->lockdep_recursion &&	\
> -			  current->hardirqs_enabled,			\
> -			  "IRQs not disabled as expected\n");		\
> -	} while (0)
> +#define lockdep_assert_irqs_enabled()					\
> +do {									\
> +	WARN_ON_ONCE(debug_locks && !this_cpu_read(hardirqs_enabled));	\
> +} while (0)
>

Can we add a small comment on top of lockdep_off(), stating that lockdep
IRQ tracking will still be kept after a lockdep_off call?

thanks,

--
Ahmed S. Darwish
Linutronix GmbH

  reply	other threads:[~2020-06-23 15:01 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23  8:36 [PATCH v4 0/8] lockdep: Change IRQ state tracking to use per-cpu variables Peter Zijlstra
2020-06-23  8:36 ` Peter Zijlstra
2020-06-23  8:36 ` Peter Zijlstra
2020-06-23  8:36 ` [PATCH v4 1/8] lockdep: Prepare for NMI IRQ state tracking Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-07-11 10:09   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-06-23  8:36 ` [PATCH v4 2/8] x86/entry: Fix NMI vs " Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-07-11 10:09   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-06-23  8:36 ` [PATCH v4 3/8] sparc64: Fix asm/percpu.h build error Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23 21:35   ` David Miller
2020-06-23 21:35     ` David Miller
2020-06-23 21:35     ` David Miller
2020-07-11 10:09   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-06-23  8:36 ` [PATCH v4 4/8] powerpc64: Break asm/percpu.h vs spinlock_types.h dependency Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23  8:36 ` [PATCH v4 5/8] s390: Break cyclic percpu include Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-07-11 10:09   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-06-23  8:36 ` [PATCH v4 6/8] arm: " Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23  8:36   ` Peter Zijlstra
2020-06-23  9:02   ` Will Deacon
2020-06-23  9:02     ` Will Deacon
2020-06-23  9:02     ` Will Deacon
2020-06-24 17:53     ` Peter Zijlstra
2020-06-24 17:53       ` Peter Zijlstra
2020-06-24 17:53       ` Peter Zijlstra
2020-06-25  7:31       ` Will Deacon
2020-06-25  7:31         ` Will Deacon
2020-06-25  7:31         ` Will Deacon
2020-07-11 10:09   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-06-23  8:36 ` [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables Peter Zijlstra
2020-06-23  8:36   ` [PATCH v4 7/8] lockdep: Change hardirq{s_enabled, _context} " Peter Zijlstra
2020-06-23  8:36   ` [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} " Peter Zijlstra
2020-06-23 15:00   ` Ahmed S. Darwish [this message]
2020-06-23 15:00     ` Ahmed S. Darwish
2020-06-23 15:00     ` Ahmed S. Darwish
2020-06-23 15:24     ` Peter Zijlstra
2020-06-23 15:24       ` Peter Zijlstra
2020-06-23 15:24       ` Peter Zijlstra
2020-06-23 16:13       ` Ahmed S. Darwish
2020-06-23 16:13         ` Ahmed S. Darwish
2020-06-23 16:13         ` Ahmed S. Darwish
2020-06-23 16:37         ` Peter Zijlstra
2020-06-23 16:37           ` Peter Zijlstra
2020-06-23 16:37           ` Peter Zijlstra
2020-06-23 17:59           ` Marco Elver
2020-06-23 17:59             ` Marco Elver
2020-06-23 17:59             ` Marco Elver
2020-06-23 18:12             ` Peter Zijlstra
2020-06-23 18:12               ` Peter Zijlstra
2020-06-23 18:12               ` Peter Zijlstra
2020-06-23 18:39               ` Marco Elver
2020-06-23 18:39                 ` Marco Elver
2020-06-23 18:39                 ` Marco Elver
2020-06-23 19:13                 ` Marco Elver
2020-06-23 19:13                   ` Marco Elver
2020-06-23 19:13                   ` Marco Elver
2020-06-23 19:41                   ` Peter Zijlstra
2020-06-23 19:41                     ` Peter Zijlstra
2020-06-23 19:41                     ` Peter Zijlstra
2020-06-23 20:08                   ` Peter Zijlstra
2020-06-23 20:08                     ` Peter Zijlstra
2020-06-23 20:08                     ` Peter Zijlstra
2020-06-23 20:24               ` Peter Zijlstra
2020-06-23 20:24                 ` Peter Zijlstra
2020-06-23 20:24                 ` Peter Zijlstra
2020-06-23 20:33                 ` Peter Zijlstra
2020-06-23 20:33                   ` Peter Zijlstra
2020-06-23 20:33                   ` Peter Zijlstra
2020-06-24  9:00                 ` Peter Zijlstra
2020-06-24  9:00                   ` Peter Zijlstra
2020-06-24  9:00                   ` Peter Zijlstra
2020-06-24 10:17                   ` Marco Elver
2020-06-24 10:17                     ` Marco Elver
2020-06-24 10:17                     ` Marco Elver
2020-06-24 12:31                     ` Peter Zijlstra
2020-06-24 12:31                       ` Peter Zijlstra
2020-06-24 12:31                       ` Peter Zijlstra
2020-06-24 11:32                 ` Marco Elver
2020-06-24 11:32                   ` Marco Elver
2020-06-24 11:32                   ` Marco Elver
2020-06-24 15:18                   ` Peter Zijlstra
2020-06-24 15:18                     ` Peter Zijlstra
2020-06-24 15:18                     ` Peter Zijlstra
2020-07-11 10:09                   ` [tip: locking/core] kcsan: Make KCSAN compatible with new IRQ state tracking tip-bot2 for Marco Elver
2020-06-30  5:59   ` [PATCH v4 7/8] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables Ahmed S. Darwish
2020-06-30  5:59     ` Ahmed S. Darwish
2020-06-30  5:59     ` Ahmed S. Darwish
2020-06-30  9:40     ` Peter Zijlstra
2020-06-30  9:40       ` Peter Zijlstra
2020-06-30  9:40       ` Peter Zijlstra
2020-07-11 10:09   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-06-23  8:36 ` [PATCH v4 8/8] lockdep: Remove lockdep_hardirq{s_enabled,_context}() argument Peter Zijlstra
2020-06-23  8:36   ` [PATCH v4 8/8] lockdep: Remove lockdep_hardirq{s_enabled, _context}() argument Peter Zijlstra
2020-06-23  8:36   ` [PATCH v4 8/8] lockdep: Remove lockdep_hardirq{s_enabled,_context}() argument Peter Zijlstra
2020-07-11 10:09   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623150031.GA2986783@debian-buster-darwi.lab.linutronix.de \
    --to=a.darwish@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.