All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Ignat Korchagin <ignat@cloudflare.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	"dm-crypt@saout.de" <dm-crypt@saout.de>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"agk@redhat.com" <agk@redhat.com>,
	"kernel-team@cloudflare.com" <kernel-team@cloudflare.com>
Subject: Re: [RFC PATCH 0/1] dm-crypt excessive overhead
Date: Tue, 23 Jun 2020 11:22:36 -0400	[thread overview]
Message-ID: <20200623152235.GB19657@redhat.com> (raw)
In-Reply-To: <CALrw=nHNJTX3kzv2Q=dc6hYr=d8S2=gT0VHkWigS1pmwr9ps5Q@mail.gmail.com>

On Tue, Jun 23 2020 at 11:07am -0400,
Ignat Korchagin <ignat@cloudflare.com> wrote:

> Do you think it may be better to break it in two flags: one for read
> path and one for write? So, depending on the needs and workflow these
> could be enabled independently?

If there is a need to split, then sure.  But I think Damien had a hard
requirement that writes had to be inlined but that reads didn't _need_
to be for his dm-zoned usecase.  Damien may not yet have assessed the
performance implications, of not have reads inlined, as much as you
have.

So let's see how Damien's work goes and if he trully doesn't need/want
reads to be inlined then 2 flags can be created.

Mike


WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Ignat Korchagin <ignat@cloudflare.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	"dm-crypt@saout.de" <dm-crypt@saout.de>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"agk@redhat.com" <agk@redhat.com>,
	"kernel-team@cloudflare.com" <kernel-team@cloudflare.com>
Subject: Re: [dm-crypt] [RFC PATCH 0/1] dm-crypt excessive overhead
Date: Tue, 23 Jun 2020 11:22:36 -0400	[thread overview]
Message-ID: <20200623152235.GB19657@redhat.com> (raw)
In-Reply-To: <CALrw=nHNJTX3kzv2Q=dc6hYr=d8S2=gT0VHkWigS1pmwr9ps5Q@mail.gmail.com>

On Tue, Jun 23 2020 at 11:07am -0400,
Ignat Korchagin <ignat@cloudflare.com> wrote:

> Do you think it may be better to break it in two flags: one for read
> path and one for write? So, depending on the needs and workflow these
> could be enabled independently?

If there is a need to split, then sure.  But I think Damien had a hard
requirement that writes had to be inlined but that reads didn't _need_
to be for his dm-zoned usecase.  Damien may not yet have assessed the
performance implications, of not have reads inlined, as much as you
have.

So let's see how Damien's work goes and if he trully doesn't need/want
reads to be inlined then 2 flags can be created.

Mike

  reply	other threads:[~2020-06-23 15:22 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 16:41 [RFC PATCH 0/1] dm-crypt excessive overhead Ignat Korchagin
2020-06-19 16:41 ` [dm-crypt] " Ignat Korchagin
2020-06-19 16:41 ` [RFC PATCH 1/1] Add DM_CRYPT_FORCE_INLINE flag to dm-crypt target Ignat Korchagin
2020-06-19 16:41   ` [dm-crypt] " Ignat Korchagin
2020-06-24  5:04   ` Eric Biggers
2020-06-24  5:21     ` [dm-devel] " Damien Le Moal
2020-06-24  5:21       ` [dm-crypt] [dm-devel] " Damien Le Moal
2020-06-24  5:27       ` [dm-devel] [dm-crypt] " Eric Biggers
2020-06-24  5:27         ` [dm-crypt] [dm-devel] " Eric Biggers
2020-06-24  6:46         ` [dm-devel] [dm-crypt] " Damien Le Moal
2020-06-24  6:46           ` [dm-crypt] [dm-devel] " Damien Le Moal
2020-06-24  7:24         ` [dm-devel] [dm-crypt] " Damien Le Moal
2020-06-24  7:24           ` [dm-crypt] [dm-devel] " Damien Le Moal
2020-06-24  7:49     ` [dm-devel] [dm-crypt] " Damien Le Moal
2020-06-24  7:49       ` [dm-crypt] [dm-devel] " Damien Le Moal
2020-06-24  8:24     ` [dm-crypt] " Ignat Korchagin
2020-06-24 16:24       ` Eric Biggers
2020-06-24 17:00         ` Ignat Korchagin
2020-06-24  5:12   ` [dm-devel] " Damien Le Moal
2020-06-24  5:12     ` [dm-crypt] " Damien Le Moal
2020-06-19 16:55 ` [RFC PATCH 0/1] dm-crypt excessive overhead Mike Snitzer
2020-06-19 16:55   ` [dm-crypt] " Mike Snitzer
2020-06-19 18:39   ` Mikulas Patocka
2020-06-19 18:39     ` [dm-crypt] " Mikulas Patocka
2020-06-19 19:44     ` Ignat Korchagin
2020-06-19 19:44       ` [dm-crypt] " Ignat Korchagin
2020-06-20  1:23     ` Herbert Xu
2020-06-20  1:23       ` [dm-crypt] " Herbert Xu
2020-06-20 19:36       ` Mikulas Patocka
2020-06-20 19:36         ` Mikulas Patocka
2020-06-20 19:36         ` [dm-crypt] " Mikulas Patocka
2020-06-20 21:02         ` Ignat Korchagin
2020-06-20 21:02           ` Ignat Korchagin
2020-06-20 21:02           ` [dm-crypt] " Ignat Korchagin
2020-06-23 15:33       ` Mike Snitzer
2020-06-23 15:33         ` Mike Snitzer
2020-06-23 15:33         ` [dm-crypt] " Mike Snitzer
2020-06-23 16:24         ` Ignat Korchagin
2020-06-23 16:24           ` [dm-crypt] " Ignat Korchagin
2020-06-24  0:23           ` Herbert Xu
2020-06-24  0:23             ` [dm-crypt] " Herbert Xu
2020-06-22  0:45   ` [dm-devel] " Damien Le Moal
2020-06-22  0:45     ` Damien Le Moal
2020-06-22  0:45     ` [dm-crypt] [dm-devel] " Damien Le Moal
2020-06-22  7:55     ` Ignat Korchagin
2020-06-22  7:55       ` [dm-crypt] " Ignat Korchagin
2020-06-22  8:08       ` Damien Le Moal
2020-06-22  8:08         ` Damien Le Moal
2020-06-22  8:08         ` [dm-crypt] [dm-devel] " Damien Le Moal
2020-06-23 15:01     ` Mike Snitzer
2020-06-23 15:01       ` [dm-crypt] " Mike Snitzer
2020-06-23 15:07       ` Ignat Korchagin
2020-06-23 15:07         ` [dm-crypt] " Ignat Korchagin
2020-06-23 15:22         ` Mike Snitzer [this message]
2020-06-23 15:22           ` Mike Snitzer
2020-06-24  4:54           ` [dm-devel] " Damien Le Moal
2020-06-24  4:54             ` [dm-crypt] " Damien Le Moal
2020-06-24  5:22             ` Mike Snitzer
2020-06-24  5:22               ` Mike Snitzer
2020-06-24  5:22               ` [dm-crypt] " Mike Snitzer
2020-06-24  8:02               ` Ignat Korchagin
2020-06-24  8:02                 ` [dm-crypt] " Ignat Korchagin
2020-06-24  4:28       ` Damien Le Moal
2020-06-24  4:28         ` Damien Le Moal
2020-06-24  4:28         ` [dm-crypt] " Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623152235.GB19657@redhat.com \
    --to=snitzer@redhat.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=agk@redhat.com \
    --cc=dm-crypt@saout.de \
    --cc=dm-devel@redhat.com \
    --cc=ignat@cloudflare.com \
    --cc=kernel-team@cloudflare.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.