From: Sean Paul <sean@poorly.run> To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, Sean Paul <seanpaul@chromium.org>, juston.li@intel.com, rodrigo.vivi@intel.com Subject: [PATCH v7 03/17] drm/i915: WARN if HDCP signalling is enabled upon disable Date: Tue, 23 Jun 2020 11:58:53 -0400 [thread overview] Message-ID: <20200623155907.22961-4-sean@poorly.run> (raw) In-Reply-To: <20200623155907.22961-1-sean@poorly.run> From: Sean Paul <seanpaul@chromium.org> HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Ramalingam C <ramalingam.c@intel.com> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-sean@poorly.run #v2 Link: https://patchwork.freedesktop.org/patch/msgid/20200117193103.156821-4-sean@poorly.run #v3 Link: https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-4-sean@poorly.run #v4 Link: https://patchwork.freedesktop.org/patch/msgid/20200305201236.152307-4-sean@poorly.run #v5 Link: https://patchwork.freedesktop.org/patch/msgid/20200429195502.39919-4-sean@poorly.run #v6 Changes in v2: -Added to the set in lieu of just clearing the bit Changes in v3: -None Changes in v4: -None Changes in v5: -Change WARN_ON to drm_WARN_ON Changes in v6: -None Changes in v7: -Rebased, variable name changed from 'ctl' to 'val' --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 73d6cc29291a..8a03c58cbd31 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -1708,6 +1708,8 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_state ctl = intel_de_read(dev_priv, TRANS_DDI_FUNC_CTL(cpu_transcoder)); + drm_WARN_ON(crtc->base.dev, ctl & TRANS_DDI_HDCP_SIGNALLING); + ctl &= ~TRANS_DDI_FUNC_ENABLE; if (IS_GEN_RANGE(dev_priv, 8, 10)) -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run> To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: daniel.vetter@ffwll.ch, Sean Paul <seanpaul@chromium.org> Subject: [Intel-gfx] [PATCH v7 03/17] drm/i915: WARN if HDCP signalling is enabled upon disable Date: Tue, 23 Jun 2020 11:58:53 -0400 [thread overview] Message-ID: <20200623155907.22961-4-sean@poorly.run> (raw) In-Reply-To: <20200623155907.22961-1-sean@poorly.run> From: Sean Paul <seanpaul@chromium.org> HDCP signalling should not be left on, WARN if it is Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Ramalingam C <ramalingam.c@intel.com> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20191212190230.188505-4-sean@poorly.run #v2 Link: https://patchwork.freedesktop.org/patch/msgid/20200117193103.156821-4-sean@poorly.run #v3 Link: https://patchwork.freedesktop.org/patch/msgid/20200218220242.107265-4-sean@poorly.run #v4 Link: https://patchwork.freedesktop.org/patch/msgid/20200305201236.152307-4-sean@poorly.run #v5 Link: https://patchwork.freedesktop.org/patch/msgid/20200429195502.39919-4-sean@poorly.run #v6 Changes in v2: -Added to the set in lieu of just clearing the bit Changes in v3: -None Changes in v4: -None Changes in v5: -Change WARN_ON to drm_WARN_ON Changes in v6: -None Changes in v7: -Rebased, variable name changed from 'ctl' to 'val' --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 73d6cc29291a..8a03c58cbd31 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -1708,6 +1708,8 @@ void intel_ddi_disable_transcoder_func(const struct intel_crtc_state *crtc_state ctl = intel_de_read(dev_priv, TRANS_DDI_FUNC_CTL(cpu_transcoder)); + drm_WARN_ON(crtc->base.dev, ctl & TRANS_DDI_HDCP_SIGNALLING); + ctl &= ~TRANS_DDI_FUNC_ENABLE; if (IS_GEN_RANGE(dev_priv, 8, 10)) -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-23 15:59 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-23 15:58 [PATCH v7 00/17] drm/i915: Add support for HDCP 1.4 over MST Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-06-23 15:58 ` [PATCH v7 01/17] drm/i915: Fix sha_text population code Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-06-23 15:58 ` Sean Paul 2020-06-25 14:53 ` Sasha Levin 2020-06-25 14:53 ` [Intel-gfx] " Sasha Levin 2020-06-25 14:53 ` Sasha Levin 2020-06-23 15:58 ` [PATCH v7 02/17] drm/i915: Clear the repeater bit on HDCP disable Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-06-23 15:58 ` Sean Paul 2020-06-25 14:53 ` Sasha Levin 2020-06-25 14:53 ` [Intel-gfx] " Sasha Levin 2020-06-25 14:53 ` Sasha Levin 2020-06-23 15:58 ` Sean Paul [this message] 2020-06-23 15:58 ` [Intel-gfx] [PATCH v7 03/17] drm/i915: WARN if HDCP signalling is enabled upon disable Sean Paul 2020-06-23 15:58 ` [PATCH v7 04/17] drm/i915: Intercept Aksv writes in the aux hooks Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-06-23 15:58 ` [PATCH v7 05/17] drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-06-23 15:58 ` [PATCH v7 06/17] drm/i915: Factor out hdcp->value assignments Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-06-23 15:58 ` [PATCH v7 07/17] drm/i915: Protect workers against disappearing connectors Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-06-23 15:58 ` [PATCH v7 08/17] drm/i915: Clean up intel_hdcp_disable Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-07-03 11:36 ` Anshuman Gupta 2020-07-03 11:36 ` Anshuman Gupta 2020-07-09 5:40 ` Ramalingam C 2020-07-09 5:40 ` [Intel-gfx] " Ramalingam C 2020-06-23 15:58 ` [PATCH v7 09/17] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it Sean Paul 2020-06-23 15:58 ` [Intel-gfx] " Sean Paul 2020-07-09 5:57 ` Ramalingam C 2020-07-09 5:57 ` [Intel-gfx] " Ramalingam C 2020-06-23 15:59 ` [PATCH v7 10/17] drm/i915: Support DP MST in enc_to_dig_port() function Sean Paul 2020-06-23 15:59 ` [Intel-gfx] " Sean Paul 2020-07-09 10:16 ` Ramalingam C 2020-07-09 10:16 ` [Intel-gfx] " Ramalingam C 2020-06-23 15:59 ` [PATCH v7 11/17] drm/i915: Use ddi_update_pipe in intel_dp_mst Sean Paul 2020-06-23 15:59 ` [Intel-gfx] " Sean Paul 2020-07-09 10:49 ` C, Ramalingam 2020-07-09 10:49 ` [Intel-gfx] " C, Ramalingam 2020-06-23 15:59 ` [PATCH v7 12/17] drm/i915: Factor out HDCP shim functions from dp for use by dp_mst Sean Paul 2020-06-23 15:59 ` [Intel-gfx] " Sean Paul 2020-07-09 10:51 ` C, Ramalingam 2020-07-09 10:51 ` [Intel-gfx] " C, Ramalingam 2020-06-23 15:59 ` [PATCH v7 13/17] drm/i915: Plumb port through hdcp init Sean Paul 2020-06-23 15:59 ` [Intel-gfx] " Sean Paul 2020-07-03 10:22 ` Anshuman Gupta 2020-07-03 10:22 ` Anshuman Gupta 2020-07-09 10:55 ` Ramalingam C 2020-07-09 10:55 ` [Intel-gfx] " Ramalingam C 2020-06-23 15:59 ` [PATCH v7 14/17] drm/i915: Add connector to hdcp_shim->check_link() Sean Paul 2020-06-23 15:59 ` [Intel-gfx] " Sean Paul 2020-07-03 10:13 ` Anshuman Gupta 2020-07-03 10:13 ` Anshuman Gupta 2020-07-09 10:56 ` C, Ramalingam 2020-07-09 10:56 ` [Intel-gfx] " C, Ramalingam 2020-06-23 15:59 ` [PATCH v7 15/17] drm/mst: Add support for QUERY_STREAM_ENCRYPTION_STATUS MST sideband message Sean Paul 2020-06-23 15:59 ` [Intel-gfx] " Sean Paul 2020-06-30 14:09 ` Anshuman Gupta 2020-06-30 14:09 ` Anshuman Gupta 2020-06-30 16:48 ` Sean Paul 2020-06-30 16:48 ` Sean Paul 2020-07-02 14:37 ` Anshuman Gupta 2020-07-02 14:37 ` Anshuman Gupta 2020-07-09 12:58 ` Anshuman Gupta 2020-07-09 12:58 ` Anshuman Gupta 2020-08-11 17:21 ` Sean Paul 2020-08-11 17:21 ` Sean Paul 2020-08-12 8:18 ` Anshuman Gupta 2020-08-12 8:18 ` Anshuman Gupta 2020-08-11 14:43 ` Sean Paul 2020-08-11 14:43 ` Sean Paul 2020-06-23 15:59 ` [PATCH v7 16/17] drm/i915: Print HDCP version info for all connectors Sean Paul 2020-06-23 15:59 ` [Intel-gfx] " Sean Paul 2020-06-23 15:59 ` [PATCH v7 17/17] drm/i915: Add HDCP 1.4 support for MST connectors Sean Paul 2020-06-23 15:59 ` [Intel-gfx] " Sean Paul 2020-07-03 11:18 ` Anshuman Gupta 2020-07-03 11:18 ` Anshuman Gupta 2020-07-03 14:55 ` Anshuman Gupta 2020-07-03 14:55 ` Anshuman Gupta 2020-07-09 10:37 ` Ramalingam C 2020-07-09 10:37 ` [Intel-gfx] " Ramalingam C 2020-07-09 12:28 ` Anshuman Gupta 2020-07-09 12:28 ` Anshuman Gupta 2020-08-11 17:28 ` Sean Paul 2020-08-11 17:28 ` Sean Paul 2020-08-12 7:03 ` Anshuman Gupta 2020-08-12 7:03 ` Anshuman Gupta 2020-08-12 17:21 ` Sean Paul 2020-08-12 17:21 ` Sean Paul 2020-08-13 9:17 ` Anshuman Gupta 2020-08-13 9:17 ` Anshuman Gupta 2020-06-23 16:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for HDCP 1.4 over MST Patchwork 2020-06-23 16:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2020-06-23 16:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-06-24 2:15 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200623155907.22961-4-sean@poorly.run \ --to=sean@poorly.run \ --cc=daniel.vetter@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=juston.li@intel.com \ --cc=rodrigo.vivi@intel.com \ --cc=seanpaul@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.