[djwong-xfs:repair-quota 30/55] fs/xfs/scrub/inode_repair.c:650 xrep_inode() error: we previously assumed 'sc->ip' could be null (see line 631)

[djwong-xfs:repair-quota 30/55] fs/xfs/scrub/inode_repair.c:650 xrep_inode() error: we previously assumed 'sc->ip' could be null (see line 631)

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 3648 bytes --]

CC: kbuild-all(a)lists.01.org
CC: "Darrick J. Wong" <darrick.wong@oracle.com>
TO: "Darrick J. Wong" <darrick.wong@oracle.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git repair-quota
head:   46c1bb2989f596b35ff8fd23fc42a15d36b27e96
commit: a8d2f5412b426e6fe1b74a6ef9e2067ea1873aa9 [30/55] xfs: repair inode records
:::::: branch date: 21 hours ago
:::::: commit date: 21 hours ago
config: x86_64-randconfig-m001-20200623 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
fs/xfs/scrub/inode_repair.c:650 xrep_inode() error: we previously assumed 'sc->ip' could be null (see line 631)

# https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=a8d2f5412b426e6fe1b74a6ef9e2067ea1873aa9
git remote add djwong-xfs https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
git remote update djwong-xfs
git checkout a8d2f5412b426e6fe1b74a6ef9e2067ea1873aa9
vim +650 fs/xfs/scrub/inode_repair.c

a8d2f5412b426e6 Darrick J. Wong 2020-02-19  619  
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  620  /* Repair an inode's fields. */
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  621  int
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  622  xrep_inode(
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  623  	struct xfs_scrub	*sc)
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  624  {
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  625  	int			error = 0;
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  626  
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  627  	/*
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  628  	 * No inode?  That means we failed the _iget verifiers.  Repair all
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  629  	 * the things that the inode verifiers care about, then retry _iget.
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  630  	 */
a8d2f5412b426e6 Darrick J. Wong 2020-02-19 @631  	if (!sc->ip) {
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  632  		error = xrep_dinode_problems(sc);
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  633  		if (error)
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  634  			goto out;
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  635  	}
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  636  
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  637  	/* By this point we had better have a working incore inode. */
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  638  	ASSERT(sc->ip);
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  639  	xfs_trans_ijoin(sc->tp, sc->ip, 0);
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  640  
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  641  	/* If we found corruption of any kind, try to fix it. */
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  642  	if ((sc->sm->sm_flags & XFS_SCRUB_OFLAG_CORRUPT) ||
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  643  	    (sc->sm->sm_flags & XFS_SCRUB_OFLAG_XCORRUPT)) {
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  644  		error = xrep_inode_problems(sc);
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  645  		if (error)
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  646  			goto out;
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  647  	}
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  648  
a8d2f5412b426e6 Darrick J. Wong 2020-02-19  649  	/* See if we can clear the reflink flag. */
a8d2f5412b426e6 Darrick J. Wong 2020-02-19 @650  	if (xfs_is_reflink_inode(sc->ip))

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33931 bytes --]