[PATCH v2] Revert "packagegroup-xfce-base: add RDEPEND packagegroup-core-x11"

[PATCH v2] Revert "packagegroup-xfce-base: add RDEPEND packagegroup-core-x11"

[Andreas Müller]

packagegroup-core-x11 drags stuff not everybody needs e.g xserver-nodm-init and
that's not what everybody wants. packagegroup-core-x11 is something to add into
images.

This reverts commit 394567c0078c627642e7b80b722f147da5a6f376:

    packagegroup-xfce-base: add RDEPEND packagegroup-core-x11

    without packagegroup-core-x11, after boot target, and run
    startx, it will report error like:

    /usr/bin/startx: line 203: xauth: command not found

    xinit: unable to run server "/usr/bin/X": No such file or directory
    Use the -- option, or make sure that /usr/bin is in your path and
    that "/usr/bin/X" is a program or a link to the right type of server
    for your display.  Possible server names include:

        Xorg        Common X server for most displays
        Xvfb        Virtual frame buffer
        Xfake       kdrive-based virtual frame buffer
        Xnest       X server nested in a window on anot

    Signed-off-by: Changqing Li <changqing.li@windriver.com>
    Signed-off-by: Khem Raj <raj.khem@gmail.com>

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
V1 -> V2:
* Add commit message of patch reverted
* Add Signed-off-by

 meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb b/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
index 6ddf8ee91..70ef909ef 100644
--- a/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
+++ b/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
@@ -7,7 +7,6 @@ inherit packagegroup features_check
 REQUIRED_DISTRO_FEATURES = "x11"
 
 RDEPENDS_${PN} = " \
-    packagegroup-core-x11 \
     xfwm4 \
     xfce4-session \
     xfconf \
-- 
2.26.2

Re: [oe] [PATCH v2] Revert "packagegroup-xfce-base: add RDEPEND packagegroup-core-x11"

[Khem Raj]

On 6/24/20 11:49 PM, Andreas Müller wrote:
> packagegroup-core-x11 drags stuff not everybody needs e.g xserver-nodm-init and
> that's not what everybody wants. packagegroup-core-x11 is something to add into
> images.
> 
> This reverts commit 394567c0078c627642e7b80b722f147da5a6f376:
> 
>     packagegroup-xfce-base: add RDEPEND packagegroup-core-x11
> 
>     without packagegroup-core-x11, after boot target, and run
>     startx, it will report error like:
> 
>     /usr/bin/startx: line 203: xauth: command not found
> 
>     xinit: unable to run server "/usr/bin/X": No such file or directory
>     Use the -- option, or make sure that /usr/bin is in your path and
>     that "/usr/bin/X" is a program or a link to the right type of server
>     for your display.  Possible server names include:


will these issues resurface if we revert it ?

> 
>         Xorg        Common X server for most displays
>         Xvfb        Virtual frame buffer
>         Xfake       kdrive-based virtual frame buffer
>         Xnest       X server nested in a window on anot
> 
>     Signed-off-by: Changqing Li <changqing.li@windriver.com>
>     Signed-off-by: Khem Raj <raj.khem@gmail.com>
> 
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
> V1 -> V2:
> * Add commit message of patch reverted
> * Add Signed-off-by
> 
>  meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb b/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
> index 6ddf8ee91..70ef909ef 100644
> --- a/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
> +++ b/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
> @@ -7,7 +7,6 @@ inherit packagegroup features_check
>  REQUIRED_DISTRO_FEATURES = "x11"
>  
>  RDEPENDS_${PN} = " \
> -    packagegroup-core-x11 \
>      xfwm4 \
>      xfce4-session \
>      xfconf \
> 
> 
> 
> 

Re: [oe] [PATCH v2] Revert "packagegroup-xfce-base: add RDEPEND packagegroup-core-x11"

[Andreas Müller]

On Thu, Jun 25, 2020 at 6:01 PM Khem Raj <raj.khem@gmail.com> wrote:
>
>
>
> On 6/24/20 11:49 PM, Andreas Müller wrote:
> > packagegroup-core-x11 drags stuff not everybody needs e.g xserver-nodm-init and
> > that's not what everybody wants. packagegroup-core-x11 is something to add into
> > images.
> >
> > This reverts commit 394567c0078c627642e7b80b722f147da5a6f376:
> >
> >     packagegroup-xfce-base: add RDEPEND packagegroup-core-x11
> >
> >     without packagegroup-core-x11, after boot target, and run
> >     startx, it will report error like:
> >
> >     /usr/bin/startx: line 203: xauth: command not found
> >
> >     xinit: unable to run server "/usr/bin/X": No such file or directory
> >     Use the -- option, or make sure that /usr/bin is in your path and
> >     that "/usr/bin/X" is a program or a link to the right type of server
> >     for your display.  Possible server names include:
>
>
> will these issues resurface if we revert it ?
No but creating a running image is not the use case of this
packagegroup. I created this packagegroup long time ago as a
collection of XFCE recipes necessary for a XFCE session. Anything
around it is optional by design. This is a packagegroup and not an
image - and by the way meta-xfce has images including necessary X11
packages.
By this patch loads of packages unrelated to XFCE are dragged in. If
one does not want them, the only chance to get around is to get a copy
of this packagegroup as it was before this patch. To make it clear:
This patch is totally wrong and should have never been applied.

Andreas
>
> >
> >         Xorg        Common X server for most displays
> >         Xvfb        Virtual frame buffer
> >         Xfake       kdrive-based virtual frame buffer
> >         Xnest       X server nested in a window on anot
> >
> >     Signed-off-by: Changqing Li <changqing.li@windriver.com>
> >     Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >
> > Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> > ---
> > V1 -> V2:
> > * Add commit message of patch reverted
> > * Add Signed-off-by
> >
> >  meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb b/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
> > index 6ddf8ee91..70ef909ef 100644
> > --- a/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
> > +++ b/meta-xfce/recipes-xfce/packagegroups/packagegroup-xfce-base.bb
> > @@ -7,7 +7,6 @@ inherit packagegroup features_check
> >  REQUIRED_DISTRO_FEATURES = "x11"
> >
> >  RDEPENDS_${PN} = " \
> > -    packagegroup-core-x11 \
> >      xfwm4 \
> >      xfce4-session \
> >      xfconf \
> >
> >
> > 
> >