[PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression

[PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression

[Fabio Estevam]

Since commit:

commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc
Author: Michael Walle <michael@walle.cc>
Date:   Thu May 7 00:11:58 2020 +0200

    phy: atheros: ar8035: remove static clock config

    We can configure the clock output in the device tree. Disable the
    hardcoded one in here. This is highly board-specific and should have
    never been enabled in the PHY driver.

    If bisecting shows that this commit breaks your board it probably
    depends on the clock output of your Atheros AR8035 PHY. Please have a
    look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set
    "clk-out-frequency = <125000000>" because that value was the hardcoded
    value until this commit.

    Signed-off-by: Michael Walle <michael@walle.cc>
    Acked-by: Joe Hershberger <joe.hershberger@ni.com>

, the clock output setting for the AR803x driver is removed from being 
hardcoded in the PHY driver and should be passed via device tree instead.

Update the device tree with the "qca,clk-out-frequency" property so that
Ethernet can work again.

Reported-by: Soeren Moch <smoch@web.de>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Removed extra unnecessary extra blank line from device tree.

 arch/arm/dts/imx6q-tbs2910.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/dts/imx6q-tbs2910.dts b/arch/arm/dts/imx6q-tbs2910.dts
index cc5df37b46..7d0a0676ff 100644
--- a/arch/arm/dts/imx6q-tbs2910.dts
+++ b/arch/arm/dts/imx6q-tbs2910.dts
@@ -107,7 +107,18 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+	phy-handle = <&phy>;
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy: ethernet-phy at 4 {
+			reg = <4>;
+			qca,clk-out-frequency = <125000000>;
+		};
+	};
 };
 
 &hdmi {
-- 
2.17.1

[PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression

[Soeren Moch]

On 25.06.20 13:14, Fabio Estevam wrote:
> Since commit:
>
> commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc
> Author: Michael Walle <michael@walle.cc>
> Date:   Thu May 7 00:11:58 2020 +0200
>
>     phy: atheros: ar8035: remove static clock config
>
>     We can configure the clock output in the device tree. Disable the
>     hardcoded one in here. This is highly board-specific and should have
>     never been enabled in the PHY driver.
>
>     If bisecting shows that this commit breaks your board it probably
>     depends on the clock output of your Atheros AR8035 PHY. Please have a
>     look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set
>     "clk-out-frequency = <125000000>" because that value was the hardcoded
>     value until this commit.
>
>     Signed-off-by: Michael Walle <michael@walle.cc>
>     Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
> , the clock output setting for the AR803x driver is removed from being
> hardcoded in the PHY driver and should be passed via device tree instead.
>
> Update the device tree with the "qca,clk-out-frequency" property so that
> Ethernet can work again.
>
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Tested-by: Soeren Moch <smoch@web.de>

Thanks,
Soeren
> ---
> Changes since v1:
> - Removed extra unnecessary extra blank line from device tree.
>
>  arch/arm/dts/imx6q-tbs2910.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/dts/imx6q-tbs2910.dts b/arch/arm/dts/imx6q-tbs2910.dts
> index cc5df37b46..7d0a0676ff 100644
> --- a/arch/arm/dts/imx6q-tbs2910.dts
> +++ b/arch/arm/dts/imx6q-tbs2910.dts
> @@ -107,7 +107,18 @@
>  	pinctrl-0 = <&pinctrl_enet>;
>  	phy-mode = "rgmii-id";
>  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> +	phy-handle = <&phy>;
>  	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		phy: ethernet-phy at 4 {
> +			reg = <4>;
> +			qca,clk-out-frequency = <125000000>;
> +		};
> +	};
>  };
>
>  &hdmi {

[PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression

[Fabio Estevam]

Hi Tom,

On Thu, Jun 25, 2020 at 10:52 AM Soeren Moch <smoch@web.de> wrote:
>
> On 25.06.20 13:14, Fabio Estevam wrote:
> > Since commit:
> >
> > commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc
> > Author: Michael Walle <michael@walle.cc>
> > Date:   Thu May 7 00:11:58 2020 +0200
> >
> >     phy: atheros: ar8035: remove static clock config
> >
> >     We can configure the clock output in the device tree. Disable the
> >     hardcoded one in here. This is highly board-specific and should have
> >     never been enabled in the PHY driver.
> >
> >     If bisecting shows that this commit breaks your board it probably
> >     depends on the clock output of your Atheros AR8035 PHY. Please have a
> >     look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set
> >     "clk-out-frequency = <125000000>" because that value was the hardcoded
> >     value until this commit.
> >
> >     Signed-off-by: Michael Walle <michael@walle.cc>
> >     Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> >
> > , the clock output setting for the AR803x driver is removed from being
> > hardcoded in the PHY driver and should be passed via device tree instead.
> >
> > Update the device tree with the "qca,clk-out-frequency" property so that
> > Ethernet can work again.
> >
> > Reported-by: Soeren Moch <smoch@web.de>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Tested-by: Soeren Moch <smoch@web.de>

My understanding is that Stefano does not have any other pull requests
for 2020.07.

In this case, could you apply this regression fix directly?

Thanks

[PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression

[Stefano Babic]

On 25.06.20 15:55, Fabio Estevam wrote:
> Hi Tom,
> 
> On Thu, Jun 25, 2020 at 10:52 AM Soeren Moch <smoch@web.de> wrote:
>>
>> On 25.06.20 13:14, Fabio Estevam wrote:
>>> Since commit:
>>>
>>> commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc
>>> Author: Michael Walle <michael@walle.cc>
>>> Date:   Thu May 7 00:11:58 2020 +0200
>>>
>>>     phy: atheros: ar8035: remove static clock config
>>>
>>>     We can configure the clock output in the device tree. Disable the
>>>     hardcoded one in here. This is highly board-specific and should have
>>>     never been enabled in the PHY driver.
>>>
>>>     If bisecting shows that this commit breaks your board it probably
>>>     depends on the clock output of your Atheros AR8035 PHY. Please have a
>>>     look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set
>>>     "clk-out-frequency = <125000000>" because that value was the hardcoded
>>>     value until this commit.
>>>
>>>     Signed-off-by: Michael Walle <michael@walle.cc>
>>>     Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>>>
>>> , the clock output setting for the AR803x driver is removed from being
>>> hardcoded in the PHY driver and should be passed via device tree instead.
>>>
>>> Update the device tree with the "qca,clk-out-frequency" property so that
>>> Ethernet can work again.
>>>
>>> Reported-by: Soeren Moch <smoch@web.de>
>>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>> Tested-by: Soeren Moch <smoch@web.de>
> 
> My understanding is that Stefano does not have any other pull requests
> for 2020.07.
> 

Yes, I do not see (this is an exception) other urgent patches that
should flow into the release.

> In this case, could you apply this regression fix directly?
> 

+1

Thanks,
Stefano

> Thanks
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression

[Tom Rini]

On Thu, Jun 25, 2020 at 04:18:00PM +0200, Stefano Babic wrote:
> On 25.06.20 15:55, Fabio Estevam wrote:
> > Hi Tom,
> > 
> > On Thu, Jun 25, 2020 at 10:52 AM Soeren Moch <smoch@web.de> wrote:
> >>
> >> On 25.06.20 13:14, Fabio Estevam wrote:
> >>> Since commit:
> >>>
> >>> commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc
> >>> Author: Michael Walle <michael@walle.cc>
> >>> Date:   Thu May 7 00:11:58 2020 +0200
> >>>
> >>>     phy: atheros: ar8035: remove static clock config
> >>>
> >>>     We can configure the clock output in the device tree. Disable the
> >>>     hardcoded one in here. This is highly board-specific and should have
> >>>     never been enabled in the PHY driver.
> >>>
> >>>     If bisecting shows that this commit breaks your board it probably
> >>>     depends on the clock output of your Atheros AR8035 PHY. Please have a
> >>>     look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set
> >>>     "clk-out-frequency = <125000000>" because that value was the hardcoded
> >>>     value until this commit.
> >>>
> >>>     Signed-off-by: Michael Walle <michael@walle.cc>
> >>>     Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> >>>
> >>> , the clock output setting for the AR803x driver is removed from being
> >>> hardcoded in the PHY driver and should be passed via device tree instead.
> >>>
> >>> Update the device tree with the "qca,clk-out-frequency" property so that
> >>> Ethernet can work again.
> >>>
> >>> Reported-by: Soeren Moch <smoch@web.de>
> >>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> >> Tested-by: Soeren Moch <smoch@web.de>
> > 
> > My understanding is that Stefano does not have any other pull requests
> > for 2020.07.
> > 
> 
> Yes, I do not see (this is an exception) other urgent patches that
> should flow into the release.
> 
> > In this case, could you apply this regression fix directly?
> > 
> 
> +1

OK, will do, thanks for sorting this out so quickly!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200625/3c9869aa/attachment.sig>

[PATCH v2] ARM: dts: imx6q-tbs2910: Fix Ethernet regression

[Tom Rini]

On Thu, Jun 25, 2020 at 08:14:57AM -0300, Fabio Estevam wrote:

> Since commit:
> 
> commit 6333cbb3817ed551cd7d4e92f7359c73ccc567fc
> Author: Michael Walle <michael@walle.cc>
> Date:   Thu May 7 00:11:58 2020 +0200
> 
>     phy: atheros: ar8035: remove static clock config
> 
>     We can configure the clock output in the device tree. Disable the
>     hardcoded one in here. This is highly board-specific and should have
>     never been enabled in the PHY driver.
> 
>     If bisecting shows that this commit breaks your board it probably
>     depends on the clock output of your Atheros AR8035 PHY. Please have a
>     look at doc/device-tree-bindings/net/phy/atheros.txt. You need to set
>     "clk-out-frequency = <125000000>" because that value was the hardcoded
>     value until this commit.
> 
>     Signed-off-by: Michael Walle <michael@walle.cc>
>     Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> 
> , the clock output setting for the AR803x driver is removed from being 
> hardcoded in the PHY driver and should be passed via device tree instead.
> 
> Update the device tree with the "qca,clk-out-frequency" property so that
> Ethernet can work again.
> 
> Reported-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Tested-by: Soeren Moch <smoch@web.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200625/664ca1e6/attachment.sig>