* [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp
@ 2020-06-25 20:17 Douglas Anderson
2020-06-26 8:44 ` Rakesh Pillai
2020-07-09 8:36 ` Rakesh Pillai
0 siblings, 2 replies; 3+ messages in thread
From: Douglas Anderson @ 2020-06-25 20:17 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: Evan Green, Sibi Sankar, Rakesh Pillai, Douglas Anderson,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
The WiFi supplies that were added recently can't have done anything
useful because they were missing the "-supply" suffix. Booting
without the "-supply" suffix would give these messages:
ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-0.8-cx-mx not found, using dummy regulator
ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-1.8-xo not found, using dummy regulator
ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-1.3-rfa not found, using dummy regulator
ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-3.3-ch0 not found, using dummy regulator
Let's add the "-supply" suffix.
Fixes: 1e7594a38f37 ("arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
I don't have an IDP setup but I have a similar board. Testing on IDP
would, of course, be appreciated.
Repost because I screwed up the "after-the-cut" notes on first post.
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 39dbfc89689e..472f7f41cc93 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -391,10 +391,10 @@ video-firmware {
&wifi {
status = "okay";
- vdd-0.8-cx-mx = <&vreg_l9a_0p6>;
- vdd-1.8-xo = <&vreg_l1c_1p8>;
- vdd-1.3-rfa = <&vreg_l2c_1p3>;
- vdd-3.3-ch0 = <&vreg_l10c_3p3>;
+ vdd-0.8-cx-mx-supply = <&vreg_l9a_0p6>;
+ vdd-1.8-xo-supply = <&vreg_l1c_1p8>;
+ vdd-1.3-rfa-supply = <&vreg_l2c_1p3>;
+ vdd-3.3-ch0-supply = <&vreg_l10c_3p3>;
wifi-firmware {
iommus = <&apps_smmu 0xc2 0x1>;
};
--
2.27.0.212.ge8ba1cc988-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp
2020-06-25 20:17 [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp Douglas Anderson
@ 2020-06-26 8:44 ` Rakesh Pillai
2020-07-09 8:36 ` Rakesh Pillai
1 sibling, 0 replies; 3+ messages in thread
From: Rakesh Pillai @ 2020-06-26 8:44 UTC (permalink / raw)
To: 'Douglas Anderson', 'Andy Gross',
'Bjorn Andersson'
Cc: 'Evan Green', 'Sibi Sankar',
'Rob Herring',
devicetree, linux-arm-msm, linux-kernel
> -----Original Message-----
> From: Douglas Anderson <dianders@chromium.org>
> Sent: Friday, June 26, 2020 1:47 AM
> To: Andy Gross <agross@kernel.org>; Bjorn Andersson
> <bjorn.andersson@linaro.org>
> Cc: Evan Green <evgreen@chromium.org>; Sibi Sankar
> <sibis@codeaurora.org>; Rakesh Pillai <pillair@codeaurora.org>; Douglas
> Anderson <dianders@chromium.org>; Rob Herring <robh+dt@kernel.org>;
> devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp
>
> The WiFi supplies that were added recently can't have done anything
> useful because they were missing the "-supply" suffix. Booting
> without the "-supply" suffix would give these messages:
>
> ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-0.8-cx-mx not found,
> using dummy regulator
> ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-1.8-xo not found,
using
> dummy regulator
> ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-1.3-rfa not found,
using
> dummy regulator
> ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-3.3-ch0 not found,
> using dummy regulator
>
> Let's add the "-supply" suffix.
>
> Fixes: 1e7594a38f37 ("arm64: dts: qcom: sc7180: Add WCN3990 WLAN
> module device node")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>
I missed this in the DTSI patch, while manually rebasing to the kernel tip.
> I don't have an IDP setup but I have a similar board. Testing on IDP
> would, of course, be appreciated.
>
> Repost because I screwed up the "after-the-cut" notes on first post.
>
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 39dbfc89689e..472f7f41cc93 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -391,10 +391,10 @@ video-firmware {
>
> &wifi {
> status = "okay";
> - vdd-0.8-cx-mx = <&vreg_l9a_0p6>;
> - vdd-1.8-xo = <&vreg_l1c_1p8>;
> - vdd-1.3-rfa = <&vreg_l2c_1p3>;
> - vdd-3.3-ch0 = <&vreg_l10c_3p3>;
> + vdd-0.8-cx-mx-supply = <&vreg_l9a_0p6>;
> + vdd-1.8-xo-supply = <&vreg_l1c_1p8>;
> + vdd-1.3-rfa-supply = <&vreg_l2c_1p3>;
> + vdd-3.3-ch0-supply = <&vreg_l10c_3p3>;
> wifi-firmware {
> iommus = <&apps_smmu 0xc2 0x1>;
> };
> --
> 2.27.0.212.ge8ba1cc988-goog
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp
2020-06-25 20:17 [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp Douglas Anderson
2020-06-26 8:44 ` Rakesh Pillai
@ 2020-07-09 8:36 ` Rakesh Pillai
1 sibling, 0 replies; 3+ messages in thread
From: Rakesh Pillai @ 2020-07-09 8:36 UTC (permalink / raw)
To: 'Douglas Anderson', 'Andy Gross',
'Bjorn Andersson'
Cc: 'Evan Green', 'Sibi Sankar',
'Rob Herring',
devicetree, linux-arm-msm, linux-kernel
> -----Original Message-----
> From: Rakesh Pillai <pillair@codeaurora.org>
> Sent: Friday, June 26, 2020 2:14 PM
> To: 'Douglas Anderson' <dianders@chromium.org>; 'Andy Gross'
> <agross@kernel.org>; 'Bjorn Andersson' <bjorn.andersson@linaro.org>
> Cc: 'Evan Green' <evgreen@chromium.org>; 'Sibi Sankar'
> <sibis@codeaurora.org>; 'Rob Herring' <robh+dt@kernel.org>;
> 'devicetree@vger.kernel.org' <devicetree@vger.kernel.org>; 'linux-arm-
> msm@vger.kernel.org' <linux-arm-msm@vger.kernel.org>; 'linux-
> kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>
> Subject: RE: [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-
> idp
>
>
>
> > -----Original Message-----
> > From: Douglas Anderson <dianders@chromium.org>
> > Sent: Friday, June 26, 2020 1:47 AM
> > To: Andy Gross <agross@kernel.org>; Bjorn Andersson
> > <bjorn.andersson@linaro.org>
> > Cc: Evan Green <evgreen@chromium.org>; Sibi Sankar
> > <sibis@codeaurora.org>; Rakesh Pillai <pillair@codeaurora.org>; Douglas
> > Anderson <dianders@chromium.org>; Rob Herring <robh+dt@kernel.org>;
> > devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on
sc7180-idp
> >
> > The WiFi supplies that were added recently can't have done anything
> > useful because they were missing the "-supply" suffix. Booting
> > without the "-supply" suffix would give these messages:
> >
> > ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-0.8-cx-mx not found,
> > using dummy regulator
> > ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-1.8-xo not found,
> using
> > dummy regulator
> > ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-1.3-rfa not found,
> using
> > dummy regulator
> > ath10k_snoc 18800000.wifi: 18800000.wifi supply vdd-3.3-ch0 not found,
> > using dummy regulator
> >
> > Let's add the "-supply" suffix.
> >
> > Fixes: 1e7594a38f37 ("arm64: dts: qcom: sc7180: Add WCN3990 WLAN
> > module device node")
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> Reviewed-by: Rakesh Pillai <pillair@codeaurora.org>
Tested-by: Rakesh Pillai <pillair@codeaurora.org>
>
> I missed this in the DTSI patch, while manually rebasing to the kernel
tip.
>
> > I don't have an IDP setup but I have a similar board. Testing on IDP
> > would, of course, be appreciated.
> >
> > Repost because I screwed up the "after-the-cut" notes on first post.
> >
> > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > index 39dbfc89689e..472f7f41cc93 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > @@ -391,10 +391,10 @@ video-firmware {
> >
> > &wifi {
> > status = "okay";
> > - vdd-0.8-cx-mx = <&vreg_l9a_0p6>;
> > - vdd-1.8-xo = <&vreg_l1c_1p8>;
> > - vdd-1.3-rfa = <&vreg_l2c_1p3>;
> > - vdd-3.3-ch0 = <&vreg_l10c_3p3>;
> > + vdd-0.8-cx-mx-supply = <&vreg_l9a_0p6>;
> > + vdd-1.8-xo-supply = <&vreg_l1c_1p8>;
> > + vdd-1.3-rfa-supply = <&vreg_l2c_1p3>;
> > + vdd-3.3-ch0-supply = <&vreg_l10c_3p3>;
> > wifi-firmware {
> > iommus = <&apps_smmu 0xc2 0x1>;
> > };
> > --
> > 2.27.0.212.ge8ba1cc988-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-09 8:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25 20:17 [REPOST PATCH] arm64: dts: qcom: Fix WiFi supplies on sc7180-idp Douglas Anderson
2020-06-26 8:44 ` Rakesh Pillai
2020-07-09 8:36 ` Rakesh Pillai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.