[djwong-xfs:djwong-wtf 188/196] fs/xfs/scrub/dir_repair.c:892:17: sparse: sparse: symbol 'xfs_name_dot' was not declared. Should it be

[djwong-xfs:djwong-wtf 188/196] fs/xfs/scrub/dir_repair.c:892:17: sparse: sparse: symbol 'xfs_name_dot' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git djwong-wtf
head:   ca8918affe0afef5157d52218354c69563b5ab89
commit: 0dacfa4427da8f6f22a5810cfd9caae22113c3de [188/196] xfs: use atomic extent swapping to repair directories
config: x86_64-randconfig-s021-20200626 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-dirty
        git checkout 0dacfa4427da8f6f22a5810cfd9caae22113c3de
        # save the attached .config to linux build tree
        make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

   fs/xfs/xfs_quota.h:166:10: sparse: sparse: preprocessor token xfs_trans_mod_ino_dquot redefined
   fs/xfs/xfs_quota.h:128:9: sparse: this was the original definition
>> fs/xfs/scrub/dir_repair.c:892:17: sparse: sparse: symbol 'xfs_name_dot' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29057 bytes --]

[RFC PATCH djwong-xfs] xfs: xfs_name_dot can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]


Fixes: 0dacfa4427da ("xfs: use atomic extent swapping to repair directories")
Signed-off-by: kernel test robot <lkp@intel.com>
---
 dir_repair.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/scrub/dir_repair.c b/fs/xfs/scrub/dir_repair.c
index 3ac0905f4fcab..291018defbb77 100644
--- a/fs/xfs/scrub/dir_repair.c
+++ b/fs/xfs/scrub/dir_repair.c
@@ -889,7 +889,7 @@ xrep_dir_swap_local(
 	xfs_trans_log_inode(sc->tp, sc->ip, XFS_ILOG_CORE | XFS_ILOG_DDATA);
 }
 
-struct xfs_name xfs_name_dot = { (unsigned char *)".", 1, XFS_DIR3_FT_DIR };
+static struct xfs_name xfs_name_dot = { (unsigned char *)".", 1, XFS_DIR3_FT_DIR };
 
 /* Swap the temporary directory's data fork with the one being repaired. */
 STATIC int