[PATCH] huawei: fix AT^SYSCFGEX acqorder "0201"

[PATCH] huawei: fix AT^SYSCFGEX acqorder "0201"

[Jimmy Gysens]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

Commit 6c574ee24a57d0397e4e3c617016bf026405960a ("huawei: the AT^SYSCFGEX
command supports additional modes") has a mistake for acqorder "0201". It
should be UMTS and GSM preferred.
---
 drivers/huaweimodem/radio-settings.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/huaweimodem/radio-settings.c b/drivers/huaweimodem/radio-settings.c
index ff7be48a..c8ebcba0 100644
--- a/drivers/huaweimodem/radio-settings.c
+++ b/drivers/huaweimodem/radio-settings.c
@@ -210,7 +210,7 @@ static void syscfgex_query_mode_cb(gboolean ok, GAtResult *result,
 	else if (strstr(acqorder, "0302"))
 		mode = (OFONO_RADIO_ACCESS_MODE_LTE | OFONO_RADIO_ACCESS_MODE_UMTS);
 	else if (strstr(acqorder, "0201"))
-		mode = (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_LTE);
+		mode = (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_GSM);
 	else if (strstr(acqorder, "03"))
 		mode = OFONO_RADIO_ACCESS_MODE_LTE;
 	else if (strstr(acqorder, "02"))
@@ -330,7 +330,7 @@ static void syscfgex_set_rat_mode(struct radio_settings_data *rsd,
 
 	if (mode == (OFONO_RADIO_ACCESS_MODE_LTE | OFONO_RADIO_ACCESS_MODE_UMTS))
 		acqorder = "0302";
-	else if (mode == (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_LTE))
+	else if (mode == (OFONO_RADIO_ACCESS_MODE_UMTS | OFONO_RADIO_ACCESS_MODE_GSM))
 		acqorder = "0201";
 
 	snprintf(buf, sizeof(buf), atcmd, acqorder);
-- 
2.17.1

Re: [PATCH] huawei: fix AT^SYSCFGEX acqorder "0201"

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

Hi Jimmy,

On 6/26/20 1:36 AM, Jimmy Gysens wrote:
> Commit 6c574ee24a57d0397e4e3c617016bf026405960a ("huawei: the AT^SYSCFGEX
> command supports additional modes") has a mistake for acqorder "0201". It
> should be UMTS and GSM preferred.
> ---
>   drivers/huaweimodem/radio-settings.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Applied, thanks.

Regards,
-Denis