* [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.
@ 2020-06-26 17:00 Robert Foley
2020-06-29 13:26 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Robert Foley @ 2020-06-26 17:00 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, robert.foley, cota, Stefan Hajnoczi, peter.puhov,
alex.bennee
This is a cleanup patch to follow-up the patch which introduced TSAN.
This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
This does two things:
1. Unrelated ASAN and TSAN code is separate and each function only
has arguments that are actually needed.
2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
access from within #ifdef CONFIG_TSAN.
Signed-off-by: Robert Foley <robert.foley@linaro.org>
---
util/coroutine-ucontext.c | 52 +++++++++++++++++++++++++--------------
1 file changed, 34 insertions(+), 18 deletions(-)
diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c
index 613f4c118e..bac164d1f1 100644
--- a/util/coroutine-ucontext.c
+++ b/util/coroutine-ucontext.c
@@ -47,8 +47,10 @@ typedef struct {
size_t stack_size;
sigjmp_buf env;
+#ifdef CONFIG_TSAN
void *tsan_co_fiber;
void *tsan_caller_fiber;
+#endif
#ifdef CONFIG_VALGRIND_H
unsigned int valgrind_stack_id;
@@ -72,7 +74,10 @@ union cc_arg {
int i[2];
};
-/* QEMU_ALWAYS_INLINE only does so if __OPTIMIZE__, so we cannot use it. */
+/*
+ * QEMU_ALWAYS_INLINE only does so if __OPTIMIZE__, so we cannot use it.
+ * always_inline is required to avoid TSan runtime fatal errors.
+ */
static inline __attribute__((always_inline))
void on_new_fiber(CoroutineUContext *co)
{
@@ -82,6 +87,7 @@ void on_new_fiber(CoroutineUContext *co)
#endif
}
+/* always_inline is required to avoid TSan runtime fatal errors. */
static inline __attribute__((always_inline))
void finish_switch_fiber(void *fake_stack_save)
{
@@ -104,18 +110,29 @@ void finish_switch_fiber(void *fake_stack_save)
#endif
}
-static inline __attribute__((always_inline)) void start_switch_fiber(
- CoroutineAction action, void **fake_stack_save,
- const void *bottom, size_t size, void *new_fiber)
+/* always_inline is required to avoid TSan runtime fatal errors. */
+static inline __attribute__((always_inline))
+void start_switch_fiber_asan(CoroutineAction action, void **fake_stack_save,
+ const void *bottom, size_t size)
{
#ifdef CONFIG_ASAN
__sanitizer_start_switch_fiber(
action == COROUTINE_TERMINATE ? NULL : fake_stack_save,
bottom, size);
#endif
+}
+
+/* always_inline is required to avoid TSan runtime fatal errors. */
+static inline __attribute__((always_inline))
+void start_switch_fiber_tsan(void **fake_stack_save,
+ CoroutineUContext *co,
+ bool caller)
+{
#ifdef CONFIG_TSAN
- void *curr_fiber =
- __tsan_get_current_fiber();
+ void *new_fiber = caller ?
+ co->tsan_caller_fiber :
+ co->tsan_co_fiber;
+ void *curr_fiber = __tsan_get_current_fiber();
__tsan_acquire(curr_fiber);
*fake_stack_save = curr_fiber;
@@ -139,12 +156,9 @@ static void coroutine_trampoline(int i0, int i1)
/* Initialize longjmp environment and switch back the caller */
if (!sigsetjmp(self->env, 0)) {
- start_switch_fiber(
- COROUTINE_YIELD,
- &fake_stack_save,
- leader.stack,
- leader.stack_size,
- self->tsan_caller_fiber);
+ start_switch_fiber_asan(COROUTINE_YIELD, &fake_stack_save, leader.stack,
+ leader.stack_size);
+ start_switch_fiber_tsan(&fake_stack_save, self, true); /* true=caller */
siglongjmp(*(sigjmp_buf *)co->entry_arg, 1);
}
@@ -199,10 +213,10 @@ Coroutine *qemu_coroutine_new(void)
/* swapcontext() in, siglongjmp() back out */
if (!sigsetjmp(old_env, 0)) {
- start_switch_fiber(
- COROUTINE_YIELD,
- &fake_stack_save,
- co->stack, co->stack_size, co->tsan_co_fiber);
+ start_switch_fiber_asan(COROUTINE_YIELD, &fake_stack_save, co->stack,
+ co->stack_size);
+ start_switch_fiber_tsan(&fake_stack_save,
+ co, false); /* false=not caller */
swapcontext(&old_uc, &uc);
}
@@ -259,8 +273,10 @@ qemu_coroutine_switch(Coroutine *from_, Coroutine *to_,
ret = sigsetjmp(from->env, 0);
if (ret == 0) {
- start_switch_fiber(action, &fake_stack_save,
- to->stack, to->stack_size, to->tsan_co_fiber);
+ start_switch_fiber_asan(action, &fake_stack_save, to->stack,
+ to->stack_size);
+ start_switch_fiber_tsan(&fake_stack_save,
+ to, false); /* false=not caller */
siglongjmp(to->env, action);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.
2020-06-26 17:00 [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN Robert Foley
@ 2020-06-29 13:26 ` Stefan Hajnoczi
2020-06-29 16:04 ` Alex Bennée
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2020-06-29 13:26 UTC (permalink / raw)
To: Robert Foley
Cc: Kevin Wolf, qemu-devel, cota, Stefan Hajnoczi, peter.puhov, alex.bennee
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Fri, Jun 26, 2020 at 01:00:01PM -0400, Robert Foley wrote:
> This is a cleanup patch to follow-up the patch which introduced TSAN.
> This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
>
> This does two things:
> 1. Unrelated ASAN and TSAN code is separate and each function only
> has arguments that are actually needed.
> 2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
> access from within #ifdef CONFIG_TSAN.
>
> Signed-off-by: Robert Foley <robert.foley@linaro.org>
> ---
> util/coroutine-ucontext.c | 52 +++++++++++++++++++++++++--------------
> 1 file changed, 34 insertions(+), 18 deletions(-)
Thank you for revisiting this patch after it was applied!
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.
2020-06-29 13:26 ` Stefan Hajnoczi
@ 2020-06-29 16:04 ` Alex Bennée
2020-06-30 8:50 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Alex Bennée @ 2020-06-29 16:04 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Robert Foley, qemu-devel, cota, Stefan Hajnoczi, peter.puhov
Stefan Hajnoczi <stefanha@gmail.com> writes:
> On Fri, Jun 26, 2020 at 01:00:01PM -0400, Robert Foley wrote:
>> This is a cleanup patch to follow-up the patch which introduced TSAN.
>> This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
>>
>> This does two things:
>> 1. Unrelated ASAN and TSAN code is separate and each function only
>> has arguments that are actually needed.
>> 2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
>> access from within #ifdef CONFIG_TSAN.
>>
>> Signed-off-by: Robert Foley <robert.foley@linaro.org>
>> ---
>> util/coroutine-ucontext.c | 52 +++++++++++++++++++++++++--------------
>> 1 file changed, 34 insertions(+), 18 deletions(-)
>
> Thank you for revisiting this patch after it was applied!
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Who takes care of coroutine patches or should this go via a different
tree?
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.
2020-06-29 16:04 ` Alex Bennée
@ 2020-06-30 8:50 ` Stefan Hajnoczi
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2020-06-30 8:50 UTC (permalink / raw)
To: Alex Bennée
Cc: Kevin Wolf, Robert Foley, Stefan Hajnoczi, qemu-devel, cota, peter.puhov
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Mon, Jun 29, 2020 at 05:04:19PM +0100, Alex Bennée wrote:
>
> Stefan Hajnoczi <stefanha@gmail.com> writes:
>
> > On Fri, Jun 26, 2020 at 01:00:01PM -0400, Robert Foley wrote:
> >> This is a cleanup patch to follow-up the patch which introduced TSAN.
> >> This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
> >>
> >> This does two things:
> >> 1. Unrelated ASAN and TSAN code is separate and each function only
> >> has arguments that are actually needed.
> >> 2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
> >> access from within #ifdef CONFIG_TSAN.
> >>
> >> Signed-off-by: Robert Foley <robert.foley@linaro.org>
> >> ---
> >> util/coroutine-ucontext.c | 52 +++++++++++++++++++++++++--------------
> >> 1 file changed, 34 insertions(+), 18 deletions(-)
> >
> > Thank you for revisiting this patch after it was applied!
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Who takes care of coroutine patches or should this go via a different
> tree?
Commit 0aebab04b9289bd37017593b413ce7a762b54c55 ("configure: add
--enable-tsan flag + fiber annotations for coroutine-ucontext") went
through your tree. Please take this follow-up patch too.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-30 8:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-26 17:00 [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN Robert Foley
2020-06-29 13:26 ` Stefan Hajnoczi
2020-06-29 16:04 ` Alex Bennée
2020-06-30 8:50 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.