From: Jordan Crouse <jcrouse@codeaurora.org> To: linux-arm-msm@vger.kernel.org Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>, iommu@lists.linux-foundation.org, John Stultz <john.stultz@linaro.org>, freedreno@lists.freedesktop.org, Joerg Roedel <jroedel@suse.de>, Robin Murphy <robin.murphy@arm.com>, Will Deacon <will@kernel.org>, Yong Wu <yong.wu@mediatek.com>, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/6] iommu/io-pgtable: Allow a pgtable implementation to skip TLB operations Date: Fri, 26 Jun 2020 14:04:10 -0600 [thread overview] Message-ID: <20200626200414.14382-3-jcrouse@codeaurora.org> (raw) In-Reply-To: <20200626200414.14382-1-jcrouse@codeaurora.org> Allow a io-pgtable implementation to skip TLB operations by checking for NULL pointers in the helper functions. It will be up to to the owner of the io-pgtable instance to make sure that they independently handle the TLB correctly. Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> --- include/linux/io-pgtable.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/linux/io-pgtable.h b/include/linux/io-pgtable.h index 53d53c6c2be9..bbed1d3925ba 100644 --- a/include/linux/io-pgtable.h +++ b/include/linux/io-pgtable.h @@ -210,21 +210,24 @@ struct io_pgtable { static inline void io_pgtable_tlb_flush_all(struct io_pgtable *iop) { - iop->cfg.tlb->tlb_flush_all(iop->cookie); + if (iop->cfg.tlb) + iop->cfg.tlb->tlb_flush_all(iop->cookie); } static inline void io_pgtable_tlb_flush_walk(struct io_pgtable *iop, unsigned long iova, size_t size, size_t granule) { - iop->cfg.tlb->tlb_flush_walk(iova, size, granule, iop->cookie); + if (iop->cfg.tlb) + iop->cfg.tlb->tlb_flush_walk(iova, size, granule, iop->cookie); } static inline void io_pgtable_tlb_flush_leaf(struct io_pgtable *iop, unsigned long iova, size_t size, size_t granule) { - iop->cfg.tlb->tlb_flush_leaf(iova, size, granule, iop->cookie); + if (iop->cfg.tlb) + iop->cfg.tlb->tlb_flush_leaf(iova, size, granule, iop->cookie); } static inline void @@ -232,7 +235,7 @@ io_pgtable_tlb_add_page(struct io_pgtable *iop, struct iommu_iotlb_gather * gather, unsigned long iova, size_t granule) { - if (iop->cfg.tlb->tlb_add_page) + if (iop->cfg.tlb && iop->cfg.tlb->tlb_add_page) iop->cfg.tlb->tlb_add_page(gather, iova, granule, iop->cookie); } -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Jordan Crouse <jcrouse@codeaurora.org> To: linux-arm-msm@vger.kernel.org Cc: Joerg Roedel <jroedel@suse.de>, Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, John Stultz <john.stultz@linaro.org>, freedreno@lists.freedesktop.org Subject: [PATCH v2 2/6] iommu/io-pgtable: Allow a pgtable implementation to skip TLB operations Date: Fri, 26 Jun 2020 14:04:10 -0600 [thread overview] Message-ID: <20200626200414.14382-3-jcrouse@codeaurora.org> (raw) In-Reply-To: <20200626200414.14382-1-jcrouse@codeaurora.org> Allow a io-pgtable implementation to skip TLB operations by checking for NULL pointers in the helper functions. It will be up to to the owner of the io-pgtable instance to make sure that they independently handle the TLB correctly. Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> --- include/linux/io-pgtable.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/linux/io-pgtable.h b/include/linux/io-pgtable.h index 53d53c6c2be9..bbed1d3925ba 100644 --- a/include/linux/io-pgtable.h +++ b/include/linux/io-pgtable.h @@ -210,21 +210,24 @@ struct io_pgtable { static inline void io_pgtable_tlb_flush_all(struct io_pgtable *iop) { - iop->cfg.tlb->tlb_flush_all(iop->cookie); + if (iop->cfg.tlb) + iop->cfg.tlb->tlb_flush_all(iop->cookie); } static inline void io_pgtable_tlb_flush_walk(struct io_pgtable *iop, unsigned long iova, size_t size, size_t granule) { - iop->cfg.tlb->tlb_flush_walk(iova, size, granule, iop->cookie); + if (iop->cfg.tlb) + iop->cfg.tlb->tlb_flush_walk(iova, size, granule, iop->cookie); } static inline void io_pgtable_tlb_flush_leaf(struct io_pgtable *iop, unsigned long iova, size_t size, size_t granule) { - iop->cfg.tlb->tlb_flush_leaf(iova, size, granule, iop->cookie); + if (iop->cfg.tlb) + iop->cfg.tlb->tlb_flush_leaf(iova, size, granule, iop->cookie); } static inline void @@ -232,7 +235,7 @@ io_pgtable_tlb_add_page(struct io_pgtable *iop, struct iommu_iotlb_gather * gather, unsigned long iova, size_t granule) { - if (iop->cfg.tlb->tlb_add_page) + if (iop->cfg.tlb && iop->cfg.tlb->tlb_add_page) iop->cfg.tlb->tlb_add_page(gather, iova, granule, iop->cookie); } -- 2.17.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-06-26 20:05 UTC|newest] Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-26 20:04 [PATCH v2 0/6] iommu-arm-smmu: Add auxiliary domains and per-instance pagetables Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` [PATCH v2 1/6] iommu/arm-smmu: Add auxiliary domain support for arm-smmuv2 Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-07-07 10:48 ` Jean-Philippe Brucker 2020-07-07 10:48 ` Jean-Philippe Brucker 2020-07-07 10:48 ` Jean-Philippe Brucker 2020-07-07 12:34 ` Robin Murphy 2020-07-07 12:34 ` Robin Murphy 2020-07-07 12:34 ` Robin Murphy 2020-07-07 15:09 ` [Freedreno] " Rob Clark 2020-07-07 15:09 ` Rob Clark 2020-07-07 15:09 ` Rob Clark 2020-07-13 17:35 ` Jordan Crouse 2020-07-13 17:35 ` Jordan Crouse 2020-07-13 17:35 ` Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse [this message] 2020-06-26 20:04 ` [PATCH v2 2/6] iommu/io-pgtable: Allow a pgtable implementation to skip TLB operations Jordan Crouse 2020-07-07 11:34 ` Robin Murphy 2020-07-07 11:34 ` Robin Murphy 2020-07-07 14:25 ` [Freedreno] " Rob Clark 2020-07-07 14:25 ` Rob Clark 2020-07-07 14:58 ` Rob Clark 2020-07-07 14:58 ` Rob Clark 2020-07-08 19:19 ` Jordan Crouse 2020-07-08 19:19 ` Jordan Crouse 2020-06-26 20:04 ` [PATCH v2 3/6] iommu/arm-smmu: Add a domain attribute to pass the pagetable config Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` [PATCH v2 4/6] drm/msm: Add support to create a local pagetable Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-07-07 11:36 ` Robin Murphy 2020-07-07 11:36 ` Robin Murphy 2020-07-07 11:36 ` Robin Murphy 2020-07-07 14:41 ` [Freedreno] " Rob Clark 2020-07-07 14:41 ` Rob Clark 2020-07-07 14:41 ` Rob Clark 2020-07-08 19:35 ` Jordan Crouse 2020-07-08 19:35 ` Jordan Crouse 2020-07-08 19:35 ` Jordan Crouse 2020-06-26 20:04 ` [PATCH v2 5/6] drm/msm: Add support for address space instances Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` [PATCH v2 6/6] drm/msm/a6xx: Add support for per-instance pagetables Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-26 20:04 ` Jordan Crouse 2020-06-27 19:56 ` Rob Clark 2020-06-27 19:56 ` Rob Clark 2020-06-27 19:56 ` Rob Clark 2020-06-27 20:11 ` Rob Clark 2020-06-27 20:11 ` Rob Clark 2020-06-27 20:11 ` Rob Clark 2020-06-29 14:56 ` [Freedreno] " Jordan Crouse 2020-06-29 14:56 ` Jordan Crouse 2020-06-29 14:56 ` Jordan Crouse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200626200414.14382-3-jcrouse@codeaurora.org \ --to=jcrouse@codeaurora.org \ --cc=freedreno@lists.freedesktop.org \ --cc=iommu@lists.linux-foundation.org \ --cc=john.stultz@linaro.org \ --cc=jroedel@suse.de \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robin.murphy@arm.com \ --cc=saiprakash.ranjan@codeaurora.org \ --cc=will@kernel.org \ --cc=yong.wu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.