From: Lu Baolu <baolu.lu@linux.intel.com> To: Joerg Roedel <joro@8bytes.org>, Alex Williamson <alex.williamson@redhat.com> Cc: Cornelia Huck <cohuck@redhat.com>, Kevin Tian <kevin.tian@intel.com>, Ashok Raj <ashok.raj@intel.com>, Dave Jiang <dave.jiang@intel.com>, Liu Yi L <yi.l.liu@intel.com>, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Lu Baolu <baolu.lu@linux.intel.com> Subject: [PATCH 1/2] iommu: Add iommu_group_get/set_domain() Date: Sat, 27 Jun 2020 11:15:31 +0800 [thread overview] Message-ID: <20200627031532.28046-1-baolu.lu@linux.intel.com> (raw) The hardware assistant vfio mediated device is a use case of iommu aux-domain. The interactions between vfio/mdev and iommu during mdev creation and passthr are: - Create a group for mdev with iommu_group_alloc(); - Add the device to the group with group = iommu_group_alloc(); if (IS_ERR(group)) return PTR_ERR(group); ret = iommu_group_add_device(group, &mdev->dev); if (!ret) dev_info(&mdev->dev, "MDEV: group_id = %d\n", iommu_group_id(group)); - Allocate an aux-domain iommu_domain_alloc() - Attach the aux-domain to the physical device from which the mdev is created. iommu_aux_attach_device() In the whole process, an iommu group was allocated for the mdev and an iommu domain was attached to the group, but the group->domain leaves NULL. As the result, iommu_get_domain_for_dev() doesn't work anymore. This adds iommu_group_get/set_domain() so that group->domain could be managed whenever a domain is attached or detached through the aux-domain api's. Fixes: 7bd50f0cd2fd5 ("vfio/type1: Add domain at(de)taching group helpers") Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> --- drivers/iommu/iommu.c | 28 ++++++++++++++++++++++++++++ include/linux/iommu.h | 14 ++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index d43120eb1dc5..e2b665303d70 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -715,6 +715,34 @@ int iommu_group_set_name(struct iommu_group *group, const char *name) } EXPORT_SYMBOL_GPL(iommu_group_set_name); +/** + * iommu_group_get_domain - get domain of a group + * @group: the group + * + * This is called to get the domain of a group. + */ +struct iommu_domain *iommu_group_get_domain(struct iommu_group *group) +{ + return group->domain; +} +EXPORT_SYMBOL_GPL(iommu_group_get_domain); + +/** + * iommu_group_set_domain - set domain for a group + * @group: the group + * @domain: iommu domain + * + * This is called to set the domain for a group. In aux-domain case, a domain + * might attach or detach to an iommu group through the aux-domain apis, but + * the group->domain doesn't get a chance to be updated there. + */ +void iommu_group_set_domain(struct iommu_group *group, + struct iommu_domain *domain) +{ + group->domain = domain; +} +EXPORT_SYMBOL_GPL(iommu_group_set_domain); + static int iommu_create_device_direct_mappings(struct iommu_group *group, struct device *dev) { diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 5f0b7859d2eb..ff88d548a870 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -496,6 +496,9 @@ extern void iommu_group_set_iommudata(struct iommu_group *group, void *iommu_data, void (*release)(void *iommu_data)); extern int iommu_group_set_name(struct iommu_group *group, const char *name); +extern struct iommu_domain *iommu_group_get_domain(struct iommu_group *group); +extern void iommu_group_set_domain(struct iommu_group *group, + struct iommu_domain *domain); extern int iommu_group_add_device(struct iommu_group *group, struct device *dev); extern void iommu_group_remove_device(struct device *dev); @@ -840,6 +843,17 @@ static inline int iommu_group_set_name(struct iommu_group *group, return -ENODEV; } +static inline +struct iommu_domain *iommu_group_get_domain(struct iommu_group *group) +{ + return NULL; +} + +static inline void iommu_group_set_domain(struct iommu_group *group, + struct iommu_domain *domain) +{ +} + static inline int iommu_group_add_device(struct iommu_group *group, struct device *dev) { -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com> To: Joerg Roedel <joro@8bytes.org>, Alex Williamson <alex.williamson@redhat.com> Cc: Kevin Tian <kevin.tian@intel.com>, Dave Jiang <dave.jiang@intel.com>, Ashok Raj <ashok.raj@intel.com>, kvm@vger.kernel.org, Cornelia Huck <cohuck@redhat.com>, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: [PATCH 1/2] iommu: Add iommu_group_get/set_domain() Date: Sat, 27 Jun 2020 11:15:31 +0800 [thread overview] Message-ID: <20200627031532.28046-1-baolu.lu@linux.intel.com> (raw) The hardware assistant vfio mediated device is a use case of iommu aux-domain. The interactions between vfio/mdev and iommu during mdev creation and passthr are: - Create a group for mdev with iommu_group_alloc(); - Add the device to the group with group = iommu_group_alloc(); if (IS_ERR(group)) return PTR_ERR(group); ret = iommu_group_add_device(group, &mdev->dev); if (!ret) dev_info(&mdev->dev, "MDEV: group_id = %d\n", iommu_group_id(group)); - Allocate an aux-domain iommu_domain_alloc() - Attach the aux-domain to the physical device from which the mdev is created. iommu_aux_attach_device() In the whole process, an iommu group was allocated for the mdev and an iommu domain was attached to the group, but the group->domain leaves NULL. As the result, iommu_get_domain_for_dev() doesn't work anymore. This adds iommu_group_get/set_domain() so that group->domain could be managed whenever a domain is attached or detached through the aux-domain api's. Fixes: 7bd50f0cd2fd5 ("vfio/type1: Add domain at(de)taching group helpers") Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> --- drivers/iommu/iommu.c | 28 ++++++++++++++++++++++++++++ include/linux/iommu.h | 14 ++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index d43120eb1dc5..e2b665303d70 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -715,6 +715,34 @@ int iommu_group_set_name(struct iommu_group *group, const char *name) } EXPORT_SYMBOL_GPL(iommu_group_set_name); +/** + * iommu_group_get_domain - get domain of a group + * @group: the group + * + * This is called to get the domain of a group. + */ +struct iommu_domain *iommu_group_get_domain(struct iommu_group *group) +{ + return group->domain; +} +EXPORT_SYMBOL_GPL(iommu_group_get_domain); + +/** + * iommu_group_set_domain - set domain for a group + * @group: the group + * @domain: iommu domain + * + * This is called to set the domain for a group. In aux-domain case, a domain + * might attach or detach to an iommu group through the aux-domain apis, but + * the group->domain doesn't get a chance to be updated there. + */ +void iommu_group_set_domain(struct iommu_group *group, + struct iommu_domain *domain) +{ + group->domain = domain; +} +EXPORT_SYMBOL_GPL(iommu_group_set_domain); + static int iommu_create_device_direct_mappings(struct iommu_group *group, struct device *dev) { diff --git a/include/linux/iommu.h b/include/linux/iommu.h index 5f0b7859d2eb..ff88d548a870 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -496,6 +496,9 @@ extern void iommu_group_set_iommudata(struct iommu_group *group, void *iommu_data, void (*release)(void *iommu_data)); extern int iommu_group_set_name(struct iommu_group *group, const char *name); +extern struct iommu_domain *iommu_group_get_domain(struct iommu_group *group); +extern void iommu_group_set_domain(struct iommu_group *group, + struct iommu_domain *domain); extern int iommu_group_add_device(struct iommu_group *group, struct device *dev); extern void iommu_group_remove_device(struct device *dev); @@ -840,6 +843,17 @@ static inline int iommu_group_set_name(struct iommu_group *group, return -ENODEV; } +static inline +struct iommu_domain *iommu_group_get_domain(struct iommu_group *group) +{ + return NULL; +} + +static inline void iommu_group_set_domain(struct iommu_group *group, + struct iommu_domain *domain) +{ +} + static inline int iommu_group_add_device(struct iommu_group *group, struct device *dev) { -- 2.17.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2020-06-27 3:19 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-27 3:15 Lu Baolu [this message] 2020-06-27 3:15 ` [PATCH 1/2] iommu: Add iommu_group_get/set_domain() Lu Baolu 2020-06-27 3:15 ` [PATCH 2/2] vfio/type1: Update group->domain after aux attach and detach Lu Baolu 2020-06-27 3:15 ` Lu Baolu 2020-06-29 11:56 ` [PATCH 1/2] iommu: Add iommu_group_get/set_domain() Robin Murphy 2020-06-29 11:56 ` Robin Murphy 2020-06-30 1:03 ` Lu Baolu 2020-06-30 1:03 ` Lu Baolu 2020-06-30 16:51 ` Robin Murphy 2020-06-30 16:51 ` Robin Murphy 2020-07-01 7:32 ` Lu Baolu 2020-07-01 7:32 ` Lu Baolu 2020-07-01 12:18 ` Robin Murphy 2020-07-01 12:18 ` Robin Murphy 2020-07-02 1:32 ` Lu Baolu 2020-07-02 1:32 ` Lu Baolu 2020-07-02 2:36 ` Lu Baolu 2020-07-02 2:36 ` Lu Baolu 2020-07-07 1:26 ` Lu Baolu 2020-07-07 1:26 ` Lu Baolu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200627031532.28046-1-baolu.lu@linux.intel.com \ --to=baolu.lu@linux.intel.com \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=cohuck@redhat.com \ --cc=dave.jiang@intel.com \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.