[PATCH] gitlab: add pycrypto for arm64

[PATCH] gitlab: add pycrypto for arm64

[Kever Yang]

pycrypto is needed for script to generate correct its.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 .gitlab-ci.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index f2e491c117..4841e7afbe 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -67,7 +67,7 @@ build all 64bit ARM platforms:
   script:
     - virtualenv -p /usr/bin/python3 /tmp/venv
     - . /tmp/venv/bin/activate
-    - pip install pyelftools
+    - pip install pyelftools pycrypto
     - ret=0;
       ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
       if [[ $ret -ne 0 ]]; then
@@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
       export USER=gitlab;
       virtualenv -p /usr/bin/python3 /tmp/venv;
       . /tmp/venv/bin/activate;
-      pip install pyelftools pytest;
+      pip install pyelftools pytest pycrypto;
       export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
       export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
       export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";
-- 
2.17.1

[PATCH] gitlab: add pycrypto for arm64

[Tom Rini]

On Sun, Jun 28, 2020 at 06:20:52PM +0800, Kever Yang wrote:

> pycrypto is needed for script to generate correct its.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  .gitlab-ci.yml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index f2e491c117..4841e7afbe 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -67,7 +67,7 @@ build all 64bit ARM platforms:
>    script:
>      - virtualenv -p /usr/bin/python3 /tmp/venv
>      - . /tmp/venv/bin/activate
> -    - pip install pyelftools
> +    - pip install pyelftools pycrypto
>      - ret=0;
>        ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
>        if [[ $ret -ne 0 ]]; then
> @@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
>        export USER=gitlab;
>        virtualenv -p /usr/bin/python3 /tmp/venv;
>        . /tmp/venv/bin/activate;
> -      pip install pyelftools pytest;
> +      pip install pyelftools pytest pycrypto;
>        export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
>        export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
>        export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";

We need to update all of the CI config files to install the needed
modules.  I also assume we haven't pushed changes in yet that require
pycrypto, so which tool is going to need it?  I want to make sure we
document it and perhaps we need to start thinking about a
requirement.txt for our python tools if it's binman that needs it (as
that's what also needs pyelftools).  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200629/12c13587/attachment.sig>

[PATCH] gitlab: add pycrypto for arm64

[Kever Yang]

Hi Tom,

On 2020/6/30 ??12:00, Tom Rini wrote:
> On Sun, Jun 28, 2020 at 06:20:52PM +0800, Kever Yang wrote:
>
>> pycrypto is needed for script to generate correct its.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>>
>>   .gitlab-ci.yml | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index f2e491c117..4841e7afbe 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -67,7 +67,7 @@ build all 64bit ARM platforms:
>>     script:
>>       - virtualenv -p /usr/bin/python3 /tmp/venv
>>       - . /tmp/venv/bin/activate
>> -    - pip install pyelftools
>> +    - pip install pyelftools pycrypto
>>       - ret=0;
>>         ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
>>         if [[ $ret -ne 0 ]]; then
>> @@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
>>         export USER=gitlab;
>>         virtualenv -p /usr/bin/python3 /tmp/venv;
>>         . /tmp/venv/bin/activate;
>> -      pip install pyelftools pytest;
>> +      pip install pyelftools pytest pycrypto;
>>         export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
>>         export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
>>         export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";
> We need to update all of the CI config files to install the needed
> modules.  I also assume we haven't pushed changes in yet that require
> pycrypto, so which tool is going to need it?  I want to make sure we
> document it and perhaps we need to start thinking about a
> requirement.txt for our python tools if it's binman that needs it (as
> that's what also needs pyelftools).  Thanks!

This is need by below patches

http://patchwork.ozlabs.org/project/uboot/cover/20200619104550.1972307-1-heiko at sntech.de/


Thanks,

- Kever

[PATCH] gitlab: add pycrypto for arm64

[Tom Rini]

On Tue, Jun 30, 2020 at 05:17:54PM +0800, Kever Yang wrote:
> Hi Tom,
> 
> On 2020/6/30 ??12:00, Tom Rini wrote:
> > On Sun, Jun 28, 2020 at 06:20:52PM +0800, Kever Yang wrote:
> > 
> > > pycrypto is needed for script to generate correct its.
> > > 
> > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> > > ---
> > > 
> > >   .gitlab-ci.yml | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > > index f2e491c117..4841e7afbe 100644
> > > --- a/.gitlab-ci.yml
> > > +++ b/.gitlab-ci.yml
> > > @@ -67,7 +67,7 @@ build all 64bit ARM platforms:
> > >     script:
> > >       - virtualenv -p /usr/bin/python3 /tmp/venv
> > >       - . /tmp/venv/bin/activate
> > > -    - pip install pyelftools
> > > +    - pip install pyelftools pycrypto
> > >       - ret=0;
> > >         ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
> > >         if [[ $ret -ne 0 ]]; then
> > > @@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
> > >         export USER=gitlab;
> > >         virtualenv -p /usr/bin/python3 /tmp/venv;
> > >         . /tmp/venv/bin/activate;
> > > -      pip install pyelftools pytest;
> > > +      pip install pyelftools pytest pycrypto;
> > >         export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
> > >         export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
> > >         export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";
> > We need to update all of the CI config files to install the needed
> > modules.  I also assume we haven't pushed changes in yet that require
> > pycrypto, so which tool is going to need it?  I want to make sure we
> > document it and perhaps we need to start thinking about a
> > requirement.txt for our python tools if it's binman that needs it (as
> > that's what also needs pyelftools).  Thanks!
> 
> This is need by below patches
> 
> http://patchwork.ozlabs.org/project/uboot/cover/20200619104550.1972307-1-heiko at sntech.de/

OK, so the patch here needs to update all CI, so I'm marking this as
Changes Requested in patchwork.  I have some other comments for that
series (thanks) and I'll follow up there.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200630/e26a428c/attachment.sig>