From: Vinod Koul <vkoul@kernel.org> To: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz> Cc: "Vinod Koul" <vkoul@kernel.org>, "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>, "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>, "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>, "Charles Keepax" <ckeepax@opensource.cirrus.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 0/3] ALSA: compress: Document stream states and fix gapless SM Date: Mon, 29 Jun 2020 19:17:34 +0530 [thread overview] Message-ID: <20200629134737.105993-1-vkoul@kernel.org> (raw) Srini found issue with gapless implementation which prompted to look deeper into SM for compressed stream. So documenting SM was first step, so first two patches add that. Last patch fixes the issue by keeping track on partial_drain and then moving state to 'running' in snd_compr_drain_notify() for partial_drain case on success. While at it, noticed snd_compr_drain_notify() is lockless state change, so fixed that as well. I have tested this on Dragon board RB3, compressed audio works out of the box on that platform and Srini will send driver and fcplay patches for gapless soon. Changes in v5: - Update SM diagram as suggested by Amadeusz Changes in v4: - Add review tag by Charles - fix the lock deadlock pointed by Charles Changes in v3: - Add pause->stop->free transition - Add setup->free transition - remove running->free as that goes thru stop Changes in v2: - Added tested tag by Srini - Update compress SM with Free state and compr_stop() transitions Vinod Koul (3): ALSA: compress: document the compress audio state machine ALSA: compress: document the compress gapless audio state machine ALSA: compress: fix partial_drain completion state .../sound/designs/compress-offload.rst | 83 +++++++++++++++++++ include/sound/compress_driver.h | 10 ++- sound/core/compress_offload.c | 4 + 3 files changed, 96 insertions(+), 1 deletion(-) -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz> Cc: alsa-devel@alsa-project.org, "Charles Keepax" <ckeepax@opensource.cirrus.com>, "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>, linux-kernel@vger.kernel.org, "Vinod Koul" <vkoul@kernel.org>, "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>, "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com> Subject: [PATCH v5 0/3] ALSA: compress: Document stream states and fix gapless SM Date: Mon, 29 Jun 2020 19:17:34 +0530 [thread overview] Message-ID: <20200629134737.105993-1-vkoul@kernel.org> (raw) Srini found issue with gapless implementation which prompted to look deeper into SM for compressed stream. So documenting SM was first step, so first two patches add that. Last patch fixes the issue by keeping track on partial_drain and then moving state to 'running' in snd_compr_drain_notify() for partial_drain case on success. While at it, noticed snd_compr_drain_notify() is lockless state change, so fixed that as well. I have tested this on Dragon board RB3, compressed audio works out of the box on that platform and Srini will send driver and fcplay patches for gapless soon. Changes in v5: - Update SM diagram as suggested by Amadeusz Changes in v4: - Add review tag by Charles - fix the lock deadlock pointed by Charles Changes in v3: - Add pause->stop->free transition - Add setup->free transition - remove running->free as that goes thru stop Changes in v2: - Added tested tag by Srini - Update compress SM with Free state and compr_stop() transitions Vinod Koul (3): ALSA: compress: document the compress audio state machine ALSA: compress: document the compress gapless audio state machine ALSA: compress: fix partial_drain completion state .../sound/designs/compress-offload.rst | 83 +++++++++++++++++++ include/sound/compress_driver.h | 10 ++- sound/core/compress_offload.c | 4 + 3 files changed, 96 insertions(+), 1 deletion(-) -- 2.26.2
next reply other threads:[~2020-06-29 18:42 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 13:47 Vinod Koul [this message] 2020-06-29 13:47 ` [PATCH v5 0/3] ALSA: compress: Document stream states and fix gapless SM Vinod Koul 2020-06-29 13:47 ` [PATCH v5 1/3] ALSA: compress: document the compress audio state machine Vinod Koul 2020-06-29 13:47 ` Vinod Koul 2020-07-07 9:54 ` Takashi Iwai 2020-07-07 9:54 ` Takashi Iwai 2020-06-29 13:47 ` [PATCH v5 2/3] ALSA: compress: document the compress gapless " Vinod Koul 2020-06-29 13:47 ` Vinod Koul 2020-07-07 9:54 ` Takashi Iwai 2020-07-07 9:54 ` Takashi Iwai 2020-06-29 13:47 ` [PATCH v5 3/3] ALSA: compress: fix partial_drain completion state Vinod Koul 2020-06-29 13:47 ` Vinod Koul 2020-07-01 14:20 ` Charles Keepax 2020-07-01 14:20 ` Charles Keepax 2020-07-01 15:04 ` Vinod Koul 2020-07-01 15:04 ` Vinod Koul 2020-07-07 9:55 ` Takashi Iwai 2020-07-07 9:55 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200629134737.105993-1-vkoul@kernel.org \ --to=vkoul@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=amadeuszx.slawinski@linux.intel.com \ --cc=ckeepax@opensource.cirrus.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.