From: Eric Biggers <ebiggers@kernel.org> To: Satya Tangirala <satyat@google.com> Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org> Subject: Re: [PATCH v2 3/4] f2fs: add inline encryption support Date: Mon, 29 Jun 2020 11:53:20 -0700 [thread overview] Message-ID: <20200629185320.GH20492@sol.localdomain> (raw) In-Reply-To: <20200629120405.701023-4-satyat@google.com> On Mon, Jun 29, 2020 at 12:04:04PM +0000, Satya Tangirala via Linux-f2fs-devel wrote: > Wire up f2fs to support inline encryption via the helper functions which > fs/crypto/ now provides. This includes: > > - Adding a mount option 'inlinecrypt' which enables inline encryption > on encrypted files where it can be used. > > - Setting the bio_crypt_ctx on bios that will be submitted to an > inline-encrypted file. > > - Not adding logically discontiguous data to bios that will be submitted > to an inline-encrypted file. > > - Not doing filesystem-layer crypto on inline-encrypted files. > > This patch includes a fix for a race during IPU by > Sahitya Tummala <stummala@codeaurora.org> > > Co-developed-by: Eric Biggers <ebiggers@google.com> > Signed-off-by: Eric Biggers <ebiggers@google.com> > Signed-off-by: Satya Tangirala <satyat@google.com> > Acked-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Eric Biggers <ebiggers@google.com> > --- > Documentation/filesystems/f2fs.rst | 7 +++ > fs/f2fs/compress.c | 2 +- > fs/f2fs/data.c | 78 +++++++++++++++++++++++++----- > fs/f2fs/super.c | 35 ++++++++++++++ > 4 files changed, 108 insertions(+), 14 deletions(-) > > diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst > index 099d45ac8d8f..8b4fac44f4e1 100644 > --- a/Documentation/filesystems/f2fs.rst > +++ b/Documentation/filesystems/f2fs.rst > @@ -258,6 +258,13 @@ compress_extension=%s Support adding specified extension, so that f2fs can enab > on compression extension list and enable compression on > these file by default rather than to enable it via ioctl. > For other files, we can still enable compression via ioctl. > +inlinecrypt > + When possible, encrypt/decrypt the contents of encrypted > + files using the blk-crypto framework rather than > + filesystem-layer encryption. This allows the use of > + inline encryption hardware. The on-disk format is > + unaffected. For more details, see > + Documentation/block/inline-encryption.rst. > ====================== ============================================================ Last time I suggested adding "When possible, ", and it got added here but not in the ext4 patch. It should go in both. - Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org> To: Satya Tangirala <satyat@google.com> Cc: linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v2 3/4] f2fs: add inline encryption support Date: Mon, 29 Jun 2020 11:53:20 -0700 [thread overview] Message-ID: <20200629185320.GH20492@sol.localdomain> (raw) In-Reply-To: <20200629120405.701023-4-satyat@google.com> On Mon, Jun 29, 2020 at 12:04:04PM +0000, Satya Tangirala via Linux-f2fs-devel wrote: > Wire up f2fs to support inline encryption via the helper functions which > fs/crypto/ now provides. This includes: > > - Adding a mount option 'inlinecrypt' which enables inline encryption > on encrypted files where it can be used. > > - Setting the bio_crypt_ctx on bios that will be submitted to an > inline-encrypted file. > > - Not adding logically discontiguous data to bios that will be submitted > to an inline-encrypted file. > > - Not doing filesystem-layer crypto on inline-encrypted files. > > This patch includes a fix for a race during IPU by > Sahitya Tummala <stummala@codeaurora.org> > > Co-developed-by: Eric Biggers <ebiggers@google.com> > Signed-off-by: Eric Biggers <ebiggers@google.com> > Signed-off-by: Satya Tangirala <satyat@google.com> > Acked-by: Jaegeuk Kim <jaegeuk@kernel.org> Reviewed-by: Eric Biggers <ebiggers@google.com> > --- > Documentation/filesystems/f2fs.rst | 7 +++ > fs/f2fs/compress.c | 2 +- > fs/f2fs/data.c | 78 +++++++++++++++++++++++++----- > fs/f2fs/super.c | 35 ++++++++++++++ > 4 files changed, 108 insertions(+), 14 deletions(-) > > diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst > index 099d45ac8d8f..8b4fac44f4e1 100644 > --- a/Documentation/filesystems/f2fs.rst > +++ b/Documentation/filesystems/f2fs.rst > @@ -258,6 +258,13 @@ compress_extension=%s Support adding specified extension, so that f2fs can enab > on compression extension list and enable compression on > these file by default rather than to enable it via ioctl. > For other files, we can still enable compression via ioctl. > +inlinecrypt > + When possible, encrypt/decrypt the contents of encrypted > + files using the blk-crypto framework rather than > + filesystem-layer encryption. This allows the use of > + inline encryption hardware. The on-disk format is > + unaffected. For more details, see > + Documentation/block/inline-encryption.rst. > ====================== ============================================================ Last time I suggested adding "When possible, ", and it got added here but not in the ext4 patch. It should go in both. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-06-29 21:17 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 12:04 [PATCH v2 0/4] Inline Encryption Support for fscrypt Satya Tangirala 2020-06-29 12:04 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-29 12:04 ` [PATCH v2 1/4] fs: introduce SB_INLINECRYPT Satya Tangirala 2020-06-29 12:04 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-29 18:24 ` Eric Biggers 2020-06-29 18:24 ` [f2fs-dev] " Eric Biggers 2020-06-29 12:04 ` [PATCH v2 2/4] fscrypt: add inline encryption support Satya Tangirala 2020-06-29 12:04 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-29 18:22 ` Eric Biggers 2020-06-29 18:22 ` [f2fs-dev] " Eric Biggers 2020-06-29 12:04 ` [PATCH v2 3/4] f2fs: " Satya Tangirala 2020-06-29 12:04 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-29 18:53 ` Eric Biggers [this message] 2020-06-29 18:53 ` Eric Biggers 2020-06-29 12:04 ` [PATCH v2 4/4] ext4: " Satya Tangirala 2020-06-29 12:04 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-06-29 18:44 ` Eric Biggers 2020-06-29 18:44 ` [f2fs-dev] " Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200629185320.GH20492@sol.localdomain \ --to=ebiggers@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=satyat@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.