* [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case
@ 2020-06-30 6:41 sai.gowtham.ch
2020-06-30 8:56 ` Melkaveri, Arjun
2020-06-30 9:28 ` Chris Wilson
0 siblings, 2 replies; 5+ messages in thread
From: sai.gowtham.ch @ 2020-06-30 6:41 UTC (permalink / raw)
To: igt-dev, arjun.melkaveri, sai.gowtham.ch
From: sai gowtham <sai.gowtham.ch@intel.com>
Added test description for test and to all 3 subtests.
Signed-off-by: sai gowtham <sai.gowtham.ch@intel.com>
---
tests/i915/gem_exec_create.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
index ee7d4e5d..5236d477 100644
--- a/tests/i915/gem_exec_create.c
+++ b/tests/i915/gem_exec_create.c
@@ -42,6 +42,10 @@
#include "i915/gem.h"
#include "igt.h"
+IGT_TEST_DESCRIPTION("\n This test runs an uninterrupted loop within the specified timeouts"
+ " with different flags & ncpus combinations and checks if there are any"
+ " missed interrupts reported from the driver.");
+
#define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
static double elapsed(const struct timespec *start, const struct timespec *end)
@@ -133,12 +137,16 @@ igt_main
igt_fork_hang_detector(device);
}
-
+ igt_describe("Runs single uninterrupted loop for 2s.");
igt_subtest("basic")
all(device, 0, 2, 1);
+
+ igt_describe("Runs single uninterrupted loop for 20s.");
igt_subtest("forked")
all(device, 0, 20, ncpus);
+ igt_describe("Runs single uninterrupted loop with"
+ " different flag combination for 20s.");
igt_subtest("madvise")
all(device, LEAK, 20, 1);
--
2.25.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case
2020-06-30 6:41 [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
@ 2020-06-30 8:56 ` Melkaveri, Arjun
2020-06-30 9:28 ` Chris Wilson
1 sibling, 0 replies; 5+ messages in thread
From: Melkaveri, Arjun @ 2020-06-30 8:56 UTC (permalink / raw)
To: sai.gowtham.ch; +Cc: igt-dev
On Tue, Jun 30, 2020 at 12:11:10PM +0530, sai.gowtham.ch@intel.com wrote:
> From: sai gowtham <sai.gowtham.ch@intel.com>
>
> Added test description for test and to all 3 subtests.
>
> Signed-off-by: sai gowtham <sai.gowtham.ch@intel.com>
> ---
> tests/i915/gem_exec_create.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
> index ee7d4e5d..5236d477 100644
> --- a/tests/i915/gem_exec_create.c
> +++ b/tests/i915/gem_exec_create.c
> @@ -42,6 +42,10 @@
> #include "i915/gem.h"
> #include "igt.h"
>
> +IGT_TEST_DESCRIPTION("\n This test runs an uninterrupted loop within the specified timeouts"
> + " with different flags & ncpus combinations and checks if there are any"
> + " missed interrupts reported from the driver.");
> +
> #define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
>
> static double elapsed(const struct timespec *start, const struct timespec *end)
> @@ -133,12 +137,16 @@ igt_main
>
> igt_fork_hang_detector(device);
> }
> -
> + igt_describe("Runs single uninterrupted loop for 2s.");
> igt_subtest("basic")
> all(device, 0, 2, 1);
> +
> + igt_describe("Runs single uninterrupted loop for 20s.");
Can you add more information here . What happens in Forked subtest
> igt_subtest("forked")
> all(device, 0, 20, ncpus);
>
> + igt_describe("Runs single uninterrupted loop with"
> + " different flag combination for 20s.");
Same as above , Need more description of subtest . What does LEAK here
signify . git blame/log would give you moe information to update this .
> igt_subtest("madvise")
> all(device, LEAK, 20, 1);
>
> --
> 2.25.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case
2020-06-30 6:41 [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
2020-06-30 8:56 ` Melkaveri, Arjun
@ 2020-06-30 9:28 ` Chris Wilson
2020-07-01 4:22 ` Ch, Sai Gowtham
1 sibling, 1 reply; 5+ messages in thread
From: Chris Wilson @ 2020-06-30 9:28 UTC (permalink / raw)
To: arjun.melkaveri, igt-dev, sai.gowtham.ch
Quoting sai.gowtham.ch@intel.com (2020-06-30 07:41:10)
> From: sai gowtham <sai.gowtham.ch@intel.com>
>
> Added test description for test and to all 3 subtests.
>
> Signed-off-by: sai gowtham <sai.gowtham.ch@intel.com>
> ---
> tests/i915/gem_exec_create.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
> index ee7d4e5d..5236d477 100644
> --- a/tests/i915/gem_exec_create.c
> +++ b/tests/i915/gem_exec_create.c
> @@ -42,6 +42,10 @@
> #include "i915/gem.h"
> #include "igt.h"
>
> +IGT_TEST_DESCRIPTION("\n This test runs an uninterrupted loop within the specified timeouts"
> + " with different flags & ncpus combinations and checks if there are any"
> + " missed interrupts reported from the driver.");
No. The intent of the test is to flood the driver with transient active
objects and check we don't kill the system under the mempressure. Some
of the symptoms we look for include mysterious hangs.
> +
> #define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
>
> static double elapsed(const struct timespec *start, const struct timespec *end)
> @@ -133,12 +137,16 @@ igt_main
>
> igt_fork_hang_detector(device);
> }
> -
Lost visual whitespacing.
> + igt_describe("Runs single uninterrupted loop for 2s.");
> igt_subtest("basic")
> all(device, 0, 2, 1);
> +
> + igt_describe("Runs single uninterrupted loop for 20s.");
> igt_subtest("forked")
> all(device, 0, 20, ncpus);
>
> + igt_describe("Runs single uninterrupted loop with"
> + " different flag combination for 20s.");
That is abysmal. We already know the above and more from the test setup
itself. The difference in the test intentions should be discernible from
the different path coverage in the driver...
Quick sanitycheck; concurrent execution; forced reclaim, behaving like a
bad application leaking its bo cache.
> igt_subtest("madvise")
> all(device, LEAK, 20, 1);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case
2020-06-30 9:28 ` Chris Wilson
@ 2020-07-01 4:22 ` Ch, Sai Gowtham
0 siblings, 0 replies; 5+ messages in thread
From: Ch, Sai Gowtham @ 2020-07-01 4:22 UTC (permalink / raw)
To: Chris Wilson, Melkaveri, Arjun, igt-dev
Thank you for your inputs and correcting my understanding Chris, Sure I'll make changes accordingly.
-----Original Message-----
From: Chris Wilson <chris@chris-wilson.co.uk>
Sent: Tuesday, June 30, 2020 2:58 PM
To: Melkaveri, Arjun <arjun.melkaveri@intel.com>; igt-dev@lists.freedesktop.org; Ch, Sai Gowtham <sai.gowtham.ch@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case
Quoting sai.gowtham.ch@intel.com (2020-06-30 07:41:10)
> From: sai gowtham <sai.gowtham.ch@intel.com>
>
> Added test description for test and to all 3 subtests.
>
> Signed-off-by: sai gowtham <sai.gowtham.ch@intel.com>
> ---
> tests/i915/gem_exec_create.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_create.c
> b/tests/i915/gem_exec_create.c index ee7d4e5d..5236d477 100644
> --- a/tests/i915/gem_exec_create.c
> +++ b/tests/i915/gem_exec_create.c
> @@ -42,6 +42,10 @@
> #include "i915/gem.h"
> #include "igt.h"
>
> +IGT_TEST_DESCRIPTION("\n This test runs an uninterrupted loop within the specified timeouts"
> + " with different flags & ncpus combinations and checks if there are any"
> + " missed interrupts reported from the driver.");
No. The intent of the test is to flood the driver with transient active objects and check we don't kill the system under the mempressure. Some of the symptoms we look for include mysterious hangs.
> +
> #define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
>
> static double elapsed(const struct timespec *start, const struct
> timespec *end) @@ -133,12 +137,16 @@ igt_main
>
> igt_fork_hang_detector(device);
> }
> -
Lost visual whitespacing.
> + igt_describe("Runs single uninterrupted loop for 2s.");
> igt_subtest("basic")
> all(device, 0, 2, 1);
> +
> + igt_describe("Runs single uninterrupted loop for 20s.");
> igt_subtest("forked")
> all(device, 0, 20, ncpus);
>
> + igt_describe("Runs single uninterrupted loop with"
> + " different flag combination for 20s.");
That is abysmal. We already know the above and more from the test setup itself. The difference in the test intentions should be discernible from the different path coverage in the driver...
Quick sanitycheck; concurrent execution; forced reclaim, behaving like a bad application leaking its bo cache.
> igt_subtest("madvise")
> all(device, LEAK, 20, 1);
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case
@ 2020-06-29 17:16 sai.gowtham.ch
0 siblings, 0 replies; 5+ messages in thread
From: sai.gowtham.ch @ 2020-06-29 17:16 UTC (permalink / raw)
To: igt-dev
From: sai gowtham <sai.gowtham.ch@intel.com>
Added test description for test and to all 3 subtests.
Signed-off-by: sai gowtham <sai.gowtham.ch@intel.com>
---
tests/i915/gem_exec_create.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c
index ee7d4e5d..5236d477 100644
--- a/tests/i915/gem_exec_create.c
+++ b/tests/i915/gem_exec_create.c
@@ -42,6 +42,10 @@
#include "i915/gem.h"
#include "igt.h"
+IGT_TEST_DESCRIPTION("\n This test runs an uninterrupted loop within the specified timeouts"
+ " with different flags & ncpus combinations and checks if there are any"
+ " missed interrupts reported from the driver.");
+
#define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
static double elapsed(const struct timespec *start, const struct timespec *end)
@@ -133,12 +137,16 @@ igt_main
igt_fork_hang_detector(device);
}
-
+ igt_describe("Runs single uninterrupted loop for 2s.");
igt_subtest("basic")
all(device, 0, 2, 1);
+
+ igt_describe("Runs single uninterrupted loop for 20s.");
igt_subtest("forked")
all(device, 0, 20, ncpus);
+ igt_describe("Runs single uninterrupted loop with"
+ " different flag combination for 20s.");
igt_subtest("madvise")
all(device, LEAK, 20, 1);
--
2.25.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-01 4:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 6:41 [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case sai.gowtham.ch
2020-06-30 8:56 ` Melkaveri, Arjun
2020-06-30 9:28 ` Chris Wilson
2020-07-01 4:22 ` Ch, Sai Gowtham
-- strict thread matches above, loose matches on Subject: below --
2020-06-29 17:16 sai.gowtham.ch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.