[PATCH 1/2] python3-libarchive-c: add the missing rdepends

[PATCH 1/2] python3-libarchive-c: add the missing rdepends

[Yu, Mingli]

From: Mingli Yu <mingli.yu@windriver.com>

Add the missing rdepends to fix below error:
 # python3
 [snip]
 >>> import libarchive
 [snip]
 ModuleNotFoundError: No module named 'ctypes'
 ModuleNotFoundError: No module named 'mmap'

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 meta/recipes-devtools/python/python3-libarchive-c_2.9.bb | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/python/python3-libarchive-c_2.9.bb b/meta/recipes-devtools/python/python3-libarchive-c_2.9.bb
index 4983ae527a..3a2d8733e9 100644
--- a/meta/recipes-devtools/python/python3-libarchive-c_2.9.bb
+++ b/meta/recipes-devtools/python/python3-libarchive-c_2.9.bb
@@ -12,6 +12,10 @@ inherit pypi setuptools3
 SRC_URI[md5sum] = "083bd2cb0043c1e22a52cb9a05e31532"
 SRC_URI[sha256sum] = "9919344cec203f5db6596a29b5bc26b07ba9662925a05e24980b84709232ef60"
 
-RDEPENDS_${PN} += "libarchive"
+RDEPENDS_${PN} += "\
+  libarchive \
+  ${PYTHON_PN}-ctypes \
+  ${PYTHON_PN}-mmap \
+"
 
 BBCLASSEXTEND = "native"
-- 
2.17.1

[PATCH 2/2] python3: add ldconfig rdepends for python3-ctypes

[Yu, Mingli]

From: Mingli Yu <mingli.yu@windriver.com>

The ctypes module needs to use "ldconfig -p" to find the
library path and it simply has below logic if no ldconfig
installed.
  except OSError:
      pass

Before the patch:
  >>> from ctypes.util import find_library
  >>> lib_path = find_library('archive')
  >>> print(lib_path)
  None

After the patch:
  >>> from ctypes.util import find_library
  >>> lib_path = find_library('archive')
  >>> print(lib_path)
  libarchive.so.13

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 meta/recipes-devtools/python/python3_3.8.3.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/python/python3_3.8.3.bb b/meta/recipes-devtools/python/python3_3.8.3.bb
index 2eb2a422e6..abcd16e63d 100644
--- a/meta/recipes-devtools/python/python3_3.8.3.bb
+++ b/meta/recipes-devtools/python/python3_3.8.3.bb
@@ -350,6 +350,7 @@ FILES_${PN}-man = "${datadir}/man"
 
 # See https://bugs.python.org/issue18748 and https://bugs.python.org/issue37395
 RDEPENDS_libpython3_append_libc-glibc = " libgcc"
+RDEPENDS_${PN}-ctypes_append_libc-glibc = " ldconfig"
 RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip bzip2 libgcc tzdata-europe coreutils sed"
 RDEPENDS_${PN}-ptest_append_libc-glibc = " locale-base-tr-tr.iso-8859-9"
 RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk tk-lib', '', d)}"
-- 
2.17.1

Re: [OE-core] [PATCH 2/2] python3: add ldconfig rdepends for python3-ctypes

[Richard Purdie]

On Wed, 2020-07-01 at 10:33 +0800, Yu, Mingli wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
> 
> The ctypes module needs to use "ldconfig -p" to find the
> library path and it simply has below logic if no ldconfig
> installed.
>   except OSError:
>       pass
> 
> Before the patch:
>   >>> from ctypes.util import find_library
>   >>> lib_path = find_library('archive')
>   >>> print(lib_path)
>   None
> 
> After the patch:
>   >>> from ctypes.util import find_library
>   >>> lib_path = find_library('archive')
>   >>> print(lib_path)
>   libarchive.so.13
> 
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  meta/recipes-devtools/python/python3_3.8.3.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/python/python3_3.8.3.bb b/meta/recipes-devtools/python/python3_3.8.3.bb
> index 2eb2a422e6..abcd16e63d 100644
> --- a/meta/recipes-devtools/python/python3_3.8.3.bb
> +++ b/meta/recipes-devtools/python/python3_3.8.3.bb
> @@ -350,6 +350,7 @@ FILES_${PN}-man = "${datadir}/man"
>  
>  # See https://bugs.python.org/issue18748 and https://bugs.python.org/issue37395
>  RDEPENDS_libpython3_append_libc-glibc = " libgcc"
> +RDEPENDS_${PN}-ctypes_append_libc-glibc = " ldconfig"
>  RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip bzip2 libgcc tzdata-europe coreutils sed"
>  RDEPENDS_${PN}-ptest_append_libc-glibc = " locale-base-tr-tr.iso-8859-9"
>  RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk tk-lib', '', d)}"

Throws warnings in test builds:

https://autobuilder.yoctoproject.org/typhoon/#/builders/44/builds/2123

Cheers,

Richard

Re: [OE-core] [PATCH 2/2] python3: add ldconfig rdepends for python3-ctypes

[Yu, Mingli]

On 7/1/20 10:20 PM, Richard Purdie wrote:
> On Wed, 2020-07-01 at 10:33 +0800, Yu, Mingli wrote:
>> From: Mingli Yu <mingli.yu@windriver.com>
>>
>> The ctypes module needs to use "ldconfig -p" to find the
>> library path and it simply has below logic if no ldconfig
>> installed.
>>    except OSError:
>>        pass
>>
>> Before the patch:
>>    >>> from ctypes.util import find_library
>>    >>> lib_path = find_library('archive')
>>    >>> print(lib_path)
>>    None
>>
>> After the patch:
>>    >>> from ctypes.util import find_library
>>    >>> lib_path = find_library('archive')
>>    >>> print(lib_path)
>>    libarchive.so.13
>>
>> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
>> ---
>>   meta/recipes-devtools/python/python3_3.8.3.bb | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-devtools/python/python3_3.8.3.bb b/meta/recipes-devtools/python/python3_3.8.3.bb
>> index 2eb2a422e6..abcd16e63d 100644
>> --- a/meta/recipes-devtools/python/python3_3.8.3.bb
>> +++ b/meta/recipes-devtools/python/python3_3.8.3.bb
>> @@ -350,6 +350,7 @@ FILES_${PN}-man = "${datadir}/man"
>>   
>>   # See https://bugs.python.org/issue18748 and https://bugs.python.org/issue37395
>>   RDEPENDS_libpython3_append_libc-glibc = " libgcc"
>> +RDEPENDS_${PN}-ctypes_append_libc-glibc = " ldconfig"
>>   RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip bzip2 libgcc tzdata-europe coreutils sed"
>>   RDEPENDS_${PN}-ptest_append_libc-glibc = " locale-base-tr-tr.iso-8859-9"
>>   RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk tk-lib', '', d)}"
> 
> Throws warnings in test builds:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/44/builds/2123

Will send V2 to fix the warning.

Thanks,

> 
> Cheers,
> 
> Richard
>