* [PATCH v2 0/8] dt-bindings: media: Conversion of Renesas bindings to YAML
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
This patch series converts the DT bindings for the Renesas R-Car FCP,
FDP1 and VSP1 to YAML. It also updates the bindings based on the
properties that have been added to the DT sources over time but never
documented.
Compared to v1, review comments have been incorporated to fix small
typos and simplify a few comments in the bindings, and MAINTAINERS has
been updated.
Rob, this series has been reviewed by Geert, could you merge it ?
Alternatively you can provide acks and I can send a pull request to get
it merged through the linux-media tree.
Laurent Pinchart (8):
dt-bindings: media: renesas,fcp: Convert binding to YAML
dt-bindings: media: renesas,fcp: Make power-domains mandatory
dt-bindings: media: renesas,fcp: Add resets and iommus properties
dt-bindings: media: renesas,fdp1: Convert binding to YAML
dt-bindings: media: renesas,fdp1: Make power-domains mandatory
dt-bindings: media: renesas,fdp1: Add resets property
dt-bindings: media: renesas,vsp1: Convert binding to YAML
dt-bindings: media: renesas,vsp1: Add power-domains and resets
.../devicetree/bindings/media/renesas,fcp.txt | 34 -------
.../bindings/media/renesas,fcp.yaml | 66 +++++++++++++
.../bindings/media/renesas,fdp1.txt | 37 -------
.../bindings/media/renesas,fdp1.yaml | 69 +++++++++++++
.../bindings/media/renesas,vsp1.txt | 30 ------
.../bindings/media/renesas,vsp1.yaml | 97 +++++++++++++++++++
MAINTAINERS | 6 +-
7 files changed, 235 insertions(+), 104 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v2 0/8] dt-bindings: media: Conversion of Renesas bindings to YAML
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
This patch series converts the DT bindings for the Renesas R-Car FCP,
FDP1 and VSP1 to YAML. It also updates the bindings based on the
properties that have been added to the DT sources over time but never
documented.
Compared to v1, review comments have been incorporated to fix small
typos and simplify a few comments in the bindings, and MAINTAINERS has
been updated.
Rob, this series has been reviewed by Geert, could you merge it ?
Alternatively you can provide acks and I can send a pull request to get
it merged through the linux-media tree.
Laurent Pinchart (8):
dt-bindings: media: renesas,fcp: Convert binding to YAML
dt-bindings: media: renesas,fcp: Make power-domains mandatory
dt-bindings: media: renesas,fcp: Add resets and iommus properties
dt-bindings: media: renesas,fdp1: Convert binding to YAML
dt-bindings: media: renesas,fdp1: Make power-domains mandatory
dt-bindings: media: renesas,fdp1: Add resets property
dt-bindings: media: renesas,vsp1: Convert binding to YAML
dt-bindings: media: renesas,vsp1: Add power-domains and resets
.../devicetree/bindings/media/renesas,fcp.txt | 34 -------
.../bindings/media/renesas,fcp.yaml | 66 +++++++++++++
.../bindings/media/renesas,fdp1.txt | 37 -------
.../bindings/media/renesas,fdp1.yaml | 69 +++++++++++++
.../bindings/media/renesas,vsp1.txt | 30 ------
.../bindings/media/renesas,vsp1.yaml | 97 +++++++++++++++++++
MAINTAINERS | 6 +-
7 files changed, 235 insertions(+), 104 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-21 0:47 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
Convert the Renesas R-Car FCP text binding to YAML.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Simplify comments on compatible strings
- Update MAINTAINERS
---
.../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
.../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 57 insertions(+), 35 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
deleted file mode 100644
index 79c37395b396..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-Renesas R-Car Frame Compression Processor (FCP)
------------------------------------------------
-
-The FCP is a companion module of video processing modules in the Renesas R-Car
-Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
-caching, and conversion of AXI transactions in order to reduce the memory
-bandwidth.
-
-There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
-for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV and FCPF.
-
- - compatible: Must be one or more of the following
-
- - "renesas,fcpv" for generic compatible 'FCP for VSP'
- - "renesas,fcpf" for generic compatible 'FCP for FDP'
-
- - reg: the register base and size for the device registers
- - clocks: Reference to the functional clock
-
-Optional properties:
- - power-domains : power-domain property defined with a power domain specifier
- to respective power domain.
-
-
-Device node example
--------------------
-
- fcpvd1: fcp@fea2f000 {
- compatible = "renesas,fcpv";
- reg = <0 0xfea2f000 0 0x200>;
- clocks = <&cpg CPG_MOD 602>;
- power-domains = <&sysc R8A7795_PD_A3VP>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
new file mode 100644
index 000000000000..9241bf3c5efc
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Frame Compression Processor (FCP)
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description: |
+ The FCP is a companion module of video processing modules in the Renesas
+ R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
+ data caching, and conversion of AXI transactions in order to reduce the
+ memory bandwidth.
+
+ There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
+ FCP for FDP (FCPF). Their configuration and behaviour depend on the module
+ they are paired with. These DT bindings currently support the FCPV and FCPF.
+
+properties:
+ compatible:
+ enum:
+ - renesas,fcpv # FCP for VSP
+ - renesas,fcpf # FCP for FDP
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ # R8A7790 (R-Car H2) VSP1-S
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/power/r8a7795-sysc.h>
+
+ fcp@fea2f000 {
+ compatible = "renesas,fcpv";
+ reg = <0xfea2f000 0x200>;
+ clocks = <&cpg CPG_MOD 602>;
+ power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 68f21d46614c..660ed6606de2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
L: linux-renesas-soc@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,fcp.txt
+F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
F: drivers/media/platform/rcar-fcp.c
F: include/media/rcar-fcp.h
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 1/8] dt-bindings: media: renesas, fcp: Convert binding to YAML
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
Convert the Renesas R-Car FCP text binding to YAML.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Simplify comments on compatible strings
- Update MAINTAINERS
---
.../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
.../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 57 insertions(+), 35 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
deleted file mode 100644
index 79c37395b396..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-Renesas R-Car Frame Compression Processor (FCP)
------------------------------------------------
-
-The FCP is a companion module of video processing modules in the Renesas R-Car
-Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
-caching, and conversion of AXI transactions in order to reduce the memory
-bandwidth.
-
-There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
-for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV and FCPF.
-
- - compatible: Must be one or more of the following
-
- - "renesas,fcpv" for generic compatible 'FCP for VSP'
- - "renesas,fcpf" for generic compatible 'FCP for FDP'
-
- - reg: the register base and size for the device registers
- - clocks: Reference to the functional clock
-
-Optional properties:
- - power-domains : power-domain property defined with a power domain specifier
- to respective power domain.
-
-
-Device node example
--------------------
-
- fcpvd1: fcp@fea2f000 {
- compatible = "renesas,fcpv";
- reg = <0 0xfea2f000 0 0x200>;
- clocks = <&cpg CPG_MOD 602>;
- power-domains = <&sysc R8A7795_PD_A3VP>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
new file mode 100644
index 000000000000..9241bf3c5efc
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Frame Compression Processor (FCP)
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description: |
+ The FCP is a companion module of video processing modules in the Renesas
+ R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
+ data caching, and conversion of AXI transactions in order to reduce the
+ memory bandwidth.
+
+ There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
+ FCP for FDP (FCPF). Their configuration and behaviour depend on the module
+ they are paired with. These DT bindings currently support the FCPV and FCPF.
+
+properties:
+ compatible:
+ enum:
+ - renesas,fcpv # FCP for VSP
+ - renesas,fcpf # FCP for FDP
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ # R8A7790 (R-Car H2) VSP1-S
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/power/r8a7795-sysc.h>
+
+ fcp@fea2f000 {
+ compatible = "renesas,fcpv";
+ reg = <0xfea2f000 0x200>;
+ clocks = <&cpg CPG_MOD 602>;
+ power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 68f21d46614c..660ed6606de2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
L: linux-renesas-soc@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,fcp.txt
+F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
F: drivers/media/platform/rcar-fcp.c
F: include/media/rcar-fcp.h
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 2/8] dt-bindings: media: renesas,fcp: Make power-domains mandatory
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-21 0:47 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
All DT source files in the kernel tree specify the power-domains
property. Make it mandatory.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Fix typo in commit message
---
Documentation/devicetree/bindings/media/renesas,fcp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
index 9241bf3c5efc..eeca7e255420 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -38,6 +38,7 @@ required:
- compatible
- reg
- clocks
+ - power-domains
additionalProperties: false
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 2/8] dt-bindings: media: renesas, fcp: Make power-domains mandatory
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
All DT source files in the kernel tree specify the power-domains
property. Make it mandatory.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Fix typo in commit message
---
Documentation/devicetree/bindings/media/renesas,fcp.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
index 9241bf3c5efc..eeca7e255420 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -38,6 +38,7 @@ required:
- compatible
- reg
- clocks
+ - power-domains
additionalProperties: false
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 3/8] dt-bindings: media: renesas,fcp: Add resets and iommus properties
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-21 0:47 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
The resets and iommus properties are used in DT sources in the kernel
tree. Document them, and make resets mandatory. The iommus property is
optional as not all platforms wire the FCP to a functional IOMMU.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/media/renesas,fcp.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
index eeca7e255420..b6cf2958e6c9 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -31,14 +31,21 @@ properties:
clocks:
maxItems: 1
+ iommus:
+ maxItems: 1
+
power-domains:
maxItems: 1
+ resets:
+ maxItems: 1
+
required:
- compatible
- reg
- clocks
- power-domains
+ - resets
additionalProperties: false
@@ -53,5 +60,7 @@ examples:
reg = <0xfea2f000 0x200>;
clocks = <&cpg CPG_MOD 602>;
power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+ resets = <&cpg 602>;
+ iommus = <&ipmmu_vi0 9>;
};
...
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 3/8] dt-bindings: media: renesas, fcp: Add resets and iommus properties
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
The resets and iommus properties are used in DT sources in the kernel
tree. Document them, and make resets mandatory. The iommus property is
optional as not all platforms wire the FCP to a functional IOMMU.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/media/renesas,fcp.yaml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
index eeca7e255420..b6cf2958e6c9 100644
--- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -31,14 +31,21 @@ properties:
clocks:
maxItems: 1
+ iommus:
+ maxItems: 1
+
power-domains:
maxItems: 1
+ resets:
+ maxItems: 1
+
required:
- compatible
- reg
- clocks
- power-domains
+ - resets
additionalProperties: false
@@ -53,5 +60,7 @@ examples:
reg = <0xfea2f000 0x200>;
clocks = <&cpg CPG_MOD 602>;
power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+ resets = <&cpg 602>;
+ iommus = <&ipmmu_vi0 9>;
};
...
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 4/8] dt-bindings: media: renesas,fdp1: Convert binding to YAML
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-21 0:47 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
Convert the Renesas R-Car FDP1 text binding to YAML.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Update MAINTAINERS
---
.../bindings/media/renesas,fdp1.txt | 37 -----------
.../bindings/media/renesas,fdp1.yaml | 63 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 64 insertions(+), 38 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
deleted file mode 100644
index 8dd1007bb573..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,fdp1.txt
+++ /dev/null
@@ -1,37 +0,0 @@
-Renesas R-Car Fine Display Processor (FDP1)
--------------------------------------------
-
-The FDP1 is a de-interlacing module which converts interlaced video to
-progressive video. It is capable of performing pixel format conversion between
-YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
-an input to the module.
-
-Required properties:
-
- - compatible: must be "renesas,fdp1"
- - reg: the register base and size for the device registers
- - interrupts : interrupt specifier for the FDP1 instance
- - clocks: reference to the functional clock
-
-Optional properties:
-
- - power-domains: reference to the power domain that the FDP1 belongs to, if
- any.
- - renesas,fcp: a phandle referencing the FCP that handles memory accesses
- for the FDP1. Not needed on Gen2, mandatory on Gen3.
-
-Please refer to the binding documentation for the clock and/or power domain
-providers for more details.
-
-
-Device node example
--------------------
-
- fdp1@fe940000 {
- compatible = "renesas,fdp1";
- reg = <0 0xfe940000 0 0x2400>;
- interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&cpg CPG_MOD 119>;
- power-domains = <&sysc R8A7795_PD_A3VP>;
- renesas,fcp = <&fcpf0>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
new file mode 100644
index 000000000000..f4db96a1f53c
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,fdp1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Fine Display Processor (FDP1)
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description:
+ The FDP1 is a de-interlacing module which converts interlaced video to
+ progressive video. It is capable of performing pixel format conversion
+ between YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are
+ supported as an input to the module.
+
+properties:
+ compatible:
+ enum:
+ - renesas,fdp1
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ renesas,fcp:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ A phandle referencing the FCP that handles memory accesses for the FDP1.
+ Not allowed on R-Car Gen2, mandatory on R-Car Gen3.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/r8a7795-sysc.h>
+
+ fdp1@fe940000 {
+ compatible = "renesas,fdp1";
+ reg = <0xfe940000 0x2400>;
+ interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 119>;
+ power-domains = <&sysc R8A7795_PD_A3VP>;
+ renesas,fcp = <&fcpf0>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 660ed6606de2..7383dfa510a3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10710,7 +10710,7 @@ L: linux-media@vger.kernel.org
L: linux-renesas-soc@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,fdp1.txt
+F: Documentation/devicetree/bindings/media/renesas,fdp1.yaml
F: drivers/media/platform/rcar_fdp1.c
MEDIA DRIVERS FOR RENESAS - VIN
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
Convert the Renesas R-Car FDP1 text binding to YAML.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Update MAINTAINERS
---
.../bindings/media/renesas,fdp1.txt | 37 -----------
.../bindings/media/renesas,fdp1.yaml | 63 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 64 insertions(+), 38 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
deleted file mode 100644
index 8dd1007bb573..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,fdp1.txt
+++ /dev/null
@@ -1,37 +0,0 @@
-Renesas R-Car Fine Display Processor (FDP1)
--------------------------------------------
-
-The FDP1 is a de-interlacing module which converts interlaced video to
-progressive video. It is capable of performing pixel format conversion between
-YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
-an input to the module.
-
-Required properties:
-
- - compatible: must be "renesas,fdp1"
- - reg: the register base and size for the device registers
- - interrupts : interrupt specifier for the FDP1 instance
- - clocks: reference to the functional clock
-
-Optional properties:
-
- - power-domains: reference to the power domain that the FDP1 belongs to, if
- any.
- - renesas,fcp: a phandle referencing the FCP that handles memory accesses
- for the FDP1. Not needed on Gen2, mandatory on Gen3.
-
-Please refer to the binding documentation for the clock and/or power domain
-providers for more details.
-
-
-Device node example
--------------------
-
- fdp1@fe940000 {
- compatible = "renesas,fdp1";
- reg = <0 0xfe940000 0 0x2400>;
- interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&cpg CPG_MOD 119>;
- power-domains = <&sysc R8A7795_PD_A3VP>;
- renesas,fcp = <&fcpf0>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
new file mode 100644
index 000000000000..f4db96a1f53c
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,fdp1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Fine Display Processor (FDP1)
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description:
+ The FDP1 is a de-interlacing module which converts interlaced video to
+ progressive video. It is capable of performing pixel format conversion
+ between YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are
+ supported as an input to the module.
+
+properties:
+ compatible:
+ enum:
+ - renesas,fdp1
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+ renesas,fcp:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ A phandle referencing the FCP that handles memory accesses for the FDP1.
+ Not allowed on R-Car Gen2, mandatory on R-Car Gen3.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/r8a7795-sysc.h>
+
+ fdp1@fe940000 {
+ compatible = "renesas,fdp1";
+ reg = <0xfe940000 0x2400>;
+ interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 119>;
+ power-domains = <&sysc R8A7795_PD_A3VP>;
+ renesas,fcp = <&fcpf0>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 660ed6606de2..7383dfa510a3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10710,7 +10710,7 @@ L: linux-media@vger.kernel.org
L: linux-renesas-soc@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,fdp1.txt
+F: Documentation/devicetree/bindings/media/renesas,fdp1.yaml
F: drivers/media/platform/rcar_fdp1.c
MEDIA DRIVERS FOR RENESAS - VIN
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 5/8] dt-bindings: media: renesas,fdp1: Make power-domains mandatory
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-21 0:47 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
All DT source files in the kernel tree specify the power-domains
property. Make it mandatory.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Fix typo in comment message
---
Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
index f4db96a1f53c..39184bd21a27 100644
--- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
@@ -43,6 +43,7 @@ required:
- reg
- interrupts
- clocks
+ - power-domains
additionalProperties: false
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: Make power-domains mandatory
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
All DT source files in the kernel tree specify the power-domains
property. Make it mandatory.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Fix typo in comment message
---
Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
index f4db96a1f53c..39184bd21a27 100644
--- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
@@ -43,6 +43,7 @@ required:
- reg
- interrupts
- clocks
+ - power-domains
additionalProperties: false
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-21 0:47 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
The resets property is used in DT sources in the kernel tree. Document
it and make it mandatory.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Fix typo in commit message
---
Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
index 39184bd21a27..2a27a7296fea 100644
--- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
@@ -32,6 +32,9 @@ properties:
power-domains:
maxItems: 1
+ resets:
+ maxItems: 1
+
renesas,fcp:
$ref: /schemas/types.yaml#/definitions/phandle
description:
@@ -44,6 +47,7 @@ required:
- interrupts
- clocks
- power-domains
+ - resets
additionalProperties: false
@@ -59,6 +63,7 @@ examples:
interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 119>;
power-domains = <&sysc R8A7795_PD_A3VP>;
+ resets = <&cpg 119>;
renesas,fcp = <&fcpf0>;
};
...
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
The resets property is used in DT sources in the kernel tree. Document
it and make it mandatory.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Fix typo in commit message
---
Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
index 39184bd21a27..2a27a7296fea 100644
--- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
@@ -32,6 +32,9 @@ properties:
power-domains:
maxItems: 1
+ resets:
+ maxItems: 1
+
renesas,fcp:
$ref: /schemas/types.yaml#/definitions/phandle
description:
@@ -44,6 +47,7 @@ required:
- interrupts
- clocks
- power-domains
+ - resets
additionalProperties: false
@@ -59,6 +63,7 @@ examples:
interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 119>;
power-domains = <&sysc R8A7795_PD_A3VP>;
+ resets = <&cpg 119>;
renesas,fcp = <&fcpf0>;
};
...
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 7/8] dt-bindings: media: renesas,vsp1: Convert binding to YAML
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-21 0:47 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
Convert the Renesas R-Car VSP1 text binding to YAML.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Simplify comments on compatible strings
- Update MAINTAINERS
---
.../bindings/media/renesas,vsp1.txt | 30 -------
.../bindings/media/renesas,vsp1.yaml | 83 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 84 insertions(+), 31 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/media/renesas,vsp1.txt
deleted file mode 100644
index cd5a955b2ea0..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt
+++ /dev/null
@@ -1,30 +0,0 @@
-* Renesas VSP Video Processing Engine
-
-The VSP is a video processing engine that supports up-/down-scaling, alpha
-blending, color space conversion and various other image processing features.
-It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
-
-Required properties:
-
- - compatible: Must contain one of the following values
- - "renesas,vsp1" for the R-Car Gen2 and RZ/G1 VSP1
- - "renesas,vsp2" for the R-Car Gen3 and RZ/G2 VSP2
-
- - reg: Base address and length of the registers block for the VSP.
- - interrupts: VSP interrupt specifier.
- - clocks: A phandle + clock-specifier pair for the VSP functional clock.
-
-Optional properties:
-
- - renesas,fcp: A phandle referencing the FCP that handles memory accesses
- for the VSP. Not needed on Gen2, mandatory on Gen3.
-
-
-Example: R8A7790 (R-Car H2) VSP1-S node
-
- vsp@fe928000 {
- compatible = "renesas,vsp1";
- reg = <0 0xfe928000 0 0x8000>;
- interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&mstp1_clks R8A7790_CLK_VSP1_S>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
new file mode 100644
index 000000000000..65e8ee61ce90
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,vsp1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas VSP Video Processing Engine
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description:
+ The VSP is a video processing engine that supports up-/down-scaling, alpha
+ blending, color space conversion and various other image processing features.
+ It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
+
+properties:
+ compatible:
+ enum:
+ - renesas,vsp1 # R-Car Gen2 and RZ/G1
+ - renesas,vsp2 # R-Car Gen3 and RZ/G2
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ renesas,fcp:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ A phandle referencing the FCP that handles memory accesses for the VSP.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+
+additionalProperties: false
+
+if:
+ properties:
+ compatible:
+ items:
+ - const: renesas,vsp1
+then:
+ properties:
+ renesas,fcp: false
+else:
+ required:
+ - renesas,fcp
+
+examples:
+ # R8A7790 (R-Car H2) VSP1-S
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ vsp@fe928000 {
+ compatible = "renesas,vsp1";
+ reg = <0xfe928000 0x8000>;
+ interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 131>;
+ };
+
+ # R8A77951 (R-Car H3) VSP2-BC
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ vsp@fe920000 {
+ compatible = "renesas,vsp2";
+ reg = <0xfe920000 0x8000>;
+ interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 624>;
+
+ renesas,fcp = <&fcpvb1>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 7383dfa510a3..22e079cc3e3f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10730,7 +10730,7 @@ L: linux-media@vger.kernel.org
L: linux-renesas-soc@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,vsp1.txt
+F: Documentation/devicetree/bindings/media/renesas,vsp1.yaml
F: drivers/media/platform/vsp1/
MEDIA DRIVERS FOR ST STV0910 DEMODULATOR ICs
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
Convert the Renesas R-Car VSP1 text binding to YAML.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
- Simplify comments on compatible strings
- Update MAINTAINERS
---
.../bindings/media/renesas,vsp1.txt | 30 -------
.../bindings/media/renesas,vsp1.yaml | 83 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 84 insertions(+), 31 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/media/renesas,vsp1.txt
deleted file mode 100644
index cd5a955b2ea0..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt
+++ /dev/null
@@ -1,30 +0,0 @@
-* Renesas VSP Video Processing Engine
-
-The VSP is a video processing engine that supports up-/down-scaling, alpha
-blending, color space conversion and various other image processing features.
-It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
-
-Required properties:
-
- - compatible: Must contain one of the following values
- - "renesas,vsp1" for the R-Car Gen2 and RZ/G1 VSP1
- - "renesas,vsp2" for the R-Car Gen3 and RZ/G2 VSP2
-
- - reg: Base address and length of the registers block for the VSP.
- - interrupts: VSP interrupt specifier.
- - clocks: A phandle + clock-specifier pair for the VSP functional clock.
-
-Optional properties:
-
- - renesas,fcp: A phandle referencing the FCP that handles memory accesses
- for the VSP. Not needed on Gen2, mandatory on Gen3.
-
-
-Example: R8A7790 (R-Car H2) VSP1-S node
-
- vsp@fe928000 {
- compatible = "renesas,vsp1";
- reg = <0 0xfe928000 0 0x8000>;
- interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&mstp1_clks R8A7790_CLK_VSP1_S>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
new file mode 100644
index 000000000000..65e8ee61ce90
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
@@ -0,0 +1,83 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,vsp1.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas VSP Video Processing Engine
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description:
+ The VSP is a video processing engine that supports up-/down-scaling, alpha
+ blending, color space conversion and various other image processing features.
+ It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
+
+properties:
+ compatible:
+ enum:
+ - renesas,vsp1 # R-Car Gen2 and RZ/G1
+ - renesas,vsp2 # R-Car Gen3 and RZ/G2
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ renesas,fcp:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ A phandle referencing the FCP that handles memory accesses for the VSP.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+
+additionalProperties: false
+
+if:
+ properties:
+ compatible:
+ items:
+ - const: renesas,vsp1
+then:
+ properties:
+ renesas,fcp: false
+else:
+ required:
+ - renesas,fcp
+
+examples:
+ # R8A7790 (R-Car H2) VSP1-S
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ vsp@fe928000 {
+ compatible = "renesas,vsp1";
+ reg = <0xfe928000 0x8000>;
+ interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 131>;
+ };
+
+ # R8A77951 (R-Car H3) VSP2-BC
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ vsp@fe920000 {
+ compatible = "renesas,vsp2";
+ reg = <0xfe920000 0x8000>;
+ interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 624>;
+
+ renesas,fcp = <&fcpvb1>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 7383dfa510a3..22e079cc3e3f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10730,7 +10730,7 @@ L: linux-media@vger.kernel.org
L: linux-renesas-soc@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,vsp1.txt
+F: Documentation/devicetree/bindings/media/renesas,vsp1.yaml
F: drivers/media/platform/vsp1/
MEDIA DRIVERS FOR ST STV0910 DEMODULATOR ICs
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 8/8] dt-bindings: media: renesas,vsp1: Add power-domains and resets
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-21 0:47 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: devicetree, linux-renesas-soc, Rob Herring
The power-domains and resets properties are used in all DT sources in
the kernel but are absent from the bindings. Document them and make them
mandatory.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../devicetree/bindings/media/renesas,vsp1.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
index 65e8ee61ce90..990e9c1dbc43 100644
--- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
@@ -29,6 +29,12 @@ properties:
clocks:
maxItems: 1
+ power-domains:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
renesas,fcp:
$ref: /schemas/types.yaml#/definitions/phandle
description:
@@ -39,6 +45,8 @@ required:
- reg
- interrupts
- clocks
+ - power-domains
+ - resets
additionalProperties: false
@@ -59,24 +67,30 @@ examples:
- |
#include <dt-bindings/clock/renesas-cpg-mssr.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/r8a7790-sysc.h>
vsp@fe928000 {
compatible = "renesas,vsp1";
reg = <0xfe928000 0x8000>;
interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 131>;
+ power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
+ resets = <&cpg 131>;
};
# R8A77951 (R-Car H3) VSP2-BC
- |
#include <dt-bindings/clock/renesas-cpg-mssr.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/r8a7795-sysc.h>
vsp@fe920000 {
compatible = "renesas,vsp2";
reg = <0xfe920000 0x8000>;
interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 624>;
+ power-domains = <&sysc R8A7795_PD_A3VP>;
+ resets = <&cpg 624>;
renesas,fcp = <&fcpvb1>;
};
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: Add power-domains and resets
@ 2020-06-21 0:47 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-06-21 0:47 UTC (permalink / raw)
To: dri-devel, linux-media; +Cc: linux-renesas-soc, devicetree, Rob Herring
The power-domains and resets properties are used in all DT sources in
the kernel but are absent from the bindings. Document them and make them
mandatory.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../devicetree/bindings/media/renesas,vsp1.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
index 65e8ee61ce90..990e9c1dbc43 100644
--- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
@@ -29,6 +29,12 @@ properties:
clocks:
maxItems: 1
+ power-domains:
+ maxItems: 1
+
+ resets:
+ maxItems: 1
+
renesas,fcp:
$ref: /schemas/types.yaml#/definitions/phandle
description:
@@ -39,6 +45,8 @@ required:
- reg
- interrupts
- clocks
+ - power-domains
+ - resets
additionalProperties: false
@@ -59,24 +67,30 @@ examples:
- |
#include <dt-bindings/clock/renesas-cpg-mssr.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/r8a7790-sysc.h>
vsp@fe928000 {
compatible = "renesas,vsp1";
reg = <0xfe928000 0x8000>;
interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 131>;
+ power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
+ resets = <&cpg 131>;
};
# R8A77951 (R-Car H3) VSP2-BC
- |
#include <dt-bindings/clock/renesas-cpg-mssr.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/r8a7795-sysc.h>
vsp@fe920000 {
compatible = "renesas,vsp2";
reg = <0xfe920000 0x8000>;
interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 624>;
+ power-domains = <&sysc R8A7795_PD_A3VP>;
+ resets = <&cpg 624>;
renesas,fcp = <&fcpvb1>;
};
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
2020-06-21 0:47 ` [PATCH v2 1/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
@ 2020-06-30 20:49 ` Niklas Söderlund
-1 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:49 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, linux-media, devicetree, linux-renesas-soc, Rob Herring
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FCP text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
> .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 57 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> deleted file mode 100644
> index 79c37395b396..000000000000
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -Renesas R-Car Frame Compression Processor (FCP)
> ------------------------------------------------
> -
> -The FCP is a companion module of video processing modules in the Renesas R-Car
> -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
> -caching, and conversion of AXI transactions in order to reduce the memory
> -bandwidth.
> -
> -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
> -for FDP (FCPF). Their configuration and behaviour depend on the module they
> -are paired with. These DT bindings currently support the FCPV and FCPF.
> -
> - - compatible: Must be one or more of the following
> -
> - - "renesas,fcpv" for generic compatible 'FCP for VSP'
> - - "renesas,fcpf" for generic compatible 'FCP for FDP'
> -
> - - reg: the register base and size for the device registers
> - - clocks: Reference to the functional clock
> -
> -Optional properties:
> - - power-domains : power-domain property defined with a power domain specifier
> - to respective power domain.
> -
> -
> -Device node example
> --------------------
> -
> - fcpvd1: fcp@fea2f000 {
> - compatible = "renesas,fcpv";
> - reg = <0 0xfea2f000 0 0x200>;
> - clocks = <&cpg CPG_MOD 602>;
> - power-domains = <&sysc R8A7795_PD_A3VP>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> new file mode 100644
> index 000000000000..9241bf3c5efc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car Frame Compression Processor (FCP)
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description: |
> + The FCP is a companion module of video processing modules in the Renesas
> + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
> + data caching, and conversion of AXI transactions in order to reduce the
> + memory bandwidth.
> +
> + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> + FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> + they are paired with. These DT bindings currently support the FCPV and FCPF.
> +
> +properties:
> + compatible:
> + enum:
> + - renesas,fcpv # FCP for VSP
> + - renesas,fcpf # FCP for FDP
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + # R8A7790 (R-Car H2) VSP1-S
Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it
not? With this fixed,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
> +
> + fcp@fea2f000 {
> + compatible = "renesas,fcpv";
> + reg = <0xfea2f000 0x200>;
> + clocks = <&cpg CPG_MOD 602>;
> + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 68f21d46614c..660ed6606de2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
> L: linux-renesas-soc@vger.kernel.org
> S: Supported
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/renesas,fcp.txt
> +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
> F: drivers/media/platform/rcar-fcp.c
> F: include/media/rcar-fcp.h
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
@ 2020-06-30 20:49 ` Niklas Söderlund
0 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:49 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FCP text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
> .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 57 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> deleted file mode 100644
> index 79c37395b396..000000000000
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -Renesas R-Car Frame Compression Processor (FCP)
> ------------------------------------------------
> -
> -The FCP is a companion module of video processing modules in the Renesas R-Car
> -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
> -caching, and conversion of AXI transactions in order to reduce the memory
> -bandwidth.
> -
> -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
> -for FDP (FCPF). Their configuration and behaviour depend on the module they
> -are paired with. These DT bindings currently support the FCPV and FCPF.
> -
> - - compatible: Must be one or more of the following
> -
> - - "renesas,fcpv" for generic compatible 'FCP for VSP'
> - - "renesas,fcpf" for generic compatible 'FCP for FDP'
> -
> - - reg: the register base and size for the device registers
> - - clocks: Reference to the functional clock
> -
> -Optional properties:
> - - power-domains : power-domain property defined with a power domain specifier
> - to respective power domain.
> -
> -
> -Device node example
> --------------------
> -
> - fcpvd1: fcp@fea2f000 {
> - compatible = "renesas,fcpv";
> - reg = <0 0xfea2f000 0 0x200>;
> - clocks = <&cpg CPG_MOD 602>;
> - power-domains = <&sysc R8A7795_PD_A3VP>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> new file mode 100644
> index 000000000000..9241bf3c5efc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car Frame Compression Processor (FCP)
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description: |
> + The FCP is a companion module of video processing modules in the Renesas
> + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
> + data caching, and conversion of AXI transactions in order to reduce the
> + memory bandwidth.
> +
> + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> + FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> + they are paired with. These DT bindings currently support the FCPV and FCPF.
> +
> +properties:
> + compatible:
> + enum:
> + - renesas,fcpv # FCP for VSP
> + - renesas,fcpf # FCP for FDP
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + # R8A7790 (R-Car H2) VSP1-S
Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it
not? With this fixed,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
> +
> + fcp@fea2f000 {
> + compatible = "renesas,fcpv";
> + reg = <0xfea2f000 0x200>;
> + clocks = <&cpg CPG_MOD 602>;
> + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 68f21d46614c..660ed6606de2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
> L: linux-renesas-soc@vger.kernel.org
> S: Supported
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/renesas,fcp.txt
> +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
> F: drivers/media/platform/rcar-fcp.c
> F: include/media/rcar-fcp.h
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 2/8] dt-bindings: media: renesas,fcp: Make power-domains mandatory
2020-06-21 0:47 ` [PATCH v2 2/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
@ 2020-06-30 20:49 ` Niklas Söderlund
-1 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:49 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, linux-media, devicetree, linux-renesas-soc, Rob Herring
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:28 +0300, Laurent Pinchart wrote:
> All DT source files in the kernel tree specify the power-domains
> property. Make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Fix typo in commit message
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> index 9241bf3c5efc..eeca7e255420 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -38,6 +38,7 @@ required:
> - compatible
> - reg
> - clocks
> + - power-domains
>
> additionalProperties: false
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 2/8] dt-bindings: media: renesas,fcp: Make power-domains mandatory
@ 2020-06-30 20:49 ` Niklas Söderlund
0 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:49 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:28 +0300, Laurent Pinchart wrote:
> All DT source files in the kernel tree specify the power-domains
> property. Make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Fix typo in commit message
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> index 9241bf3c5efc..eeca7e255420 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -38,6 +38,7 @@ required:
> - compatible
> - reg
> - clocks
> + - power-domains
>
> additionalProperties: false
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 3/8] dt-bindings: media: renesas,fcp: Add resets and iommus properties
2020-06-21 0:47 ` [PATCH v2 3/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
@ 2020-06-30 20:50 ` Niklas Söderlund
-1 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:50 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, linux-media, devicetree, linux-renesas-soc, Rob Herring
Hi Laurent,
Thanks for your patch.
On 2020-06-21 03:47:29 +0300, Laurent Pinchart wrote:
> The resets and iommus properties are used in DT sources in the kernel
> tree. Document them, and make resets mandatory. The iommus property is
> optional as not all platforms wire the FCP to a functional IOMMU.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> index eeca7e255420..b6cf2958e6c9 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -31,14 +31,21 @@ properties:
> clocks:
> maxItems: 1
>
> + iommus:
> + maxItems: 1
> +
> power-domains:
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> - clocks
> - power-domains
> + - resets
>
> additionalProperties: false
>
> @@ -53,5 +60,7 @@ examples:
> reg = <0xfea2f000 0x200>;
> clocks = <&cpg CPG_MOD 602>;
> power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> + resets = <&cpg 602>;
> + iommus = <&ipmmu_vi0 9>;
> };
> ...
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 3/8] dt-bindings: media: renesas,fcp: Add resets and iommus properties
@ 2020-06-30 20:50 ` Niklas Söderlund
0 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:50 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
Hi Laurent,
Thanks for your patch.
On 2020-06-21 03:47:29 +0300, Laurent Pinchart wrote:
> The resets and iommus properties are used in DT sources in the kernel
> tree. Document them, and make resets mandatory. The iommus property is
> optional as not all platforms wire the FCP to a functional IOMMU.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> index eeca7e255420..b6cf2958e6c9 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -31,14 +31,21 @@ properties:
> clocks:
> maxItems: 1
>
> + iommus:
> + maxItems: 1
> +
> power-domains:
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> - clocks
> - power-domains
> + - resets
>
> additionalProperties: false
>
> @@ -53,5 +60,7 @@ examples:
> reg = <0xfea2f000 0x200>;
> clocks = <&cpg CPG_MOD 602>;
> power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> + resets = <&cpg 602>;
> + iommus = <&ipmmu_vi0 9>;
> };
> ...
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 4/8] dt-bindings: media: renesas,fdp1: Convert binding to YAML
2020-06-21 0:47 ` [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: " Laurent Pinchart
@ 2020-06-30 20:55 ` Niklas Söderlund
-1 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:55 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, linux-media, devicetree, linux-renesas-soc, Rob Herring
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:30 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FDP1 text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Update MAINTAINERS
> ---
> .../bindings/media/renesas,fdp1.txt | 37 -----------
> .../bindings/media/renesas,fdp1.yaml | 63 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 64 insertions(+), 38 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> deleted file mode 100644
> index 8dd1007bb573..000000000000
> --- a/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -Renesas R-Car Fine Display Processor (FDP1)
> --------------------------------------------
> -
> -The FDP1 is a de-interlacing module which converts interlaced video to
> -progressive video. It is capable of performing pixel format conversion between
> -YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
> -an input to the module.
> -
> -Required properties:
> -
> - - compatible: must be "renesas,fdp1"
> - - reg: the register base and size for the device registers
> - - interrupts : interrupt specifier for the FDP1 instance
> - - clocks: reference to the functional clock
> -
> -Optional properties:
> -
> - - power-domains: reference to the power domain that the FDP1 belongs to, if
> - any.
> - - renesas,fcp: a phandle referencing the FCP that handles memory accesses
> - for the FDP1. Not needed on Gen2, mandatory on Gen3.
> -
> -Please refer to the binding documentation for the clock and/or power domain
> -providers for more details.
> -
> -
> -Device node example
> --------------------
> -
> - fdp1@fe940000 {
> - compatible = "renesas,fdp1";
> - reg = <0 0xfe940000 0 0x2400>;
> - interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 119>;
> - power-domains = <&sysc R8A7795_PD_A3VP>;
> - renesas,fcp = <&fcpf0>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> new file mode 100644
> index 000000000000..f4db96a1f53c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,fdp1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car Fine Display Processor (FDP1)
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description:
> + The FDP1 is a de-interlacing module which converts interlaced video to
> + progressive video. It is capable of performing pixel format conversion
> + between YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are
> + supported as an input to the module.
> +
> +properties:
> + compatible:
> + enum:
> + - renesas,fdp1
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + renesas,fcp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + A phandle referencing the FCP that handles memory accesses for the FDP1.
> + Not allowed on R-Car Gen2, mandatory on R-Car Gen3.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
> +
> + fdp1@fe940000 {
> + compatible = "renesas,fdp1";
> + reg = <0xfe940000 0x2400>;
> + interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 119>;
> + power-domains = <&sysc R8A7795_PD_A3VP>;
> + renesas,fcp = <&fcpf0>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 660ed6606de2..7383dfa510a3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10710,7 +10710,7 @@ L: linux-media@vger.kernel.org
> L: linux-renesas-soc@vger.kernel.org
> S: Supported
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/renesas,fdp1.txt
> +F: Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> F: drivers/media/platform/rcar_fdp1.c
>
> MEDIA DRIVERS FOR RENESAS - VIN
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML
@ 2020-06-30 20:55 ` Niklas Söderlund
0 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:55 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:30 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FDP1 text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Update MAINTAINERS
> ---
> .../bindings/media/renesas,fdp1.txt | 37 -----------
> .../bindings/media/renesas,fdp1.yaml | 63 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 64 insertions(+), 38 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> deleted file mode 100644
> index 8dd1007bb573..000000000000
> --- a/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -Renesas R-Car Fine Display Processor (FDP1)
> --------------------------------------------
> -
> -The FDP1 is a de-interlacing module which converts interlaced video to
> -progressive video. It is capable of performing pixel format conversion between
> -YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
> -an input to the module.
> -
> -Required properties:
> -
> - - compatible: must be "renesas,fdp1"
> - - reg: the register base and size for the device registers
> - - interrupts : interrupt specifier for the FDP1 instance
> - - clocks: reference to the functional clock
> -
> -Optional properties:
> -
> - - power-domains: reference to the power domain that the FDP1 belongs to, if
> - any.
> - - renesas,fcp: a phandle referencing the FCP that handles memory accesses
> - for the FDP1. Not needed on Gen2, mandatory on Gen3.
> -
> -Please refer to the binding documentation for the clock and/or power domain
> -providers for more details.
> -
> -
> -Device node example
> --------------------
> -
> - fdp1@fe940000 {
> - compatible = "renesas,fdp1";
> - reg = <0 0xfe940000 0 0x2400>;
> - interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 119>;
> - power-domains = <&sysc R8A7795_PD_A3VP>;
> - renesas,fcp = <&fcpf0>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> new file mode 100644
> index 000000000000..f4db96a1f53c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,fdp1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car Fine Display Processor (FDP1)
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description:
> + The FDP1 is a de-interlacing module which converts interlaced video to
> + progressive video. It is capable of performing pixel format conversion
> + between YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are
> + supported as an input to the module.
> +
> +properties:
> + compatible:
> + enum:
> + - renesas,fdp1
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + renesas,fcp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + A phandle referencing the FCP that handles memory accesses for the FDP1.
> + Not allowed on R-Car Gen2, mandatory on R-Car Gen3.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
> +
> + fdp1@fe940000 {
> + compatible = "renesas,fdp1";
> + reg = <0xfe940000 0x2400>;
> + interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 119>;
> + power-domains = <&sysc R8A7795_PD_A3VP>;
> + renesas,fcp = <&fcpf0>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 660ed6606de2..7383dfa510a3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10710,7 +10710,7 @@ L: linux-media@vger.kernel.org
> L: linux-renesas-soc@vger.kernel.org
> S: Supported
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/renesas,fdp1.txt
> +F: Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> F: drivers/media/platform/rcar_fdp1.c
>
> MEDIA DRIVERS FOR RENESAS - VIN
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 5/8] dt-bindings: media: renesas,fdp1: Make power-domains mandatory
2020-06-21 0:47 ` [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: " Laurent Pinchart
@ 2020-06-30 20:56 ` Niklas Söderlund
-1 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:56 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, linux-media, devicetree, linux-renesas-soc, Rob Herring
Hi Laurent,
Thank for your patch.
On 2020-06-21 03:47:31 +0300, Laurent Pinchart wrote:
> All DT source files in the kernel tree specify the power-domains
> property. Make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Fix typo in comment message
> ---
> Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> index f4db96a1f53c..39184bd21a27 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> @@ -43,6 +43,7 @@ required:
> - reg
> - interrupts
> - clocks
> + - power-domains
>
> additionalProperties: false
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 5/8] dt-bindings: media: renesas,fdp1: Make power-domains mandatory
@ 2020-06-30 20:56 ` Niklas Söderlund
0 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:56 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
Hi Laurent,
Thank for your patch.
On 2020-06-21 03:47:31 +0300, Laurent Pinchart wrote:
> All DT source files in the kernel tree specify the power-domains
> property. Make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Fix typo in comment message
> ---
> Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> index f4db96a1f53c..39184bd21a27 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> @@ -43,6 +43,7 @@ required:
> - reg
> - interrupts
> - clocks
> + - power-domains
>
> additionalProperties: false
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-06-30 20:57 ` Niklas Söderlund
-1 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, linux-media, devicetree, linux-renesas-soc, Rob Herring
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:32 +0300, Laurent Pinchart wrote:
> The resets property is used in DT sources in the kernel tree. Document
> it and make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Fix typo in commit message
> ---
> Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> index 39184bd21a27..2a27a7296fea 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> @@ -32,6 +32,9 @@ properties:
> power-domains:
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> renesas,fcp:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> @@ -44,6 +47,7 @@ required:
> - interrupts
> - clocks
> - power-domains
> + - resets
>
> additionalProperties: false
>
> @@ -59,6 +63,7 @@ examples:
> interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 119>;
> power-domains = <&sysc R8A7795_PD_A3VP>;
> + resets = <&cpg 119>;
> renesas,fcp = <&fcpf0>;
> };
> ...
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property
@ 2020-06-30 20:57 ` Niklas Söderlund
0 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 20:57 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:32 +0300, Laurent Pinchart wrote:
> The resets property is used in DT sources in the kernel tree. Document
> it and make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Fix typo in commit message
> ---
> Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> index 39184bd21a27..2a27a7296fea 100644
> --- a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> @@ -32,6 +32,9 @@ properties:
> power-domains:
> maxItems: 1
>
> + resets:
> + maxItems: 1
> +
> renesas,fcp:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> @@ -44,6 +47,7 @@ required:
> - interrupts
> - clocks
> - power-domains
> + - resets
>
> additionalProperties: false
>
> @@ -59,6 +63,7 @@ examples:
> interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 119>;
> power-domains = <&sysc R8A7795_PD_A3VP>;
> + resets = <&cpg 119>;
> renesas,fcp = <&fcpf0>;
> };
> ...
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 7/8] dt-bindings: media: renesas,vsp1: Convert binding to YAML
2020-06-21 0:47 ` [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: " Laurent Pinchart
@ 2020-06-30 21:02 ` Niklas Söderlund
-1 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 21:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, linux-media, devicetree, linux-renesas-soc, Rob Herring
Hi Laurent,
Thanks for your patch.
On 2020-06-21 03:47:33 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car VSP1 text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../bindings/media/renesas,vsp1.txt | 30 -------
> .../bindings/media/renesas,vsp1.yaml | 83 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 84 insertions(+), 31 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> deleted file mode 100644
> index cd5a955b2ea0..000000000000
> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -* Renesas VSP Video Processing Engine
> -
> -The VSP is a video processing engine that supports up-/down-scaling, alpha
> -blending, color space conversion and various other image processing features.
> -It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
> -
> -Required properties:
> -
> - - compatible: Must contain one of the following values
> - - "renesas,vsp1" for the R-Car Gen2 and RZ/G1 VSP1
> - - "renesas,vsp2" for the R-Car Gen3 and RZ/G2 VSP2
> -
> - - reg: Base address and length of the registers block for the VSP.
> - - interrupts: VSP interrupt specifier.
> - - clocks: A phandle + clock-specifier pair for the VSP functional clock.
> -
> -Optional properties:
> -
> - - renesas,fcp: A phandle referencing the FCP that handles memory accesses
> - for the VSP. Not needed on Gen2, mandatory on Gen3.
> -
> -
> -Example: R8A7790 (R-Car H2) VSP1-S node
> -
> - vsp@fe928000 {
> - compatible = "renesas,vsp1";
> - reg = <0 0xfe928000 0 0x8000>;
> - interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&mstp1_clks R8A7790_CLK_VSP1_S>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> new file mode 100644
> index 000000000000..65e8ee61ce90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,vsp1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas VSP Video Processing Engine
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description:
> + The VSP is a video processing engine that supports up-/down-scaling, alpha
> + blending, color space conversion and various other image processing features.
> + It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
> +
> +properties:
> + compatible:
> + enum:
> + - renesas,vsp1 # R-Car Gen2 and RZ/G1
> + - renesas,vsp2 # R-Car Gen3 and RZ/G2
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + renesas,fcp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + A phandle referencing the FCP that handles memory accesses for the VSP.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
> +
> +if:
> + properties:
> + compatible:
> + items:
> + - const: renesas,vsp1
> +then:
> + properties:
> + renesas,fcp: false
> +else:
> + required:
> + - renesas,fcp
> +
> +examples:
> + # R8A7790 (R-Car H2) VSP1-S
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + vsp@fe928000 {
> + compatible = "renesas,vsp1";
> + reg = <0xfe928000 0x8000>;
> + interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 131>;
> + };
> +
> + # R8A77951 (R-Car H3) VSP2-BC
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + vsp@fe920000 {
> + compatible = "renesas,vsp2";
> + reg = <0xfe920000 0x8000>;
> + interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 624>;
> +
> + renesas,fcp = <&fcpvb1>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7383dfa510a3..22e079cc3e3f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10730,7 +10730,7 @@ L: linux-media@vger.kernel.org
> L: linux-renesas-soc@vger.kernel.org
> S: Supported
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/renesas,vsp1.txt
> +F: Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> F: drivers/media/platform/vsp1/
>
> MEDIA DRIVERS FOR ST STV0910 DEMODULATOR ICs
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML
@ 2020-06-30 21:02 ` Niklas Söderlund
0 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 21:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
Hi Laurent,
Thanks for your patch.
On 2020-06-21 03:47:33 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car VSP1 text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../bindings/media/renesas,vsp1.txt | 30 -------
> .../bindings/media/renesas,vsp1.yaml | 83 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 84 insertions(+), 31 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> deleted file mode 100644
> index cd5a955b2ea0..000000000000
> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -* Renesas VSP Video Processing Engine
> -
> -The VSP is a video processing engine that supports up-/down-scaling, alpha
> -blending, color space conversion and various other image processing features.
> -It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
> -
> -Required properties:
> -
> - - compatible: Must contain one of the following values
> - - "renesas,vsp1" for the R-Car Gen2 and RZ/G1 VSP1
> - - "renesas,vsp2" for the R-Car Gen3 and RZ/G2 VSP2
> -
> - - reg: Base address and length of the registers block for the VSP.
> - - interrupts: VSP interrupt specifier.
> - - clocks: A phandle + clock-specifier pair for the VSP functional clock.
> -
> -Optional properties:
> -
> - - renesas,fcp: A phandle referencing the FCP that handles memory accesses
> - for the VSP. Not needed on Gen2, mandatory on Gen3.
> -
> -
> -Example: R8A7790 (R-Car H2) VSP1-S node
> -
> - vsp@fe928000 {
> - compatible = "renesas,vsp1";
> - reg = <0 0xfe928000 0 0x8000>;
> - interrupts = <0 267 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&mstp1_clks R8A7790_CLK_VSP1_S>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> new file mode 100644
> index 000000000000..65e8ee61ce90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,vsp1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas VSP Video Processing Engine
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description:
> + The VSP is a video processing engine that supports up-/down-scaling, alpha
> + blending, color space conversion and various other image processing features.
> + It can be found in the Renesas R-Car Gen2, R-Car Gen3, RZ/G1, and RZ/G2 SoCs.
> +
> +properties:
> + compatible:
> + enum:
> + - renesas,vsp1 # R-Car Gen2 and RZ/G1
> + - renesas,vsp2 # R-Car Gen3 and RZ/G2
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + renesas,fcp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + A phandle referencing the FCP that handles memory accesses for the VSP.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> +
> +additionalProperties: false
> +
> +if:
> + properties:
> + compatible:
> + items:
> + - const: renesas,vsp1
> +then:
> + properties:
> + renesas,fcp: false
> +else:
> + required:
> + - renesas,fcp
> +
> +examples:
> + # R8A7790 (R-Car H2) VSP1-S
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + vsp@fe928000 {
> + compatible = "renesas,vsp1";
> + reg = <0xfe928000 0x8000>;
> + interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 131>;
> + };
> +
> + # R8A77951 (R-Car H3) VSP2-BC
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + vsp@fe920000 {
> + compatible = "renesas,vsp2";
> + reg = <0xfe920000 0x8000>;
> + interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 624>;
> +
> + renesas,fcp = <&fcpvb1>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7383dfa510a3..22e079cc3e3f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10730,7 +10730,7 @@ L: linux-media@vger.kernel.org
> L: linux-renesas-soc@vger.kernel.org
> S: Supported
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/renesas,vsp1.txt
> +F: Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> F: drivers/media/platform/vsp1/
>
> MEDIA DRIVERS FOR ST STV0910 DEMODULATOR ICs
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 8/8] dt-bindings: media: renesas,vsp1: Add power-domains and resets
2020-06-21 0:47 ` [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: " Laurent Pinchart
@ 2020-06-30 21:03 ` Niklas Söderlund
-1 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 21:03 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, linux-media, devicetree, linux-renesas-soc, Rob Herring
Hi Laurent,
Thanks for your patch.
On 2020-06-21 03:47:34 +0300, Laurent Pinchart wrote:
> The power-domains and resets properties are used in all DT sources in
> the kernel but are absent from the bindings. Document them and make them
> mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> .../devicetree/bindings/media/renesas,vsp1.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> index 65e8ee61ce90..990e9c1dbc43 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> @@ -29,6 +29,12 @@ properties:
> clocks:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> renesas,fcp:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> @@ -39,6 +45,8 @@ required:
> - reg
> - interrupts
> - clocks
> + - power-domains
> + - resets
>
> additionalProperties: false
>
> @@ -59,24 +67,30 @@ examples:
> - |
> #include <dt-bindings/clock/renesas-cpg-mssr.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/r8a7790-sysc.h>
>
> vsp@fe928000 {
> compatible = "renesas,vsp1";
> reg = <0xfe928000 0x8000>;
> interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 131>;
> + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> + resets = <&cpg 131>;
> };
>
> # R8A77951 (R-Car H3) VSP2-BC
> - |
> #include <dt-bindings/clock/renesas-cpg-mssr.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
>
> vsp@fe920000 {
> compatible = "renesas,vsp2";
> reg = <0xfe920000 0x8000>;
> interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 624>;
> + power-domains = <&sysc R8A7795_PD_A3VP>;
> + resets = <&cpg 624>;
>
> renesas,fcp = <&fcpvb1>;
> };
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 8/8] dt-bindings: media: renesas,vsp1: Add power-domains and resets
@ 2020-06-30 21:03 ` Niklas Söderlund
0 siblings, 0 replies; 54+ messages in thread
From: Niklas Söderlund @ 2020-06-30 21:03 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
Hi Laurent,
Thanks for your patch.
On 2020-06-21 03:47:34 +0300, Laurent Pinchart wrote:
> The power-domains and resets properties are used in all DT sources in
> the kernel but are absent from the bindings. Document them and make them
> mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> .../devicetree/bindings/media/renesas,vsp1.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> index 65e8ee61ce90..990e9c1dbc43 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> @@ -29,6 +29,12 @@ properties:
> clocks:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> renesas,fcp:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> @@ -39,6 +45,8 @@ required:
> - reg
> - interrupts
> - clocks
> + - power-domains
> + - resets
>
> additionalProperties: false
>
> @@ -59,24 +67,30 @@ examples:
> - |
> #include <dt-bindings/clock/renesas-cpg-mssr.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/r8a7790-sysc.h>
>
> vsp@fe928000 {
> compatible = "renesas,vsp1";
> reg = <0xfe928000 0x8000>;
> interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 131>;
> + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> + resets = <&cpg 131>;
> };
>
> # R8A77951 (R-Car H3) VSP2-BC
> - |
> #include <dt-bindings/clock/renesas-cpg-mssr.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
>
> vsp@fe920000 {
> compatible = "renesas,vsp2";
> reg = <0xfe920000 0x8000>;
> interrupts = <GIC_SPI 465 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 624>;
> + power-domains = <&sysc R8A7795_PD_A3VP>;
> + resets = <&cpg 624>;
>
> renesas,fcp = <&fcpvb1>;
> };
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
2020-06-30 20:49 ` Niklas Söderlund
@ 2020-07-01 6:03 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-07-01 6:03 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Laurent Pinchart, dri-devel, linux-media, devicetree,
linux-renesas-soc, Rob Herring
Hi Niklas,
On Tue, Jun 30, 2020 at 10:49:18PM +0200, Niklas Söderlund wrote:
> On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote:
> > Convert the Renesas R-Car FCP text binding to YAML.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Changes since v1:
> >
> > - Simplify comments on compatible strings
> > - Update MAINTAINERS
> > ---
> > .../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
> > .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
> > MAINTAINERS | 2 +-
> > 3 files changed, 57 insertions(+), 35 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> > create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> > deleted file mode 100644
> > index 79c37395b396..000000000000
> > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> > +++ /dev/null
> > @@ -1,34 +0,0 @@
> > -Renesas R-Car Frame Compression Processor (FCP)
> > ------------------------------------------------
> > -
> > -The FCP is a companion module of video processing modules in the Renesas R-Car
> > -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
> > -caching, and conversion of AXI transactions in order to reduce the memory
> > -bandwidth.
> > -
> > -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
> > -for FDP (FCPF). Their configuration and behaviour depend on the module they
> > -are paired with. These DT bindings currently support the FCPV and FCPF.
> > -
> > - - compatible: Must be one or more of the following
> > -
> > - - "renesas,fcpv" for generic compatible 'FCP for VSP'
> > - - "renesas,fcpf" for generic compatible 'FCP for FDP'
> > -
> > - - reg: the register base and size for the device registers
> > - - clocks: Reference to the functional clock
> > -
> > -Optional properties:
> > - - power-domains : power-domain property defined with a power domain specifier
> > - to respective power domain.
> > -
> > -
> > -Device node example
> > --------------------
> > -
> > - fcpvd1: fcp@fea2f000 {
> > - compatible = "renesas,fcpv";
> > - reg = <0 0xfea2f000 0 0x200>;
> > - clocks = <&cpg CPG_MOD 602>;
> > - power-domains = <&sysc R8A7795_PD_A3VP>;
> > - };
> > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > new file mode 100644
> > index 000000000000..9241bf3c5efc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas R-Car Frame Compression Processor (FCP)
> > +
> > +maintainers:
> > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > +
> > +description: |
> > + The FCP is a companion module of video processing modules in the Renesas
> > + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
> > + data caching, and conversion of AXI transactions in order to reduce the
> > + memory bandwidth.
> > +
> > + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> > + FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> > + they are paired with. These DT bindings currently support the FCPV and FCPF.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - renesas,fcpv # FCP for VSP
> > + - renesas,fcpf # FCP for FDP
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + # R8A7790 (R-Car H2) VSP1-S
>
> Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it
> not? With this fixed,
Absolutely. I don't know how it ended there. I'll fix this.
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> > + - |
> > + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> > + #include <dt-bindings/power/r8a7795-sysc.h>
> > +
> > + fcp@fea2f000 {
> > + compatible = "renesas,fcpv";
> > + reg = <0xfea2f000 0x200>;
> > + clocks = <&cpg CPG_MOD 602>;
> > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> > + };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 68f21d46614c..660ed6606de2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
> > L: linux-renesas-soc@vger.kernel.org
> > S: Supported
> > T: git git://linuxtv.org/media_tree.git
> > -F: Documentation/devicetree/bindings/media/renesas,fcp.txt
> > +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > F: drivers/media/platform/rcar-fcp.c
> > F: include/media/rcar-fcp.h
> >
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
@ 2020-07-01 6:03 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-07-01 6:03 UTC (permalink / raw)
To: Niklas Söderlund
Cc: devicetree, Laurent Pinchart, dri-devel, linux-renesas-soc,
Rob Herring, linux-media
Hi Niklas,
On Tue, Jun 30, 2020 at 10:49:18PM +0200, Niklas Söderlund wrote:
> On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote:
> > Convert the Renesas R-Car FCP text binding to YAML.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > Changes since v1:
> >
> > - Simplify comments on compatible strings
> > - Update MAINTAINERS
> > ---
> > .../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
> > .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
> > MAINTAINERS | 2 +-
> > 3 files changed, 57 insertions(+), 35 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> > create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> > deleted file mode 100644
> > index 79c37395b396..000000000000
> > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> > +++ /dev/null
> > @@ -1,34 +0,0 @@
> > -Renesas R-Car Frame Compression Processor (FCP)
> > ------------------------------------------------
> > -
> > -The FCP is a companion module of video processing modules in the Renesas R-Car
> > -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
> > -caching, and conversion of AXI transactions in order to reduce the memory
> > -bandwidth.
> > -
> > -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
> > -for FDP (FCPF). Their configuration and behaviour depend on the module they
> > -are paired with. These DT bindings currently support the FCPV and FCPF.
> > -
> > - - compatible: Must be one or more of the following
> > -
> > - - "renesas,fcpv" for generic compatible 'FCP for VSP'
> > - - "renesas,fcpf" for generic compatible 'FCP for FDP'
> > -
> > - - reg: the register base and size for the device registers
> > - - clocks: Reference to the functional clock
> > -
> > -Optional properties:
> > - - power-domains : power-domain property defined with a power domain specifier
> > - to respective power domain.
> > -
> > -
> > -Device node example
> > --------------------
> > -
> > - fcpvd1: fcp@fea2f000 {
> > - compatible = "renesas,fcpv";
> > - reg = <0 0xfea2f000 0 0x200>;
> > - clocks = <&cpg CPG_MOD 602>;
> > - power-domains = <&sysc R8A7795_PD_A3VP>;
> > - };
> > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > new file mode 100644
> > index 000000000000..9241bf3c5efc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas R-Car Frame Compression Processor (FCP)
> > +
> > +maintainers:
> > + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > +
> > +description: |
> > + The FCP is a companion module of video processing modules in the Renesas
> > + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
> > + data caching, and conversion of AXI transactions in order to reduce the
> > + memory bandwidth.
> > +
> > + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> > + FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> > + they are paired with. These DT bindings currently support the FCPV and FCPF.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - renesas,fcpv # FCP for VSP
> > + - renesas,fcpf # FCP for FDP
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + # R8A7790 (R-Car H2) VSP1-S
>
> Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it
> not? With this fixed,
Absolutely. I don't know how it ended there. I'll fix this.
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>
> > + - |
> > + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> > + #include <dt-bindings/power/r8a7795-sysc.h>
> > +
> > + fcp@fea2f000 {
> > + compatible = "renesas,fcpv";
> > + reg = <0xfea2f000 0x200>;
> > + clocks = <&cpg CPG_MOD 602>;
> > + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> > + };
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 68f21d46614c..660ed6606de2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
> > L: linux-renesas-soc@vger.kernel.org
> > S: Supported
> > T: git git://linuxtv.org/media_tree.git
> > -F: Documentation/devicetree/bindings/media/renesas,fcp.txt
> > +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > F: drivers/media/platform/rcar-fcp.c
> > F: include/media/rcar-fcp.h
> >
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* [PATCH v2.1 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
2020-07-01 6:03 ` Laurent Pinchart
@ 2020-07-01 6:05 ` Laurent Pinchart
-1 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-07-01 6:05 UTC (permalink / raw)
To: linux-media
Cc: devicetree, linux-renesas-soc, dri-devel, Rob Herring,
Niklas Söderlund
Convert the Renesas R-Car FCP text binding to YAML.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
Changes since v2:
- Refer to the correct device in the comment above the example
Changes since v1:
- Simplify comments on compatible strings
- Update MAINTAINERS
---
.../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
.../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 57 insertions(+), 35 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
deleted file mode 100644
index 79c37395b396..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-Renesas R-Car Frame Compression Processor (FCP)
------------------------------------------------
-
-The FCP is a companion module of video processing modules in the Renesas R-Car
-Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
-caching, and conversion of AXI transactions in order to reduce the memory
-bandwidth.
-
-There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
-for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV and FCPF.
-
- - compatible: Must be one or more of the following
-
- - "renesas,fcpv" for generic compatible 'FCP for VSP'
- - "renesas,fcpf" for generic compatible 'FCP for FDP'
-
- - reg: the register base and size for the device registers
- - clocks: Reference to the functional clock
-
-Optional properties:
- - power-domains : power-domain property defined with a power domain specifier
- to respective power domain.
-
-
-Device node example
--------------------
-
- fcpvd1: fcp@fea2f000 {
- compatible = "renesas,fcpv";
- reg = <0 0xfea2f000 0 0x200>;
- clocks = <&cpg CPG_MOD 602>;
- power-domains = <&sysc R8A7795_PD_A3VP>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
new file mode 100644
index 000000000000..ec0cb42ca464
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Frame Compression Processor (FCP)
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description: |
+ The FCP is a companion module of video processing modules in the Renesas
+ R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
+ data caching, and conversion of AXI transactions in order to reduce the
+ memory bandwidth.
+
+ There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
+ FCP for FDP (FCPF). Their configuration and behaviour depend on the module
+ they are paired with. These DT bindings currently support the FCPV and FCPF.
+
+properties:
+ compatible:
+ enum:
+ - renesas,fcpv # FCP for VSP
+ - renesas,fcpf # FCP for FDP
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ # R8A7795 (R-Car H3) FCP for VSP-D1
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/power/r8a7795-sysc.h>
+
+ fcp@fea2f000 {
+ compatible = "renesas,fcpv";
+ reg = <0xfea2f000 0x200>;
+ clocks = <&cpg CPG_MOD 602>;
+ power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 634d2c3d621a..d69e49067d1a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
L: linux-renesas-soc@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,fcp.txt
+F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
F: drivers/media/platform/rcar-fcp.c
F: include/media/rcar-fcp.h
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 54+ messages in thread
* [PATCH v2.1 1/8] dt-bindings: media: renesas, fcp: Convert binding to YAML
@ 2020-07-01 6:05 ` Laurent Pinchart
0 siblings, 0 replies; 54+ messages in thread
From: Laurent Pinchart @ 2020-07-01 6:05 UTC (permalink / raw)
To: linux-media
Cc: linux-renesas-soc, devicetree, Rob Herring,
Niklas Söderlund, dri-devel
Convert the Renesas R-Car FCP text binding to YAML.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
Changes since v2:
- Refer to the correct device in the comment above the example
Changes since v1:
- Simplify comments on compatible strings
- Update MAINTAINERS
---
.../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
.../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
MAINTAINERS | 2 +-
3 files changed, 57 insertions(+), 35 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
deleted file mode 100644
index 79c37395b396..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-Renesas R-Car Frame Compression Processor (FCP)
------------------------------------------------
-
-The FCP is a companion module of video processing modules in the Renesas R-Car
-Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
-caching, and conversion of AXI transactions in order to reduce the memory
-bandwidth.
-
-There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
-for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV and FCPF.
-
- - compatible: Must be one or more of the following
-
- - "renesas,fcpv" for generic compatible 'FCP for VSP'
- - "renesas,fcpf" for generic compatible 'FCP for FDP'
-
- - reg: the register base and size for the device registers
- - clocks: Reference to the functional clock
-
-Optional properties:
- - power-domains : power-domain property defined with a power domain specifier
- to respective power domain.
-
-
-Device node example
--------------------
-
- fcpvd1: fcp@fea2f000 {
- compatible = "renesas,fcpv";
- reg = <0 0xfea2f000 0 0x200>;
- clocks = <&cpg CPG_MOD 602>;
- power-domains = <&sysc R8A7795_PD_A3VP>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
new file mode 100644
index 000000000000..ec0cb42ca464
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Frame Compression Processor (FCP)
+
+maintainers:
+ - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
+
+description: |
+ The FCP is a companion module of video processing modules in the Renesas
+ R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
+ data caching, and conversion of AXI transactions in order to reduce the
+ memory bandwidth.
+
+ There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
+ FCP for FDP (FCPF). Their configuration and behaviour depend on the module
+ they are paired with. These DT bindings currently support the FCPV and FCPF.
+
+properties:
+ compatible:
+ enum:
+ - renesas,fcpv # FCP for VSP
+ - renesas,fcpf # FCP for FDP
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ # R8A7795 (R-Car H3) FCP for VSP-D1
+ - |
+ #include <dt-bindings/clock/renesas-cpg-mssr.h>
+ #include <dt-bindings/power/r8a7795-sysc.h>
+
+ fcp@fea2f000 {
+ compatible = "renesas,fcpv";
+ reg = <0xfea2f000 0x200>;
+ clocks = <&cpg CPG_MOD 602>;
+ power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+ };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 634d2c3d621a..d69e49067d1a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
L: linux-renesas-soc@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,fcp.txt
+F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
F: drivers/media/platform/rcar-fcp.c
F: include/media/rcar-fcp.h
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 54+ messages in thread
* Re: [PATCH v2 2/8] dt-bindings: media: renesas, fcp: Make power-domains mandatory
2020-06-21 0:47 ` [PATCH v2 2/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
@ 2020-07-13 23:59 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-13 23:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, dri-devel, Rob Herring, linux-renesas-soc
On Sun, 21 Jun 2020 03:47:28 +0300, Laurent Pinchart wrote:
> All DT source files in the kernel tree specify the power-domains
> property. Make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Fix typo in commit message
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 2/8] dt-bindings: media: renesas, fcp: Make power-domains mandatory
@ 2020-07-13 23:59 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-13 23:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
On Sun, 21 Jun 2020 03:47:28 +0300, Laurent Pinchart wrote:
> All DT source files in the kernel tree specify the power-domains
> property. Make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Fix typo in commit message
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 3/8] dt-bindings: media: renesas, fcp: Add resets and iommus properties
2020-06-21 0:47 ` [PATCH v2 3/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
@ 2020-07-13 23:59 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-13 23:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Rob Herring, dri-devel, devicetree, linux-renesas-soc, linux-media
On Sun, 21 Jun 2020 03:47:29 +0300, Laurent Pinchart wrote:
> The resets and iommus properties are used in DT sources in the kernel
> tree. Document them, and make resets mandatory. The iommus property is
> optional as not all platforms wire the FCP to a functional IOMMU.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 3/8] dt-bindings: media: renesas, fcp: Add resets and iommus properties
@ 2020-07-13 23:59 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-13 23:59 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
On Sun, 21 Jun 2020 03:47:29 +0300, Laurent Pinchart wrote:
> The resets and iommus properties are used in DT sources in the kernel
> tree. Document them, and make resets mandatory. The iommus property is
> optional as not all platforms wire the FCP to a functional IOMMU.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/media/renesas,fcp.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML
2020-06-21 0:47 ` [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: " Laurent Pinchart
@ 2020-07-14 0:00 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:00 UTC (permalink / raw)
To: Laurent Pinchart
Cc: dri-devel, devicetree, linux-media, Rob Herring, linux-renesas-soc
On Sun, 21 Jun 2020 03:47:30 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FDP1 text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Update MAINTAINERS
> ---
> .../bindings/media/renesas,fdp1.txt | 37 -----------
> .../bindings/media/renesas,fdp1.yaml | 63 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 64 insertions(+), 38 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML
@ 2020-07-14 0:00 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:00 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
On Sun, 21 Jun 2020 03:47:30 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FDP1 text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Update MAINTAINERS
> ---
> .../bindings/media/renesas,fdp1.txt | 37 -----------
> .../bindings/media/renesas,fdp1.yaml | 63 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 64 insertions(+), 38 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: Make power-domains mandatory
2020-06-21 0:47 ` [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: " Laurent Pinchart
@ 2020-07-14 0:00 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:00 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, linux-media, linux-renesas-soc, dri-devel, Rob Herring
On Sun, 21 Jun 2020 03:47:31 +0300, Laurent Pinchart wrote:
> All DT source files in the kernel tree specify the power-domains
> property. Make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Fix typo in comment message
> ---
> Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: Make power-domains mandatory
@ 2020-07-14 0:00 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:00 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
On Sun, 21 Jun 2020 03:47:31 +0300, Laurent Pinchart wrote:
> All DT source files in the kernel tree specify the power-domains
> property. Make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Fix typo in comment message
> ---
> Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property
2020-06-21 0:47 ` Laurent Pinchart
@ 2020-07-14 0:01 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:01 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, linux-renesas-soc, Rob Herring, dri-devel, devicetree
On Sun, 21 Jun 2020 03:47:32 +0300, Laurent Pinchart wrote:
> The resets property is used in DT sources in the kernel tree. Document
> it and make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Fix typo in commit message
> ---
> Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property
@ 2020-07-14 0:01 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:01 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
On Sun, 21 Jun 2020 03:47:32 +0300, Laurent Pinchart wrote:
> The resets property is used in DT sources in the kernel tree. Document
> it and make it mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Fix typo in commit message
> ---
> Documentation/devicetree/bindings/media/renesas,fdp1.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML
2020-06-21 0:47 ` [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: " Laurent Pinchart
@ 2020-07-14 0:02 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, dri-devel, Rob Herring, devicetree, linux-renesas-soc
On Sun, 21 Jun 2020 03:47:33 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car VSP1 text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../bindings/media/renesas,vsp1.txt | 30 -------
> .../bindings/media/renesas,vsp1.yaml | 83 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 84 insertions(+), 31 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: Convert binding to YAML
@ 2020-07-14 0:02 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
On Sun, 21 Jun 2020 03:47:33 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car VSP1 text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../bindings/media/renesas,vsp1.txt | 30 -------
> .../bindings/media/renesas,vsp1.yaml | 83 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 84 insertions(+), 31 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,vsp1.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: Add power-domains and resets
2020-06-21 0:47 ` [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: " Laurent Pinchart
@ 2020-07-14 0:02 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-media, devicetree, Rob Herring, dri-devel, linux-renesas-soc
On Sun, 21 Jun 2020 03:47:34 +0300, Laurent Pinchart wrote:
> The power-domains and resets properties are used in all DT sources in
> the kernel but are absent from the bindings. Document them and make them
> mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/media/renesas,vsp1.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: Add power-domains and resets
@ 2020-07-14 0:02 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 0:02 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, devicetree, Rob Herring, dri-devel, linux-media
On Sun, 21 Jun 2020 03:47:34 +0300, Laurent Pinchart wrote:
> The power-domains and resets properties are used in all DT sources in
> the kernel but are absent from the bindings. Document them and make them
> mandatory.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/media/renesas,vsp1.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2.1 1/8] dt-bindings: media: renesas, fcp: Convert binding to YAML
2020-07-01 6:05 ` [PATCH v2.1 1/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
@ 2020-07-14 2:45 ` Rob Herring
-1 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 2:45 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-renesas-soc, dri-devel, Niklas Söderlund, linux-media,
devicetree, Rob Herring
On Wed, 01 Jul 2020 09:05:25 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FCP text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v2:
>
> - Refer to the correct device in the comment above the example
>
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
> .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 57 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 54+ messages in thread
* Re: [PATCH v2.1 1/8] dt-bindings: media: renesas, fcp: Convert binding to YAML
@ 2020-07-14 2:45 ` Rob Herring
0 siblings, 0 replies; 54+ messages in thread
From: Rob Herring @ 2020-07-14 2:45 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, dri-devel, linux-renesas-soc, Rob Herring,
Niklas Söderlund, linux-media
On Wed, 01 Jul 2020 09:05:25 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FCP text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> Changes since v2:
>
> - Refer to the correct device in the comment above the example
>
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
> .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 57 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 54+ messages in thread
end of thread, other threads:[~2020-07-14 2:45 UTC | newest]
Thread overview: 54+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21 0:47 [PATCH v2 0/8] dt-bindings: media: Conversion of Renesas bindings to YAML Laurent Pinchart
2020-06-21 0:47 ` Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding " Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 1/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
2020-06-30 20:49 ` [PATCH v2 1/8] dt-bindings: media: renesas,fcp: " Niklas Söderlund
2020-06-30 20:49 ` Niklas Söderlund
2020-07-01 6:03 ` Laurent Pinchart
2020-07-01 6:03 ` Laurent Pinchart
2020-07-01 6:05 ` [PATCH v2.1 " Laurent Pinchart
2020-07-01 6:05 ` [PATCH v2.1 1/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
2020-07-14 2:45 ` Rob Herring
2020-07-14 2:45 ` Rob Herring
2020-06-21 0:47 ` [PATCH v2 2/8] dt-bindings: media: renesas,fcp: Make power-domains mandatory Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 2/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
2020-06-30 20:49 ` [PATCH v2 2/8] dt-bindings: media: renesas,fcp: " Niklas Söderlund
2020-06-30 20:49 ` Niklas Söderlund
2020-07-13 23:59 ` [PATCH v2 2/8] dt-bindings: media: renesas, fcp: " Rob Herring
2020-07-13 23:59 ` Rob Herring
2020-06-21 0:47 ` [PATCH v2 3/8] dt-bindings: media: renesas,fcp: Add resets and iommus properties Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 3/8] dt-bindings: media: renesas, fcp: " Laurent Pinchart
2020-06-30 20:50 ` [PATCH v2 3/8] dt-bindings: media: renesas,fcp: " Niklas Söderlund
2020-06-30 20:50 ` Niklas Söderlund
2020-07-13 23:59 ` [PATCH v2 3/8] dt-bindings: media: renesas, fcp: " Rob Herring
2020-07-13 23:59 ` Rob Herring
2020-06-21 0:47 ` [PATCH v2 4/8] dt-bindings: media: renesas,fdp1: Convert binding to YAML Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: " Laurent Pinchart
2020-06-30 20:55 ` [PATCH v2 4/8] dt-bindings: media: renesas,fdp1: " Niklas Söderlund
2020-06-30 20:55 ` [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: " Niklas Söderlund
2020-07-14 0:00 ` Rob Herring
2020-07-14 0:00 ` Rob Herring
2020-06-21 0:47 ` [PATCH v2 5/8] dt-bindings: media: renesas,fdp1: Make power-domains mandatory Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: " Laurent Pinchart
2020-06-30 20:56 ` [PATCH v2 5/8] dt-bindings: media: renesas,fdp1: " Niklas Söderlund
2020-06-30 20:56 ` Niklas Söderlund
2020-07-14 0:00 ` [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: " Rob Herring
2020-07-14 0:00 ` Rob Herring
2020-06-21 0:47 ` [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property Laurent Pinchart
2020-06-21 0:47 ` Laurent Pinchart
2020-06-30 20:57 ` Niklas Söderlund
2020-06-30 20:57 ` Niklas Söderlund
2020-07-14 0:01 ` Rob Herring
2020-07-14 0:01 ` Rob Herring
2020-06-21 0:47 ` [PATCH v2 7/8] dt-bindings: media: renesas,vsp1: Convert binding to YAML Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: " Laurent Pinchart
2020-06-30 21:02 ` [PATCH v2 7/8] dt-bindings: media: renesas,vsp1: " Niklas Söderlund
2020-06-30 21:02 ` [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: " Niklas Söderlund
2020-07-14 0:02 ` Rob Herring
2020-07-14 0:02 ` Rob Herring
2020-06-21 0:47 ` [PATCH v2 8/8] dt-bindings: media: renesas,vsp1: Add power-domains and resets Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: " Laurent Pinchart
2020-06-30 21:03 ` [PATCH v2 8/8] dt-bindings: media: renesas,vsp1: " Niklas Söderlund
2020-06-30 21:03 ` Niklas Söderlund
2020-07-14 0:02 ` [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: " Rob Herring
2020-07-14 0:02 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.