From: Lee Jones <lee.jones@linaro.org> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>, Baolin Wang <baolin.wang7@gmail.com>, Chunyan Zhang <zhang.lyra@gmail.com> Cc: johan@kernel.org Subject: [PATCH] mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting Date: Wed, 1 Jul 2020 10:15:18 +0100 [thread overview] Message-ID: <20200701091518.GW1179328@dell> (raw) In-Reply-To: <20200629123215.1014747-5-lee.jones@linaro.org> 'i / pdata->num_irqs' always equates to 0 and 'BIT(i % pdata->num_irqs)' always ends up being BIT(i) here, so make that clearer in the code. If the code base needs to support more than 32 IRQs in the future, this will have to be reworked, but lets just keep it simple for as long as we can. This fixes the following W=1 warning: drivers/mfd/sprd-sc27xx-spi.c:255 sprd_pmic_probe() debug: sval_binop_unsigned: divide by zero Cc: Orson Zhai <orsonzhai@gmail.com> Cc: Chunyan Zhang <zhang.lyra@gmail.com> Cc: Johan Hovold <johan@kernel.org> Suggested-by: Baolin Wang <baolin.wang7@gmail.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index c305e941e435c..4a1a61e1a86ea 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -251,10 +251,8 @@ static int sprd_pmic_probe(struct spi_device *spi) return -ENOMEM; ddata->irq_chip.irqs = ddata->irqs; - for (i = 0; i < pdata->num_irqs; i++) { - ddata->irqs[i].reg_offset = i / pdata->num_irqs; - ddata->irqs[i].mask = BIT(i % pdata->num_irqs); - } + for (i = 0; i < pdata->num_irqs; i++) + ddata->irqs[i].mask = BIT(i); ret = devm_regmap_add_irq_chip(&spi->dev, ddata->regmap, ddata->irq, IRQF_ONESHOT | IRQF_NO_SUSPEND, 0,
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>, Baolin Wang <baolin.wang7@gmail.com>, Chunyan Zhang <zhang.lyra@gmail.com> Cc: johan@kernel.org Subject: [PATCH] mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting Date: Wed, 1 Jul 2020 10:15:18 +0100 [thread overview] Message-ID: <20200701091518.GW1179328@dell> (raw) In-Reply-To: <20200629123215.1014747-5-lee.jones@linaro.org> 'i / pdata->num_irqs' always equates to 0 and 'BIT(i % pdata->num_irqs)' always ends up being BIT(i) here, so make that clearer in the code. If the code base needs to support more than 32 IRQs in the future, this will have to be reworked, but lets just keep it simple for as long as we can. This fixes the following W=1 warning: drivers/mfd/sprd-sc27xx-spi.c:255 sprd_pmic_probe() debug: sval_binop_unsigned: divide by zero Cc: Orson Zhai <orsonzhai@gmail.com> Cc: Chunyan Zhang <zhang.lyra@gmail.com> Cc: Johan Hovold <johan@kernel.org> Suggested-by: Baolin Wang <baolin.wang7@gmail.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c index c305e941e435c..4a1a61e1a86ea 100644 --- a/drivers/mfd/sprd-sc27xx-spi.c +++ b/drivers/mfd/sprd-sc27xx-spi.c @@ -251,10 +251,8 @@ static int sprd_pmic_probe(struct spi_device *spi) return -ENOMEM; ddata->irq_chip.irqs = ddata->irqs; - for (i = 0; i < pdata->num_irqs; i++) { - ddata->irqs[i].reg_offset = i / pdata->num_irqs; - ddata->irqs[i].mask = BIT(i % pdata->num_irqs); - } + for (i = 0; i < pdata->num_irqs; i++) + ddata->irqs[i].mask = BIT(i); ret = devm_regmap_add_irq_chip(&spi->dev, ddata->regmap, ddata->irq, IRQF_ONESHOT | IRQF_NO_SUSPEND, 0, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-01 9:15 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 12:32 [PATCH 0/5] Last batch of W=1 warning fixes in MFD Lee Jones 2020-06-29 12:32 ` Lee Jones 2020-06-29 12:32 ` [PATCH 1/5] mfd: si476x-cmd: Add missing documentation for si476x_cmd_fm_rds_status()'s arg 'report' Lee Jones 2020-06-29 12:32 ` Lee Jones 2020-06-29 12:32 ` [PATCH 2/5] mfd: lm3533-ctrlbank: Cap BRIGHTNESS_MAX to 127 since API uses u8 as carrier Lee Jones 2020-06-29 12:32 ` Lee Jones 2020-06-29 12:51 ` Johan Hovold 2020-06-29 12:51 ` Johan Hovold 2020-06-29 13:25 ` Lee Jones 2020-06-29 13:25 ` Lee Jones 2020-06-30 8:38 ` Johan Hovold 2020-06-30 8:38 ` Johan Hovold 2020-06-29 12:32 ` [PATCH 3/5] mfd: rave-sp: Fix mistake in 'struct rave_sp_deframer's kerneldoc Lee Jones 2020-06-29 12:32 ` Lee Jones 2020-06-29 12:32 ` [PATCH 4/5] mfd: sprd-sc27xx-spi: Fix divide by zero when allocating register offset/mask Lee Jones 2020-06-29 12:32 ` Lee Jones 2020-06-29 13:06 ` Johan Hovold 2020-06-29 13:06 ` Johan Hovold 2020-06-29 14:01 ` Lee Jones 2020-06-29 14:01 ` Lee Jones 2020-06-29 14:35 ` Baolin Wang 2020-06-29 14:35 ` Baolin Wang 2020-06-29 14:43 ` Johan Hovold 2020-06-29 14:43 ` Johan Hovold 2020-06-29 15:08 ` Baolin Wang 2020-06-29 15:08 ` Baolin Wang 2020-06-29 15:45 ` Lee Jones 2020-06-29 15:45 ` Lee Jones 2020-07-01 9:15 ` Lee Jones [this message] 2020-07-01 9:15 ` [PATCH] mfd: sprd-sc27xx-spi: Fix-up bogus IRQ register offset and mask setting Lee Jones 2020-07-01 14:10 ` Baolin Wang 2020-07-01 14:10 ` Baolin Wang 2020-06-29 12:32 ` [PATCH 5/5] mfd: axp20x-i2c: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones 2020-06-29 12:32 ` Lee Jones 2020-06-29 15:38 ` Chen-Yu Tsai 2020-06-29 15:38 ` Chen-Yu Tsai 2020-07-06 7:31 ` Lee Jones 2020-07-06 7:31 ` Lee Jones 2020-07-01 6:59 ` [PATCH v2] mfd: axp20x-i2c: Tell the compiler that ACPI functions may not be used Lee Jones 2020-07-01 6:59 ` Lee Jones 2020-07-01 8:38 ` Chen-Yu Tsai 2020-07-01 8:38 ` Chen-Yu Tsai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200701091518.GW1179328@dell \ --to=lee.jones@linaro.org \ --cc=baolin.wang7@gmail.com \ --cc=johan@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=orsonzhai@gmail.com \ --cc=zhang.lyra@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.