[PATCH v3 0/2] x86: p2sb: P2SB fixes

[PATCH v3 0/2] x86: p2sb: P2SB fixes

[Wolfgang Wallner]

Currently it is possible to select the P2SB driver without selecting the
P2SB uclass, which can't work. Fix this by adding a "depends on" in
Kconfig.

While at it, correct the meaning of P2SB (according to Intel's
documentation P2SB stands for "Primary to Sideband Bridge").

Remark: I have resent this series as V2 as I had messed up the cover
letter in V1.

Changes in v3:
- Replaced the term in two more places

Changes in v2:
- Fixed cover letter

Wolfgang Wallner (2):
  drivers: p2sb: replace Primary-to-Sideband Bus with Primary to
    Sideband Bridge
  x86: p2sb: make P2SB driver depend on P2SB uclass

 arch/x86/Kconfig     |  1 +
 drivers/misc/Kconfig | 12 ++++++------
 2 files changed, 7 insertions(+), 6 deletions(-)

-- 
2.27.0

[PATCH v3 1/2] drivers: p2sb: replace Primary-to-Sideband Bus with Primary to Sideband Bridge

[Wolfgang Wallner]

In Intel's documentation the term P2SB stands for "Primary to Sideband
Bridge".

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
---

Changes in v3:
- Replaced the term in two more places

 drivers/misc/Kconfig | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 6bb5bc77e9..b67e906a76 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -243,10 +243,10 @@ config NUVOTON_NCT6102D
 	  in the Nuvoton Super IO chips on X86 platforms.
 
 config P2SB
-	bool "Intel Primary-to-Sideband Bus"
+	bool "Intel Primary to Sideband Bridge"
 	depends on X86 || SANDBOX
 	help
-	  This enables support for the Intel Primary-to-Sideband bus,
+	  This enables support for the Intel Primary to Sideband Bridge,
 	  abbreviated to P2SB. The P2SB is used to access various peripherals
 	  such as eSPI, GPIO, through memory-mapped I/O in a large chunk of PCI
 	  space. The space is segmented into different channels and peripherals
@@ -256,20 +256,20 @@ config P2SB
 	  devices - see pcr_readl(), etc.
 
 config SPL_P2SB
-	bool "Intel Primary-to-Sideband Bus in SPL"
+	bool "Intel Primary to Sideband Bridge in SPL"
 	depends on SPL && (X86 || SANDBOX)
 	help
-	  The Primary-to-Sideband bus is used to access various peripherals
+	  The Primary to Sideband Bridge is used to access various peripherals
 	  through memory-mapped I/O in a large chunk of PCI space. The space is
 	  segmented into different channels and peripherals are accessed by
 	  device-specific means within those channels. Devices should be added
 	  in the device tree as subnodes of the p2sb.
 
 config TPL_P2SB
-	bool "Intel Primary-to-Sideband Bus in TPL"
+	bool "Intel Primary to Sideband Bridge in TPL"
 	depends on TPL && (X86 || SANDBOX)
 	help
-	  The Primary-to-Sideband bus is used to access various peripherals
+	  The Primary to Sideband Bridge is used to access various peripherals
 	  through memory-mapped I/O in a large chunk of PCI space. The space is
 	  segmented into different channels and peripherals are accessed by
 	  device-specific means within those channels. Devices should be added
-- 
2.27.0

[PATCH v3 2/2] x86: p2sb: make P2SB driver depend on P2SB uclass

[Wolfgang Wallner]

Currently it is possible to select the P2SB driver without selecting the
P2SB uclass, which can't work. Fix this by adding a "depends on" in
Kconfig.

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>

---

(no changes since v2)

Changes in v2:
- Fixed cover letter

 arch/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index c8eae24c07..27295ef384 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -717,6 +717,7 @@ config HAVE_ITSS
 
 config HAVE_P2SB
 	bool "Enable P2SB"
+	depends on P2SB
 	help
 	  Select this to include the driver for the Primary to
 	  Sideband Bridge (P2SB) which is found on several Intel
-- 
2.27.0

[PATCH v3 2/2] x86: p2sb: make P2SB driver depend on P2SB uclass

[Simon Glass]

On Wed, 1 Jul 2020 at 05:37, Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently it is possible to select the P2SB driver without selecting the
> P2SB uclass, which can't work. Fix this by adding a "depends on" in
> Kconfig.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Fixed cover letter
>
>  arch/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH v3 1/2] drivers: p2sb: replace Primary-to-Sideband Bus with Primary to Sideband Bridge

[Simon Glass]

On Wed, 1 Jul 2020 at 05:37, Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> In Intel's documentation the term P2SB stands for "Primary to Sideband
> Bridge".
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> ---
>
> Changes in v3:
> - Replaced the term in two more places
>
>  drivers/misc/Kconfig | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

[PATCH v3 1/2] drivers: p2sb: replace Primary-to-Sideband Bus with Primary to Sideband Bridge

[Bin Meng]

On Wed, Jul 1, 2020 at 7:37 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> In Intel's documentation the term P2SB stands for "Primary to Sideband
> Bridge".
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
> ---
>
> Changes in v3:
> - Replaced the term in two more places
>
>  drivers/misc/Kconfig | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>

applied to u-boot-x86, thanks!

[PATCH v3 2/2] x86: p2sb: make P2SB driver depend on P2SB uclass

[Bin Meng]

On Wed, Jul 1, 2020 at 7:37 PM Wolfgang Wallner
<wolfgang.wallner@br-automation.com> wrote:
>
> Currently it is possible to select the P2SB driver without selecting the
> P2SB uclass, which can't work. Fix this by adding a "depends on" in
> Kconfig.
>
> Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> - Fixed cover letter
>
>  arch/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

applied to u-boot-x86, thanks!