All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: ulf.hansson@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Roger Tseng <rogerable@realtek.com>
Subject: [PATCH 10/15] mmc: host: rtsx_usb_sdmmc: Remove set but unused variable 'err'
Date: Wed,  1 Jul 2020 13:46:57 +0100	[thread overview]
Message-ID: <20200701124702.908713-11-lee.jones@linaro.org> (raw)
In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org>

Seeing as sd_wait_data_idle() returns void and only a very specific
read value is checked, there doesn't seem to be a good reason to
check the return value of rtsx_pci_read_register().  So remove
the assignment and definition of 'err'.

Squashes the following W=1 kernel build warning:

 drivers/mmc/host/rtsx_usb_sdmmc.c: In function ‘sd_wait_data_idle’:
 drivers/mmc/host/rtsx_usb_sdmmc.c:657:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
 657 | int err, i;
 | ^~~

Cc: Roger Tseng <rogerable@realtek.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mmc/host/rtsx_usb_sdmmc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
index a7084c50ad65f..7225d9312af8c 100644
--- a/drivers/mmc/host/rtsx_usb_sdmmc.c
+++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
@@ -654,12 +654,11 @@ static u8 sd_search_final_phase(struct rtsx_usb_sdmmc *host, u32 phase_map)
 
 static void sd_wait_data_idle(struct rtsx_usb_sdmmc *host)
 {
-	int err, i;
+	int i;
 	u8 val = 0;
 
 	for (i = 0; i < 100; i++) {
-		err = rtsx_usb_ep0_read_register(host->ucr,
-				SD_DATA_STATE, &val);
+		rtsx_usb_ep0_read_register(host->ucr, SD_DATA_STATE, &val);
 		if (val & SD_DATA_IDLE)
 			return;
 
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: ulf.hansson@linaro.org
Cc: Roger Tseng <rogerable@realtek.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/15] mmc: host: rtsx_usb_sdmmc: Remove set but unused variable 'err'
Date: Wed,  1 Jul 2020 13:46:57 +0100	[thread overview]
Message-ID: <20200701124702.908713-11-lee.jones@linaro.org> (raw)
In-Reply-To: <20200701124702.908713-1-lee.jones@linaro.org>

Seeing as sd_wait_data_idle() returns void and only a very specific
read value is checked, there doesn't seem to be a good reason to
check the return value of rtsx_pci_read_register().  So remove
the assignment and definition of 'err'.

Squashes the following W=1 kernel build warning:

 drivers/mmc/host/rtsx_usb_sdmmc.c: In function ‘sd_wait_data_idle’:
 drivers/mmc/host/rtsx_usb_sdmmc.c:657:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
 657 | int err, i;
 | ^~~

Cc: Roger Tseng <rogerable@realtek.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mmc/host/rtsx_usb_sdmmc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c
index a7084c50ad65f..7225d9312af8c 100644
--- a/drivers/mmc/host/rtsx_usb_sdmmc.c
+++ b/drivers/mmc/host/rtsx_usb_sdmmc.c
@@ -654,12 +654,11 @@ static u8 sd_search_final_phase(struct rtsx_usb_sdmmc *host, u32 phase_map)
 
 static void sd_wait_data_idle(struct rtsx_usb_sdmmc *host)
 {
-	int err, i;
+	int i;
 	u8 val = 0;
 
 	for (i = 0; i < 100; i++) {
-		err = rtsx_usb_ep0_read_register(host->ucr,
-				SD_DATA_STATE, &val);
+		rtsx_usb_ep0_read_register(host->ucr, SD_DATA_STATE, &val);
 		if (val & SD_DATA_IDLE)
 			return;
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-01 12:47 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 12:46 [PATCH 00/15] Clean-up MMC's W=1 build warnings Lee Jones
2020-07-01 12:46 ` Lee Jones
2020-07-01 12:46 ` [PATCH 01/15] mmc: core: quirks: Mark fixups as __maybe_unused Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 12:46 ` [PATCH 02/15] mmc: core: sdio_io: Provide description for sdio_set_host_pm_flags()'s 'flag' arg Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 12:46 ` [PATCH 03/15] mmc: core: regulator: Add missing documetation for 'mmc' and 'ios' Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 12:46 ` [PATCH 04/15] mmc: host: sdhci-s3c: Provide documentation for missing struct properties Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-05 23:53   ` Jaehoon Chung
2020-07-05 23:53     ` Jaehoon Chung
2020-07-01 12:46 ` [PATCH 05/15] mmc: host: mtk-sd: Demote msdc_recheck_sdio_irq() function header Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 13:09   ` Matthias Brugger
2020-07-01 13:09     ` Matthias Brugger
2020-07-01 13:09     ` Matthias Brugger
2020-07-01 12:46 ` [PATCH 06/15] mmc: host: atmel-mci: Provide 2 new and correct 1 existing property description Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 12:46 ` [PATCH 07/15] mmc: core: queue: Correct misspelling of 'mq' in mmc_init_request()'s docs Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 12:46 ` [PATCH 08/15] mmc: host: dw_mmc-exynos: Add kerneldoc descriptions of for 'dev' args Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-05 23:53   ` Jaehoon Chung
2020-07-05 23:53     ` Jaehoon Chung
2020-07-01 12:46 ` [PATCH 09/15] mmc: host: rtsx_pci_sdmmc: Remove set but unused variable 'err' Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 12:46 ` Lee Jones [this message]
2020-07-01 12:46   ` [PATCH 10/15] mmc: host: rtsx_usb_sdmmc: " Lee Jones
2020-07-01 12:46 ` [PATCH 11/15] mmc: host: sdhci-of-arasan: Correct formatting and provide missing function arg(s) Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-08  7:53   ` Michal Simek
2020-07-08  7:53     ` Michal Simek
2020-07-01 12:46 ` [PATCH 12/15] mmc: host: sdhci-msm: Staticify local function sdhci_msm_dump_vendor_regs() Lee Jones
2020-07-01 12:46   ` Lee Jones
2020-07-01 12:47 ` [PATCH 13/15] mmc: host: sdhci-msm: Demote faux kerneldoc header down to basic comment block Lee Jones
2020-07-01 12:47   ` Lee Jones
2020-07-01 12:47 ` [PATCH 14/15] mmc: host: cqhci: " Lee Jones
2020-07-01 12:47   ` Lee Jones
2020-07-02  6:43   ` Adrian Hunter
2020-07-02  6:43     ` Adrian Hunter
2020-07-01 12:47 ` [PATCH 15/15] mmc: host: sdhci-iproc: Tell the compiler that ACPI functions may not be used Lee Jones
2020-07-01 12:47   ` Lee Jones
2020-07-02 19:42   ` Scott Branden
2020-07-02 19:42     ` Scott Branden
2020-07-02 20:13     ` Lee Jones
2020-07-02 20:13       ` Lee Jones
2020-07-02 20:49       ` Scott Branden
2020-07-02 20:49         ` Scott Branden
2020-07-07  6:47   ` [PATCH v2 15/15] mmc: host: sdhci-iproc: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones
2020-07-07  6:47     ` Lee Jones
2020-07-07 15:47     ` Scott Branden
2020-07-07 15:47       ` Scott Branden
2020-07-08 13:20     ` Ulf Hansson
2020-07-08 13:20       ` Ulf Hansson
2020-07-07  6:50 ` [PATCH 00/15] Clean-up MMC's W=1 build warnings Ulf Hansson
2020-07-07  6:50   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701124702.908713-11-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rogerable@realtek.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.