* NVMe regression, NVMe no longer uses blk_path_error()
@ 2020-07-01 16:39 ` Mike Snitzer
0 siblings, 0 replies; 2+ messages in thread
From: Mike Snitzer @ 2020-07-01 16:39 UTC (permalink / raw)
To: Keith Busch, Christoph Hellwig
Cc: Ewan Milne, Hannes Reinecke, John Meneghini, linux-block,
linux-nvme, dm-devel
IF NVMe's isn't a primary user of blk_path_error() it largely kills
the entire point of blk_path_error(). (And no the response to this must
not be: "that's fine")
This commit shows NVMe's previous continued use of blk_path_error():
8decf5d5b9f3f7 ("nvme: remove nvme_req_needs_failover")
but then nvme_failover_req() was relatively recently refactored with:
764e9332098c0 ("nvme-multipath: do not reset on unknown status")
NVMe should've continued to use blk_path_error(). If there was some gap
in error classification that should've been fixed in NVMe.
Instead, with commit 764e9332098c0 NVMe is no longer using retryable
error classifications commonly maintained within block core. As such it
introduces serious potential for regression with DM multipath no longer
having a shared understanding for what _really_ constitutes a retryable
blk_status_t from NVMe.
Mike
^ permalink raw reply [flat|nested] 2+ messages in thread
* NVMe regression, NVMe no longer uses blk_path_error()
@ 2020-07-01 16:39 ` Mike Snitzer
0 siblings, 0 replies; 2+ messages in thread
From: Mike Snitzer @ 2020-07-01 16:39 UTC (permalink / raw)
To: Keith Busch, Christoph Hellwig
Cc: linux-nvme, linux-block, dm-devel, Hannes Reinecke,
John Meneghini, Ewan Milne
IF NVMe's isn't a primary user of blk_path_error() it largely kills
the entire point of blk_path_error(). (And no the response to this must
not be: "that's fine")
This commit shows NVMe's previous continued use of blk_path_error():
8decf5d5b9f3f7 ("nvme: remove nvme_req_needs_failover")
but then nvme_failover_req() was relatively recently refactored with:
764e9332098c0 ("nvme-multipath: do not reset on unknown status")
NVMe should've continued to use blk_path_error(). If there was some gap
in error classification that should've been fixed in NVMe.
Instead, with commit 764e9332098c0 NVMe is no longer using retryable
error classifications commonly maintained within block core. As such it
introduces serious potential for regression with DM multipath no longer
having a shared understanding for what _really_ constitutes a retryable
blk_status_t from NVMe.
Mike
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-01 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 16:39 NVMe regression, NVMe no longer uses blk_path_error() Mike Snitzer
2020-07-01 16:39 ` Mike Snitzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.