* [kvm-unit-tests PATCH] x86: realmode: fix serial_init()
@ 2020-07-01 19:30 Nadav Amit
0 siblings, 0 replies; only message in thread
From: Nadav Amit @ 2020-07-01 19:30 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm, Nadav Amit
In some setups serial output from the real-mode tests is corrupted.
I do not know the serial port initialization code well, but the
protected mode initialization code is different than the real-mode code.
Using the protected mode serial port initialization fixes the problem.
Keeping the tradition of code duplication between real-mode and
protected mode, this patch copies the missing initialization into
real-mode serial port initialization.
Signed-off-by: Nadav Amit <namit@vmware.com>
---
x86/realmode.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/x86/realmode.c b/x86/realmode.c
index 90ecd13..7c2d776 100644
--- a/x86/realmode.c
+++ b/x86/realmode.c
@@ -77,6 +77,15 @@ static void serial_init(void)
lcr = inb(serial_iobase + 0x03);
lcr &= ~0x80;
outb(lcr, serial_iobase + 0x03);
+
+ /* IER: disable interrupts */
+ outb(0x00, serial_iobase + 0x01);
+ /* LCR: 8 bits, no parity, one stop bit */
+ outb(0x03, serial_iobase + 0x03);
+ /* FCR: disable FIFO queues */
+ outb(0x00, serial_iobase + 0x02);
+ /* MCR: RTS, DTR on */
+ outb(0x03, serial_iobase + 0x04);
}
#endif
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-01 19:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 19:30 [kvm-unit-tests PATCH] x86: realmode: fix serial_init() Nadav Amit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.