All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Markus Elfring <Markus.Elfring@web.de>,
	linux-doc@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org,
	Julia Lawall <julia.lawall@lip6.fr>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Michal Marek <michal.lkml@markovi.net>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [v2] Documentation: Coccinelle: fix typos and command example
Date: Thu, 2 Jul 2020 01:08:43 +0100	[thread overview]
Message-ID: <20200702000843.GV25523@casper.infradead.org> (raw)
In-Reply-To: <dfa2ed9f-fe68-58d1-c3d0-ac436f9bee09@infradead.org>

On Wed, Jul 01, 2020 at 07:52:58AM -0700, Randy Dunlap wrote:
> On 7/1/20 6:32 AM, Markus Elfring wrote:
> >>> How do you think about to use the following command variant
> >>> for the adjustment of the software documentation?
> >>>
> >>> +    make C=1 CHECK='scripts/coccicheck' 'path/to/file.o'
> >>
> >> I don't understand the reason for that change...
> 
> IOW, your "patch" needs justification and/or explanation. It was missing that info.

What Markus is trying so completely ineptly to say is that
  make C=1 CHECK=scripts/coccicheck path/to/file.c
doesn't work.  You need to use the .o suffix to check the .c file.


WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-doc@vger.kernel.org, Nicolas Palix <nicolas.palix@imag.fr>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Julia Lawall <julia.lawall@lip6.fr>,
	Markus Elfring <Markus.Elfring@web.de>,
	Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [v2] Documentation: Coccinelle: fix typos and command example
Date: Thu, 02 Jul 2020 00:08:43 +0000	[thread overview]
Message-ID: <20200702000843.GV25523@casper.infradead.org> (raw)
In-Reply-To: <dfa2ed9f-fe68-58d1-c3d0-ac436f9bee09@infradead.org>

On Wed, Jul 01, 2020 at 07:52:58AM -0700, Randy Dunlap wrote:
> On 7/1/20 6:32 AM, Markus Elfring wrote:
> >>> How do you think about to use the following command variant
> >>> for the adjustment of the software documentation?
> >>>
> >>> +    make C=1 CHECK='scripts/coccicheck' 'path/to/file.o'
> >>
> >> I don't understand the reason for that change...
> 
> IOW, your "patch" needs justification and/or explanation. It was missing that info.

What Markus is trying so completely ineptly to say is that
  make C=1 CHECK=scripts/coccicheck path/to/file.c
doesn't work.  You need to use the .o suffix to check the .c file.

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Michal Marek <michal.lkml@markovi.net>,
	linux-doc@vger.kernel.org, Nicolas Palix <nicolas.palix@imag.fr>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Julia Lawall <julia.lawall@lip6.fr>,
	Markus Elfring <Markus.Elfring@web.de>,
	Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [v2] Documentation: Coccinelle: fix typos and command example
Date: Thu, 2 Jul 2020 01:08:43 +0100	[thread overview]
Message-ID: <20200702000843.GV25523@casper.infradead.org> (raw)
In-Reply-To: <dfa2ed9f-fe68-58d1-c3d0-ac436f9bee09@infradead.org>

On Wed, Jul 01, 2020 at 07:52:58AM -0700, Randy Dunlap wrote:
> On 7/1/20 6:32 AM, Markus Elfring wrote:
> >>> How do you think about to use the following command variant
> >>> for the adjustment of the software documentation?
> >>>
> >>> +    make C=1 CHECK='scripts/coccicheck' 'path/to/file.o'
> >>
> >> I don't understand the reason for that change...
> 
> IOW, your "patch" needs justification and/or explanation. It was missing that info.

What Markus is trying so completely ineptly to say is that
  make C=1 CHECK=scripts/coccicheck path/to/file.c
doesn't work.  You need to use the .o suffix to check the .c file.

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2020-07-02  0:08 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29 21:16 [PATCH v2] Documentation: Coccinelle: fix typos and command example Randy Dunlap
2020-06-29 21:16 ` [Cocci] " Randy Dunlap
2020-06-30  8:04 ` Markus Elfring
2020-06-30  8:04   ` Markus Elfring
2020-06-30 12:23 ` Markus Elfring
2020-06-30 12:23   ` Markus Elfring
2020-06-30 15:11   ` Randy Dunlap
2020-06-30 15:11     ` [Cocci] " Randy Dunlap
2020-06-30 15:11     ` Randy Dunlap
2020-07-01 11:56     ` Markus Elfring
2020-07-01 11:56       ` Markus Elfring
2020-07-01 13:20       ` Randy Dunlap
2020-07-01 13:20         ` [Cocci] " Randy Dunlap
2020-07-01 13:20         ` Randy Dunlap
2020-07-01 13:32         ` [v2] " Markus Elfring
2020-07-01 13:32           ` Markus Elfring
2020-07-01 14:52           ` Randy Dunlap
2020-07-01 14:52             ` [Cocci] " Randy Dunlap
2020-07-01 14:52             ` Randy Dunlap
2020-07-01 15:02             ` Markus Elfring
2020-07-01 15:02               ` Markus Elfring
2020-07-01 15:07               ` Randy Dunlap
2020-07-01 15:07                 ` [Cocci] " Randy Dunlap
2020-07-01 15:07                 ` Randy Dunlap
2020-07-01 15:15                 ` Markus Elfring
2020-07-01 15:15                   ` Markus Elfring
2020-07-01 15:19                   ` Jonathan Corbet
2020-07-01 15:19                     ` Jonathan Corbet
2020-07-01 15:23                     ` Markus Elfring
2020-07-01 15:23                       ` Markus Elfring
2020-07-01 15:15                 ` Markus Elfring
2020-07-01 15:15                   ` Markus Elfring
2020-07-01 15:19                   ` Randy Dunlap
2020-07-01 15:19                     ` [Cocci] " Randy Dunlap
2020-07-01 15:19                     ` Randy Dunlap
2020-07-01 15:32                     ` Markus Elfring
2020-07-01 15:32                       ` Markus Elfring
2020-07-01 17:32                     ` Markus Elfring
2020-07-01 17:32                       ` Markus Elfring
2020-07-01 19:15                       ` Randy Dunlap
2020-07-01 19:15                         ` [Cocci] " Randy Dunlap
2020-07-01 19:15                         ` Randy Dunlap
2020-07-01 20:10                         ` Markus Elfring
2020-07-01 20:10                           ` Markus Elfring
     [not found]                           ` <alpine.DEB.2.22.394.2007012232510.2540@hadrien>
2020-07-02  6:01                             ` Markus Elfring
2020-07-02  6:01                               ` Markus Elfring
2020-07-02  8:22                             ` Markus Elfring
2020-07-02  8:22                               ` Markus Elfring
2020-07-02  0:08             ` Matthew Wilcox [this message]
2020-07-02  0:08               ` [Cocci] " Matthew Wilcox
2020-07-02  0:08               ` Matthew Wilcox
2020-07-02  5:40               ` Julia Lawall
2020-07-02  5:40                 ` [Cocci] " Julia Lawall
2020-07-02  5:40                 ` Julia Lawall
2020-07-01 15:29 ` [Cocci] [PATCH v2] " Julia Lawall
2020-07-01 15:29   ` Julia Lawall
2020-07-01 16:06   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200702000843.GV25523@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=Gilles.Muller@lip6.fr \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=corbet@lwn.net \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=rdunlap@infradead.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.