* [PATCH] USB: serial: console: add support for enabling flow control
@ 2020-07-01 17:37 Johan Hovold
2020-07-02 7:38 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2020-07-01 17:37 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-usb
Add support for enabling hardware flow control using the 'r' command
line option.
This also avoids a W=1 (-Wunused-but-set-variable) warning.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
Missed this one at first... The white space change is done on purpose to
remove a stray tab.
Johan
drivers/usb/serial/console.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
index 7d289302ff6c..b97aa40ca4d1 100644
--- a/drivers/usb/serial/console.c
+++ b/drivers/usb/serial/console.c
@@ -79,7 +79,7 @@ static int usb_console_setup(struct console *co, char *options)
if (*s)
doflow = (*s++ == 'r');
}
-
+
/* Sane default */
if (baud == 0)
baud = 9600;
@@ -102,6 +102,9 @@ static int usb_console_setup(struct console *co, char *options)
break;
}
+ if (doflow)
+ cflag |= CRTSCTS;
+
/*
* no need to check the index here: if the index is wrong, console
* code won't call us
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: serial: console: add support for enabling flow control
2020-07-01 17:37 [PATCH] USB: serial: console: add support for enabling flow control Johan Hovold
@ 2020-07-02 7:38 ` Greg KH
2020-07-02 8:44 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-07-02 7:38 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-usb
On Wed, Jul 01, 2020 at 07:37:22PM +0200, Johan Hovold wrote:
> Add support for enabling hardware flow control using the 'r' command
> line option.
>
> This also avoids a W=1 (-Wunused-but-set-variable) warning.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>
> Missed this one at first... The white space change is done on purpose to
> remove a stray tab.
>
> Johan
>
>
> drivers/usb/serial/console.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
> index 7d289302ff6c..b97aa40ca4d1 100644
> --- a/drivers/usb/serial/console.c
> +++ b/drivers/usb/serial/console.c
> @@ -79,7 +79,7 @@ static int usb_console_setup(struct console *co, char *options)
> if (*s)
> doflow = (*s++ == 'r');
> }
> -
> +
> /* Sane default */
> if (baud == 0)
> baud = 9600;
> @@ -102,6 +102,9 @@ static int usb_console_setup(struct console *co, char *options)
> break;
> }
>
> + if (doflow)
> + cflag |= CRTSCTS;
> +
> /*
> * no need to check the index here: if the index is wrong, console
> * code won't call us
> --
> 2.26.2
>
Nice fix!
And I think one of the first real "bugfixes" that have come out of the
recent W=1 work...
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: serial: console: add support for enabling flow control
2020-07-02 7:38 ` Greg KH
@ 2020-07-02 8:44 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2020-07-02 8:44 UTC (permalink / raw)
To: Greg KH; +Cc: Johan Hovold, linux-usb
On Thu, Jul 02, 2020 at 09:38:28AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 01, 2020 at 07:37:22PM +0200, Johan Hovold wrote:
> > Add support for enabling hardware flow control using the 'r' command
> > line option.
> >
> > This also avoids a W=1 (-Wunused-but-set-variable) warning.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > drivers/usb/serial/console.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/serial/console.c b/drivers/usb/serial/console.c
> > index 7d289302ff6c..b97aa40ca4d1 100644
> > --- a/drivers/usb/serial/console.c
> > +++ b/drivers/usb/serial/console.c
> > @@ -102,6 +102,9 @@ static int usb_console_setup(struct console *co, char *options)
> > break;
> > }
> >
> > + if (doflow)
> > + cflag |= CRTSCTS;
> > +
> > /*
> > * no need to check the index here: if the index is wrong, console
> > * code won't call us
> > --
> > 2.26.2
> >
>
> Nice fix!
Or is it a new feature? ;)
> And I think one of the first real "bugfixes" that have come out of the
> recent W=1 work...
Yeah, first one I've seen too.
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks for reviewing. All of these now applied.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-02 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 17:37 [PATCH] USB: serial: console: add support for enabling flow control Johan Hovold
2020-07-02 7:38 ` Greg KH
2020-07-02 8:44 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.