* [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K @ 2020-07-02 9:15 Stanislav Lisovskiy 2020-07-02 11:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K (rev2) Patchwork ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: Stanislav Lisovskiy @ 2020-07-02 9:15 UTC (permalink / raw) To: intel-gfx We still need "Bump up CDCLK" workaround otherwise getting underruns - however currently it blocks 8K as CDCLK = Pixel rate, in 8K case would require CDCLK to be around 1 Ghz which is not possible. v2: - Convert to expression(max(min_cdclk, min(pixel_rate, max_cdclk)) (Ville Syrjälä) - Use type specific min_t, max_t(Ville Syrjälä) Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> --- drivers/gpu/drm/i915/display/intel_cdclk.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index 45f7f33d1144..8f9320e1e249 100644 --- a/drivers/gpu/drm/i915/display/intel_cdclk.c +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c @@ -2080,8 +2080,15 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state) * Explicitly stating here that this seems to be currently * rather a Hack, than final solution. */ - if (IS_TIGERLAKE(dev_priv)) - min_cdclk = max(min_cdclk, (int)crtc_state->pixel_rate); + if (IS_TIGERLAKE(dev_priv)) { + /* + * Clamp to max_cdclk_freq in case pixel rate is higher, + * in order not to break an 8K, but still leave W/A at place. + */ + min_cdclk = max_t(int, min_cdclk, + min_t(int, crtc_state->pixel_rate, + dev_priv->max_cdclk_freq)); + } if (min_cdclk > dev_priv->max_cdclk_freq) { drm_dbg_kms(&dev_priv->drm, -- 2.24.1.485.gad05a3d8e5 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K (rev2) 2020-07-02 9:15 [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K Stanislav Lisovskiy @ 2020-07-02 11:01 ` Patchwork 2020-07-02 15:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-07-03 0:04 ` [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K Manasi Navare 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-07-02 11:01 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx == Series Details == Series: drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K (rev2) URL : https://patchwork.freedesktop.org/series/78940/ State : success == Summary == CI Bug Log - changes from CI_DRM_8693 -> Patchwork_18066 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/index.html Known issues ------------ Here are the changes found in Patchwork_18066 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html #### Possible fixes #### * igt@kms_busy@basic@flip: - fi-kbl-x1275: [DMESG-WARN][3] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/fi-kbl-x1275/igt@kms_busy@basic@flip.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/fi-kbl-x1275/igt@kms_busy@basic@flip.html #### Warnings #### * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][5] ([i915#1982] / [i915#62] / [i915#92]) -> [DMESG-WARN][6] ([i915#62] / [i915#92] / [i915#95]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html * igt@kms_flip@basic-flip-vs-modeset@a-dp1: - fi-kbl-x1275: [DMESG-WARN][7] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][8] ([i915#62] / [i915#92]) +2 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html * igt@kms_force_connector_basic@force-edid: - fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92]) -> [DMESG-WARN][10] ([i915#62] / [i915#92] / [i915#95]) +4 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/fi-kbl-x1275/igt@kms_force_connector_basic@force-edid.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-kbl-x1275: [DMESG-WARN][11] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][12] ([i915#1982] / [i915#62] / [i915#92]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/fi-kbl-x1275/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (43 -> 37) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_8693 -> Patchwork_18066 CI-20190529: 20190529 CI_DRM_8693: 878d924ea8a8c4c8812215d881f3bd70b3d4f2ee @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5720: f35053d4b6d7bbcf6505ef67a8bd56acc7fb2eb2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18066: e766a332c302f3ade90296b8b094acd9ebaeb520 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == e766a332c302 drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K (rev2) 2020-07-02 9:15 [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K Stanislav Lisovskiy 2020-07-02 11:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K (rev2) Patchwork @ 2020-07-02 15:26 ` Patchwork 2020-07-03 0:04 ` [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K Manasi Navare 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2020-07-02 15:26 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx == Series Details == Series: drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K (rev2) URL : https://patchwork.freedesktop.org/series/78940/ State : success == Summary == CI Bug Log - changes from CI_DRM_8693_full -> Patchwork_18066_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_18066_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@drm_import_export@prime: - shard-tglb: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-tglb5/igt@drm_import_export@prime.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-tglb8/igt@drm_import_export@prime.html * igt@gem_ctx_isolation@preservation-s3@bcs0: - shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#198]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-skl4/igt@gem_ctx_isolation@preservation-s3@bcs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-skl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html * igt@gem_exec_reloc@basic-concurrent0: - shard-glk: [PASS][5] -> [FAIL][6] ([i915#1930]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-glk2/igt@gem_exec_reloc@basic-concurrent0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-glk4/igt@gem_exec_reloc@basic-concurrent0.html * igt@gem_exec_reloc@basic-many-active@vecs0: - shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#93] / [i915#95]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-kbl4/igt@gem_exec_reloc@basic-many-active@vecs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-kbl7/igt@gem_exec_reloc@basic-many-active@vecs0.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-hsw: [PASS][9] -> [WARN][10] ([i915#1519]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-hsw1/igt@i915_pm_rc6_residency@rc6-fence.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-hsw1/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [PASS][11] -> [FAIL][12] ([i915#1515]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html * igt@i915_pm_rpm@i2c: - shard-skl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +6 similar issues [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-skl6/igt@i915_pm_rpm@i2c.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-skl2/igt@i915_pm_rpm@i2c.html * igt@i915_selftest@mock@requests: - shard-skl: [PASS][15] -> [INCOMPLETE][16] ([i915#198] / [i915#2110]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-skl1/igt@i915_selftest@mock@requests.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-skl9/igt@i915_selftest@mock@requests.html * igt@kms_big_fb@y-tiled-64bpp-rotate-180: - shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl7/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl3/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html * igt@kms_color@pipe-a-ctm-0-75: - shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#1635] / [i915#95]) +29 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl3/igt@kms_color@pipe-a-ctm-0-75.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl6/igt@kms_color@pipe-a-ctm-0-75.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1: - shard-skl: [PASS][21] -> [FAIL][22] ([i915#79]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-skl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1: - shard-hsw: [PASS][23] -> [INCOMPLETE][24] ([i915#2055]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render: - shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +1 similar issue [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render: - shard-tglb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#180]) +1 similar issue [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145] / [i915#265]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +1 similar issue [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-iclb8/igt@kms_psr@psr2_cursor_plane_move.html * igt@syncobj_wait@single-wait-for-submit-submitted: - shard-iclb: [PASS][35] -> [DMESG-WARN][36] ([i915#1226]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-iclb1/igt@syncobj_wait@single-wait-for-submit-submitted.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-iclb2/igt@syncobj_wait@single-wait-for-submit-submitted.html #### Possible fixes #### * igt@gem_exec_flush@basic-wb-rw-default: - shard-glk: [INCOMPLETE][37] ([i915#58] / [k.org#198133]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-glk7/igt@gem_exec_flush@basic-wb-rw-default.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-glk2/igt@gem_exec_flush@basic-wb-rw-default.html * igt@gem_exec_whisper@basic-queues-forked: - shard-glk: [DMESG-WARN][39] ([i915#118] / [i915#95]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-glk4/igt@gem_exec_whisper@basic-queues-forked.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-glk3/igt@gem_exec_whisper@basic-queues-forked.html * igt@i915_module_load@reload: - shard-iclb: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-iclb7/igt@i915_module_load@reload.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-iclb2/igt@i915_module_load@reload.html * igt@i915_pm_rpm@gem-mmap-type@uc: - shard-skl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +7 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-skl3/igt@i915_pm_rpm@gem-mmap-type@uc.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-skl1/igt@i915_pm_rpm@gem-mmap-type@uc.html * igt@kms_color@pipe-a-gamma: - shard-tglb: [FAIL][45] ([i915#1149]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-tglb8/igt@kms_color@pipe-a-gamma.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-tglb1/igt@kms_color@pipe-a-gamma.html * igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge: - shard-glk: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-glk2/igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-glk4/igt@kms_cursor_edge_walk@pipe-c-64x64-bottom-edge.html * igt@kms_cursor_legacy@cursora-vs-flipa-legacy: - shard-tglb: [DMESG-WARN][49] ([i915#402]) -> [PASS][50] +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-tglb1/igt@kms_cursor_legacy@cursora-vs-flipa-legacy.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-tglb6/igt@kms_cursor_legacy@cursora-vs-flipa-legacy.html * igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled: - shard-apl: [DMESG-WARN][51] ([i915#1635] / [i915#95]) -> [PASS][52] +20 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl8/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl7/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [DMESG-WARN][53] ([i915#180]) -> [PASS][54] +7 similar issues [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render: - shard-tglb: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render: - shard-snb: [TIMEOUT][57] ([i915#1958] / [i915#2119]) -> [PASS][58] +3 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-snb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc: - shard-tglb: [DMESG-WARN][59] ([i915#1982] / [i915#402]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-wc.html * igt@kms_hdr@bpc-switch: - shard-skl: [FAIL][61] ([i915#1188]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-skl5/igt@kms_hdr@bpc-switch.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-skl2/igt@kms_hdr@bpc-switch.html * igt@kms_rmfb@rmfb-ioctl: - shard-snb: [INCOMPLETE][63] ([i915#82]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-snb1/igt@kms_rmfb@rmfb-ioctl.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-snb6/igt@kms_rmfb@rmfb-ioctl.html * igt@sysfs_heartbeat_interval@mixed@vecs0: - shard-skl: [FAIL][65] ([i915#1731]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-skl7/igt@sysfs_heartbeat_interval@mixed@vecs0.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-skl6/igt@sysfs_heartbeat_interval@mixed@vecs0.html #### Warnings #### * igt@gem_exec_reloc@basic-concurrent16: - shard-snb: [TIMEOUT][67] ([i915#1958] / [i915#2119]) -> [FAIL][68] ([i915#1930]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-snb6/igt@gem_exec_reloc@basic-concurrent16.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-snb4/igt@gem_exec_reloc@basic-concurrent16.html * igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs: - shard-apl: [SKIP][69] ([fdo#109271] / [i915#1635]) -> [SKIP][70] ([fdo#109271]) +12 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl4/igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl8/igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs.html * igt@kms_chamelium@vga-edid-read: - shard-apl: [SKIP][71] ([fdo#109271] / [fdo#111827] / [i915#1635]) -> [SKIP][72] ([fdo#109271] / [fdo#111827]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl7/igt@kms_chamelium@vga-edid-read.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl8/igt@kms_chamelium@vga-edid-read.html * igt@kms_chamelium@vga-hpd-with-enabled-mode: - shard-apl: [SKIP][73] ([fdo#109271] / [fdo#111827]) -> [SKIP][74] ([fdo#109271] / [fdo#111827] / [i915#1635]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl8/igt@kms_chamelium@vga-hpd-with-enabled-mode.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl7/igt@kms_chamelium@vga-hpd-with-enabled-mode.html * igt@kms_color@pipe-a-ctm-0-75: - shard-tglb: [FAIL][75] ([i915#1149] / [i915#315]) -> [DMESG-FAIL][76] ([i915#1149] / [i915#402]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-tglb1/igt@kms_color@pipe-a-ctm-0-75.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-tglb3/igt@kms_color@pipe-a-ctm-0-75.html * igt@kms_content_protection@srm: - shard-kbl: [TIMEOUT][77] ([i915#1319] / [i915#1958] / [i915#2119]) -> [TIMEOUT][78] ([i915#1319] / [i915#2119]) [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-kbl7/igt@kms_content_protection@srm.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-kbl3/igt@kms_content_protection@srm.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [SKIP][79] ([fdo#109349]) -> [DMESG-WARN][80] ([i915#1226]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff: - shard-apl: [SKIP][81] ([fdo#109271]) -> [SKIP][82] ([fdo#109271] / [i915#1635]) +11 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl3/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl6/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff.html * igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant: - shard-apl: [DMESG-FAIL][83] ([fdo#108145] / [i915#1635] / [i915#1982] / [i915#95]) -> [DMESG-FAIL][84] ([fdo#108145] / [i915#1635] / [i915#95]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html * igt@kms_plane_lowres@pipe-b-tiling-y: - shard-snb: [TIMEOUT][85] ([i915#1958] / [i915#2119]) -> [SKIP][86] ([fdo#109271]) +1 similar issue [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-snb6/igt@kms_plane_lowres@pipe-b-tiling-y.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-snb4/igt@kms_plane_lowres@pipe-b-tiling-y.html * igt@runner@aborted: - shard-apl: ([FAIL][87], [FAIL][88], [FAIL][89]) ([i915#1610] / [i915#1635] / [i915#2110]) -> [FAIL][90] ([i915#1635] / [i915#2110]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl1/igt@runner@aborted.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl6/igt@runner@aborted.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8693/shard-apl8/igt@runner@aborted.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/shard-apl2/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515 [i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930 [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055 [i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110 [i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_8693 -> Patchwork_18066 CI-20190529: 20190529 CI_DRM_8693: 878d924ea8a8c4c8812215d881f3bd70b3d4f2ee @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5720: f35053d4b6d7bbcf6505ef67a8bd56acc7fb2eb2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18066: e766a332c302f3ade90296b8b094acd9ebaeb520 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18066/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K 2020-07-02 9:15 [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K Stanislav Lisovskiy 2020-07-02 11:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K (rev2) Patchwork 2020-07-02 15:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2020-07-03 0:04 ` Manasi Navare 2020-07-03 10:46 ` Jani Nikula 2 siblings, 1 reply; 5+ messages in thread From: Manasi Navare @ 2020-07-03 0:04 UTC (permalink / raw) To: Stanislav Lisovskiy; +Cc: intel-gfx On Thu, Jul 02, 2020 at 12:15:26PM +0300, Stanislav Lisovskiy wrote: > We still need "Bump up CDCLK" workaround otherwise getting > underruns - however currently it blocks 8K as CDCLK = Pixel rate, > in 8K case would require CDCLK to be around 1 Ghz which is not > possible. > > v2: - Convert to expression(max(min_cdclk, min(pixel_rate, max_cdclk)) > (Ville Syrjälä) > - Use type specific min_t, max_t(Ville Syrjälä) > > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> I have tested this and this unblocks 8K Reviewed-by: Manasi Navare <manasi.d.navare@intel.com> Manasi > --- > drivers/gpu/drm/i915/display/intel_cdclk.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c > index 45f7f33d1144..8f9320e1e249 100644 > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > @@ -2080,8 +2080,15 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state) > * Explicitly stating here that this seems to be currently > * rather a Hack, than final solution. > */ > - if (IS_TIGERLAKE(dev_priv)) > - min_cdclk = max(min_cdclk, (int)crtc_state->pixel_rate); > + if (IS_TIGERLAKE(dev_priv)) { > + /* > + * Clamp to max_cdclk_freq in case pixel rate is higher, > + * in order not to break an 8K, but still leave W/A at place. > + */ > + min_cdclk = max_t(int, min_cdclk, > + min_t(int, crtc_state->pixel_rate, > + dev_priv->max_cdclk_freq)); > + } > > if (min_cdclk > dev_priv->max_cdclk_freq) { > drm_dbg_kms(&dev_priv->drm, > -- > 2.24.1.485.gad05a3d8e5 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K 2020-07-03 0:04 ` [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K Manasi Navare @ 2020-07-03 10:46 ` Jani Nikula 0 siblings, 0 replies; 5+ messages in thread From: Jani Nikula @ 2020-07-03 10:46 UTC (permalink / raw) To: Manasi Navare, Stanislav Lisovskiy; +Cc: intel-gfx On Thu, 02 Jul 2020, Manasi Navare <manasi.d.navare@intel.com> wrote: > On Thu, Jul 02, 2020 at 12:15:26PM +0300, Stanislav Lisovskiy wrote: >> We still need "Bump up CDCLK" workaround otherwise getting >> underruns - however currently it blocks 8K as CDCLK = Pixel rate, >> in 8K case would require CDCLK to be around 1 Ghz which is not >> possible. >> >> v2: - Convert to expression(max(min_cdclk, min(pixel_rate, max_cdclk)) >> (Ville Syrjälä) >> - Use type specific min_t, max_t(Ville Syrjälä) >> >> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> > > I have tested this and this unblocks 8K > > Reviewed-by: Manasi Navare <manasi.d.navare@intel.com> Thanks for the patch and review, pushed to dinq. BR, Jani. > > Manasi > >> --- >> drivers/gpu/drm/i915/display/intel_cdclk.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c >> index 45f7f33d1144..8f9320e1e249 100644 >> --- a/drivers/gpu/drm/i915/display/intel_cdclk.c >> +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c >> @@ -2080,8 +2080,15 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state) >> * Explicitly stating here that this seems to be currently >> * rather a Hack, than final solution. >> */ >> - if (IS_TIGERLAKE(dev_priv)) >> - min_cdclk = max(min_cdclk, (int)crtc_state->pixel_rate); >> + if (IS_TIGERLAKE(dev_priv)) { >> + /* >> + * Clamp to max_cdclk_freq in case pixel rate is higher, >> + * in order not to break an 8K, but still leave W/A at place. >> + */ >> + min_cdclk = max_t(int, min_cdclk, >> + min_t(int, crtc_state->pixel_rate, >> + dev_priv->max_cdclk_freq)); >> + } >> >> if (min_cdclk > dev_priv->max_cdclk_freq) { >> drm_dbg_kms(&dev_priv->drm, >> -- >> 2.24.1.485.gad05a3d8e5 >> > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-03 10:47 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-02 9:15 [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K Stanislav Lisovskiy 2020-07-02 11:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K (rev2) Patchwork 2020-07-02 15:26 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2020-07-03 0:04 ` [Intel-gfx] [PATCH v2] drm/i915: Clamp min_cdclk to max_cdclk_freq to unblock 8K Manasi Navare 2020-07-03 10:46 ` Jani Nikula
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.