* [PATCH][next] xen-netfront: remove redundant assignment to variable 'act'
@ 2020-07-02 14:22 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2020-07-02 14:22 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini,
David S . Miller, Jakub Kicinski, xen-devel, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable act is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/xen-netfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 468f3f6f1425..860a0cce346d 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -856,7 +856,7 @@ static u32 xennet_run_xdp(struct netfront_queue *queue, struct page *pdata,
{
struct xdp_frame *xdpf;
u32 len = rx->status;
- u32 act = XDP_PASS;
+ u32 act;
int err;
xdp->data_hard_start = page_address(pdata);
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH][next] xen-netfront: remove redundant assignment to variable 'act'
@ 2020-07-02 14:22 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2020-07-02 14:22 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini,
David S . Miller, Jakub Kicinski, xen-devel, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable act is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/xen-netfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 468f3f6f1425..860a0cce346d 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -856,7 +856,7 @@ static u32 xennet_run_xdp(struct netfront_queue *queue, struct page *pdata,
{
struct xdp_frame *xdpf;
u32 len = rx->status;
- u32 act = XDP_PASS;
+ u32 act;
int err;
xdp->data_hard_start = page_address(pdata);
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][next] xen-netfront: remove redundant assignment to variable 'act'
2020-07-02 14:22 ` Colin King
(?)
@ 2020-07-02 21:37 ` David Miller
-1 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2020-07-02 21:37 UTC (permalink / raw)
To: colin.king
Cc: boris.ostrovsky, jgross, sstabellini, kuba, xen-devel, netdev,
kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 2 Jul 2020 15:22:23 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable act is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] xen-netfront: remove redundant assignment to variable 'act'
@ 2020-07-02 21:37 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2020-07-02 21:37 UTC (permalink / raw)
To: colin.king
Cc: boris.ostrovsky, jgross, sstabellini, kuba, xen-devel, netdev,
kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 2 Jul 2020 15:22:23 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable act is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][next] xen-netfront: remove redundant assignment to variable 'act'
@ 2020-07-02 21:37 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2020-07-02 21:37 UTC (permalink / raw)
To: colin.king
Cc: jgross, sstabellini, netdev, kernel-janitors, linux-kernel,
xen-devel, kuba, boris.ostrovsky
From: Colin King <colin.king@canonical.com>
Date: Thu, 2 Jul 2020 15:22:23 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable act is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-02 21:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02 14:22 [PATCH][next] xen-netfront: remove redundant assignment to variable 'act' Colin King
2020-07-02 14:22 ` Colin King
2020-07-02 21:37 ` David Miller
2020-07-02 21:37 ` David Miller
2020-07-02 21:37 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.