[PATCH] kernel.bbclass: add lz4 dependency and fix the call to lz4

[PATCH] kernel.bbclass: add lz4 dependency and fix the call to lz4

[T. Ulrich]

From: Timon Ulrich <t.ulrich@anapur.de>

If the initramfs image is type lz4, then a native lz4 is needed.

Additionally an output filename needs to be specified when calling lz4,
otherwise STDOUT will be used implicitly.

Signed-off-by: Timon Ulrich <t.ulrich@anapur.de>
---
 meta/classes/kernel.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 6d07b29e2d..add0b13bcb 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -4,7 +4,7 @@ KERNEL_PACKAGE_NAME ??= "kernel"
 KERNEL_DEPLOYSUBDIR ??= "${@ "" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else d.getVar("KERNEL_PACKAGE_NAME") }"
 
 PROVIDES += "${@ "virtual/kernel" if (d.getVar("KERNEL_PACKAGE_NAME") == "kernel") else "" }"
-DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native bison-native"
+DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native bc-native lzop-native lz4-native bison-native"
 PACKAGE_WRITE_DEPS += "depmodwrapper-cross"
 
 do_deploy[depends] += "depmodwrapper-cross:do_populate_sysroot"
@@ -210,7 +210,7 @@ copy_initramfs() {
 				;;
 			*lz4)
 				echo "lz4 decompressing image"
-				lz4 -df ${B}/usr/${INITRAMFS_IMAGE_NAME}.$img
+				lz4 -df ${B}/usr/${INITRAMFS_IMAGE_NAME}.$img ${B}/usr/${INITRAMFS_IMAGE_NAME}.cpio
 				break
 				;;
 			*lzo)
-- 
2.17.1

Re: [OE-core] [PATCH] kernel.bbclass: add lz4 dependency and fix the call to lz4

[Richard Purdie]

On Fri, 2020-07-03 at 08:22 +0200, T. Ulrich wrote:
> From: Timon Ulrich <t.ulrich@anapur.de>
> 
> If the initramfs image is type lz4, then a native lz4 is needed.
> 
> Additionally an output filename needs to be specified when calling
> lz4, otherwise STDOUT will be used implicitly.
> 
> Signed-off-by: Timon Ulrich <t.ulrich@anapur.de>
> ---
>  meta/classes/kernel.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I really don't like building tools just because we might need them. Is
there a way we can tell which compression format is being used for the
initramfs and make the dependencies conditional?

Cheers,

Richard

Re: [OE-core] [PATCH] kernel.bbclass: add lz4 dependency and fixthe call to lz4

[T. Ulrich]

[-- Attachment #1: Type: text/html, Size: 44769 bytes --]