From: "Ondřej Jirman" <megous@megous.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Icenowy Zheng <icenowy@aosc.io>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Samuel Holland <samuel@sholland.org>,
Martijn Braam <martijn@brixit.nl>, Luca Weiss <luca@z3ntu.xyz>,
Bhushan Shah <bshah@kde.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support
Date: Fri, 3 Jul 2020 15:08:41 +0200 [thread overview]
Message-ID: <20200703130841.3zqa5y4uazzl477z@core.my.home> (raw)
In-Reply-To: <20200703121706.gf2yxfe7crleatlm@gilmour.lan>
On Fri, Jul 03, 2020 at 02:17:06PM +0200, Maxime Ripard wrote:
> Hi,
>
> On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote:
> > Pinephone has a Goodix GT917S capacitive touchscreen controller on
> > I2C0 bus. Add support for it.
> >
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > index a89425ad3727..5c7386566053 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > @@ -121,6 +121,25 @@ &ehci1 {
> > status = "okay";
> > };
> >
> > +&i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c0_pins>;
> > + status = "okay";
>
> I didn't spot this earlier, but the pinctrl properties are already set
> in the DTSI. I've removed them while applying the patch.
Ah, right. Thank you very much. :)
regards,
o.
> Thanks!
> Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Ondřej Jirman" <megous@megous.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: devicetree@vger.kernel.org, Samuel Holland <samuel@sholland.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bhushan Shah <bshah@kde.org>,
linux-kernel@vger.kernel.org, Luca Weiss <luca@z3ntu.xyz>,
Martijn Braam <martijn@brixit.nl>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support
Date: Fri, 3 Jul 2020 15:08:41 +0200 [thread overview]
Message-ID: <20200703130841.3zqa5y4uazzl477z@core.my.home> (raw)
In-Reply-To: <20200703121706.gf2yxfe7crleatlm@gilmour.lan>
On Fri, Jul 03, 2020 at 02:17:06PM +0200, Maxime Ripard wrote:
> Hi,
>
> On Thu, Jul 02, 2020 at 10:14:32AM +0200, Ondrej Jirman wrote:
> > Pinephone has a Goodix GT917S capacitive touchscreen controller on
> > I2C0 bus. Add support for it.
> >
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > index a89425ad3727..5c7386566053 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > @@ -121,6 +121,25 @@ &ehci1 {
> > status = "okay";
> > };
> >
> > +&i2c0 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&i2c0_pins>;
> > + status = "okay";
>
> I didn't spot this earlier, but the pinctrl properties are already set
> in the DTSI. I've removed them while applying the patch.
Ah, right. Thank you very much. :)
regards,
o.
> Thanks!
> Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-03 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 8:14 [PATCH v8 0/2] Add support for PinePhone LCD panel Ondrej Jirman
2020-07-02 8:14 ` Ondrej Jirman
2020-07-02 8:14 ` [PATCH v8 1/2] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone Ondrej Jirman
2020-07-02 8:14 ` Ondrej Jirman
2020-07-02 8:14 ` [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support Ondrej Jirman
2020-07-02 8:14 ` Ondrej Jirman
2020-07-03 12:17 ` Maxime Ripard
2020-07-03 12:17 ` Maxime Ripard
2020-07-03 13:08 ` Ondřej Jirman [this message]
2020-07-03 13:08 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703130841.3zqa5y4uazzl477z@core.my.home \
--to=megous@megous.com \
--cc=bshah@kde.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=martijn@brixit.nl \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.