* [PATCH] net/amd: Remove needless assignment and the extra brank lines
@ 2020-07-06 14:47 Tang Bin
2020-07-06 19:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2020-07-06 14:47 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, Tang Bin, Zhang Shengju
The variable 'err = -ENODEV;' in au1000_probe() is
duplicate, so remove redundant one. And remove the
extra blank lines in the file au1000_eth.c
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/net/ethernet/amd/au1000_eth.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c
index 089a4fbc6..7dd8f2104 100644
--- a/drivers/net/ethernet/amd/au1000_eth.c
+++ b/drivers/net/ethernet/amd/au1000_eth.c
@@ -243,7 +243,6 @@ MODULE_VERSION(DRV_VERSION);
* ps: make sure the used irqs are configured properly in the board
* specific irq-map
*/
-
static void au1000_enable_mac(struct net_device *dev, int force_reset)
{
unsigned long flags;
@@ -558,7 +557,6 @@ static int au1000_mii_probe(struct net_device *dev)
return 0;
}
-
/*
* Buffer allocation/deallocation routines. The buffer descriptor returned
* has the virtual and dma address of a buffer suitable for
@@ -649,7 +647,6 @@ au1000_setup_hw_rings(struct au1000_private *aup, void __iomem *tx_base)
/*
* ethtool operations
*/
-
static void
au1000_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
{
@@ -682,7 +679,6 @@ static const struct ethtool_ops au1000_ethtool_ops = {
.set_link_ksettings = phy_ethtool_set_link_ksettings,
};
-
/*
* Initialize the interface.
*
@@ -1258,7 +1254,6 @@ static int au1000_probe(struct platform_device *pdev)
aup->rx_db_inuse[i] = pDB;
}
- err = -ENODEV;
for (i = 0; i < NUM_TX_DMA; i++) {
pDB = au1000_GetFreeDB(aup);
if (!pDB)
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/amd: Remove needless assignment and the extra brank lines
2020-07-06 14:47 [PATCH] net/amd: Remove needless assignment and the extra brank lines Tang Bin
@ 2020-07-06 19:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-07-06 19:59 UTC (permalink / raw)
To: tangbin; +Cc: netdev, linux-kernel, zhangshengju
From: Tang Bin <tangbin@cmss.chinamobile.com>
Date: Mon, 6 Jul 2020 22:47:01 +0800
> The variable 'err = -ENODEV;' in au1000_probe() is
> duplicate, so remove redundant one. And remove the
> extra blank lines in the file au1000_eth.c
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-06 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 14:47 [PATCH] net/amd: Remove needless assignment and the extra brank lines Tang Bin
2020-07-06 19:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.