From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Marcus Cooper <codekipper@gmail.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 04/16] ASoC: sun4i-i2s: Set sign extend sample
Date: Mon, 6 Jul 2020 07:17:39 +0200 [thread overview]
Message-ID: <20200706051739.iq23kvpzl7v7cpkp@gilmour.lan> (raw)
In-Reply-To: <20200704113902.336911-5-peron.clem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Sat, Jul 04, 2020 at 01:38:50PM +0200, Clément Péron wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs such as the H3 and A64 this is set by default
> to transfer a 0 after each sample in each slot. However the A10
> and A20 SoCs that this driver was developed on had a default
> setting where it padded the audio gain with zeros.
>
> This isn't a problem while we have only support for 16bit audio
> but with larger sample resolution rates in the pipeline then SEXT
> bits should be cleared so that they also pad at the LSB. Without
> this the audio gets distorted.
>
> Set sign extend sample for all the sunxi generations even if they
> are not affected. This will keep coherency and avoid relying on
> default.
Isn't it coherence? But I guess consistency would be a better fit here.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-sunxi@googlegroups.com, Takashi Iwai <tiwai@suse.com>,
Marcus Cooper <codekipper@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/16] ASoC: sun4i-i2s: Set sign extend sample
Date: Mon, 6 Jul 2020 07:17:39 +0200 [thread overview]
Message-ID: <20200706051739.iq23kvpzl7v7cpkp@gilmour.lan> (raw)
In-Reply-To: <20200704113902.336911-5-peron.clem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Sat, Jul 04, 2020 at 01:38:50PM +0200, Clément Péron wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs such as the H3 and A64 this is set by default
> to transfer a 0 after each sample in each slot. However the A10
> and A20 SoCs that this driver was developed on had a default
> setting where it padded the audio gain with zeros.
>
> This isn't a problem while we have only support for 16bit audio
> but with larger sample resolution rates in the pipeline then SEXT
> bits should be cleared so that they also pad at the LSB. Without
> this the audio gets distorted.
>
> Set sign extend sample for all the sunxi generations even if they
> are not affected. This will keep coherency and avoid relying on
> default.
Isn't it coherence? But I guess consistency would be a better fit here.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
linux-sunxi@googlegroups.com, Takashi Iwai <tiwai@suse.com>,
Jaroslav Kysela <perex@perex.cz>,
Marcus Cooper <codekipper@gmail.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/16] ASoC: sun4i-i2s: Set sign extend sample
Date: Mon, 6 Jul 2020 07:17:39 +0200 [thread overview]
Message-ID: <20200706051739.iq23kvpzl7v7cpkp@gilmour.lan> (raw)
In-Reply-To: <20200704113902.336911-5-peron.clem@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 845 bytes --]
On Sat, Jul 04, 2020 at 01:38:50PM +0200, Clément Péron wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> On the newer SoCs such as the H3 and A64 this is set by default
> to transfer a 0 after each sample in each slot. However the A10
> and A20 SoCs that this driver was developed on had a default
> setting where it padded the audio gain with zeros.
>
> This isn't a problem while we have only support for 16bit audio
> but with larger sample resolution rates in the pipeline then SEXT
> bits should be cleared so that they also pad at the LSB. Without
> this the audio gets distorted.
>
> Set sign extend sample for all the sunxi generations even if they
> are not affected. This will keep coherency and avoid relying on
> default.
Isn't it coherence? But I guess consistency would be a better fit here.
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-06 5:17 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 11:38 [PATCH 00/16] Add Allwinner H3/H5/H6/A64 HDMI audio Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` [PATCH 01/16] ASoC: sun4i-i2s: Add support for H6 I2S Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-06 5:15 ` Maxime Ripard
2020-07-06 5:15 ` Maxime Ripard
2020-07-06 5:15 ` Maxime Ripard
2020-07-10 5:44 ` [linux-sunxi] " Samuel Holland
2020-07-10 5:44 ` Samuel Holland
2020-07-10 5:44 ` Samuel Holland
2020-07-10 19:22 ` Jernej Škrabec
2020-07-10 19:22 ` Jernej Škrabec
2020-07-10 19:22 ` Jernej Škrabec
2020-07-11 1:43 ` Samuel Holland
2020-07-11 1:43 ` Samuel Holland
2020-07-11 1:43 ` Samuel Holland
2020-07-22 8:56 ` Clément Péron
2020-07-22 8:56 ` Clément Péron
2020-07-22 8:56 ` Clément Péron
2020-07-04 11:38 ` [PATCH 02/16] ASoC: sun4i-i2s: Adjust LRCLK width Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-10 5:44 ` [linux-sunxi] " Samuel Holland
2020-07-10 5:44 ` Samuel Holland
2020-07-10 5:44 ` Samuel Holland
2020-07-04 11:38 ` [PATCH 03/16] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` [PATCH 04/16] ASoC: sun4i-i2s: Set sign extend sample Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-06 5:17 ` Maxime Ripard [this message]
2020-07-06 5:17 ` Maxime Ripard
2020-07-06 5:17 ` Maxime Ripard
2020-07-10 5:44 ` [linux-sunxi] " Samuel Holland
2020-07-10 5:44 ` Samuel Holland
2020-07-10 5:44 ` Samuel Holland
2020-07-22 9:12 ` Clément Péron
2020-07-22 9:12 ` Clément Péron
2020-07-22 9:12 ` Clément Péron
2020-07-04 11:38 ` [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-06 5:18 ` Maxime Ripard
2020-07-06 5:18 ` Maxime Ripard
2020-07-06 5:18 ` Maxime Ripard
2020-07-10 5:44 ` [linux-sunxi] " Samuel Holland
2020-07-10 5:44 ` Samuel Holland
2020-07-10 5:44 ` Samuel Holland
2020-09-02 18:10 ` Jernej Škrabec
2020-09-02 18:10 ` Jernej Škrabec
2020-09-02 18:10 ` Jernej Škrabec
2020-09-03 2:22 ` Samuel Holland
2020-09-03 2:22 ` Samuel Holland
2020-09-03 2:22 ` Samuel Holland
2020-09-03 7:40 ` Maxime Ripard
2020-09-03 7:40 ` Maxime Ripard
2020-09-03 7:40 ` Maxime Ripard
2020-09-04 16:16 ` Charles Keepax
2020-09-04 16:16 ` Charles Keepax
2020-09-04 16:16 ` Charles Keepax
2020-09-04 16:23 ` Mark Brown
2020-09-04 16:23 ` Mark Brown
2020-09-04 16:23 ` Mark Brown
2020-07-04 11:38 ` [PATCH 06/16] ASoC: sun4i-i2s: Adjust regmap settings Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-06 5:24 ` Maxime Ripard
2020-07-06 5:24 ` Maxime Ripard
2020-07-06 5:24 ` Maxime Ripard
2020-07-04 11:38 ` [PATCH 07/16] ASoC: sun4i-i2s: Fix sun8i volatile regs Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-06 5:25 ` Maxime Ripard
2020-07-06 5:25 ` Maxime Ripard
2020-07-06 5:25 ` Maxime Ripard
2020-07-04 11:38 ` [PATCH 08/16] arm64: dts: allwinner: h6: Add HDMI audio node Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-06 5:29 ` Maxime Ripard
2020-07-06 5:29 ` Maxime Ripard
2020-07-06 5:29 ` Maxime Ripard
2020-07-08 16:17 ` Jernej Škrabec
2020-07-08 16:17 ` Jernej Škrabec
2020-07-08 16:17 ` Jernej Škrabec
2020-07-04 11:38 ` [PATCH 09/16] arm64: dts: allwinner: h6: Enable HDMI sound for Beelink GS1 Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` [PATCH 10/16] arm: dts: sunxi: h3/h5: Add DAI node for HDMI Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-18 21:24 ` [linux-sunxi] " Samuel Holland
2020-07-18 21:24 ` Samuel Holland
2020-07-18 21:24 ` Samuel Holland
2020-07-04 11:38 ` [PATCH 11/16] arm: dts: sunxi: h3/h5: Add HDMI audio Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` [PATCH 12/16] arm64: dts: allwinner: a64: Add DAI node for HDMI Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` [PATCH 13/16] arm64: dts: allwinner: a64: Add HDMI audio Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-04 11:38 ` Clément Péron
2020-07-06 5:31 ` Maxime Ripard
2020-07-06 5:31 ` Maxime Ripard
2020-07-06 5:31 ` Maxime Ripard
2020-07-08 16:00 ` Jernej Škrabec
2020-07-08 16:00 ` Jernej Škrabec
2020-07-08 16:00 ` Jernej Škrabec
2020-07-04 11:39 ` [PATCH 14/16] arm: sun8i: h3: Add HDMI audio to Orange Pi 2 Clément Péron
2020-07-04 11:39 ` Clément Péron
2020-07-04 11:39 ` Clément Péron
2020-07-04 11:39 ` [PATCH 15/16] arm: sun8i: h3: Add HDMI audio to Beelink X2 Clément Péron
2020-07-04 11:39 ` Clément Péron
2020-07-04 11:39 ` Clément Péron
2020-07-04 11:39 ` [PATCH 16/16] arm64: dts: allwinner: a64: Add HDMI audio to Pine64 Clément Péron
2020-07-04 11:39 ` Clément Péron
2020-07-04 11:39 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706051739.iq23kvpzl7v7cpkp@gilmour.lan \
--to=maxime@cerno.tech \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=perex@perex.cz \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.