From: Lee Jones <lee.jones@linaro.org> To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones <lee.jones@linaro.org>, Shlomi Gridish <gridish@freescale.com>, Jerry Huang <Chang-Ming.Huang@freescale.com>, Peter Barada <peterb@logicpd.com>, Anton Vorontsov <avorontsov@ru.mvista.com> Subject: [PATCH 31/32] usb: host: fhci-sched: Remove unused variable 'td' Date: Mon, 6 Jul 2020 14:33:40 +0100 [thread overview] Message-ID: <20200706133341.476881-32-lee.jones@linaro.org> (raw) In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> 'td' has been completely unused since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fhci-sched.c: In function ‘fhci_queue_urb’: drivers/usb/host/fhci-sched.c:704:13: warning: variable ‘td’ set but not used [-Wunused-but-set-variable] 704 | struct td *td; | ^~ Cc: Shlomi Gridish <gridish@freescale.com> Cc: Jerry Huang <Chang-Ming.Huang@freescale.com> Cc: Peter Barada <peterb@logicpd.com> Cc: Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/usb/host/fhci-sched.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/fhci-sched.c b/drivers/usb/host/fhci-sched.c index 3235d53074038..63c646c8f7d62 100644 --- a/drivers/usb/host/fhci-sched.c +++ b/drivers/usb/host/fhci-sched.c @@ -701,7 +701,6 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) u32 data_len = urb->transfer_buffer_length; int urb_state = 0; int toggle = 0; - struct td *td; u8 *data; u16 cnt = 0; @@ -770,7 +769,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) usb_endpoint_maxp(&urb->ep->desc)) == 0)) urb_state = US_BULK0; while (data_len > 4096) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, cnt ? USB_TD_TOGGLE_CARRY : @@ -781,7 +780,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) cnt++; } - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, cnt ? USB_TD_TOGGLE_CARRY : toggle, data, data_len, 0, 0, true); @@ -789,7 +788,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) if (urb->transfer_flags & URB_ZERO_PACKET && cnt < urb_priv->num_of_tds) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_CARRY, NULL, 0, 0, 0, true); @@ -798,7 +797,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) break; case FHCI_TF_INTR: urb->start_frame = get_frame_num(fhci) + 1; - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA0, data, data_len, urb->interval, urb->start_frame, true); @@ -808,12 +807,12 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) ed->max_pkt_size = usb_endpoint_maxp(&urb->ep->desc); /* setup stage */ - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_SETUP, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_SETUP, USB_TD_TOGGLE_DATA0, urb->setup_packet, 8, 0, 0, true); /* data stage */ if (data_len > 0) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA1, data, data_len, 0, 0, @@ -822,12 +821,12 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) /* status stage */ if (data_len > 0) - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, (usb_pipeout(urb->pipe) ? FHCI_TA_IN : FHCI_TA_OUT), USB_TD_TOGGLE_DATA1, data, 0, 0, 0, true); else - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_IN, USB_TD_TOGGLE_DATA1, data, 0, 0, 0, true); @@ -844,7 +843,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) */ frame += cnt * urb->interval; frame &= 0x07ff; - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA0, -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: gregkh@linuxfoundation.org Cc: Jerry Huang <Chang-Ming.Huang@freescale.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Barada <peterb@logicpd.com>, Shlomi Gridish <gridish@freescale.com>, Anton Vorontsov <avorontsov@ru.mvista.com>, Lee Jones <lee.jones@linaro.org>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 31/32] usb: host: fhci-sched: Remove unused variable 'td' Date: Mon, 6 Jul 2020 14:33:40 +0100 [thread overview] Message-ID: <20200706133341.476881-32-lee.jones@linaro.org> (raw) In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> 'td' has been completely unused since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fhci-sched.c: In function ‘fhci_queue_urb’: drivers/usb/host/fhci-sched.c:704:13: warning: variable ‘td’ set but not used [-Wunused-but-set-variable] 704 | struct td *td; | ^~ Cc: Shlomi Gridish <gridish@freescale.com> Cc: Jerry Huang <Chang-Ming.Huang@freescale.com> Cc: Peter Barada <peterb@logicpd.com> Cc: Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/usb/host/fhci-sched.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/fhci-sched.c b/drivers/usb/host/fhci-sched.c index 3235d53074038..63c646c8f7d62 100644 --- a/drivers/usb/host/fhci-sched.c +++ b/drivers/usb/host/fhci-sched.c @@ -701,7 +701,6 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) u32 data_len = urb->transfer_buffer_length; int urb_state = 0; int toggle = 0; - struct td *td; u8 *data; u16 cnt = 0; @@ -770,7 +769,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) usb_endpoint_maxp(&urb->ep->desc)) == 0)) urb_state = US_BULK0; while (data_len > 4096) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, cnt ? USB_TD_TOGGLE_CARRY : @@ -781,7 +780,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) cnt++; } - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, cnt ? USB_TD_TOGGLE_CARRY : toggle, data, data_len, 0, 0, true); @@ -789,7 +788,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) if (urb->transfer_flags & URB_ZERO_PACKET && cnt < urb_priv->num_of_tds) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_CARRY, NULL, 0, 0, 0, true); @@ -798,7 +797,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) break; case FHCI_TF_INTR: urb->start_frame = get_frame_num(fhci) + 1; - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA0, data, data_len, urb->interval, urb->start_frame, true); @@ -808,12 +807,12 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) ed->max_pkt_size = usb_endpoint_maxp(&urb->ep->desc); /* setup stage */ - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_SETUP, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_SETUP, USB_TD_TOGGLE_DATA0, urb->setup_packet, 8, 0, 0, true); /* data stage */ if (data_len > 0) { - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA1, data, data_len, 0, 0, @@ -822,12 +821,12 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) /* status stage */ if (data_len > 0) - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, (usb_pipeout(urb->pipe) ? FHCI_TA_IN : FHCI_TA_OUT), USB_TD_TOGGLE_DATA1, data, 0, 0, 0, true); else - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt++, FHCI_TA_IN, USB_TD_TOGGLE_DATA1, data, 0, 0, 0, true); @@ -844,7 +843,7 @@ void fhci_queue_urb(struct fhci_hcd *fhci, struct urb *urb) */ frame += cnt * urb->interval; frame &= 0x07ff; - td = fhci_td_fill(fhci, urb, urb_priv, ed, cnt, + fhci_td_fill(fhci, urb, urb_priv, ed, cnt, usb_pipeout(urb->pipe) ? FHCI_TA_OUT : FHCI_TA_IN, USB_TD_TOGGLE_DATA0, -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-06 13:34 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-06 13:33 [PATCH 00/32] Fix the final bunch of W=1 issues in USB Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 01/32] usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 02/32] usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 03/32] usb: gadget: legacy: printer: Remove unused variable 'driver_desc' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 04/32] usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 05/32] usb: gadget: function: u_ether: Downgrade kerneldoc headers which to not make the mark Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 06/32] usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-08 10:32 ` Robert Jarzmik 2020-07-08 10:32 ` Robert Jarzmik 2020-07-06 13:33 ` [PATCH 07/32] usb: misc: legousbtower: Demote function header which is clearly not kerneldoc Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 14:00 ` Hans de Goede 2020-07-06 14:00 ` Hans de Goede 2020-07-06 14:20 ` Lee Jones 2020-07-06 14:20 ` Lee Jones 2020-07-09 12:50 ` Hans de Goede 2020-07-09 12:50 ` Hans de Goede 2020-07-09 13:04 ` Lee Jones 2020-07-09 13:04 ` Lee Jones 2020-07-14 12:01 ` Hans de Goede 2020-07-14 12:01 ` Hans de Goede 2020-07-14 13:54 ` Lee Jones 2020-07-14 13:54 ` Lee Jones 2020-09-01 2:32 ` Badhri Jagan Sridharan 2020-09-01 2:32 ` Badhri Jagan Sridharan 2020-09-01 7:20 ` Hans de Goede 2020-09-01 7:20 ` Hans de Goede 2020-07-06 13:33 ` [PATCH 09/32] usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 10/32] usb: gadget: legacy: nokia: Remove unused static variable 'product_nokia' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 11/32] usb: gadget: function: f_fs: Demote function header which is clearly not kerneldoc Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 12/32] usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-07 6:16 ` Vladimir Zapolskiy 2020-07-07 6:16 ` Vladimir Zapolskiy 2020-07-06 13:33 ` [PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 14/32] usb: gadget: udc: mv_udc_core: Remove unused static const variable 'driver_desc' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 15/32] usb: gadget: udc: pch_udc: Fix a plethora of function documentation related issues Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 16/32] usb: host: imx21-hcd: Demote function header which is clearly not kerneldoc Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 17/32] usb: host: ehci-fsl: Fix incorrectly named function argument Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 18/32] usb: host: fotg210-hcd: Remove unused variable 'hcc_params' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 20/32] usb: host: bcma-hcd: " Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 21/32] usb: host: fotg210-hcd: " Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 22/32] usb: gadget: udc: mv_u3d_core: Remove unused static const 'driver_desc' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 16:08 ` Jassi Brar 2020-07-06 16:08 ` Jassi Brar 2020-07-06 13:33 ` [PATCH 24/32] usb: typec: ucsi: ucsi: Staticify and stop export of ucsi_init() Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 16:56 ` Eric W. Biederman 2020-07-06 16:56 ` Eric W. Biederman 2020-07-06 17:57 ` Lee Jones 2020-07-06 17:57 ` Lee Jones 2020-07-06 13:33 ` [PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:50 ` Jann Horn 2020-07-06 13:50 ` Jann Horn 2020-07-06 13:33 ` [PATCH 27/32] usb: early: xhci-dbc: File headers are not good candidates for kerneldoc Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 28/32] usb: host: ehci-platform: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 29/32] usb: dwc3: dwc3-qcom: " Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` [PATCH 30/32] usb: host: fhci-tds: Remove unused variables 'buf' and 'extra_data' Lee Jones 2020-07-06 13:33 ` Lee Jones 2020-07-06 13:33 ` Lee Jones [this message] 2020-07-06 13:33 ` [PATCH 31/32] usb: host: fhci-sched: Remove unused variable 'td' Lee Jones 2020-07-06 13:33 ` [PATCH 32/32] usb: host: xhci-plat: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones 2020-07-06 13:33 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200706133341.476881-32-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=Chang-Ming.Huang@freescale.com \ --cc=avorontsov@ru.mvista.com \ --cc=gregkh@linuxfoundation.org \ --cc=gridish@freescale.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=peterb@logicpd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.