* [Intel-gfx] [PATCH v3 1/3] drm/i915: Reboot CI if we get wedged during driver init @ 2020-07-06 14:01 Michał Winiarski 2020-07-06 14:01 ` [Intel-gfx] [PATCH v2 2/3] drm/i915: Print caller when tainting for CI Michał Winiarski ` (3 more replies) 0 siblings, 4 replies; 8+ messages in thread From: Michał Winiarski @ 2020-07-06 14:01 UTC (permalink / raw) To: intel-gfx; +Cc: Michał Winiarski, Chris Wilson From: Michał Winiarski <michal.winiarski@intel.com> Getting wedged device on driver init is pretty much unrecoverable. Since we're running various scenarios that may potentially hit this in CI (module reload / selftests / hotunplug), and if it happens, it means that we can't trust any subsequent CI results, we should just apply the taint to let the CI know that it should reboot (CI checks taint between test runs). v2: Comment that WEDGED_ON_INIT is non-recoverable, distinguish WEDGED_ON_INIT from WEDGED_ON_FINI (Chris) v3: Appease checkpatch, fixup search-replace logic expression mindbomb in assert (Chris) Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gt/intel_engine_user.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt.c | 2 +- drivers/gpu/drm/i915/gt/intel_gt.h | 12 ++++++++---- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +- drivers/gpu/drm/i915/gt/intel_reset.c | 13 +++++++++++-- drivers/gpu/drm/i915/gt/intel_reset.h | 10 ++-------- drivers/gpu/drm/i915/gt/intel_reset_types.h | 7 ++++++- 7 files changed, 30 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_user.c b/drivers/gpu/drm/i915/gt/intel_engine_user.c index 848decee9066..34e6096f196e 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_user.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_user.c @@ -201,7 +201,7 @@ void intel_engines_driver_register(struct drm_i915_private *i915) uabi_node); char old[sizeof(engine->name)]; - if (intel_gt_has_init_error(engine->gt)) + if (intel_gt_has_unrecoverable_error(engine->gt)) continue; /* ignore incomplete engines */ GEM_BUG_ON(engine->class >= ARRAY_SIZE(uabi_classes)); diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index ebc29b6ee86c..876f78759095 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -510,7 +510,7 @@ static int __engines_verify_workarounds(struct intel_gt *gt) static void __intel_gt_disable(struct intel_gt *gt) { - intel_gt_set_wedged_on_init(gt); + intel_gt_set_wedged_on_fini(gt); intel_gt_suspend_prepare(gt); intel_gt_suspend_late(gt); diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h index 4fac043750aa..982957ca4e62 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.h +++ b/drivers/gpu/drm/i915/gt/intel_gt.h @@ -58,14 +58,18 @@ static inline u32 intel_gt_scratch_offset(const struct intel_gt *gt, return i915_ggtt_offset(gt->scratch) + field; } -static inline bool intel_gt_is_wedged(const struct intel_gt *gt) +static inline bool intel_gt_has_unrecoverable_error(const struct intel_gt *gt) { - return __intel_reset_failed(>->reset); + return test_bit(I915_WEDGED_ON_INIT, >->reset.flags) || + test_bit(I915_WEDGED_ON_FINI, >->reset.flags); } -static inline bool intel_gt_has_init_error(const struct intel_gt *gt) +static inline bool intel_gt_is_wedged(const struct intel_gt *gt) { - return test_bit(I915_WEDGED_ON_INIT, >->reset.flags); + GEM_BUG_ON(intel_gt_has_unrecoverable_error(gt) && + !test_bit(I915_WEDGED, >->reset.flags)); + + return unlikely(test_bit(I915_WEDGED, >->reset.flags)); } #endif /* __INTEL_GT_H__ */ diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c index f1d5333f9456..274aa0dd7050 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c @@ -188,7 +188,7 @@ int intel_gt_resume(struct intel_gt *gt) enum intel_engine_id id; int err; - err = intel_gt_has_init_error(gt); + err = intel_gt_has_unrecoverable_error(gt); if (err) return err; diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index 0156f1f5c736..6f94b6479a2f 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.c +++ b/drivers/gpu/drm/i915/gt/intel_reset.c @@ -880,7 +880,7 @@ static bool __intel_gt_unset_wedged(struct intel_gt *gt) return true; /* Never fully initialised, recovery impossible */ - if (test_bit(I915_WEDGED_ON_INIT, >->reset.flags)) + if (intel_gt_has_unrecoverable_error(gt)) return false; GT_TRACE(gt, "start\n"); @@ -1342,7 +1342,7 @@ int intel_gt_terminally_wedged(struct intel_gt *gt) if (!intel_gt_is_wedged(gt)) return 0; - if (intel_gt_has_init_error(gt)) + if (intel_gt_has_unrecoverable_error(gt)) return -EIO; /* Reset still in progress? Maybe we will recover? */ @@ -1360,6 +1360,15 @@ void intel_gt_set_wedged_on_init(struct intel_gt *gt) I915_WEDGED_ON_INIT); intel_gt_set_wedged(gt); set_bit(I915_WEDGED_ON_INIT, >->reset.flags); + + /* Wedged on init is non-recoverable */ + add_taint_for_CI(TAINT_WARN); +} + +void intel_gt_set_wedged_on_fini(struct intel_gt *gt) +{ + intel_gt_set_wedged(gt); + set_bit(I915_WEDGED_ON_FINI, >->reset.flags); } void intel_gt_init_reset(struct intel_gt *gt) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.h b/drivers/gpu/drm/i915/gt/intel_reset.h index 8e8d5f761166..a0eec7c11c0c 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.h +++ b/drivers/gpu/drm/i915/gt/intel_reset.h @@ -47,8 +47,10 @@ int intel_gt_terminally_wedged(struct intel_gt *gt); /* * There's no unset_wedged_on_init paired with this one. * Once we're wedged on init, there's no going back. + * Same thing for unset_wedged_on_fini. */ void intel_gt_set_wedged_on_init(struct intel_gt *gt); +void intel_gt_set_wedged_on_fini(struct intel_gt *gt); int __intel_gt_reset(struct intel_gt *gt, intel_engine_mask_t engine_mask); @@ -71,14 +73,6 @@ void __intel_fini_wedge(struct intel_wedge_me *w); (W)->gt; \ __intel_fini_wedge((W))) -static inline bool __intel_reset_failed(const struct intel_reset *reset) -{ - GEM_BUG_ON(test_bit(I915_WEDGED_ON_INIT, &reset->flags) ? - !test_bit(I915_WEDGED, &reset->flags) : false); - - return unlikely(test_bit(I915_WEDGED, &reset->flags)); -} - bool intel_has_gpu_reset(const struct intel_gt *gt); bool intel_has_reset_engine(const struct intel_gt *gt); diff --git a/drivers/gpu/drm/i915/gt/intel_reset_types.h b/drivers/gpu/drm/i915/gt/intel_reset_types.h index f43bc3a0fe4f..add6b86d9d03 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset_types.h +++ b/drivers/gpu/drm/i915/gt/intel_reset_types.h @@ -34,12 +34,17 @@ struct intel_reset { * longer use the GPU - similar to #I915_WEDGED bit. The difference in * in the way we're handling "forced" unwedged (e.g. through debugfs), * which is not allowed in case we failed to initialize. + * + * #I915_WEDGED_ON_FINI - Similar to #I915_WEDGED_ON_INIT, except we + * use it to mark that the GPU is no longer available (and prevent + * users from using it). */ unsigned long flags; #define I915_RESET_BACKOFF 0 #define I915_RESET_MODESET 1 #define I915_RESET_ENGINE 2 -#define I915_WEDGED_ON_INIT (BITS_PER_LONG - 2) +#define I915_WEDGED_ON_INIT (BITS_PER_LONG - 3) +#define I915_WEDGED_ON_FINI (BITS_PER_LONG - 2) #define I915_WEDGED (BITS_PER_LONG - 1) struct mutex mutex; /* serialises wedging/unwedging */ -- 2.27.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH v2 2/3] drm/i915: Print caller when tainting for CI 2020-07-06 14:01 [Intel-gfx] [PATCH v3 1/3] drm/i915: Reboot CI if we get wedged during driver init Michał Winiarski @ 2020-07-06 14:01 ` Michał Winiarski 2020-07-06 14:09 ` Chris Wilson 2020-07-06 14:01 ` [Intel-gfx] [PATCH 3/3] drm/i915: Don't taint when using fault injection Michał Winiarski ` (2 subsequent siblings) 3 siblings, 1 reply; 8+ messages in thread From: Michał Winiarski @ 2020-07-06 14:01 UTC (permalink / raw) To: intel-gfx; +Cc: Chris Wilson, Michał Winiarski From: Michał Winiarski <michal.winiarski@intel.com> We can add taint from multiple places, printing the caller allows us to have a better overview of what exactly caused us to do the tainting. v2: Tweak format and print the device (Chris) Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> --- drivers/gpu/drm/i915/gt/intel_reset.c | 6 +++--- drivers/gpu/drm/i915/gt/selftest_rc6.c | 2 +- drivers/gpu/drm/i915/i915_gem.h | 2 +- drivers/gpu/drm/i915/i915_utils.h | 12 ++++++++++-- drivers/gpu/drm/i915/intel_uncore.c | 4 ++-- 5 files changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c index 6f94b6479a2f..121bf39a6f3e 100644 --- a/drivers/gpu/drm/i915/gt/intel_reset.c +++ b/drivers/gpu/drm/i915/gt/intel_reset.c @@ -930,7 +930,7 @@ static bool __intel_gt_unset_wedged(struct intel_gt *gt) * Warn CI about the unrecoverable wedged condition. * Time for a reboot. */ - add_taint_for_CI(TAINT_WARN); + add_taint_for_CI(gt->i915, TAINT_WARN); return false; } @@ -1097,7 +1097,7 @@ void intel_gt_reset(struct intel_gt *gt, * rather than continue on into oblivion. For everyone else, * the system should still plod along, but they have been warned! */ - add_taint_for_CI(TAINT_WARN); + add_taint_for_CI(gt->i915, TAINT_WARN); error: __intel_gt_set_wedged(gt); goto finish; @@ -1362,7 +1362,7 @@ void intel_gt_set_wedged_on_init(struct intel_gt *gt) set_bit(I915_WEDGED_ON_INIT, >->reset.flags); /* Wedged on init is non-recoverable */ - add_taint_for_CI(TAINT_WARN); + add_taint_for_CI(gt->i915, TAINT_WARN); } void intel_gt_set_wedged_on_fini(struct intel_gt *gt) diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers/gpu/drm/i915/gt/selftest_rc6.c index 3c8434846fa1..64ef5ee5decf 100644 --- a/drivers/gpu/drm/i915/gt/selftest_rc6.c +++ b/drivers/gpu/drm/i915/gt/selftest_rc6.c @@ -233,7 +233,7 @@ int live_rc6_ctx_wa(void *arg) i915_reset_engine_count(error, engine)) { pr_err("%s: GPU reset required\n", engine->name); - add_taint_for_CI(TAINT_WARN); + add_taint_for_CI(gt->i915, TAINT_WARN); err = -EIO; goto out; } diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h index 1753c84d6c0d..f333e88a2b6e 100644 --- a/drivers/gpu/drm/i915/i915_gem.h +++ b/drivers/gpu/drm/i915/i915_gem.h @@ -72,7 +72,7 @@ struct drm_i915_private; trace_printk(__VA_ARGS__); \ } while (0) #define GEM_TRACE_DUMP() \ - do { ftrace_dump(DUMP_ALL); add_taint_for_CI(TAINT_WARN); } while (0) + do { ftrace_dump(DUMP_ALL); __add_taint_for_CI(TAINT_WARN); } while (0) #define GEM_TRACE_DUMP_ON(expr) \ do { if (expr) GEM_TRACE_DUMP(); } while (0) #else diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h index 03a73d2bd50d..82fada1e7552 100644 --- a/drivers/gpu/drm/i915/i915_utils.h +++ b/drivers/gpu/drm/i915/i915_utils.h @@ -436,7 +436,13 @@ static inline const char *enableddisabled(bool v) return v ? "enabled" : "disabled"; } -static inline void add_taint_for_CI(unsigned int taint) +static inline void __add_taint_for_CI(unsigned int taint) +{ + add_taint(taint, LOCKDEP_STILL_OK); +} + +static inline void +add_taint_for_CI(struct drm_i915_private *i915, unsigned int taint) { /* * The system is "ok", just about surviving for the user, but @@ -444,7 +450,9 @@ static inline void add_taint_for_CI(unsigned int taint) * CI checks the taint state after every test and will reboot * the machine if the kernel is tainted. */ - add_taint(taint, LOCKDEP_STILL_OK); + __i915_printk(i915, KERN_NOTICE, "CI tainted:%x by %pS\n", + taint, (void *)_RET_IP_); + __add_taint_for_CI(taint); } void cancel_timer(struct timer_list *t); diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 592364aed2da..8e2c073da1aa 100644 --- a/drivers/gpu/drm/i915/intel_uncore.c +++ b/drivers/gpu/drm/i915/intel_uncore.c @@ -142,7 +142,7 @@ fw_domain_wait_ack_clear(const struct intel_uncore_forcewake_domain *d) if (wait_ack_clear(d, FORCEWAKE_KERNEL)) { DRM_ERROR("%s: timed out waiting for forcewake ack to clear.\n", intel_uncore_forcewake_domain_to_str(d->id)); - add_taint_for_CI(TAINT_WARN); /* CI now unreliable */ + add_taint_for_CI(d->uncore->i915, TAINT_WARN); /* CI now unreliable */ } } @@ -219,7 +219,7 @@ fw_domain_wait_ack_set(const struct intel_uncore_forcewake_domain *d) if (wait_ack_set(d, FORCEWAKE_KERNEL)) { DRM_ERROR("%s: timed out waiting for forcewake ack request.\n", intel_uncore_forcewake_domain_to_str(d->id)); - add_taint_for_CI(TAINT_WARN); /* CI now unreliable */ + add_taint_for_CI(d->uncore->i915, TAINT_WARN); /* CI now unreliable */ } } -- 2.27.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Print caller when tainting for CI 2020-07-06 14:01 ` [Intel-gfx] [PATCH v2 2/3] drm/i915: Print caller when tainting for CI Michał Winiarski @ 2020-07-06 14:09 ` Chris Wilson 0 siblings, 0 replies; 8+ messages in thread From: Chris Wilson @ 2020-07-06 14:09 UTC (permalink / raw) To: Michał Winiarski, intel-gfx; +Cc: Michał Winiarski Quoting Michał Winiarski (2020-07-06 15:01:24) > From: Michał Winiarski <michal.winiarski@intel.com> > > We can add taint from multiple places, printing the caller allows us to > have a better overview of what exactly caused us to do the tainting. > > v2: Tweak format and print the device (Chris) > > Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_reset.c | 6 +++--- > drivers/gpu/drm/i915/gt/selftest_rc6.c | 2 +- > drivers/gpu/drm/i915/i915_gem.h | 2 +- > drivers/gpu/drm/i915/i915_utils.h | 12 ++++++++++-- > drivers/gpu/drm/i915/intel_uncore.c | 4 ++-- > 5 files changed, 17 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c > index 6f94b6479a2f..121bf39a6f3e 100644 > --- a/drivers/gpu/drm/i915/gt/intel_reset.c > +++ b/drivers/gpu/drm/i915/gt/intel_reset.c > @@ -930,7 +930,7 @@ static bool __intel_gt_unset_wedged(struct intel_gt *gt) > * Warn CI about the unrecoverable wedged condition. > * Time for a reboot. > */ > - add_taint_for_CI(TAINT_WARN); > + add_taint_for_CI(gt->i915, TAINT_WARN); > return false; > } > > @@ -1097,7 +1097,7 @@ void intel_gt_reset(struct intel_gt *gt, > * rather than continue on into oblivion. For everyone else, > * the system should still plod along, but they have been warned! > */ > - add_taint_for_CI(TAINT_WARN); > + add_taint_for_CI(gt->i915, TAINT_WARN); > error: > __intel_gt_set_wedged(gt); > goto finish; > @@ -1362,7 +1362,7 @@ void intel_gt_set_wedged_on_init(struct intel_gt *gt) > set_bit(I915_WEDGED_ON_INIT, >->reset.flags); > > /* Wedged on init is non-recoverable */ > - add_taint_for_CI(TAINT_WARN); > + add_taint_for_CI(gt->i915, TAINT_WARN); > } > > void intel_gt_set_wedged_on_fini(struct intel_gt *gt) > diff --git a/drivers/gpu/drm/i915/gt/selftest_rc6.c b/drivers/gpu/drm/i915/gt/selftest_rc6.c > index 3c8434846fa1..64ef5ee5decf 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_rc6.c > +++ b/drivers/gpu/drm/i915/gt/selftest_rc6.c > @@ -233,7 +233,7 @@ int live_rc6_ctx_wa(void *arg) > i915_reset_engine_count(error, engine)) { > pr_err("%s: GPU reset required\n", > engine->name); > - add_taint_for_CI(TAINT_WARN); > + add_taint_for_CI(gt->i915, TAINT_WARN); > err = -EIO; > goto out; > } > diff --git a/drivers/gpu/drm/i915/i915_gem.h b/drivers/gpu/drm/i915/i915_gem.h > index 1753c84d6c0d..f333e88a2b6e 100644 > --- a/drivers/gpu/drm/i915/i915_gem.h > +++ b/drivers/gpu/drm/i915/i915_gem.h > @@ -72,7 +72,7 @@ struct drm_i915_private; > trace_printk(__VA_ARGS__); \ > } while (0) > #define GEM_TRACE_DUMP() \ > - do { ftrace_dump(DUMP_ALL); add_taint_for_CI(TAINT_WARN); } while (0) > + do { ftrace_dump(DUMP_ALL); __add_taint_for_CI(TAINT_WARN); } while (0) > #define GEM_TRACE_DUMP_ON(expr) \ > do { if (expr) GEM_TRACE_DUMP(); } while (0) > #else > diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h > index 03a73d2bd50d..82fada1e7552 100644 > --- a/drivers/gpu/drm/i915/i915_utils.h > +++ b/drivers/gpu/drm/i915/i915_utils.h > @@ -436,7 +436,13 @@ static inline const char *enableddisabled(bool v) > return v ? "enabled" : "disabled"; > } > > -static inline void add_taint_for_CI(unsigned int taint) > +static inline void __add_taint_for_CI(unsigned int taint) > +{ > + add_taint(taint, LOCKDEP_STILL_OK); > +} > + > +static inline void > +add_taint_for_CI(struct drm_i915_private *i915, unsigned int taint) > { > /* > * The system is "ok", just about surviving for the user, but > @@ -444,7 +450,9 @@ static inline void add_taint_for_CI(unsigned int taint) > * CI checks the taint state after every test and will reboot > * the machine if the kernel is tainted. > */ > - add_taint(taint, LOCKDEP_STILL_OK); > + __i915_printk(i915, KERN_NOTICE, "CI tainted:%x by %pS\n", > + taint, (void *)_RET_IP_); > + __add_taint_for_CI(taint); > } The only difference I made was I put this out-of-line in i915_utils.c -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH 3/3] drm/i915: Don't taint when using fault injection 2020-07-06 14:01 [Intel-gfx] [PATCH v3 1/3] drm/i915: Reboot CI if we get wedged during driver init Michał Winiarski 2020-07-06 14:01 ` [Intel-gfx] [PATCH v2 2/3] drm/i915: Print caller when tainting for CI Michał Winiarski @ 2020-07-06 14:01 ` Michał Winiarski 2020-07-06 14:10 ` Chris Wilson 2020-07-06 16:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/3] drm/i915: Reboot CI if we get wedged during driver init Patchwork 2020-07-06 18:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 3 siblings, 1 reply; 8+ messages in thread From: Michał Winiarski @ 2020-07-06 14:01 UTC (permalink / raw) To: intel-gfx; +Cc: Michał Winiarski, Chris Wilson From: Michał Winiarski <michal.winiarski@intel.com> It is not really unexpected to hit wedge on init this way. We're already downgrading error printk when running with fault injection, let's use the same approach for CI tainting. Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Petri Latvala <petri.latvala@intel.com> --- drivers/gpu/drm/i915/i915_utils.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h index 82fada1e7552..d84c23592942 100644 --- a/drivers/gpu/drm/i915/i915_utils.h +++ b/drivers/gpu/drm/i915/i915_utils.h @@ -438,7 +438,9 @@ static inline const char *enableddisabled(bool v) static inline void __add_taint_for_CI(unsigned int taint) { - add_taint(taint, LOCKDEP_STILL_OK); + /* Failures that occur during fault injection testing are expected */ + if (!i915_error_injected()) + add_taint(taint, LOCKDEP_STILL_OK); } static inline void -- 2.27.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Don't taint when using fault injection 2020-07-06 14:01 ` [Intel-gfx] [PATCH 3/3] drm/i915: Don't taint when using fault injection Michał Winiarski @ 2020-07-06 14:10 ` Chris Wilson 2020-07-06 14:11 ` Chris Wilson 0 siblings, 1 reply; 8+ messages in thread From: Chris Wilson @ 2020-07-06 14:10 UTC (permalink / raw) To: Michał Winiarski, intel-gfx; +Cc: Michał Winiarski Quoting Michał Winiarski (2020-07-06 15:01:25) > From: Michał Winiarski <michal.winiarski@intel.com> > > It is not really unexpected to hit wedge on init this way. > We're already downgrading error printk when running with fault injection, > let's use the same approach for CI tainting. > > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Petri Latvala <petri.latvala@intel.com> > --- > drivers/gpu/drm/i915/i915_utils.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h > index 82fada1e7552..d84c23592942 100644 > --- a/drivers/gpu/drm/i915/i915_utils.h > +++ b/drivers/gpu/drm/i915/i915_utils.h > @@ -438,7 +438,9 @@ static inline const char *enableddisabled(bool v) > > static inline void __add_taint_for_CI(unsigned int taint) > { > - add_taint(taint, LOCKDEP_STILL_OK); > + /* Failures that occur during fault injection testing are expected */ > + if (!i915_error_injected()) > + add_taint(taint, LOCKDEP_STILL_OK); > } And I think this is better in add_taint_for_CI(). If we hit the GEM_BUG_ON() we should always add the taint, as that trace dump is a one-shot affair. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH 3/3] drm/i915: Don't taint when using fault injection 2020-07-06 14:10 ` Chris Wilson @ 2020-07-06 14:11 ` Chris Wilson 0 siblings, 0 replies; 8+ messages in thread From: Chris Wilson @ 2020-07-06 14:11 UTC (permalink / raw) To: Michał Winiarski, intel-gfx; +Cc: Michał Winiarski Quoting Chris Wilson (2020-07-06 15:10:02) > Quoting Michał Winiarski (2020-07-06 15:01:25) > > From: Michał Winiarski <michal.winiarski@intel.com> > > > > It is not really unexpected to hit wedge on init this way. > > We're already downgrading error printk when running with fault injection, > > let's use the same approach for CI tainting. > > > > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com> > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> > > Cc: Petri Latvala <petri.latvala@intel.com> > > --- > > drivers/gpu/drm/i915/i915_utils.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h > > index 82fada1e7552..d84c23592942 100644 > > --- a/drivers/gpu/drm/i915/i915_utils.h > > +++ b/drivers/gpu/drm/i915/i915_utils.h > > @@ -438,7 +438,9 @@ static inline const char *enableddisabled(bool v) > > > > static inline void __add_taint_for_CI(unsigned int taint) > > { > > - add_taint(taint, LOCKDEP_STILL_OK); > > + /* Failures that occur during fault injection testing are expected */ > > + if (!i915_error_injected()) > > + add_taint(taint, LOCKDEP_STILL_OK); > > } > > And I think this is better in add_taint_for_CI(). If we hit the > GEM_BUG_ON() we should always add the taint, as that trace dump is a > one-shot affair. So if you agree, make add_taint_for_CI out-of-line and it there, and you can have a Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> straight away :) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/3] drm/i915: Reboot CI if we get wedged during driver init 2020-07-06 14:01 [Intel-gfx] [PATCH v3 1/3] drm/i915: Reboot CI if we get wedged during driver init Michał Winiarski 2020-07-06 14:01 ` [Intel-gfx] [PATCH v2 2/3] drm/i915: Print caller when tainting for CI Michał Winiarski 2020-07-06 14:01 ` [Intel-gfx] [PATCH 3/3] drm/i915: Don't taint when using fault injection Michał Winiarski @ 2020-07-06 16:00 ` Patchwork 2020-07-06 18:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2020-07-06 16:00 UTC (permalink / raw) To: Michał Winiarski; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/3] drm/i915: Reboot CI if we get wedged during driver init URL : https://patchwork.freedesktop.org/series/79160/ State : success == Summary == CI Bug Log - changes from CI_DRM_8708 -> Patchwork_18086 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/index.html Known issues ------------ Here are the changes found in Patchwork_18086 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html * igt@gem_linear_blits@basic: - fi-tgl-u2: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-tgl-u2/igt@gem_linear_blits@basic.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-tgl-u2/igt@gem_linear_blits@basic.html * igt@i915_pm_rpm@module-reload: - fi-glk-dsi: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-glk-dsi/igt@i915_pm_rpm@module-reload.html * igt@kms_busy@basic@flip: - fi-tgl-y: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-tgl-y/igt@kms_busy@basic@flip.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-tgl-y/igt@kms_busy@basic@flip.html * igt@prime_self_import@basic-with_two_bos: - fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#402]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-tgl-y/igt@prime_self_import@basic-with_two_bos.html #### Possible fixes #### * igt@i915_pm_rpm@basic-pci-d3-state: - fi-tgl-y: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html - fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@i915_pm_rpm@module-reload: - {fi-tgl-dsi}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-tgl-dsi/igt@i915_pm_rpm@module-reload.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-tgl-dsi/igt@i915_pm_rpm@module-reload.html * igt@vgem_basic@setversion: - fi-tgl-y: [DMESG-WARN][17] ([i915#402]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-tgl-y/igt@vgem_basic@setversion.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-tgl-y/igt@vgem_basic@setversion.html #### Warnings #### * igt@gem_exec_suspend@basic-s0: - fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92]) -> [DMESG-WARN][20] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (43 -> 37) ------------------------------ Additional (1): fi-skl-guc Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * Linux: CI_DRM_8708 -> Patchwork_18086 CI-20190529: 20190529 CI_DRM_8708: 170e94a1430fd0a4f0841ad0f7366904d52e49be @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5722: 9985cf23e9db9557bc7d714f5b72602e427497d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18086: 4b0b5628617d7c1926731ff1d631814ac9c0f23a @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 4b0b5628617d drm/i915: Don't taint when using fault injection 29374374794a drm/i915: Print caller when tainting for CI b3bbe0373d6e drm/i915: Reboot CI if we get wedged during driver init == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/3] drm/i915: Reboot CI if we get wedged during driver init 2020-07-06 14:01 [Intel-gfx] [PATCH v3 1/3] drm/i915: Reboot CI if we get wedged during driver init Michał Winiarski ` (2 preceding siblings ...) 2020-07-06 16:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/3] drm/i915: Reboot CI if we get wedged during driver init Patchwork @ 2020-07-06 18:55 ` Patchwork 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2020-07-06 18:55 UTC (permalink / raw) To: Michał Winiarski; +Cc: intel-gfx == Series Details == Series: series starting with [v3,1/3] drm/i915: Reboot CI if we get wedged during driver init URL : https://patchwork.freedesktop.org/series/79160/ State : success == Summary == CI Bug Log - changes from CI_DRM_8708_full -> Patchwork_18086_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_18086_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@reset-stress: - shard-tglb: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-tglb6/igt@gem_eio@reset-stress.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-tglb2/igt@gem_eio@reset-stress.html * igt@gem_exec_endless@dispatch@vecs0: - shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([i915#1958] / [i915#2119]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-iclb5/igt@gem_exec_endless@dispatch@vecs0.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-iclb8/igt@gem_exec_endless@dispatch@vecs0.html * igt@gem_exec_reloc@basic-concurrent0: - shard-glk: [PASS][5] -> [FAIL][6] ([i915#1930]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-glk8/igt@gem_exec_reloc@basic-concurrent0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-glk2/igt@gem_exec_reloc@basic-concurrent0.html * igt@gem_exec_whisper@basic-queues-all: - shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95]) +2 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-glk6/igt@gem_exec_whisper@basic-queues-all.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-glk5/igt@gem_exec_whisper@basic-queues-all.html * igt@gem_unfence_active_buffers: - shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#93] / [i915#95]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-kbl1/igt@gem_unfence_active_buffers.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-kbl6/igt@gem_unfence_active_buffers.html * igt@kms_big_fb@y-tiled-64bpp-rotate-0: - shard-glk: [PASS][11] -> [DMESG-FAIL][12] ([i915#118] / [i915#95]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-glk1/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-glk8/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html * igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size: - shard-hsw: [PASS][13] -> [FAIL][14] ([i915#57]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-hsw8/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [PASS][15] -> [FAIL][16] ([i915#79]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend@b-dp1: - shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-kbl1/igt@kms_flip@flip-vs-suspend@b-dp1.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-kbl6/igt@kms_flip@flip-vs-suspend@b-dp1.html * igt@kms_frontbuffer_tracking@psr-rgb565-draw-blt: - shard-tglb: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-tglb1/igt@kms_frontbuffer_tracking@psr-rgb565-draw-blt.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-tglb7/igt@kms_frontbuffer_tracking@psr-rgb565-draw-blt.html * igt@kms_lease@lease-uevent: - shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#1635] / [i915#95]) +18 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl3/igt@kms_lease@lease-uevent.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl4/igt@kms_lease@lease-uevent.html * igt@kms_plane@plane-position-covered-pipe-b-planes: - shard-skl: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +7 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl3/igt@kms_plane@plane-position-covered-pipe-b-planes.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl4/igt@kms_plane@plane-position-covered-pipe-b-planes.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min: - shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145] / [i915#265]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping: - shard-iclb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-iclb7/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-iclb3/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html * igt@template@b: - shard-snb: [PASS][29] -> [TIMEOUT][30] ([i915#1958] / [i915#2119]) +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-snb2/igt@template@b.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-snb4/igt@template@b.html #### Possible fixes #### * igt@gem_ctx_isolation@preservation-s3@vecs0: - shard-kbl: [DMESG-WARN][31] ([i915#180]) -> [PASS][32] +6 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vecs0.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-kbl4/igt@gem_ctx_isolation@preservation-s3@vecs0.html * igt@gem_ctx_persistence@legacy-engines-mixed-process@blt: - shard-skl: [FAIL][33] ([i915#1528]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl5/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl7/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html * igt@gem_exec_fence@parallel@vcs0: - shard-glk: [DMESG-WARN][35] ([i915#118] / [i915#95]) -> [PASS][36] +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-glk4/igt@gem_exec_fence@parallel@vcs0.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-glk3/igt@gem_exec_fence@parallel@vcs0.html * igt@gem_userptr_blits@unsync-unmap-after-close: - shard-kbl: [DMESG-WARN][37] ([i915#93] / [i915#95]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-kbl1/igt@gem_userptr_blits@unsync-unmap-after-close.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-kbl6/igt@gem_userptr_blits@unsync-unmap-after-close.html * igt@i915_module_load@reload: - shard-tglb: [DMESG-WARN][39] ([i915#402]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-tglb1/igt@i915_module_load@reload.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-tglb7/igt@i915_module_load@reload.html * igt@i915_selftest@mock@requests: - shard-skl: [INCOMPLETE][41] ([i915#198] / [i915#2110]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl2/igt@i915_selftest@mock@requests.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl1/igt@i915_selftest@mock@requests.html * igt@kms_big_fb@y-tiled-64bpp-rotate-180: - shard-glk: [DMESG-FAIL][43] ([i915#118] / [i915#95]) -> [PASS][44] +1 similar issue [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-glk8/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-glk9/igt@kms_big_fb@y-tiled-64bpp-rotate-180.html * igt@kms_cursor_crc@pipe-c-cursor-128x128-rapid-movement: - shard-tglb: [INCOMPLETE][45] ([i915#750]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-tglb8/igt@kms_cursor_crc@pipe-c-cursor-128x128-rapid-movement.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-tglb6/igt@kms_cursor_crc@pipe-c-cursor-128x128-rapid-movement.html * igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen: - shard-skl: [FAIL][47] ([i915#54]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html * igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled: - shard-apl: [DMESG-WARN][49] ([i915#1635] / [i915#95]) -> [PASS][50] +18 similar issues [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl7/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl8/igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled.html * igt@kms_fbcon_fbt@psr-suspend: - shard-iclb: [INCOMPLETE][51] ([i915#1185]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-iclb2/igt@kms_fbcon_fbt@psr-suspend.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-iclb3/igt@kms_fbcon_fbt@psr-suspend.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1: - shard-apl: [FAIL][53] ([i915#79]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html * igt@kms_flip@flip-vs-expired-vblank@a-edp1: - shard-skl: [FAIL][55] ([i915#46]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html * igt@kms_flip@flip-vs-suspend@a-edp1: - shard-tglb: [INCOMPLETE][57] ([i915#456]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-tglb2/igt@kms_flip@flip-vs-suspend@a-edp1.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-tglb7/igt@kms_flip@flip-vs-suspend@a-edp1.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt: - shard-tglb: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][61] ([i915#1188]) -> [PASS][62] +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl3/igt@kms_hdr@bpc-switch-dpms.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [FAIL][63] ([fdo#108145] / [i915#265]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [SKIP][65] ([fdo#109441]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_vblank@pipe-b-query-idle: - shard-skl: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68] +1 similar issue [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-skl4/igt@kms_vblank@pipe-b-query-idle.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-skl2/igt@kms_vblank@pipe-b-query-idle.html * igt@perf_pmu@semaphore-busy@rcs0: - shard-kbl: [FAIL][69] ([i915#1820]) -> [PASS][70] [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-kbl2/igt@perf_pmu@semaphore-busy@rcs0.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-kbl7/igt@perf_pmu@semaphore-busy@rcs0.html #### Warnings #### * igt@gem_exec_reloc@basic-concurrent16: - shard-snb: [FAIL][71] ([i915#1930]) -> [TIMEOUT][72] ([i915#1958] / [i915#2119]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-snb2/igt@gem_exec_reloc@basic-concurrent16.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-snb4/igt@gem_exec_reloc@basic-concurrent16.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [DMESG-WARN][73] ([i915#93] / [i915#95]) -> [DMESG-WARN][74] ([i915#180] / [i915#93] / [i915#95]) [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-kbl7/igt@gem_workarounds@suspend-resume-fd.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][75] ([i915#588]) -> [SKIP][76] ([i915#658]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-iclb5/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes: - shard-apl: [SKIP][77] ([fdo#109271] / [fdo#111827]) -> [SKIP][78] ([fdo#109271] / [fdo#111827] / [i915#1635]) +2 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl2/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl1/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html * igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge: - shard-apl: [DMESG-FAIL][79] ([i915#1635] / [i915#70] / [i915#95]) -> [DMESG-WARN][80] ([i915#1635] / [i915#95]) [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl7/igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl8/igt@kms_cursor_edge_walk@pipe-a-128x128-right-edge.html * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-pgflip-blt: - shard-snb: [SKIP][81] ([fdo#109271]) -> [TIMEOUT][82] ([i915#1958] / [i915#2119]) +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-snb2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-pgflip-blt.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-snb4/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-pgflip-blt.html * igt@kms_plane@plane-panning-top-left-pipe-d-planes: - shard-apl: [SKIP][83] ([fdo#109271] / [i915#1635]) -> [SKIP][84] ([fdo#109271]) +9 similar issues [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl2/igt@kms_plane@plane-panning-top-left-pipe-d-planes.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl7/igt@kms_plane@plane-panning-top-left-pipe-d-planes.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-apl: [DMESG-FAIL][85] ([i915#1635] / [i915#95]) -> [FAIL][86] ([i915#265]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl4/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl8/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@prime_nv_api@nv_i915_import_twice_check_flink_name: - shard-apl: [SKIP][87] ([fdo#109271]) -> [SKIP][88] ([fdo#109271] / [i915#1635]) +12 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl7/igt@prime_nv_api@nv_i915_import_twice_check_flink_name.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl8/igt@prime_nv_api@nv_i915_import_twice_check_flink_name.html * igt@runner@aborted: - shard-apl: ([FAIL][89], [FAIL][90]) ([i915#1610] / [i915#1635] / [i915#2110] / [i915#637]) -> ([FAIL][91], [FAIL][92]) ([fdo#109271] / [i915#1635] / [i915#2110] / [i915#716]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl2/igt@runner@aborted.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8708/shard-apl3/igt@runner@aborted.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl1/igt@runner@aborted.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/shard-apl7/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1820]: https://gitlab.freedesktop.org/drm/intel/issues/1820 [i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930 [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110 [i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456 [i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46 [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54 [i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57 [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588 [i915#637]: https://gitlab.freedesktop.org/drm/intel/issues/637 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#70]: https://gitlab.freedesktop.org/drm/intel/issues/70 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#750]: https://gitlab.freedesktop.org/drm/intel/issues/750 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * Linux: CI_DRM_8708 -> Patchwork_18086 CI-20190529: 20190529 CI_DRM_8708: 170e94a1430fd0a4f0841ad0f7366904d52e49be @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5722: 9985cf23e9db9557bc7d714f5b72602e427497d3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_18086: 4b0b5628617d7c1926731ff1d631814ac9c0f23a @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18086/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-06 18:56 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-06 14:01 [Intel-gfx] [PATCH v3 1/3] drm/i915: Reboot CI if we get wedged during driver init Michał Winiarski 2020-07-06 14:01 ` [Intel-gfx] [PATCH v2 2/3] drm/i915: Print caller when tainting for CI Michał Winiarski 2020-07-06 14:09 ` Chris Wilson 2020-07-06 14:01 ` [Intel-gfx] [PATCH 3/3] drm/i915: Don't taint when using fault injection Michał Winiarski 2020-07-06 14:10 ` Chris Wilson 2020-07-06 14:11 ` Chris Wilson 2020-07-06 16:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/3] drm/i915: Reboot CI if we get wedged during driver init Patchwork 2020-07-06 18:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.