* [PATCH v1] Security: Documentation: Replace deprecated :c:func: Usage
@ 2020-07-06 18:34 ` Puranjay Mohan
0 siblings, 0 replies; 4+ messages in thread
From: Puranjay Mohan @ 2020-07-06 18:34 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Puranjay Mohan, skhan, linux-kernel-mentees, linux-doc, linux-kernel
Replace :c:func: with ``func()`` as the previous usage is deprecated.
Remove an extra ')' to fix broken cross reference.
Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
---
V1: Change the subject line and remove deprecated :c:func: usage
---
Documentation/security/credentials.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/security/credentials.rst b/Documentation/security/credentials.rst
index 282e79feee6a..77b534f61c2a 100644
--- a/Documentation/security/credentials.rst
+++ b/Documentation/security/credentials.rst
@@ -453,9 +453,9 @@ still at this point.
When replacing the group list, the new list must be sorted before it
is added to the credential, as a binary search is used to test for
-membership. In practice, this means :c:func:`groups_sort` should be
-called before :c:func:`set_groups` or :c:func:`set_current_groups`.
-:c:func:`groups_sort)` must not be called on a ``struct group_list`` which
+membership. In practice, this means ``groups_sort()`` should be
+called before ``set_groups()`` or ``set_current_groups()``.
+``groups_sort()`` must not be called on a ``struct group_list`` which
is shared as it may permute elements as part of the sorting process
even if the array is already sorted.
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH v1] Security: Documentation: Replace deprecated :c:func: Usage
@ 2020-07-06 18:34 ` Puranjay Mohan
0 siblings, 0 replies; 4+ messages in thread
From: Puranjay Mohan @ 2020-07-06 18:34 UTC (permalink / raw)
To: Jonathan Corbet
Cc: linux-doc, linux-kernel-mentees, linux-kernel, Puranjay Mohan
Replace :c:func: with ``func()`` as the previous usage is deprecated.
Remove an extra ')' to fix broken cross reference.
Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
---
V1: Change the subject line and remove deprecated :c:func: usage
---
Documentation/security/credentials.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/security/credentials.rst b/Documentation/security/credentials.rst
index 282e79feee6a..77b534f61c2a 100644
--- a/Documentation/security/credentials.rst
+++ b/Documentation/security/credentials.rst
@@ -453,9 +453,9 @@ still at this point.
When replacing the group list, the new list must be sorted before it
is added to the credential, as a binary search is used to test for
-membership. In practice, this means :c:func:`groups_sort` should be
-called before :c:func:`set_groups` or :c:func:`set_current_groups`.
-:c:func:`groups_sort)` must not be called on a ``struct group_list`` which
+membership. In practice, this means ``groups_sort()`` should be
+called before ``set_groups()`` or ``set_current_groups()``.
+``groups_sort()`` must not be called on a ``struct group_list`` which
is shared as it may permute elements as part of the sorting process
even if the array is already sorted.
--
2.27.0
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] Security: Documentation: Replace deprecated :c:func: Usage
2020-07-06 18:34 ` [Linux-kernel-mentees] " Puranjay Mohan
@ 2020-07-06 18:39 ` Jonathan Corbet
-1 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2020-07-06 18:39 UTC (permalink / raw)
To: Puranjay Mohan; +Cc: skhan, linux-kernel-mentees, linux-doc, linux-kernel
On Tue, 7 Jul 2020 00:04:37 +0530
Puranjay Mohan <puranjay12@gmail.com> wrote:
> Replace :c:func: with ``func()`` as the previous usage is deprecated.
> Remove an extra ')' to fix broken cross reference.
>
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> ---
> V1: Change the subject line and remove deprecated :c:func: usage
> ---
> Documentation/security/credentials.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/security/credentials.rst b/Documentation/security/credentials.rst
> index 282e79feee6a..77b534f61c2a 100644
> --- a/Documentation/security/credentials.rst
> +++ b/Documentation/security/credentials.rst
> @@ -453,9 +453,9 @@ still at this point.
>
> When replacing the group list, the new list must be sorted before it
> is added to the credential, as a binary search is used to test for
> -membership. In practice, this means :c:func:`groups_sort` should be
> -called before :c:func:`set_groups` or :c:func:`set_current_groups`.
> -:c:func:`groups_sort)` must not be called on a ``struct group_list`` which
> +membership. In practice, this means ``groups_sort()`` should be
> +called before ``set_groups()`` or ``set_current_groups()``.
> +``groups_sort()`` must not be called on a ``struct group_list`` which
> is shared as it may permute elements as part of the sorting process
> even if the array is already sorted.
Almost ... but please leave off the ``quotes`` as well - just say
groups_sort().
Thanks,
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH v1] Security: Documentation: Replace deprecated :c:func: Usage
@ 2020-07-06 18:39 ` Jonathan Corbet
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2020-07-06 18:39 UTC (permalink / raw)
To: Puranjay Mohan; +Cc: linux-doc, linux-kernel-mentees, linux-kernel
On Tue, 7 Jul 2020 00:04:37 +0530
Puranjay Mohan <puranjay12@gmail.com> wrote:
> Replace :c:func: with ``func()`` as the previous usage is deprecated.
> Remove an extra ')' to fix broken cross reference.
>
> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
> ---
> V1: Change the subject line and remove deprecated :c:func: usage
> ---
> Documentation/security/credentials.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/security/credentials.rst b/Documentation/security/credentials.rst
> index 282e79feee6a..77b534f61c2a 100644
> --- a/Documentation/security/credentials.rst
> +++ b/Documentation/security/credentials.rst
> @@ -453,9 +453,9 @@ still at this point.
>
> When replacing the group list, the new list must be sorted before it
> is added to the credential, as a binary search is used to test for
> -membership. In practice, this means :c:func:`groups_sort` should be
> -called before :c:func:`set_groups` or :c:func:`set_current_groups`.
> -:c:func:`groups_sort)` must not be called on a ``struct group_list`` which
> +membership. In practice, this means ``groups_sort()`` should be
> +called before ``set_groups()`` or ``set_current_groups()``.
> +``groups_sort()`` must not be called on a ``struct group_list`` which
> is shared as it may permute elements as part of the sorting process
> even if the array is already sorted.
Almost ... but please leave off the ``quotes`` as well - just say
groups_sort().
Thanks,
jon
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-06 18:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 18:34 [PATCH v1] Security: Documentation: Replace deprecated :c:func: Usage Puranjay Mohan
2020-07-06 18:34 ` [Linux-kernel-mentees] " Puranjay Mohan
2020-07-06 18:39 ` Jonathan Corbet
2020-07-06 18:39 ` [Linux-kernel-mentees] " Jonathan Corbet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.