All of lore.kernel.org
 help / color / mirror / Atom feed
* [omap-audio:peter/ti-linux-5.4.y/wip 2/27] drivers/dma/ti/edma.c:1995:31: warning: Possible null pointer dereference: m_ddev
@ 2020-07-07  3:14 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-07-07  3:14 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 12247 bytes --]

tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-5.4.y/wip
head:   c10b4d1b6f2c74e568ed71ba10ad35702a01eb88
commit: cc41d908a672d6d704ad986162e1c71df48ed619 [2/27] dmaengine: ti: edma: Support for interleaved mem to mem transfer
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)

>> drivers/dma/ti/edma.c:1995:31: warning: Possible null pointer dereference: m_ddev [nullPointer]
     dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
                                 ^
   drivers/dma/ti/edma.c:1983:30: note: Assignment 'm_ddev=NULL', assigned value is 0
    struct dma_device *m_ddev = NULL;
                                ^
   drivers/dma/ti/edma.c:1995:31: note: Null pointer dereference
     dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
                                 ^

# https://github.com/omap-audio/linux-audio/commit/cc41d908a672d6d704ad986162e1c71df48ed619
git remote add omap-audio https://github.com/omap-audio/linux-audio
git remote update omap-audio
git checkout cc41d908a672d6d704ad986162e1c71df48ed619
vim +1995 drivers/dma/ti/edma.c

1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1974  
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1975  #define EDMA_DMA_BUSWIDTHS	(BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) | \
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1976  				 BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | \
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1977  				 BIT(DMA_SLAVE_BUSWIDTH_3_BYTES) | \
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1978  				 BIT(DMA_SLAVE_BUSWIDTH_4_BYTES))
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1979  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1980  static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  1981  {
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1982  	struct dma_device *s_ddev = &ecc->dma_slave;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1983  	struct dma_device *m_ddev = NULL;
ecb7deceff2a51 drivers/dma/edma.c    Peter Ujfalusi 2015-12-09  1984  	s32 *memcpy_channels = ecc->info->memcpy_channels;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  1985  	int i, j;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  1986  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1987  	dma_cap_zero(s_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1988  	dma_cap_set(DMA_SLAVE, s_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1989  	dma_cap_set(DMA_CYCLIC, s_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1990  	if (ecc->legacy_mode && !memcpy_channels) {
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1991  		dev_warn(ecc->dev,
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1992  			 "Legacy memcpy is enabled, things might not work\n");
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1993  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1994  		dma_cap_set(DMA_MEMCPY, s_ddev->cap_mask);
cc41d908a672d6 drivers/dma/ti/edma.c Peter Ujfalusi 2020-02-07 @1995  		dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1996  		s_ddev->device_prep_dma_memcpy = edma_prep_dma_memcpy;
cc41d908a672d6 drivers/dma/ti/edma.c Peter Ujfalusi 2020-02-07  1997  		s_ddev->device_prep_interleaved_dma = edma_prep_dma_interleaved;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1998  		s_ddev->directions = BIT(DMA_MEM_TO_MEM);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1999  	}
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2000  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2001  	s_ddev->device_prep_slave_sg = edma_prep_slave_sg;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2002  	s_ddev->device_prep_dma_cyclic = edma_prep_dma_cyclic;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2003  	s_ddev->device_alloc_chan_resources = edma_alloc_chan_resources;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2004  	s_ddev->device_free_chan_resources = edma_free_chan_resources;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2005  	s_ddev->device_issue_pending = edma_issue_pending;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2006  	s_ddev->device_tx_status = edma_tx_status;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2007  	s_ddev->device_config = edma_slave_config;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2008  	s_ddev->device_pause = edma_dma_pause;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2009  	s_ddev->device_resume = edma_dma_resume;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2010  	s_ddev->device_terminate_all = edma_terminate_all;
b84730ffcfccbe drivers/dma/edma.c    Peter Ujfalusi 2016-02-11  2011  	s_ddev->device_synchronize = edma_synchronize;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2012  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2013  	s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2014  	s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2015  	s_ddev->directions |= (BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV));
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2016  	s_ddev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
ea09ea51ddb9c5 drivers/dma/edma.c    Peter Ujfalusi 2017-10-03  2017  	s_ddev->max_burst = SZ_32K - 1; /* CIDX: 16bit signed */
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2018  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2019  	s_ddev->dev = ecc->dev;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2020  	INIT_LIST_HEAD(&s_ddev->channels);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2021  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2022  	if (memcpy_channels) {
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2023  		m_ddev = devm_kzalloc(ecc->dev, sizeof(*m_ddev), GFP_KERNEL);
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2024  		if (!m_ddev) {
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2025  			dev_warn(ecc->dev, "memcpy is disabled due to OoM\n");
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2026  			memcpy_channels = NULL;
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2027  			goto ch_setup;
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2028  		}
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2029  		ecc->dma_memcpy = m_ddev;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2030  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2031  		dma_cap_zero(m_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2032  		dma_cap_set(DMA_MEMCPY, m_ddev->cap_mask);
cc41d908a672d6 drivers/dma/ti/edma.c Peter Ujfalusi 2020-02-07  2033  		dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2034  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2035  		m_ddev->device_prep_dma_memcpy = edma_prep_dma_memcpy;
cc41d908a672d6 drivers/dma/ti/edma.c Peter Ujfalusi 2020-02-07  2036  		m_ddev->device_prep_interleaved_dma = edma_prep_dma_interleaved;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2037  		m_ddev->device_alloc_chan_resources = edma_alloc_chan_resources;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2038  		m_ddev->device_free_chan_resources = edma_free_chan_resources;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2039  		m_ddev->device_issue_pending = edma_issue_pending;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2040  		m_ddev->device_tx_status = edma_tx_status;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2041  		m_ddev->device_config = edma_slave_config;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2042  		m_ddev->device_pause = edma_dma_pause;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2043  		m_ddev->device_resume = edma_dma_resume;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2044  		m_ddev->device_terminate_all = edma_terminate_all;
b84730ffcfccbe drivers/dma/edma.c    Peter Ujfalusi 2016-02-11  2045  		m_ddev->device_synchronize = edma_synchronize;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2046  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2047  		m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2048  		m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2049  		m_ddev->directions = BIT(DMA_MEM_TO_MEM);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2050  		m_ddev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2051  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2052  		m_ddev->dev = ecc->dev;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2053  		INIT_LIST_HEAD(&m_ddev->channels);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2054  	} else if (!ecc->legacy_mode) {
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2055  		dev_info(ecc->dev, "memcpy is disabled\n");
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2056  	}
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2057  
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2058  ch_setup:
cb78205955d4a2 drivers/dma/edma.c    Peter Ujfalusi 2015-10-14  2059  	for (i = 0; i < ecc->num_channels; i++) {
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2060  		struct edma_chan *echan = &ecc->slave_chans[i];
2b6b3b74201908 drivers/dma/edma.c    Peter Ujfalusi 2015-10-14  2061  		echan->ch_num = EDMA_CTLR_CHAN(ecc->id, i);
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2062  		echan->ecc = ecc;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2063  		echan->vchan.desc_free = edma_desc_free;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2064  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2065  		if (m_ddev && edma_is_memcpy_channel(i, memcpy_channels))
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2066  			vchan_init(&echan->vchan, m_ddev);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2067  		else
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2068  			vchan_init(&echan->vchan, s_ddev);
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2069  
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2070  		INIT_LIST_HEAD(&echan->node);
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2071  		for (j = 0; j < EDMA_MAX_SLOTS; j++)
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2072  			echan->slot[j] = -1;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2073  	}
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2074  }
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2075  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [omap-audio:peter/ti-linux-5.4.y/wip 2/27] drivers/dma/ti/edma.c:1995:31: warning: Possible null pointer dereference: m_ddev
@ 2020-07-05  8:28 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-07-05  8:28 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 12322 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Peter Ujfalusi <peter.ujfalusi@ti.com>

tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-5.4.y/wip
head:   c10b4d1b6f2c74e568ed71ba10ad35702a01eb88
commit: cc41d908a672d6d704ad986162e1c71df48ed619 [2/27] dmaengine: ti: edma: Support for interleaved mem to mem transfer
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)

>> drivers/dma/ti/edma.c:1995:31: warning: Possible null pointer dereference: m_ddev [nullPointer]
     dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
                                 ^
   drivers/dma/ti/edma.c:1983:30: note: Assignment 'm_ddev=NULL', assigned value is 0
    struct dma_device *m_ddev = NULL;
                                ^
   drivers/dma/ti/edma.c:1995:31: note: Null pointer dereference
     dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
                                 ^

# https://github.com/omap-audio/linux-audio/commit/cc41d908a672d6d704ad986162e1c71df48ed619
git remote add omap-audio https://github.com/omap-audio/linux-audio
git remote update omap-audio
git checkout cc41d908a672d6d704ad986162e1c71df48ed619
vim +1995 drivers/dma/ti/edma.c

1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1974  
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1975  #define EDMA_DMA_BUSWIDTHS	(BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) | \
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1976  				 BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | \
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1977  				 BIT(DMA_SLAVE_BUSWIDTH_3_BYTES) | \
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1978  				 BIT(DMA_SLAVE_BUSWIDTH_4_BYTES))
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1979  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1980  static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  1981  {
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1982  	struct dma_device *s_ddev = &ecc->dma_slave;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1983  	struct dma_device *m_ddev = NULL;
ecb7deceff2a51 drivers/dma/edma.c    Peter Ujfalusi 2015-12-09  1984  	s32 *memcpy_channels = ecc->info->memcpy_channels;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  1985  	int i, j;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  1986  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1987  	dma_cap_zero(s_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1988  	dma_cap_set(DMA_SLAVE, s_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1989  	dma_cap_set(DMA_CYCLIC, s_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1990  	if (ecc->legacy_mode && !memcpy_channels) {
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1991  		dev_warn(ecc->dev,
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1992  			 "Legacy memcpy is enabled, things might not work\n");
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1993  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1994  		dma_cap_set(DMA_MEMCPY, s_ddev->cap_mask);
cc41d908a672d6 drivers/dma/ti/edma.c Peter Ujfalusi 2020-02-07 @1995  		dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1996  		s_ddev->device_prep_dma_memcpy = edma_prep_dma_memcpy;
cc41d908a672d6 drivers/dma/ti/edma.c Peter Ujfalusi 2020-02-07  1997  		s_ddev->device_prep_interleaved_dma = edma_prep_dma_interleaved;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1998  		s_ddev->directions = BIT(DMA_MEM_TO_MEM);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  1999  	}
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2000  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2001  	s_ddev->device_prep_slave_sg = edma_prep_slave_sg;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2002  	s_ddev->device_prep_dma_cyclic = edma_prep_dma_cyclic;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2003  	s_ddev->device_alloc_chan_resources = edma_alloc_chan_resources;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2004  	s_ddev->device_free_chan_resources = edma_free_chan_resources;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2005  	s_ddev->device_issue_pending = edma_issue_pending;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2006  	s_ddev->device_tx_status = edma_tx_status;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2007  	s_ddev->device_config = edma_slave_config;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2008  	s_ddev->device_pause = edma_dma_pause;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2009  	s_ddev->device_resume = edma_dma_resume;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2010  	s_ddev->device_terminate_all = edma_terminate_all;
b84730ffcfccbe drivers/dma/edma.c    Peter Ujfalusi 2016-02-11  2011  	s_ddev->device_synchronize = edma_synchronize;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2012  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2013  	s_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2014  	s_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2015  	s_ddev->directions |= (BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV));
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2016  	s_ddev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
ea09ea51ddb9c5 drivers/dma/edma.c    Peter Ujfalusi 2017-10-03  2017  	s_ddev->max_burst = SZ_32K - 1; /* CIDX: 16bit signed */
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2018  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2019  	s_ddev->dev = ecc->dev;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2020  	INIT_LIST_HEAD(&s_ddev->channels);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2021  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2022  	if (memcpy_channels) {
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2023  		m_ddev = devm_kzalloc(ecc->dev, sizeof(*m_ddev), GFP_KERNEL);
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2024  		if (!m_ddev) {
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2025  			dev_warn(ecc->dev, "memcpy is disabled due to OoM\n");
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2026  			memcpy_channels = NULL;
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2027  			goto ch_setup;
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2028  		}
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2029  		ecc->dma_memcpy = m_ddev;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2030  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2031  		dma_cap_zero(m_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2032  		dma_cap_set(DMA_MEMCPY, m_ddev->cap_mask);
cc41d908a672d6 drivers/dma/ti/edma.c Peter Ujfalusi 2020-02-07  2033  		dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2034  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2035  		m_ddev->device_prep_dma_memcpy = edma_prep_dma_memcpy;
cc41d908a672d6 drivers/dma/ti/edma.c Peter Ujfalusi 2020-02-07  2036  		m_ddev->device_prep_interleaved_dma = edma_prep_dma_interleaved;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2037  		m_ddev->device_alloc_chan_resources = edma_alloc_chan_resources;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2038  		m_ddev->device_free_chan_resources = edma_free_chan_resources;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2039  		m_ddev->device_issue_pending = edma_issue_pending;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2040  		m_ddev->device_tx_status = edma_tx_status;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2041  		m_ddev->device_config = edma_slave_config;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2042  		m_ddev->device_pause = edma_dma_pause;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2043  		m_ddev->device_resume = edma_dma_resume;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2044  		m_ddev->device_terminate_all = edma_terminate_all;
b84730ffcfccbe drivers/dma/edma.c    Peter Ujfalusi 2016-02-11  2045  		m_ddev->device_synchronize = edma_synchronize;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2046  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2047  		m_ddev->src_addr_widths = EDMA_DMA_BUSWIDTHS;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2048  		m_ddev->dst_addr_widths = EDMA_DMA_BUSWIDTHS;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2049  		m_ddev->directions = BIT(DMA_MEM_TO_MEM);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2050  		m_ddev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2051  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2052  		m_ddev->dev = ecc->dev;
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2053  		INIT_LIST_HEAD(&m_ddev->channels);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2054  	} else if (!ecc->legacy_mode) {
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2055  		dev_info(ecc->dev, "memcpy is disabled\n");
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2056  	}
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2057  
f31b323675c11e drivers/dma/edma.c    Peter Ujfalusi 2018-03-21  2058  ch_setup:
cb78205955d4a2 drivers/dma/edma.c    Peter Ujfalusi 2015-10-14  2059  	for (i = 0; i < ecc->num_channels; i++) {
02f77ef1197bd0 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2060  		struct edma_chan *echan = &ecc->slave_chans[i];
2b6b3b74201908 drivers/dma/edma.c    Peter Ujfalusi 2015-10-14  2061  		echan->ch_num = EDMA_CTLR_CHAN(ecc->id, i);
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2062  		echan->ecc = ecc;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2063  		echan->vchan.desc_free = edma_desc_free;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2064  
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2065  		if (m_ddev && edma_is_memcpy_channel(i, memcpy_channels))
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2066  			vchan_init(&echan->vchan, m_ddev);
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2067  		else
1be5336bc7ba05 drivers/dma/edma.c    Peter Ujfalusi 2015-10-16  2068  			vchan_init(&echan->vchan, s_ddev);
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2069  
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2070  		INIT_LIST_HEAD(&echan->node);
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2071  		for (j = 0; j < EDMA_MAX_SLOTS; j++)
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2072  			echan->slot[j] = -1;
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2073  	}
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2074  }
c2dde5f8f2095d drivers/dma/edma.c    Matt Porter    2012-08-22  2075  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-07  3:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07  3:14 [omap-audio:peter/ti-linux-5.4.y/wip 2/27] drivers/dma/ti/edma.c:1995:31: warning: Possible null pointer dereference: m_ddev kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-07-05  8:28 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.