* [regulator:for-5.9 36/39] drivers/regulator/fan53880.c:155:34: warning: unused variable 'fan53880_dt_ids'
@ 2020-07-07 6:23 kernel test robot
2020-07-07 9:03 ` [PATCH] regulator: fan53880: fix Kconfig dependency Christoph Fritz
0 siblings, 1 reply; 7+ messages in thread
From: kernel test robot @ 2020-07-07 6:23 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 8468 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.9
head: 083986c24b38317c958612c5a7d3f270ae708b32
commit: e6dea51e2d41679d37a81d0b1247c039092af46b [36/39] regulator: fan53880: Add initial support
config: s390-randconfig-r003-20200707 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
git checkout e6dea51e2d41679d37a81d0b1247c039092af46b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
include/uapi/linux/swab.h:19:12: note: expanded from macro '___constant_swab32'
(((__u32)(x) & (__u32)0x000000ffUL) << 24) | \
^
In file included from drivers/regulator/fan53880.c:4:
In file included from include/linux/regmap.h:20:
In file included from include/linux/iopoll.h:14:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:72:
include/asm-generic/io.h:490:45: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu(__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
^
include/uapi/linux/swab.h:119:21: note: expanded from macro '__swab32'
___constant_swab32(x) : \
^
include/uapi/linux/swab.h:20:12: note: expanded from macro '___constant_swab32'
(((__u32)(x) & (__u32)0x0000ff00UL) << 8) | \
^
In file included from drivers/regulator/fan53880.c:4:
In file included from include/linux/regmap.h:20:
In file included from include/linux/iopoll.h:14:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:72:
include/asm-generic/io.h:490:45: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu(__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
^
include/uapi/linux/swab.h:119:21: note: expanded from macro '__swab32'
___constant_swab32(x) : \
^
include/uapi/linux/swab.h:21:12: note: expanded from macro '___constant_swab32'
(((__u32)(x) & (__u32)0x00ff0000UL) >> 8) | \
^
In file included from drivers/regulator/fan53880.c:4:
In file included from include/linux/regmap.h:20:
In file included from include/linux/iopoll.h:14:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:72:
include/asm-generic/io.h:490:45: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu(__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
^
include/uapi/linux/swab.h:119:21: note: expanded from macro '__swab32'
___constant_swab32(x) : \
^
include/uapi/linux/swab.h:22:12: note: expanded from macro '___constant_swab32'
(((__u32)(x) & (__u32)0xff000000UL) >> 24)))
^
In file included from drivers/regulator/fan53880.c:4:
In file included from include/linux/regmap.h:20:
In file included from include/linux/iopoll.h:14:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:72:
include/asm-generic/io.h:490:45: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu(__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
^
include/uapi/linux/swab.h:120:12: note: expanded from macro '__swab32'
__fswab32(x))
^
In file included from drivers/regulator/fan53880.c:4:
In file included from include/linux/regmap.h:20:
In file included from include/linux/iopoll.h:14:
In file included from include/linux/io.h:13:
In file included from arch/s390/include/asm/io.h:72:
include/asm-generic/io.h:501:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:511:46: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew(cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:521:46: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel(cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:609:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
readsb(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:617:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
readsw(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:625:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
readsl(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:634:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
writesb(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:643:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
writesw(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:652:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
writesl(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
>> drivers/regulator/fan53880.c:155:34: warning: unused variable 'fan53880_dt_ids' [-Wunused-const-variable]
static const struct of_device_id fan53880_dt_ids[] = {
^
21 warnings generated.
vim +/fan53880_dt_ids +155 drivers/regulator/fan53880.c
154
> 155 static const struct of_device_id fan53880_dt_ids[] = {
156 { .compatible = "onnn,fan53880", },
157 {}
158 };
159 MODULE_DEVICE_TABLE(of, fan53880_dt_ids);
160
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 22304 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] regulator: fan53880: fix Kconfig dependency
2020-07-07 6:23 [regulator:for-5.9 36/39] drivers/regulator/fan53880.c:155:34: warning: unused variable 'fan53880_dt_ids' kernel test robot
@ 2020-07-07 9:03 ` Christoph Fritz
2020-07-07 10:20 ` Mark Brown
0 siblings, 1 reply; 7+ messages in thread
From: Christoph Fritz @ 2020-07-07 9:03 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, kbuild-all, clang-built-linux, kernel test robot,
linux-kernel
Currently the fan53880 regulator driver needs a device tree to get
probed, this patch provides the necessary dependency.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
drivers/regulator/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index d47055db999d..76ef4b2de2e7 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -338,7 +338,7 @@ config REGULATOR_FAN53555
config REGULATOR_FAN53880
tristate "Fairchild FAN53880 Regulator"
- depends on I2C
+ depends on I2C && OF
select REGMAP_I2C
help
This driver supports Fairchild (ON Semiconductor) FAN53880
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] regulator: fan53880: fix Kconfig dependency
2020-07-07 9:03 ` [PATCH] regulator: fan53880: fix Kconfig dependency Christoph Fritz
@ 2020-07-07 10:20 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-07-07 10:20 UTC (permalink / raw)
To: Christoph Fritz
Cc: Liam Girdwood, kbuild-all, clang-built-linux, kernel test robot,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
On Tue, Jul 07, 2020 at 11:03:23AM +0200, Christoph Fritz wrote:
> Currently the fan53880 regulator driver needs a device tree to get
> probed, this patch provides the necessary dependency.
It doesn't need it to run so it's better to leave an || COMPILE_TEST in
there at least and fix the warning with ifdefs and/or annotations.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] regulator: fan53880: fix Kconfig dependency
@ 2020-07-07 10:20 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-07-07 10:20 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
On Tue, Jul 07, 2020 at 11:03:23AM +0200, Christoph Fritz wrote:
> Currently the fan53880 regulator driver needs a device tree to get
> probed, this patch provides the necessary dependency.
It doesn't need it to run so it's better to leave an || COMPILE_TEST in
there at least and fix the warning with ifdefs and/or annotations.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] regulator: fan53880: Add support for COMPILE_TEST
2020-07-07 10:20 ` Mark Brown
(?)
@ 2020-07-07 10:57 ` Christoph Fritz
2020-07-07 14:17 ` Mark Brown
-1 siblings, 1 reply; 7+ messages in thread
From: Christoph Fritz @ 2020-07-07 10:57 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, kbuild-all, clang-built-linux, kernel test robot,
linux-kernel
This patch adds support for COMPILE_TEST while fixing a warning when
no support for device tree is there.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
drivers/regulator/Kconfig | 2 +-
drivers/regulator/fan53880.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index d47055db999d..1cc3c93a9621 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -338,7 +338,7 @@ config REGULATOR_FAN53555
config REGULATOR_FAN53880
tristate "Fairchild FAN53880 Regulator"
- depends on I2C
+ depends on I2C && (OF || COMPILE_TEST)
select REGMAP_I2C
help
This driver supports Fairchild (ON Semiconductor) FAN53880
diff --git a/drivers/regulator/fan53880.c b/drivers/regulator/fan53880.c
index 285acc705a55..c45baf581299 100644
--- a/drivers/regulator/fan53880.c
+++ b/drivers/regulator/fan53880.c
@@ -152,11 +152,13 @@ static int fan53880_i2c_probe(struct i2c_client *i2c,
return 0;
}
+#ifdef CONFIG_OF
static const struct of_device_id fan53880_dt_ids[] = {
{ .compatible = "onnn,fan53880", },
{}
};
MODULE_DEVICE_TABLE(of, fan53880_dt_ids);
+#endif
static const struct i2c_device_id fan53880_i2c_id[] = {
{ "fan53880", },
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] regulator: fan53880: Add support for COMPILE_TEST
2020-07-07 10:57 ` [PATCH] regulator: fan53880: Add support for COMPILE_TEST Christoph Fritz
@ 2020-07-07 14:17 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-07-07 14:17 UTC (permalink / raw)
To: Christoph Fritz
Cc: clang-built-linux, Liam Girdwood, kernel test robot, kbuild-all,
linux-kernel
On Tue, 07 Jul 2020 12:57:31 +0200, Christoph Fritz wrote:
> This patch adds support for COMPILE_TEST while fixing a warning when
> no support for device tree is there.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: fan53880: Add support for COMPILE_TEST
commit: 318b8a09f295cbf86fd504bcff3769b1fc4a936b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] regulator: fan53880: Add support for COMPILE_TEST
@ 2020-07-07 14:17 ` Mark Brown
0 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2020-07-07 14:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
On Tue, 07 Jul 2020 12:57:31 +0200, Christoph Fritz wrote:
> This patch adds support for COMPILE_TEST while fixing a warning when
> no support for device tree is there.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: fan53880: Add support for COMPILE_TEST
commit: 318b8a09f295cbf86fd504bcff3769b1fc4a936b
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-07 14:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 6:23 [regulator:for-5.9 36/39] drivers/regulator/fan53880.c:155:34: warning: unused variable 'fan53880_dt_ids' kernel test robot
2020-07-07 9:03 ` [PATCH] regulator: fan53880: fix Kconfig dependency Christoph Fritz
2020-07-07 10:20 ` Mark Brown
2020-07-07 10:20 ` Mark Brown
2020-07-07 10:57 ` [PATCH] regulator: fan53880: Add support for COMPILE_TEST Christoph Fritz
2020-07-07 14:17 ` Mark Brown
2020-07-07 14:17 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.