* [linux-nvme:nvme-5.9 34/40] drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be
@ 2020-07-07 10:50 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-07-07 10:50 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: kbuild-all, Christoph Hellwig, linux-nvme
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
tree: git://git.infradead.org/nvme.git nvme-5.9
head: f6fef27de378d96ea545d8125ab72102cac954c9
commit: 3be72d5b2ac2332319f86c0a22e514e0054100fc [34/40] nvme: expose reconnect_delay and ctrl_loss_tmo via sysfs
config: i386-randconfig-s001-20200707 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-31-gabbfd661-dirty
git checkout 3be72d5b2ac2332319f86c0a22e514e0054100fc
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be static?
drivers/nvme/host/core.c:1569:16: sparse: sparse: context imbalance in 'nvme_get_ns_from_disk' - wrong count at exit
include/linux/srcu.h:179:9: sparse: sparse: context imbalance in 'nvme_put_ns_from_disk' - unexpected unlock
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32265 bytes --]
[-- Attachment #3: Type: text/plain, Size: 158 bytes --]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-nvme:nvme-5.9 34/40] drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be
@ 2020-07-07 10:50 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-07-07 10:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
tree: git://git.infradead.org/nvme.git nvme-5.9
head: f6fef27de378d96ea545d8125ab72102cac954c9
commit: 3be72d5b2ac2332319f86c0a22e514e0054100fc [34/40] nvme: expose reconnect_delay and ctrl_loss_tmo via sysfs
config: i386-randconfig-s001-20200707 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-31-gabbfd661-dirty
git checkout 3be72d5b2ac2332319f86c0a22e514e0054100fc
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be static?
drivers/nvme/host/core.c:1569:16: sparse: sparse: context imbalance in 'nvme_get_ns_from_disk' - wrong count at exit
include/linux/srcu.h:179:9: sparse: sparse: context imbalance in 'nvme_put_ns_from_disk' - unexpected unlock
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32265 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH linux-nvme] nvme: dev_attr_ctrl_loss_tmo can be static
2020-07-07 10:50 ` kernel test robot
@ 2020-07-07 10:50 ` kernel test robot
-1 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-07-07 10:50 UTC (permalink / raw)
To: Sagi Grimberg; +Cc: kbuild-all, Christoph Hellwig, linux-nvme
Fixes: 3be72d5b2ac2 ("nvme: expose reconnect_delay and ctrl_loss_tmo via sysfs")
Signed-off-by: kernel test robot <lkp@intel.com>
---
core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 9de93298bd81b..088608714451f 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3564,7 +3564,7 @@ static ssize_t nvme_ctrl_loss_tmo_store(struct device *dev,
opts->reconnect_delay);
return count;
}
-DEVICE_ATTR(ctrl_loss_tmo, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(ctrl_loss_tmo, S_IRUGO | S_IWUSR,
nvme_ctrl_loss_tmo_show, nvme_ctrl_loss_tmo_store);
static ssize_t nvme_ctrl_reconnect_delay_show(struct device *dev,
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFC PATCH linux-nvme] nvme: dev_attr_ctrl_loss_tmo can be static
@ 2020-07-07 10:50 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2020-07-07 10:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
Fixes: 3be72d5b2ac2 ("nvme: expose reconnect_delay and ctrl_loss_tmo via sysfs")
Signed-off-by: kernel test robot <lkp@intel.com>
---
core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 9de93298bd81b..088608714451f 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3564,7 +3564,7 @@ static ssize_t nvme_ctrl_loss_tmo_store(struct device *dev,
opts->reconnect_delay);
return count;
}
-DEVICE_ATTR(ctrl_loss_tmo, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(ctrl_loss_tmo, S_IRUGO | S_IWUSR,
nvme_ctrl_loss_tmo_show, nvme_ctrl_loss_tmo_store);
static ssize_t nvme_ctrl_reconnect_delay_show(struct device *dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [linux-nvme:nvme-5.9 34/40] drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be
2020-07-07 10:50 ` kernel test robot
@ 2020-07-07 10:55 ` Christoph Hellwig
-1 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2020-07-07 10:55 UTC (permalink / raw)
To: kernel test robot
Cc: kbuild-all, Sagi Grimberg, linux-nvme, Christoph Hellwig
Fixed and force-pushed.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-nvme:nvme-5.9 34/40] drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be
@ 2020-07-07 10:55 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2020-07-07 10:55 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 23 bytes --]
Fixed and force-pushed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-07 10:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 10:50 [linux-nvme:nvme-5.9 34/40] drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be kernel test robot
2020-07-07 10:50 ` kernel test robot
2020-07-07 10:50 ` [RFC PATCH linux-nvme] nvme: dev_attr_ctrl_loss_tmo can be static kernel test robot
2020-07-07 10:50 ` kernel test robot
2020-07-07 10:55 ` [linux-nvme:nvme-5.9 34/40] drivers/nvme/host/core.c:3567:1: sparse: sparse: symbol 'dev_attr_ctrl_loss_tmo' was not declared. Should it be Christoph Hellwig
2020-07-07 10:55 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.