All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
Cc: geert@linux-m68k.org, lukas@wunner.de,
	kernel test robot <lkp@intel.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.
Date: Tue, 7 Jul 2020 12:21:44 +0100	[thread overview]
Message-ID: <20200707112144.GH4870@sirena.org.uk> (raw)
In-Reply-To: <0072bb03-d6ec-38b8-0c31-61571b77bf93@fastree3d.com>

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

On Tue, Jul 07, 2020 at 12:53:38PM +0200, Adrian Fiergolski wrote:
> On 06.07.2020 18:18, Mark Brown wrote:
> > On Mon, Jul 06, 2020 at 11:22:43AM +0200, Adrian Fiergolski wrote:

> > this.  Perhaps this needs to be a library for devices that can daisy
> > chain?  It does feel like the instances should be aware of each other
> > since half the point with building the hardware like this is that it
> > enables operations on multiple devices to happen in sync.

> Well, I assume that one can connect completely different SPI devices on
> a single daisy chain. In order to address all devices in a single
> access, a controller would need to delay a transaction, wait for a
> certain moment (how long?), synchronise and then transfer the message. I
> think it adds unnecessary complexity, as MHO many engineers' issue at

I'd imagine something more like regmap's explicit management with
pausing and unpausing transactions (indeed regmap might be a good
mechanism for this for devices with a register map) would not be that
cumbersome to use.  Pause, set the desired target state and then sync
that state out to the hardware.  This isn't something that can sensibly
be done at the controller level, the devices do need to be aware of
what's going on, which is why I'm saying that there's a need for the
devices to be aware of things.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2020-07-07 11:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 14:12 [PATCH 1/2] spi: Add the SPI daisy chain support Adrian Fiergolski
2020-07-03 14:12 ` [PATCH 2/2] dt-bindings: Add documentation for SPI daisy chain driver Adrian Fiergolski
2020-07-03 22:32 ` [PATCH 1/2] spi: Add the SPI daisy chain support kernel test robot
2020-07-03 22:32   ` kernel test robot
2020-07-04  0:18 ` kernel test robot
2020-07-04  0:18   ` kernel test robot
2020-07-06  9:22   ` [PATCH v2 " Adrian Fiergolski
2020-07-06  9:22     ` [PATCH v2 2/2] dt-bindings: Add documentation for SPI daisy chain driver Adrian Fiergolski
2020-07-06 15:10       ` Geert Uytterhoeven
2020-07-06 15:19         ` Adrian Fiergolski
2020-07-06 15:32           ` Geert Uytterhoeven
2020-07-06 16:22             ` Mark Brown
2020-07-07  9:55               ` Adrian Fiergolski
2020-07-06 16:18     ` [PATCH v2 1/2] spi: Add the SPI daisy chain support Mark Brown
2020-07-06 19:57       ` Geert Uytterhoeven
2020-07-07 10:25         ` Mark Brown
2020-07-07 11:06           ` Adrian Fiergolski
2020-07-07 10:53       ` Adrian Fiergolski
2020-07-07 11:21         ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707112144.GH4870@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=adrian.fiergolski@fastree3d.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lukas@wunner.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.