All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
Cc: kbuild-all@lists.01.org, geert@linux-m68k.org, lukas@wunner.de,
	Adrian Fiergolski <adrian.fiergolski@fastree3d.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: Add the SPI daisy chain support.
Date: Sat, 4 Jul 2020 08:18:28 +0800	[thread overview]
Message-ID: <202007040833.xIqR5rAw%lkp@intel.com> (raw)
In-Reply-To: <20200703141246.17281-1-adrian.fiergolski@fastree3d.com>

[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]

Hi Adrian,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on spi/for-next]
[also build test WARNING on v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Adrian-Fiergolski/spi-Add-the-SPI-daisy-chain-support/20200703-221615
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/spi/spi-daisy_chain.c:232:6: warning: no previous prototype for 'spi_daisy_chain_clean' [-Wmissing-prototypes]
     232 | void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
         |      ^~~~~~~~~~~~~~~~~~~~~

vim +/spi_daisy_chain_clean +232 drivers/spi/spi-daisy_chain.c

   231	
 > 232	void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
   233	{
   234		struct spi_device *spi_dev;
   235		struct spi_daisy_chain_device *spi_chain_dev;
   236	
   237		list_for_each_entry(spi_chain_dev, daisy_chain_devs, devices) {
   238			spi_dev = spi_chain_dev->spi;
   239			spi_dev_put(spi_dev);
   240			kfree(spi_chain_dev->no_operation.tx_buf);
   241			kfree(spi_chain_dev);
   242		}
   243		list_del(daisy_chain_devs);
   244		kfree(daisy_chain_devs);
   245	}
   246	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65351 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/2] spi: Add the SPI daisy chain support.
Date: Sat, 04 Jul 2020 08:18:28 +0800	[thread overview]
Message-ID: <202007040833.xIqR5rAw%lkp@intel.com> (raw)
In-Reply-To: <20200703141246.17281-1-adrian.fiergolski@fastree3d.com>

[-- Attachment #1: Type: text/plain, Size: 2065 bytes --]

Hi Adrian,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on spi/for-next]
[also build test WARNING on v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Adrian-Fiergolski/spi-Add-the-SPI-daisy-chain-support/20200703-221615
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/spi/spi-daisy_chain.c:232:6: warning: no previous prototype for 'spi_daisy_chain_clean' [-Wmissing-prototypes]
     232 | void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
         |      ^~~~~~~~~~~~~~~~~~~~~

vim +/spi_daisy_chain_clean +232 drivers/spi/spi-daisy_chain.c

   231	
 > 232	void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
   233	{
   234		struct spi_device *spi_dev;
   235		struct spi_daisy_chain_device *spi_chain_dev;
   236	
   237		list_for_each_entry(spi_chain_dev, daisy_chain_devs, devices) {
   238			spi_dev = spi_chain_dev->spi;
   239			spi_dev_put(spi_dev);
   240			kfree(spi_chain_dev->no_operation.tx_buf);
   241			kfree(spi_chain_dev);
   242		}
   243		list_del(daisy_chain_devs);
   244		kfree(daisy_chain_devs);
   245	}
   246	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65351 bytes --]

  parent reply	other threads:[~2020-07-04  1:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 14:12 [PATCH 1/2] spi: Add the SPI daisy chain support Adrian Fiergolski
2020-07-03 14:12 ` [PATCH 2/2] dt-bindings: Add documentation for SPI daisy chain driver Adrian Fiergolski
2020-07-03 22:32 ` [PATCH 1/2] spi: Add the SPI daisy chain support kernel test robot
2020-07-03 22:32   ` kernel test robot
2020-07-04  0:18 ` kernel test robot [this message]
2020-07-04  0:18   ` kernel test robot
2020-07-06  9:22   ` [PATCH v2 " Adrian Fiergolski
2020-07-06  9:22     ` [PATCH v2 2/2] dt-bindings: Add documentation for SPI daisy chain driver Adrian Fiergolski
2020-07-06 15:10       ` Geert Uytterhoeven
2020-07-06 15:19         ` Adrian Fiergolski
2020-07-06 15:32           ` Geert Uytterhoeven
2020-07-06 16:22             ` Mark Brown
2020-07-07  9:55               ` Adrian Fiergolski
2020-07-06 16:18     ` [PATCH v2 1/2] spi: Add the SPI daisy chain support Mark Brown
2020-07-06 19:57       ` Geert Uytterhoeven
2020-07-07 10:25         ` Mark Brown
2020-07-07 11:06           ` Adrian Fiergolski
2020-07-07 10:53       ` Adrian Fiergolski
2020-07-07 11:21         ` Mark Brown
2020-07-15 23:05 [PATCH " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202007040833.xIqR5rAw%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=adrian.fiergolski@fastree3d.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.