* [PATCH] sunxi-csi: fill in bus_info of media device
@ 2020-07-07 13:10 Hans Verkuil
2020-07-07 13:21 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2020-07-07 13:10 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Maxime Ripard, Yong Deng
This fixes a v4l2-compliance warning:
Required ioctls:
warn: v4l2-test-media.cpp(52): empty bus_info
test MEDIA_IOC_DEVICE_INFO: OK
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c | 2 ++
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c
index eff34ded6305..5319eb1ab309 100644
--- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c
+++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c
@@ -191,6 +191,8 @@ static int sun4i_csi_probe(struct platform_device *pdev)
strscpy(csi->mdev.model, "Allwinner Video Capture Device",
sizeof(csi->mdev.model));
csi->mdev.hw_revision = 0;
+ snprintf(csi->mdev.bus_info, sizeof(csi->mdev.bus_info), "platform:%s",
+ dev_name(csi->dev));
media_device_init(&csi->mdev);
csi->v4l.mdev = &csi->mdev;
diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
index 055eb0b8e396..28e89340fed9 100644
--- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
+++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
@@ -733,6 +733,8 @@ static int sun6i_csi_v4l2_init(struct sun6i_csi *csi)
strscpy(csi->media_dev.model, "Allwinner Video Capture Device",
sizeof(csi->media_dev.model));
csi->media_dev.hw_revision = 0;
+ snprintf(csi->media_dev.bus_info, sizeof(csi->media_dev.bus_info),
+ "platform:%s", dev_name(csi->dev));
media_device_init(&csi->media_dev);
v4l2_async_notifier_init(&csi->notifier);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sunxi-csi: fill in bus_info of media device
2020-07-07 13:10 [PATCH] sunxi-csi: fill in bus_info of media device Hans Verkuil
@ 2020-07-07 13:21 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-07-07 13:21 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List, Yong Deng
On Tue, Jul 07, 2020 at 03:10:15PM +0200, Hans Verkuil wrote:
> This fixes a v4l2-compliance warning:
>
> Required ioctls:
> warn: v4l2-test-media.cpp(52): empty bus_info
> test MEDIA_IOC_DEVICE_INFO: OK
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-07 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 13:10 [PATCH] sunxi-csi: fill in bus_info of media device Hans Verkuil
2020-07-07 13:21 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.