* [PATCH] dm zoned: assign max_io_len correctly
@ 2020-06-30 4:00 Damien Le Moal
2020-06-30 6:18 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Damien Le Moal @ 2020-06-30 4:00 UTC (permalink / raw)
To: stable, Greg Kroah-Hartman; +Cc: Mike Snitzer
From: Hou Tao <houtao1@huawei.com>
commit 7b2377486767503d47265e4d487a63c651f6b55d upstream.
The unit of max_io_len is sector instead of byte (spotted through
code review), so fix it.
Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
Cc: stable@vger.kernel.org
Signed-off-by: Hou Tao <houtao1@huawei.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm-zoned-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
index f4f83d39b3dc..29881fea6acb 100644
--- a/drivers/md/dm-zoned-target.c
+++ b/drivers/md/dm-zoned-target.c
@@ -790,7 +790,7 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv)
}
/* Set target (no write same support) */
- ti->max_io_len = dev->zone_nr_sectors << 9;
+ ti->max_io_len = dev->zone_nr_sectors;
ti->num_flush_bios = 1;
ti->num_discard_bios = 1;
ti->num_write_zeroes_bios = 1;
--
2.26.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] dm zoned: assign max_io_len correctly
2020-06-30 4:00 [PATCH] dm zoned: assign max_io_len correctly Damien Le Moal
@ 2020-06-30 6:18 ` Greg Kroah-Hartman
2020-06-30 6:20 ` Damien Le Moal
0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2020-06-30 6:18 UTC (permalink / raw)
To: Damien Le Moal; +Cc: stable, Mike Snitzer
On Tue, Jun 30, 2020 at 01:00:47PM +0900, Damien Le Moal wrote:
> From: Hou Tao <houtao1@huawei.com>
>
> commit 7b2377486767503d47265e4d487a63c651f6b55d upstream.
>
> The unit of max_io_len is sector instead of byte (spotted through
> code review), so fix it.
>
> Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> ---
> drivers/md/dm-zoned-target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
What stable tree(s) is this for?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dm zoned: assign max_io_len correctly
2020-06-30 6:18 ` Greg Kroah-Hartman
@ 2020-06-30 6:20 ` Damien Le Moal
2020-06-30 8:20 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Damien Le Moal @ 2020-06-30 6:20 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: stable, Mike Snitzer
On 2020/06/30 15:18, Greg Kroah-Hartman wrote:
> On Tue, Jun 30, 2020 at 01:00:47PM +0900, Damien Le Moal wrote:
>> From: Hou Tao <houtao1@huawei.com>
>>
>> commit 7b2377486767503d47265e4d487a63c651f6b55d upstream.
>>
>> The unit of max_io_len is sector instead of byte (spotted through
>> code review), so fix it.
>>
>> Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Hou Tao <houtao1@huawei.com>
>> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
>> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>> ---
>> drivers/md/dm-zoned-target.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> What stable tree(s) is this for?
>
5.7, 5.4, 4.19 and 4.14.
Got the automated email that the patch was not applying so I sent this corrected
version. I sent you a separate note about this.
Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dm zoned: assign max_io_len correctly
2020-06-30 6:20 ` Damien Le Moal
@ 2020-06-30 8:20 ` Greg Kroah-Hartman
2020-07-01 0:36 ` Damien Le Moal
0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2020-06-30 8:20 UTC (permalink / raw)
To: Damien Le Moal; +Cc: stable, Mike Snitzer
On Tue, Jun 30, 2020 at 06:20:58AM +0000, Damien Le Moal wrote:
> On 2020/06/30 15:18, Greg Kroah-Hartman wrote:
> > On Tue, Jun 30, 2020 at 01:00:47PM +0900, Damien Le Moal wrote:
> >> From: Hou Tao <houtao1@huawei.com>
> >>
> >> commit 7b2377486767503d47265e4d487a63c651f6b55d upstream.
> >>
> >> The unit of max_io_len is sector instead of byte (spotted through
> >> code review), so fix it.
> >>
> >> Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Hou Tao <houtao1@huawei.com>
> >> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
> >> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> >> ---
> >> drivers/md/dm-zoned-target.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > What stable tree(s) is this for?
> >
>
> 5.7, 5.4, 4.19 and 4.14.
>
> Got the automated email that the patch was not applying so I sent this corrected
> version. I sent you a separate note about this.
Yes, but given the huge email flow, you need to be specific as your
response there was seen about an hour after this email due to them not
being threaded/attached/whatever :)
thanks,
gre gk-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dm zoned: assign max_io_len correctly
2020-06-30 8:20 ` Greg Kroah-Hartman
@ 2020-07-01 0:36 ` Damien Le Moal
2020-07-07 14:05 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Damien Le Moal @ 2020-07-01 0:36 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: stable, Mike Snitzer
On 2020/06/30 17:20, Greg Kroah-Hartman wrote:
> On Tue, Jun 30, 2020 at 06:20:58AM +0000, Damien Le Moal wrote:
>> On 2020/06/30 15:18, Greg Kroah-Hartman wrote:
>>> On Tue, Jun 30, 2020 at 01:00:47PM +0900, Damien Le Moal wrote:
>>>> From: Hou Tao <houtao1@huawei.com>
>>>>
>>>> commit 7b2377486767503d47265e4d487a63c651f6b55d upstream.
>>>>
>>>> The unit of max_io_len is sector instead of byte (spotted through
>>>> code review), so fix it.
>>>>
>>>> Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
>>>> Cc: stable@vger.kernel.org
>>>> Signed-off-by: Hou Tao <houtao1@huawei.com>
>>>> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
>>>> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>>>> ---
>>>> drivers/md/dm-zoned-target.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> What stable tree(s) is this for?
>>>
>>
>> 5.7, 5.4, 4.19 and 4.14.
>>
>> Got the automated email that the patch was not applying so I sent this corrected
>> version. I sent you a separate note about this.
>
> Yes, but given the huge email flow, you need to be specific as your
> response there was seen about an hour after this email due to them not
> being threaded/attached/whatever :)
Greg,
Sorry about that. I will make sure to be more clear with a cover letter next
time. Thanks !
>
> thanks,
>
> gre gk-h
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dm zoned: assign max_io_len correctly
2020-07-01 0:36 ` Damien Le Moal
@ 2020-07-07 14:05 ` Greg Kroah-Hartman
0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-07 14:05 UTC (permalink / raw)
To: Damien Le Moal; +Cc: stable, Mike Snitzer
On Wed, Jul 01, 2020 at 12:36:49AM +0000, Damien Le Moal wrote:
> On 2020/06/30 17:20, Greg Kroah-Hartman wrote:
> > On Tue, Jun 30, 2020 at 06:20:58AM +0000, Damien Le Moal wrote:
> >> On 2020/06/30 15:18, Greg Kroah-Hartman wrote:
> >>> On Tue, Jun 30, 2020 at 01:00:47PM +0900, Damien Le Moal wrote:
> >>>> From: Hou Tao <houtao1@huawei.com>
> >>>>
> >>>> commit 7b2377486767503d47265e4d487a63c651f6b55d upstream.
> >>>>
> >>>> The unit of max_io_len is sector instead of byte (spotted through
> >>>> code review), so fix it.
> >>>>
> >>>> Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
> >>>> Cc: stable@vger.kernel.org
> >>>> Signed-off-by: Hou Tao <houtao1@huawei.com>
> >>>> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
> >>>> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> >>>> ---
> >>>> drivers/md/dm-zoned-target.c | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> What stable tree(s) is this for?
> >>>
> >>
> >> 5.7, 5.4, 4.19 and 4.14.
> >>
> >> Got the automated email that the patch was not applying so I sent this corrected
> >> version. I sent you a separate note about this.
> >
> > Yes, but given the huge email flow, you need to be specific as your
> > response there was seen about an hour after this email due to them not
> > being threaded/attached/whatever :)
>
> Greg,
>
> Sorry about that. I will make sure to be more clear with a cover letter next
> time. Thanks !
Not a problem, now queued up!
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dm zoned: assign max_io_len correctly
2020-06-15 3:33 Hou Tao
@ 2020-06-15 23:32 ` Damien Le Moal
0 siblings, 0 replies; 8+ messages in thread
From: Damien Le Moal @ 2020-06-15 23:32 UTC (permalink / raw)
To: Hou Tao, dm-devel
Cc: Hannes Reinecke, Alasdair Kergon, Mike Snitzer, Bart Van Assche
On 2020/06/15 12:26, Hou Tao wrote:
> The unit of max_io_len is sector instead of byte (spotted through
> code review), so fix it.
>
> Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
> drivers/md/dm-zoned-target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
> index a907a9446c0b..cf915009c306 100644
> --- a/drivers/md/dm-zoned-target.c
> +++ b/drivers/md/dm-zoned-target.c
> @@ -890,7 +890,7 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv)
> }
>
> /* Set target (no write same support) */
> - ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata) << 9;
> + ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata);
> ti->num_flush_bios = 1;
> ti->num_discard_bios = 1;
> ti->num_write_zeroes_bios = 1;
>
Good catch !
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] dm zoned: assign max_io_len correctly
@ 2020-06-15 3:33 Hou Tao
2020-06-15 23:32 ` Damien Le Moal
0 siblings, 1 reply; 8+ messages in thread
From: Hou Tao @ 2020-06-15 3:33 UTC (permalink / raw)
To: dm-devel
Cc: Bart Van Assche, Damien Le Moal, Alasdair Kergon, Mike Snitzer,
Hannes Reinecke
The unit of max_io_len is sector instead of byte (spotted through
code review), so fix it.
Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
Signed-off-by: Hou Tao <houtao1@huawei.com>
---
drivers/md/dm-zoned-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
index a907a9446c0b..cf915009c306 100644
--- a/drivers/md/dm-zoned-target.c
+++ b/drivers/md/dm-zoned-target.c
@@ -890,7 +890,7 @@ static int dmz_ctr(struct dm_target *ti, unsigned int argc, char **argv)
}
/* Set target (no write same support) */
- ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata) << 9;
+ ti->max_io_len = dmz_zone_nr_sectors(dmz->metadata);
ti->num_flush_bios = 1;
ti->num_discard_bios = 1;
ti->num_write_zeroes_bios = 1;
--
2.25.0.4.g0ad7144999
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-07 14:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-30 4:00 [PATCH] dm zoned: assign max_io_len correctly Damien Le Moal
2020-06-30 6:18 ` Greg Kroah-Hartman
2020-06-30 6:20 ` Damien Le Moal
2020-06-30 8:20 ` Greg Kroah-Hartman
2020-07-01 0:36 ` Damien Le Moal
2020-07-07 14:05 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2020-06-15 3:33 Hou Tao
2020-06-15 23:32 ` Damien Le Moal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.