* [gustavoars-linux:testing/fallthrough 205/560] drivers/hwmon/adt7462.c:438 voltage_label() warn: ignoring unreachable code.
@ 2020-07-07 14:39 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-07-07 14:39 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 14921 bytes --]
[ resending with correct from address. - dan ]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/fallthrough
head: d7f10c2411ed9283df8d763139de9468b88c89ce
commit: 936bc6b322737561b669cef7c243bdbcb72b0550 [205/560] hwmon: Use fallthrough pseudo-keyword
config: arm-randconfig-m031-20200701 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/hwmon/adt7462.c:438 voltage_label() warn: ignoring unreachable code.
drivers/hwmon/adt7462.c:534 voltage_multiplier() warn: ignoring unreachable code.
Old smatch warnings:
drivers/hwmon/adt7462.c:496 voltage_label() warn: ignoring unreachable code.
drivers/hwmon/adt7462.c:592 voltage_multiplier() warn: ignoring unreachable code.
# https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?id=936bc6b322737561b669cef7c243bdbcb72b0550
git remote add gustavoars-linux https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
git remote update gustavoars-linux
git checkout 936bc6b322737561b669cef7c243bdbcb72b0550
vim +438 drivers/hwmon/adt7462.c
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 419 /* Provide labels for sysfs */
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 420 static const char *voltage_label(struct adt7462_data *data, int which)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 421 {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 422 switch (which) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 423 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 424 if (!(data->pin_cfg[0] & ADT7462_PIN7_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 425 return "+12V1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 426 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 427 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 428 switch (MASK_AND_SHIFT(data->pin_cfg[1], ADT7462_PIN23)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 429 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 430 return "Vccp1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 431 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 432 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 433 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 434 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 435 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 436 return "+1.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 437 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 @438 fallthrough;
I feel like putting fallthrough here is misleading if it's unreachable.
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 439 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 440 if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 441 return "+12V3";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 442 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 443 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 444 if (!(data->pin_cfg[1] & ADT7462_PIN21_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 445 return "+5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 446 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 447 case 4:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 448 if (!(data->pin_cfg[0] & ADT7462_DIODE3_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 449 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 450 return "+0.9V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 451 return "+1.25V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 452 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 453 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 454 case 5:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 455 if (!(data->pin_cfg[0] & ADT7462_DIODE1_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 456 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 457 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 458 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 459 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 460 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 461 case 6:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 462 if (!(data->pin_cfg[1] & ADT7462_PIN13_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 463 return "+3.3V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 464 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 465 case 7:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 466 if (!(data->pin_cfg[1] & ADT7462_PIN8_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 467 return "+12V2";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 468 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 469 case 8:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 470 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN26)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 471 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 472 return "Vbatt";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 473 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 474 return "FSB_Vtt";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 475 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 476 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 477 case 9:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 478 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN25)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 479 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 480 return "+3.3V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 481 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 482 return "+1.2V1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 483 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 484 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 485 case 10:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 486 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN24)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 487 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 488 return "Vccp2";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 489 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 490 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 491 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 492 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 493 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 494 return "+1.5";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 495 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 496 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 497 case 11:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 498 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 499 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 500 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 501 return "+1.5V ICH";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 502 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 503 case 12:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 504 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 505 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 506 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 507 return "+1.5V 3GPIO";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 508 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 509 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 510 return "N/A";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 511 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 512
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 513 /* Multipliers are actually in uV, not mV. */
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 514 static int voltage_multiplier(struct adt7462_data *data, int which)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 515 {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 516 switch (which) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 517 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 518 if (!(data->pin_cfg[0] & ADT7462_PIN7_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 519 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 520 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 521 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 522 switch (MASK_AND_SHIFT(data->pin_cfg[1], ADT7462_PIN23)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 523 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 524 if (data->pin_cfg[0] & ADT7462_VID_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 525 return 12500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 526 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 527 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 528 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 529 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 530 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 531 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 532 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 533 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 @534 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 535 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 536 if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 537 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 538 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 539 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 540 if (!(data->pin_cfg[1] & ADT7462_PIN21_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 541 return 26000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 542 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 543 case 4:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 544 if (!(data->pin_cfg[0] & ADT7462_DIODE3_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 545 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 546 return 4690;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 547 return 6500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 548 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 549 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 550 case 5:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 551 if (!(data->pin_cfg[0] & ADT7462_DIODE1_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 552 if (data->pin_cfg[1] & ADT7462_PIN15_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 553 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 554 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 555 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 556 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 557 case 6:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 558 if (!(data->pin_cfg[1] & ADT7462_PIN13_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 559 return 17200;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 560 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 561 case 7:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 562 if (!(data->pin_cfg[1] & ADT7462_PIN8_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 563 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 564 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 565 case 8:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 566 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN26)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 567 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 568 return 15600;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 569 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 570 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 571 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 572 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 573 case 9:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 574 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN25)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 575 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 576 return 17200;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 577 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 578 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 579 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 580 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 581 case 10:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 582 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN24)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 583 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 584 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 585 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 586 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 587 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 588 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 589 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 590 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 591 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 592 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 593 case 11:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 594 case 12:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 595 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 596 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 597 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 598 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 599 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 600 return 0;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 601 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 602
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27417 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [gustavoars-linux:testing/fallthrough 205/560] drivers/hwmon/adt7462.c:438 voltage_label() warn: ignoring unreachable code.
@ 2020-07-07 14:39 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-07-07 14:39 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 14921 bytes --]
[ resending with correct from address. - dan ]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/fallthrough
head: d7f10c2411ed9283df8d763139de9468b88c89ce
commit: 936bc6b322737561b669cef7c243bdbcb72b0550 [205/560] hwmon: Use fallthrough pseudo-keyword
config: arm-randconfig-m031-20200701 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/hwmon/adt7462.c:438 voltage_label() warn: ignoring unreachable code.
drivers/hwmon/adt7462.c:534 voltage_multiplier() warn: ignoring unreachable code.
Old smatch warnings:
drivers/hwmon/adt7462.c:496 voltage_label() warn: ignoring unreachable code.
drivers/hwmon/adt7462.c:592 voltage_multiplier() warn: ignoring unreachable code.
# https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?id=936bc6b322737561b669cef7c243bdbcb72b0550
git remote add gustavoars-linux https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
git remote update gustavoars-linux
git checkout 936bc6b322737561b669cef7c243bdbcb72b0550
vim +438 drivers/hwmon/adt7462.c
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 419 /* Provide labels for sysfs */
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 420 static const char *voltage_label(struct adt7462_data *data, int which)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 421 {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 422 switch (which) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 423 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 424 if (!(data->pin_cfg[0] & ADT7462_PIN7_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 425 return "+12V1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 426 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 427 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 428 switch (MASK_AND_SHIFT(data->pin_cfg[1], ADT7462_PIN23)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 429 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 430 return "Vccp1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 431 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 432 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 433 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 434 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 435 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 436 return "+1.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 437 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 @438 fallthrough;
I feel like putting fallthrough here is misleading if it's unreachable.
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 439 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 440 if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 441 return "+12V3";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 442 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 443 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 444 if (!(data->pin_cfg[1] & ADT7462_PIN21_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 445 return "+5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 446 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 447 case 4:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 448 if (!(data->pin_cfg[0] & ADT7462_DIODE3_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 449 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 450 return "+0.9V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 451 return "+1.25V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 452 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 453 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 454 case 5:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 455 if (!(data->pin_cfg[0] & ADT7462_DIODE1_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 456 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 457 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 458 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 459 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 460 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 461 case 6:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 462 if (!(data->pin_cfg[1] & ADT7462_PIN13_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 463 return "+3.3V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 464 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 465 case 7:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 466 if (!(data->pin_cfg[1] & ADT7462_PIN8_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 467 return "+12V2";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 468 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 469 case 8:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 470 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN26)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 471 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 472 return "Vbatt";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 473 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 474 return "FSB_Vtt";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 475 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 476 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 477 case 9:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 478 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN25)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 479 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 480 return "+3.3V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 481 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 482 return "+1.2V1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 483 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 484 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 485 case 10:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 486 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN24)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 487 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 488 return "Vccp2";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 489 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 490 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 491 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 492 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 493 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 494 return "+1.5";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 495 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 496 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 497 case 11:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 498 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 499 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 500 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 501 return "+1.5V ICH";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 502 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 503 case 12:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 504 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 505 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 506 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 507 return "+1.5V 3GPIO";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 508 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 509 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 510 return "N/A";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 511 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 512
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 513 /* Multipliers are actually in uV, not mV. */
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 514 static int voltage_multiplier(struct adt7462_data *data, int which)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 515 {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 516 switch (which) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 517 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 518 if (!(data->pin_cfg[0] & ADT7462_PIN7_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 519 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 520 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 521 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 522 switch (MASK_AND_SHIFT(data->pin_cfg[1], ADT7462_PIN23)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 523 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 524 if (data->pin_cfg[0] & ADT7462_VID_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 525 return 12500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 526 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 527 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 528 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 529 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 530 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 531 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 532 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 533 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 @534 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 535 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 536 if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 537 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 538 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 539 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 540 if (!(data->pin_cfg[1] & ADT7462_PIN21_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 541 return 26000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 542 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 543 case 4:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 544 if (!(data->pin_cfg[0] & ADT7462_DIODE3_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 545 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 546 return 4690;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 547 return 6500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 548 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 549 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 550 case 5:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 551 if (!(data->pin_cfg[0] & ADT7462_DIODE1_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 552 if (data->pin_cfg[1] & ADT7462_PIN15_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 553 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 554 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 555 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 556 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 557 case 6:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 558 if (!(data->pin_cfg[1] & ADT7462_PIN13_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 559 return 17200;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 560 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 561 case 7:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 562 if (!(data->pin_cfg[1] & ADT7462_PIN8_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 563 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 564 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 565 case 8:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 566 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN26)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 567 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 568 return 15600;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 569 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 570 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 571 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 572 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 573 case 9:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 574 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN25)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 575 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 576 return 17200;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 577 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 578 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 579 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 580 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 581 case 10:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 582 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN24)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 583 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 584 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 585 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 586 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 587 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 588 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 589 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 590 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 591 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 592 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 593 case 11:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 594 case 12:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 595 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 596 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 597 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 598 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 599 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 600 return 0;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 601 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 602
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27417 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [gustavoars-linux:testing/fallthrough 205/560] drivers/hwmon/adt7462.c:438 voltage_label() warn: ignoring unreachable code.
@ 2020-07-03 7:41 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-07-03 7:41 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 15000 bytes --]
CC: kbuild-all(a)lists.01.org
TO: "Gustavo A. R. Silva" <gustavoars@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/fallthrough
head: d7f10c2411ed9283df8d763139de9468b88c89ce
commit: 936bc6b322737561b669cef7c243bdbcb72b0550 [205/560] hwmon: Use fallthrough pseudo-keyword
:::::: branch date: 10 hours ago
:::::: commit date: 10 hours ago
config: arm-randconfig-m031-20200701 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/hwmon/adt7462.c:438 voltage_label() warn: ignoring unreachable code.
drivers/hwmon/adt7462.c:534 voltage_multiplier() warn: ignoring unreachable code.
Old smatch warnings:
drivers/hwmon/adt7462.c:496 voltage_label() warn: ignoring unreachable code.
drivers/hwmon/adt7462.c:592 voltage_multiplier() warn: ignoring unreachable code.
# https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?id=936bc6b322737561b669cef7c243bdbcb72b0550
git remote add gustavoars-linux https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
git remote update gustavoars-linux
git checkout 936bc6b322737561b669cef7c243bdbcb72b0550
vim +438 drivers/hwmon/adt7462.c
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 418
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 419 /* Provide labels for sysfs */
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 420 static const char *voltage_label(struct adt7462_data *data, int which)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 421 {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 422 switch (which) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 423 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 424 if (!(data->pin_cfg[0] & ADT7462_PIN7_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 425 return "+12V1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 426 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 427 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 428 switch (MASK_AND_SHIFT(data->pin_cfg[1], ADT7462_PIN23)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 429 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 430 return "Vccp1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 431 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 432 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 433 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 434 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 435 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 436 return "+1.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 437 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 @438 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 439 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 440 if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 441 return "+12V3";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 442 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 443 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 444 if (!(data->pin_cfg[1] & ADT7462_PIN21_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 445 return "+5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 446 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 447 case 4:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 448 if (!(data->pin_cfg[0] & ADT7462_DIODE3_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 449 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 450 return "+0.9V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 451 return "+1.25V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 452 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 453 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 454 case 5:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 455 if (!(data->pin_cfg[0] & ADT7462_DIODE1_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 456 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 457 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 458 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 459 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 460 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 461 case 6:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 462 if (!(data->pin_cfg[1] & ADT7462_PIN13_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 463 return "+3.3V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 464 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 465 case 7:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 466 if (!(data->pin_cfg[1] & ADT7462_PIN8_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 467 return "+12V2";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 468 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 469 case 8:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 470 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN26)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 471 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 472 return "Vbatt";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 473 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 474 return "FSB_Vtt";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 475 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 476 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 477 case 9:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 478 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN25)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 479 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 480 return "+3.3V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 481 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 482 return "+1.2V1";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 483 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 484 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 485 case 10:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 486 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN24)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 487 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 488 return "Vccp2";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 489 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 490 return "+2.5V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 491 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 492 return "+1.8V";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 493 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 494 return "+1.5";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 495 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 496 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 497 case 11:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 498 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 499 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 500 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 501 return "+1.5V ICH";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 502 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 503 case 12:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 504 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 505 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 506 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 507 return "+1.5V 3GPIO";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 508 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 509 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 510 return "N/A";
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 511 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 512
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 513 /* Multipliers are actually in uV, not mV. */
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 514 static int voltage_multiplier(struct adt7462_data *data, int which)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 515 {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 516 switch (which) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 517 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 518 if (!(data->pin_cfg[0] & ADT7462_PIN7_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 519 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 520 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 521 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 522 switch (MASK_AND_SHIFT(data->pin_cfg[1], ADT7462_PIN23)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 523 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 524 if (data->pin_cfg[0] & ADT7462_VID_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 525 return 12500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 526 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 527 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 528 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 529 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 530 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 531 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 532 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 533 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 @534 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 535 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 536 if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 537 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 538 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 539 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 540 if (!(data->pin_cfg[1] & ADT7462_PIN21_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 541 return 26000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 542 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 543 case 4:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 544 if (!(data->pin_cfg[0] & ADT7462_DIODE3_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 545 if (data->pin_cfg[1] & ADT7462_PIN19_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 546 return 4690;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 547 return 6500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 548 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 549 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 550 case 5:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 551 if (!(data->pin_cfg[0] & ADT7462_DIODE1_INPUT)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 552 if (data->pin_cfg[1] & ADT7462_PIN15_INPUT)
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 553 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 554 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 555 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 556 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 557 case 6:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 558 if (!(data->pin_cfg[1] & ADT7462_PIN13_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 559 return 17200;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 560 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 561 case 7:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 562 if (!(data->pin_cfg[1] & ADT7462_PIN8_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 563 return 62500;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 564 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 565 case 8:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 566 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN26)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 567 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 568 return 15600;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 569 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 570 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 571 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 572 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 573 case 9:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 574 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN25)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 575 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 576 return 17200;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 577 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 578 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 579 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 580 break;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 581 case 10:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 582 switch (MASK_AND_SHIFT(data->pin_cfg[2], ADT7462_PIN24)) {
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 583 case 0:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 584 return 6250;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 585 case 1:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 586 return 13000;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 587 case 2:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 588 return 9400;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 589 case 3:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 590 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 591 }
936bc6b3227375 Gustavo A. R. Silva 2020-07-02 592 fallthrough;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 593 case 11:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 594 case 12:
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 595 if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 596 ADT7462_PIN28_VOLT &&
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 597 !(data->pin_cfg[0] & ADT7462_VID_INPUT))
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 598 return 7800;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 599 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 600 return 0;
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 601 }
c0b4e3ab0c7699 Darrick J. Wong 2008-11-12 602
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27417 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-07 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 14:39 [gustavoars-linux:testing/fallthrough 205/560] drivers/hwmon/adt7462.c:438 voltage_label() warn: ignoring unreachable code Dan Carpenter
2020-07-07 14:39 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-07-03 7:41 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.