From: Catalin Marinas <catalin.marinas@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Zhenyu Ye <yezhenyu2@huawei.com>,
will@kernel.org, suzuki.poulose@arm.com, steven.price@arm.com,
guohanjun@huawei.com, olof@lixom.net,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, arm@kernel.org, xiexiangyou@huawei.com,
prime.zeng@hisilicon.com, zhangshaokun@hisilicon.com,
kuhn.chenqun@huawei.com
Subject: Re: [RFC PATCH v4 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64
Date: Tue, 7 Jul 2020 18:46:12 +0100 [thread overview]
Message-ID: <20200707174612.GC32331@gaia> (raw)
In-Reply-To: <d26f23960443a7f270847c90242e07ab@kernel.org>
On Tue, Jul 07, 2020 at 06:43:35PM +0100, Marc Zyngier wrote:
> On 2020-07-07 18:36, Catalin Marinas wrote:
> > On Mon, Jun 01, 2020 at 10:47:13PM +0800, Zhenyu Ye wrote:
> > > @@ -59,6 +69,47 @@
> > > __ta; \
> > > })
> > >
> > > +/*
> > > + * __TG defines translation granule of the system, which is decided
> > > by
> > > + * PAGE_SHIFT. Used by TTL.
> > > + * - 4KB : 1
> > > + * - 16KB : 2
> > > + * - 64KB : 3
> > > + */
> > > +#define __TG ((PAGE_SHIFT - 12) / 2 + 1)
> >
> > Nitpick: maybe something like __TLBI_TG to avoid clashes in case someone
> > else defines a __TG macro.
>
> I have commented on this in the past, and still maintain that this
> would be better served by a switch statement similar to what is used
> for TTL already (I don't think this magic formula exists in the
> ARM ARM).
Good point, it would be cleaner indeed.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-arch@vger.kernel.org, suzuki.poulose@arm.com,
Zhenyu Ye <yezhenyu2@huawei.com>,
linux-kernel@vger.kernel.org, xiexiangyou@huawei.com,
steven.price@arm.com, zhangshaokun@hisilicon.com,
linux-mm@kvack.org, arm@kernel.org, prime.zeng@hisilicon.com,
guohanjun@huawei.com, olof@lixom.net, kuhn.chenqun@huawei.com,
will@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v4 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64
Date: Tue, 7 Jul 2020 18:46:12 +0100 [thread overview]
Message-ID: <20200707174612.GC32331@gaia> (raw)
In-Reply-To: <d26f23960443a7f270847c90242e07ab@kernel.org>
On Tue, Jul 07, 2020 at 06:43:35PM +0100, Marc Zyngier wrote:
> On 2020-07-07 18:36, Catalin Marinas wrote:
> > On Mon, Jun 01, 2020 at 10:47:13PM +0800, Zhenyu Ye wrote:
> > > @@ -59,6 +69,47 @@
> > > __ta; \
> > > })
> > >
> > > +/*
> > > + * __TG defines translation granule of the system, which is decided
> > > by
> > > + * PAGE_SHIFT. Used by TTL.
> > > + * - 4KB : 1
> > > + * - 16KB : 2
> > > + * - 64KB : 3
> > > + */
> > > +#define __TG ((PAGE_SHIFT - 12) / 2 + 1)
> >
> > Nitpick: maybe something like __TLBI_TG to avoid clashes in case someone
> > else defines a __TG macro.
>
> I have commented on this in the past, and still maintain that this
> would be better served by a switch statement similar to what is used
> for TTL already (I don't think this magic formula exists in the
> ARM ARM).
Good point, it would be cleaner indeed.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-07 17:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 14:47 [RFC PATCH v3 0/2] arm64: tlb: add support for TLBI RANGE instructions Zhenyu Ye
2020-06-01 14:47 ` Zhenyu Ye
2020-06-01 14:47 ` Zhenyu Ye
2020-06-01 14:47 ` Zhenyu Ye
2020-06-01 14:47 ` [RFC PATCH v4 1/2] arm64: tlb: Detect the ARMv8.4 TLBI RANGE feature Zhenyu Ye
2020-06-01 14:47 ` Zhenyu Ye
2020-06-01 14:47 ` Zhenyu Ye
2020-06-01 14:47 ` Zhenyu Ye
2020-06-01 14:47 ` [RFC PATCH v4 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64 Zhenyu Ye
2020-06-01 14:47 ` Zhenyu Ye
2020-06-01 14:47 ` Zhenyu Ye
2020-06-02 12:06 ` Zhenyu Ye
2020-06-02 12:06 ` Zhenyu Ye
2020-06-02 12:06 ` Zhenyu Ye
2020-07-07 17:36 ` Catalin Marinas
2020-07-07 17:36 ` Catalin Marinas
2020-07-07 17:43 ` Marc Zyngier
2020-07-07 17:43 ` Marc Zyngier
2020-07-07 17:46 ` Catalin Marinas [this message]
2020-07-07 17:46 ` Catalin Marinas
2020-07-07 18:12 ` Robin Murphy
2020-07-07 18:12 ` Robin Murphy
2020-07-08 9:01 ` Zhenyu Ye
2020-07-08 9:01 ` Zhenyu Ye
2020-07-08 9:01 ` Zhenyu Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707174612.GC32331@gaia \
--to=catalin.marinas@arm.com \
--cc=arm@kernel.org \
--cc=guohanjun@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maz@kernel.org \
--cc=olof@lixom.net \
--cc=prime.zeng@hisilicon.com \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=xiexiangyou@huawei.com \
--cc=yezhenyu2@huawei.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.