* [Intel-wired-lan] [PATCH v1 1/1] igc: Fix static checker warning
@ 2020-07-09 7:34 Sasha Neftin
2020-07-21 23:27 ` Brown, Aaron F
0 siblings, 1 reply; 2+ messages in thread
From: Sasha Neftin @ 2020-07-09 7:34 UTC (permalink / raw)
To: intel-wired-lan
drivers/net/ethernet/intel/igc/igc_mac.c:424 igc_check_for_copper_link()
error: uninitialized symbol 'link'.
This patch come to fix this warning and initialize the 'link' symbol.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 707abf069548 ("igc: Add initial LTR support")
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
drivers/net/ethernet/intel/igc/igc_mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c
index 674b8ad21fea..09cd0ec7ee87 100644
--- a/drivers/net/ethernet/intel/igc/igc_mac.c
+++ b/drivers/net/ethernet/intel/igc/igc_mac.c
@@ -355,8 +355,8 @@ void igc_rar_set(struct igc_hw *hw, u8 *addr, u32 index)
s32 igc_check_for_copper_link(struct igc_hw *hw)
{
struct igc_mac_info *mac = &hw->mac;
+ bool link = false;
s32 ret_val;
- bool link;
/* We only want to go out to the PHY registers to see if Auto-Neg
* has completed and/or if our link status has changed. The
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH v1 1/1] igc: Fix static checker warning
2020-07-09 7:34 [Intel-wired-lan] [PATCH v1 1/1] igc: Fix static checker warning Sasha Neftin
@ 2020-07-21 23:27 ` Brown, Aaron F
0 siblings, 0 replies; 2+ messages in thread
From: Brown, Aaron F @ 2020-07-21 23:27 UTC (permalink / raw)
To: intel-wired-lan
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Sasha Neftin
> Sent: Thursday, July 9, 2020 12:34 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH v1 1/1] igc: Fix static checker warning
>
> drivers/net/ethernet/intel/igc/igc_mac.c:424 igc_check_for_copper_link()
> error: uninitialized symbol 'link'.
> This patch come to fix this warning and initialize the 'link' symbol.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 707abf069548 ("igc: Add initial LTR support")
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-21 23:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 7:34 [Intel-wired-lan] [PATCH v1 1/1] igc: Fix static checker warning Sasha Neftin
2020-07-21 23:27 ` Brown, Aaron F
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.