From: Sudeep Holla <sudeep.holla@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Stephen Boyd <sboyd@kernel.org> Cc: Sudeep Holla <sudeep.holla@arm.com>, linux-kernel@vger.kernel.org, Michael Turquette <mturquette@baylibre.com>, Dien Pham <dien.pham.ry@renesas.com> Subject: [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates Date: Thu, 9 Jul 2020 09:17:05 +0100 [thread overview] Message-ID: <20200709081705.46084-2-sudeep.holla@arm.com> (raw) In-Reply-To: <20200709081705.46084-1-sudeep.holla@arm.com> Currently we are not initializing the scmi clock with discrete rates correctly. We fetch the min_rate and max_rate value only for clocks with ranges and ignore the ones with discrete rates. This will lead to wrong initialization of rate range when clock supports discrete rate. Fix this by using the first and the last rate in the sorted list of the discrete clock rates while registering the clock. Link: https://lore.kernel.org/r/20200708110725.18017-2-sudeep.holla@arm.com Fixes: 6d6a1d82eaef7 ("clk: add support for clocks provided by SCMI") Reported-by: Dien Pham <dien.pham.ry@renesas.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/clk/clk-scmi.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) Hi Stephen, If you are fine, I can take this via ARM SoC along with the change in firmware driver. However it is also fine if you want to merge this independently as there is no strict dependency. Let me know either way. v1[1]->v2: - Fixed the missing ; which was sent by mistake. Regards, Sudeep [1] https://lore.kernel.org/r/20200708110725.18017-2-sudeep.holla@arm.com diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c index c491f5de0f3f..c754dfbb73fd 100644 --- a/drivers/clk/clk-scmi.c +++ b/drivers/clk/clk-scmi.c @@ -103,6 +103,8 @@ static const struct clk_ops scmi_clk_ops = { static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk) { int ret; + unsigned long min_rate, max_rate; + struct clk_init_data init = { .flags = CLK_GET_RATE_NOCACHE, .num_parents = 0, @@ -112,9 +114,23 @@ static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk) sclk->hw.init = &init; ret = devm_clk_hw_register(dev, &sclk->hw); - if (!ret) - clk_hw_set_rate_range(&sclk->hw, sclk->info->range.min_rate, - sclk->info->range.max_rate); + if (ret) + return ret; + + if (sclk->info->rate_discrete) { + int num_rates = sclk->info->list.num_rates; + + if (num_rates <= 0) + return -EINVAL; + + min_rate = sclk->info->list.rates[0]; + max_rate = sclk->info->list.rates[num_rates - 1]; + } else { + min_rate = sclk->info->range.min_rate; + max_rate = sclk->info->range.max_rate; + } + + clk_hw_set_rate_range(&sclk->hw, min_rate, max_rate); return ret; } -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Stephen Boyd <sboyd@kernel.org> Cc: Michael Turquette <mturquette@baylibre.com>, Dien Pham <dien.pham.ry@renesas.com>, linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com> Subject: [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates Date: Thu, 9 Jul 2020 09:17:05 +0100 [thread overview] Message-ID: <20200709081705.46084-2-sudeep.holla@arm.com> (raw) In-Reply-To: <20200709081705.46084-1-sudeep.holla@arm.com> Currently we are not initializing the scmi clock with discrete rates correctly. We fetch the min_rate and max_rate value only for clocks with ranges and ignore the ones with discrete rates. This will lead to wrong initialization of rate range when clock supports discrete rate. Fix this by using the first and the last rate in the sorted list of the discrete clock rates while registering the clock. Link: https://lore.kernel.org/r/20200708110725.18017-2-sudeep.holla@arm.com Fixes: 6d6a1d82eaef7 ("clk: add support for clocks provided by SCMI") Reported-by: Dien Pham <dien.pham.ry@renesas.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/clk/clk-scmi.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) Hi Stephen, If you are fine, I can take this via ARM SoC along with the change in firmware driver. However it is also fine if you want to merge this independently as there is no strict dependency. Let me know either way. v1[1]->v2: - Fixed the missing ; which was sent by mistake. Regards, Sudeep [1] https://lore.kernel.org/r/20200708110725.18017-2-sudeep.holla@arm.com diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c index c491f5de0f3f..c754dfbb73fd 100644 --- a/drivers/clk/clk-scmi.c +++ b/drivers/clk/clk-scmi.c @@ -103,6 +103,8 @@ static const struct clk_ops scmi_clk_ops = { static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk) { int ret; + unsigned long min_rate, max_rate; + struct clk_init_data init = { .flags = CLK_GET_RATE_NOCACHE, .num_parents = 0, @@ -112,9 +114,23 @@ static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk) sclk->hw.init = &init; ret = devm_clk_hw_register(dev, &sclk->hw); - if (!ret) - clk_hw_set_rate_range(&sclk->hw, sclk->info->range.min_rate, - sclk->info->range.max_rate); + if (ret) + return ret; + + if (sclk->info->rate_discrete) { + int num_rates = sclk->info->list.num_rates; + + if (num_rates <= 0) + return -EINVAL; + + min_rate = sclk->info->list.rates[0]; + max_rate = sclk->info->list.rates[num_rates - 1]; + } else { + min_rate = sclk->info->range.min_rate; + max_rate = sclk->info->range.max_rate; + } + + clk_hw_set_rate_range(&sclk->hw, min_rate, max_rate); return ret; } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-09 8:17 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-09 8:17 [PATCH v2 1/2] firmware: arm_scmi: Keep the discrete clock rates sorted Sudeep Holla 2020-07-09 8:17 ` Sudeep Holla 2020-07-09 8:17 ` Sudeep Holla [this message] 2020-07-09 8:17 ` [PATCH v2 2/2] clk: scmi: Fix min and max rate when registering clocks with discrete rates Sudeep Holla 2020-07-09 8:26 ` Dien Pham 2020-07-09 8:26 ` Dien Pham 2020-07-09 8:39 ` Sudeep Holla 2020-07-09 8:39 ` Sudeep Holla 2020-07-09 8:55 ` Dien Pham 2020-07-09 8:55 ` Dien Pham 2020-07-10 23:50 ` Stephen Boyd 2020-07-10 23:50 ` Stephen Boyd 2020-07-13 13:21 ` Sudeep Holla 2020-07-13 13:21 ` Sudeep Holla 2020-07-13 13:00 ` [PATCH v2 1/2] firmware: arm_scmi: Keep the discrete clock rates sorted Sudeep Holla 2020-07-13 13:00 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200709081705.46084-2-sudeep.holla@arm.com \ --to=sudeep.holla@arm.com \ --cc=dien.pham.ry@renesas.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.