All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/iommu/amd/iommu.c:733 amd_iommu_int_thread() warn: this loop depends on readl() succeeding
@ 2020-07-12 18:31 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-07-12 18:31 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4551 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Joerg Roedel <jroedel@suse.de>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
CC: Jerry Snitselaar <jsnitsel@redhat.com>

Hi Joerg,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0aea6d5c5be33ce94c16f9ab2f64de1f481f424b
commit: ad8694bac410e5d72ad610dfb146f58bf2fe0365 iommu/amd: Move AMD IOMMU driver into subdirectory
date:   5 weeks ago
:::::: branch date: 24 hours ago
:::::: commit date: 5 weeks ago
config: x86_64-randconfig-m001-20200713 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/iommu/amd/iommu.c:733 amd_iommu_int_thread() warn: this loop depends on readl() succeeding

# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ad8694bac410e5d72ad610dfb146f58bf2fe0365
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout ad8694bac410e5d72ad610dfb146f58bf2fe0365
vim +733 drivers/iommu/amd/iommu.c

bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  722  
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  723  #define AMD_IOMMU_INT_MASK	\
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  724  	(MMIO_STATUS_EVT_INT_MASK | \
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  725  	 MMIO_STATUS_PPR_INT_MASK | \
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  726  	 MMIO_STATUS_GALOG_INT_MASK)
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  727  
72fe00f01f9a32 arch/x86/kernel/amd_iommu.c Joerg Roedel          2011-05-10  728  irqreturn_t amd_iommu_int_thread(int irq, void *data)
a80dc3e0e0dc83 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-11  729  {
3f398bc7762adc drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  730  	struct amd_iommu *iommu = (struct amd_iommu *) data;
3f398bc7762adc drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  731  	u32 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-09  732  
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23 @733  	while (status & AMD_IOMMU_INT_MASK) {
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  734  		/* Enable EVT and PPR and GA interrupts again */
bd6fcefc66f6d0 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  735  		writel(AMD_IOMMU_INT_MASK,
3f398bc7762adc drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  736  			iommu->mmio_base + MMIO_STATUS_OFFSET);
90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-09  737  
3f398bc7762adc drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  738  		if (status & MMIO_STATUS_EVT_INT_MASK) {
101fa0371478aa drivers/iommu/amd_iommu.c   Joerg Roedel          2018-11-27  739  			pr_devel("Processing IOMMU Event Log\n");
90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-09  740  			iommu_poll_events(iommu);
3f398bc7762adc drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  741  		}
3f398bc7762adc drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  742  
3f398bc7762adc drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  743  		if (status & MMIO_STATUS_PPR_INT_MASK) {
101fa0371478aa drivers/iommu/amd_iommu.c   Joerg Roedel          2018-11-27  744  			pr_devel("Processing IOMMU PPR Log\n");
72e1dcc4192288 drivers/iommu/amd_iommu.c   Joerg Roedel          2011-11-10  745  			iommu_poll_ppr_log(iommu);
72e1dcc4192288 drivers/iommu/amd_iommu.c   Joerg Roedel          2011-11-10  746  		}
90008ee4b811c9 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-09  747  

:::::: The code at line 733 was first introduced by commit
:::::: bd6fcefc66f6d038406e38edf96a95d9842f819d iommu/amd: Adding GALOG interrupt handler

:::::: TO: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
:::::: CC: Joerg Roedel <jroedel@suse.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35501 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* drivers/iommu/amd/iommu.c:733 amd_iommu_int_thread() warn: this loop depends on readl() succeeding
@ 2020-10-14  4:42 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-10-14  4:42 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 4287 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Joerg Roedel <jroedel@suse.de>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
CC: Jerry Snitselaar <jsnitsel@redhat.com>

Hi Joerg,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b5fc7a89e58bcc059a3d5e4db79c481fb437de59
commit: ad8694bac410e5d72ad610dfb146f58bf2fe0365 iommu/amd: Move AMD IOMMU driver into subdirectory
date:   4 months ago
:::::: branch date: 5 hours ago
:::::: commit date: 4 months ago
config: x86_64-randconfig-m001-20201014 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/iommu/amd/iommu.c:733 amd_iommu_int_thread() warn: this loop depends on readl() succeeding

vim +733 drivers/iommu/amd/iommu.c

bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  722  
bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  723  #define AMD_IOMMU_INT_MASK	\
bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  724  	(MMIO_STATUS_EVT_INT_MASK | \
bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  725  	 MMIO_STATUS_PPR_INT_MASK | \
bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  726  	 MMIO_STATUS_GALOG_INT_MASK)
bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  727  
72fe00f01f9a324 arch/x86/kernel/amd_iommu.c Joerg Roedel          2011-05-10  728  irqreturn_t amd_iommu_int_thread(int irq, void *data)
a80dc3e0e0dc839 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-11  729  {
3f398bc7762adcd drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  730  	struct amd_iommu *iommu = (struct amd_iommu *) data;
3f398bc7762adcd drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  731  	u32 status = readl(iommu->mmio_base + MMIO_STATUS_OFFSET);
90008ee4b811c94 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-09  732  
bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23 @733  	while (status & AMD_IOMMU_INT_MASK) {
bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  734  		/* Enable EVT and PPR and GA interrupts again */
bd6fcefc66f6d03 drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2016-08-23  735  		writel(AMD_IOMMU_INT_MASK,
3f398bc7762adcd drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  736  			iommu->mmio_base + MMIO_STATUS_OFFSET);
90008ee4b811c94 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-09  737  
3f398bc7762adcd drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  738  		if (status & MMIO_STATUS_EVT_INT_MASK) {
101fa0371478aa0 drivers/iommu/amd_iommu.c   Joerg Roedel          2018-11-27  739  			pr_devel("Processing IOMMU Event Log\n");
90008ee4b811c94 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-09  740  			iommu_poll_events(iommu);
3f398bc7762adcd drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  741  		}
3f398bc7762adcd drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  742  
3f398bc7762adcd drivers/iommu/amd_iommu.c   Suravee Suthikulpanit 2013-04-22  743  		if (status & MMIO_STATUS_PPR_INT_MASK) {
101fa0371478aa0 drivers/iommu/amd_iommu.c   Joerg Roedel          2018-11-27  744  			pr_devel("Processing IOMMU PPR Log\n");
72e1dcc4192288a drivers/iommu/amd_iommu.c   Joerg Roedel          2011-11-10  745  			iommu_poll_ppr_log(iommu);
72e1dcc4192288a drivers/iommu/amd_iommu.c   Joerg Roedel          2011-11-10  746  		}
90008ee4b811c94 arch/x86/kernel/amd_iommu.c Joerg Roedel          2008-09-09  747  

:::::: The code at line 733 was first introduced by commit
:::::: bd6fcefc66f6d038406e38edf96a95d9842f819d iommu/amd: Adding GALOG interrupt handler

:::::: TO: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
:::::: CC: Joerg Roedel <jroedel@suse.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28236 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-14  4:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-12 18:31 drivers/iommu/amd/iommu.c:733 amd_iommu_int_thread() warn: this loop depends on readl() succeeding kernel test robot
2020-10-14  4:42 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.