All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fbdev: sm712fb: handle ioremap() errors in probe
@ 2020-07-13  8:05   ` Evgeny Novikov
  0 siblings, 0 replies; 6+ messages in thread
From: Evgeny Novikov @ 2020-07-13  8:05 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: Evgeny Novikov, Teddy Wang, Bartlomiej Zolnierkiewicz,
	linux-fbdev, dri-devel, linux-kernel, ldv-project

smtcfb_pci_probe() does not handle ioremap() errors for case 0x720. The
patch fixes that exactly like for case 0x710/2.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
---
 drivers/video/fbdev/sm712fb.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
index 6a1b4a853d9e..0171b23fa211 100644
--- a/drivers/video/fbdev/sm712fb.c
+++ b/drivers/video/fbdev/sm712fb.c
@@ -1602,6 +1602,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 		sfb->fb->fix.mmio_start = mmio_base;
 		sfb->fb->fix.mmio_len = 0x00200000;
 		sfb->dp_regs = ioremap(mmio_base, 0x00200000 + smem_size);
+		if (!sfb->dp_regs) {
+			dev_err(&pdev->dev,
+				"%s: unable to map memory mapped IO!\n",
+				sfb->fb->fix.id);
+			err = -ENOMEM;
+			goto failed_fb;
+		}
+
 		sfb->lfb = sfb->dp_regs + 0x00200000;
 		sfb->mmio = (smtc_regbaseaddress =
 		    sfb->dp_regs + 0x000c0000);
-- 
2.16.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] fbdev: sm712fb: handle ioremap() errors in probe
@ 2020-07-13  8:05   ` Evgeny Novikov
  0 siblings, 0 replies; 6+ messages in thread
From: Evgeny Novikov @ 2020-07-13  8:05 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: ldv-project, linux-fbdev, Teddy Wang, Bartlomiej Zolnierkiewicz,
	Evgeny Novikov, linux-kernel, dri-devel

smtcfb_pci_probe() does not handle ioremap() errors for case 0x720. The
patch fixes that exactly like for case 0x710/2.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
---
 drivers/video/fbdev/sm712fb.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
index 6a1b4a853d9e..0171b23fa211 100644
--- a/drivers/video/fbdev/sm712fb.c
+++ b/drivers/video/fbdev/sm712fb.c
@@ -1602,6 +1602,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 		sfb->fb->fix.mmio_start = mmio_base;
 		sfb->fb->fix.mmio_len = 0x00200000;
 		sfb->dp_regs = ioremap(mmio_base, 0x00200000 + smem_size);
+		if (!sfb->dp_regs) {
+			dev_err(&pdev->dev,
+				"%s: unable to map memory mapped IO!\n",
+				sfb->fb->fix.id);
+			err = -ENOMEM;
+			goto failed_fb;
+		}
+
 		sfb->lfb = sfb->dp_regs + 0x00200000;
 		sfb->mmio = (smtc_regbaseaddress  		    sfb->dp_regs + 0x000c0000);
-- 
2.16.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] fbdev: sm712fb: handle ioremap() errors in probe
@ 2020-07-13  8:05   ` Evgeny Novikov
  0 siblings, 0 replies; 6+ messages in thread
From: Evgeny Novikov @ 2020-07-13  8:05 UTC (permalink / raw)
  To: Sudip Mukherjee
  Cc: ldv-project, linux-fbdev, Teddy Wang, Bartlomiej Zolnierkiewicz,
	Evgeny Novikov, linux-kernel, dri-devel

smtcfb_pci_probe() does not handle ioremap() errors for case 0x720. The
patch fixes that exactly like for case 0x710/2.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
---
 drivers/video/fbdev/sm712fb.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
index 6a1b4a853d9e..0171b23fa211 100644
--- a/drivers/video/fbdev/sm712fb.c
+++ b/drivers/video/fbdev/sm712fb.c
@@ -1602,6 +1602,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 		sfb->fb->fix.mmio_start = mmio_base;
 		sfb->fb->fix.mmio_len = 0x00200000;
 		sfb->dp_regs = ioremap(mmio_base, 0x00200000 + smem_size);
+		if (!sfb->dp_regs) {
+			dev_err(&pdev->dev,
+				"%s: unable to map memory mapped IO!\n",
+				sfb->fb->fix.id);
+			err = -ENOMEM;
+			goto failed_fb;
+		}
+
 		sfb->lfb = sfb->dp_regs + 0x00200000;
 		sfb->mmio = (smtc_regbaseaddress =
 		    sfb->dp_regs + 0x000c0000);
-- 
2.16.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: sm712fb: handle ioremap() errors in probe
  2020-07-13  8:05   ` Evgeny Novikov
  (?)
@ 2020-09-08 11:36     ` Bartlomiej Zolnierkiewicz
  -1 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-09-08 11:36 UTC (permalink / raw)
  To: Evgeny Novikov
  Cc: Sudip Mukherjee, Teddy Wang, linux-fbdev, dri-devel,
	linux-kernel, ldv-project


On 7/13/20 10:05 AM, Evgeny Novikov wrote:
> smtcfb_pci_probe() does not handle ioremap() errors for case 0x720. The
> patch fixes that exactly like for case 0x710/2.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>

Applied to drm-misc-next tree, thanks and sorry for the delay.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/sm712fb.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
> index 6a1b4a853d9e..0171b23fa211 100644
> --- a/drivers/video/fbdev/sm712fb.c
> +++ b/drivers/video/fbdev/sm712fb.c
> @@ -1602,6 +1602,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
>  		sfb->fb->fix.mmio_start = mmio_base;
>  		sfb->fb->fix.mmio_len = 0x00200000;
>  		sfb->dp_regs = ioremap(mmio_base, 0x00200000 + smem_size);
> +		if (!sfb->dp_regs) {
> +			dev_err(&pdev->dev,
> +				"%s: unable to map memory mapped IO!\n",
> +				sfb->fb->fix.id);
> +			err = -ENOMEM;
> +			goto failed_fb;
> +		}
> +
>  		sfb->lfb = sfb->dp_regs + 0x00200000;
>  		sfb->mmio = (smtc_regbaseaddress =
>  		    sfb->dp_regs + 0x000c0000);
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: sm712fb: handle ioremap() errors in probe
@ 2020-09-08 11:36     ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-09-08 11:36 UTC (permalink / raw)
  To: Evgeny Novikov
  Cc: ldv-project, linux-fbdev, Teddy Wang, linux-kernel, dri-devel,
	Sudip Mukherjee


On 7/13/20 10:05 AM, Evgeny Novikov wrote:
> smtcfb_pci_probe() does not handle ioremap() errors for case 0x720. The
> patch fixes that exactly like for case 0x710/2.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>

Applied to drm-misc-next tree, thanks and sorry for the delay.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/sm712fb.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
> index 6a1b4a853d9e..0171b23fa211 100644
> --- a/drivers/video/fbdev/sm712fb.c
> +++ b/drivers/video/fbdev/sm712fb.c
> @@ -1602,6 +1602,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
>  		sfb->fb->fix.mmio_start = mmio_base;
>  		sfb->fb->fix.mmio_len = 0x00200000;
>  		sfb->dp_regs = ioremap(mmio_base, 0x00200000 + smem_size);
> +		if (!sfb->dp_regs) {
> +			dev_err(&pdev->dev,
> +				"%s: unable to map memory mapped IO!\n",
> +				sfb->fb->fix.id);
> +			err = -ENOMEM;
> +			goto failed_fb;
> +		}
> +
>  		sfb->lfb = sfb->dp_regs + 0x00200000;
>  		sfb->mmio = (smtc_regbaseaddress >  		    sfb->dp_regs + 0x000c0000);
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: sm712fb: handle ioremap() errors in probe
@ 2020-09-08 11:36     ` Bartlomiej Zolnierkiewicz
  0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-09-08 11:36 UTC (permalink / raw)
  To: Evgeny Novikov
  Cc: ldv-project, linux-fbdev, Teddy Wang, linux-kernel, dri-devel,
	Sudip Mukherjee


On 7/13/20 10:05 AM, Evgeny Novikov wrote:
> smtcfb_pci_probe() does not handle ioremap() errors for case 0x720. The
> patch fixes that exactly like for case 0x710/2.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>

Applied to drm-misc-next tree, thanks and sorry for the delay.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/sm712fb.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
> index 6a1b4a853d9e..0171b23fa211 100644
> --- a/drivers/video/fbdev/sm712fb.c
> +++ b/drivers/video/fbdev/sm712fb.c
> @@ -1602,6 +1602,14 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
>  		sfb->fb->fix.mmio_start = mmio_base;
>  		sfb->fb->fix.mmio_len = 0x00200000;
>  		sfb->dp_regs = ioremap(mmio_base, 0x00200000 + smem_size);
> +		if (!sfb->dp_regs) {
> +			dev_err(&pdev->dev,
> +				"%s: unable to map memory mapped IO!\n",
> +				sfb->fb->fix.id);
> +			err = -ENOMEM;
> +			goto failed_fb;
> +		}
> +
>  		sfb->lfb = sfb->dp_regs + 0x00200000;
>  		sfb->mmio = (smtc_regbaseaddress =
>  		    sfb->dp_regs + 0x000c0000);
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-08 19:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20200713080538eucas1p15f1739af7b66fbb88987aeb6bdaca4f4@eucas1p1.samsung.com>
2020-07-13  8:05 ` [PATCH] fbdev: sm712fb: handle ioremap() errors in probe Evgeny Novikov
2020-07-13  8:05   ` Evgeny Novikov
2020-07-13  8:05   ` Evgeny Novikov
2020-09-08 11:36   ` Bartlomiej Zolnierkiewicz
2020-09-08 11:36     ` Bartlomiej Zolnierkiewicz
2020-09-08 11:36     ` Bartlomiej Zolnierkiewicz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.