From: David Miller <davem@davemloft.net>
To: borisp@mellanox.com
Cc: kuba@kernel.org, john.fastabend@gmail.com, daniel@iogearbox.net,
tariqt@mellanox.com, netdev@vger.kernel.org
Subject: Re: [PATCH] tls: add zerocopy device sendpage
Date: Tue, 14 Jul 2020 13:42:51 -0700 (PDT) [thread overview]
Message-ID: <20200714.134251.618655351471501947.davem@davemloft.net> (raw)
In-Reply-To: <8dd10152-b790-d56f-8fbc-5eb2250f2798@mellanox.com>
From: Boris Pismenny <borisp@mellanox.com>
Date: Tue, 14 Jul 2020 10:27:11 +0300
> Why is it the kernel's role to protect against such an error?
Because the kernel should perform it's task correctly no matter what
in the world the user does.
> Surely the user that modifies pagecache data while sending it over
> sendfile (with TCP) will suffer from consistency bugs that are even worse.
No they won't, often times this is completely legitimate. One task is
doing a sendpage while another process with access to the file writes
to it.
And that's perfectly fine and allowed by the APIs.
And we must set the IP checksums and TLS signatures correctly.
I will not allow for an implementation that can knowingly send corrupt
things onto the wire.
> The copy in the TLS_DEVICE sendfile path greatly reduces the value of
> all of this work. If we want to get the maximum out of this, then the
> copy has to go.
>
> If we can't make this the default (as it is in FreeBSD), and we can't
> add a knob to enable this. Then, what should we do here?
I have no problem people using FreeBSD if it serves their needs better
than Linux does. If people want corrupt TLS signatures in legitimate
use cases, and FreeBSD allows it, so be it.
So don't bother using this as a threat or a reason for me to allow a
feature or a change into the Linux networking. It will never work.
And, let me get this straight, from the very beginning you intended to
try and add this thing even though I was %100 explicitly against it?
next prev parent reply other threads:[~2020-07-14 20:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1594550649-3097-1-git-send-email-borisp@mellanox.com>
[not found] ` <20200712.153233.370000904740228888.davem@davemloft.net>
2020-07-13 7:49 ` [PATCH] tls: add zerocopy device sendpage Boris Pismenny
2020-07-13 19:05 ` David Miller
2020-07-13 22:15 ` Boris Pismenny
2020-07-13 22:59 ` Jakub Kicinski
2020-07-14 7:31 ` Boris Pismenny
2020-07-14 16:23 ` Jakub Kicinski
2020-07-14 20:38 ` David Miller
2020-07-14 1:02 ` David Miller
2020-07-14 7:27 ` Boris Pismenny
2020-07-14 20:42 ` David Miller [this message]
2020-07-14 20:56 ` Boris Pismenny
2020-07-12 10:53 Boris Pismenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714.134251.618655351471501947.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.