From: Boris Pismenny <borisp@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: kuba@kernel.org, john.fastabend@gmail.com, daniel@iogearbox.net,
tariqt@mellanox.com, netdev@vger.kernel.org
Subject: Re: [PATCH] tls: add zerocopy device sendpage
Date: Tue, 14 Jul 2020 10:27:11 +0300 [thread overview]
Message-ID: <8dd10152-b790-d56f-8fbc-5eb2250f2798@mellanox.com> (raw)
In-Reply-To: <20200713.180210.1797175286159137272.davem@davemloft.net>
On 14/07/2020 4:02, David Miller wrote:
> From: Boris Pismenny <borisp@mellanox.com>
> Date: Tue, 14 Jul 2020 01:15:26 +0300
>
>> On 13/07/2020 22:05, David Miller wrote:
>>> From: Boris Pismenny <borisp@mellanox.com>
>>> Date: Mon, 13 Jul 2020 10:49:49 +0300
>>>
>>> Why can't the device generate the correct TLS signature when
>>> offloading? Just like for the protocol checksum, the device should
>>> load the payload into the device over DMA and make it's calculations
>>> on that copy.
>> Right. The problematic case is when some part of the record is already
>> received by the other party, and then some (modified) data including
>> the TLS authentication tag is re-transmitted.
> Then we must copy to avoid this.
Why is it the kernel's role to protect against such an error?
Surely the user that modifies pagecache data while sending it over
sendfile (with TCP) will suffer from consistency bugs that are even worse.
The copy in the TLS_DEVICE sendfile path greatly reduces the value of
all of this work. If we want to get the maximum out of this, then the
copy has to go.
If we can't make this the default (as it is in FreeBSD), and we can't
add a knob to enable this. Then, what should we do here?
next prev parent reply other threads:[~2020-07-14 7:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1594550649-3097-1-git-send-email-borisp@mellanox.com>
[not found] ` <20200712.153233.370000904740228888.davem@davemloft.net>
2020-07-13 7:49 ` [PATCH] tls: add zerocopy device sendpage Boris Pismenny
2020-07-13 19:05 ` David Miller
2020-07-13 22:15 ` Boris Pismenny
2020-07-13 22:59 ` Jakub Kicinski
2020-07-14 7:31 ` Boris Pismenny
2020-07-14 16:23 ` Jakub Kicinski
2020-07-14 20:38 ` David Miller
2020-07-14 1:02 ` David Miller
2020-07-14 7:27 ` Boris Pismenny [this message]
2020-07-14 20:42 ` David Miller
2020-07-14 20:56 ` Boris Pismenny
2020-07-12 10:53 Boris Pismenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dd10152-b790-d56f-8fbc-5eb2250f2798@mellanox.com \
--to=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.